Mastodon
/
pachli-android
mirror of https://github.com/pachli/pachli-android.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Don't clip buttons when choosing scheduled post time (#1024) 

The MaterialTimePicker library has a bug that results in the "Cancel"
and "Ok" buttons on the dialog being cut off.

See
https://github.com/material-components/material-components-android/issues/3584

Work around this by updating their layout params and explicitly setting
the "bottomToBottom" constraint to their parent.
This commit is contained in:
Nik Clayton 2024-10-18 15:13:17 +02:00 committed by GitHub
parent 0c4a17f073
commit 8fac5c3d4d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 28 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
app/src/main/java/app/pachli/components/compose/view/ComposeScheduleView.kt
View File

@ -19,11 +19,15 @@ package app.pachli.components.compose.view
import android.content.Context import android.content.Context
import android.util.AttributeSet import android.util.AttributeSet
import android.view.LayoutInflater import android.view.LayoutInflater
import android.widget.Button
import androidx.appcompat.app.AppCompatActivity import androidx.appcompat.app.AppCompatActivity
import androidx.appcompat.content.res.AppCompatResources import androidx.appcompat.content.res.AppCompatResources
import androidx.constraintlayout.widget.ConstraintLayout import androidx.constraintlayout.widget.ConstraintLayout
import androidx.lifecycle.DefaultLifecycleObserver
import androidx.lifecycle.LifecycleOwner
import app.pachli.R import app.pachli.R
import app.pachli.databinding.ViewComposeScheduleBinding import app.pachli.databinding.ViewComposeScheduleBinding
import com.google.android.material.R as MaterialR
import com.google.android.material.datepicker.CalendarConstraints import com.google.android.material.datepicker.CalendarConstraints
import com.google.android.material.datepicker.DateValidatorPointForward import com.google.android.material.datepicker.DateValidatorPointForward
import com.google.android.material.datepicker.MaterialDatePicker import com.google.android.material.datepicker.MaterialDatePicker
@ -158,6 +162,30 @@ class ComposeScheduleView
pickerBuilder.setTimeFormat(getTimeFormat(context)) pickerBuilder.setTimeFormat(getTimeFormat(context))
val picker = pickerBuilder.build() val picker = pickerBuilder.build()
// Work around https://github.com/material-components/material-components-android/issues/3584
// where the buttons get cut off because of incorrect constraints. Force the
// constraints when the dialog resumes.
picker.lifecycle.addObserver(
object : DefaultLifecycleObserver {
fun Button.constrainToBottomOfParent() {
(layoutParams as? LayoutParams)?.let { lp ->
lp.bottomToBottom = LayoutParams.PARENT_ID
layoutParams = lp
}
}
override fun onResume(owner: LifecycleOwner) {
picker.dialog
?.findViewById<Button>(MaterialR.id.material_timepicker_cancel_button)
?.constrainToBottomOfParent()
picker.dialog
?.findViewById<Button>(MaterialR.id.material_timepicker_ok_button)
?.constrainToBottomOfParent()
}
},
)
picker.addOnPositiveButtonClickListener { onTimeSet(picker.hour, picker.minute) } picker.addOnPositiveButtonClickListener { onTimeSet(picker.hour, picker.minute) }
picker.show((context as AppCompatActivity).supportFragmentManager, "time_picker") picker.show((context as AppCompatActivity).supportFragmentManager, "time_picker")
} }