From 8e22a4e557266d6a5942c222488d287f77a18daa Mon Sep 17 00:00:00 2001 From: Nik Clayton Date: Wed, 13 Nov 2024 23:36:28 +0100 Subject: [PATCH] test: Fix ViewThreadViewModel flakiness (#1099) Some tests were assuming the uiState would transition from .Loading to .Success, without considering there might be a .LoadingThread intermediate step. Cater for that to prevent test flakes. --- .../components/viewthread/ViewThreadViewModelTest.kt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/src/test/java/app/pachli/components/viewthread/ViewThreadViewModelTest.kt b/app/src/test/java/app/pachli/components/viewthread/ViewThreadViewModelTest.kt index b03b05c84..dbd4fa781 100644 --- a/app/src/test/java/app/pachli/components/viewthread/ViewThreadViewModelTest.kt +++ b/app/src/test/java/app/pachli/components/viewthread/ViewThreadViewModelTest.kt @@ -178,7 +178,7 @@ class ViewThreadViewModelTest { do { item = awaitItem() - } while (item is ThreadUiState.Loading) + } while (item !is ThreadUiState.Success) assertEquals( ThreadUiState.Success( @@ -219,7 +219,7 @@ class ViewThreadViewModelTest { do { item = awaitItem() - } while (item is ThreadUiState.Loading) + } while (item !is ThreadUiState.Success) assertEquals( ThreadUiState.Success( @@ -252,7 +252,7 @@ class ViewThreadViewModelTest { do { item = awaitItem() - } while (item is ThreadUiState.Loading) + } while (item !is ThreadUiState.Error) assertEquals( ThreadUiState.Error::class.java, @@ -279,7 +279,7 @@ class ViewThreadViewModelTest { do { item = awaitItem() - } while (item is ThreadUiState.Loading) + } while (item !is ThreadUiState.Error) assertEquals( ThreadUiState.Error::class.java,