From 2a7eda667bc076c187e4d4d4fed3fba01f115fa1 Mon Sep 17 00:00:00 2001 From: Nik Clayton Date: Sat, 9 Dec 2023 22:38:19 +0100 Subject: [PATCH] fix: Prevent crash if a preview card does not have an author --- app/src/main/java/app/pachli/view/PreviewCardView.kt | 2 +- .../src/main/kotlin/app/pachli/core/network/model/TrendsLink.kt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/app/pachli/view/PreviewCardView.kt b/app/src/main/java/app/pachli/view/PreviewCardView.kt index 9bdb3116a..65a834a30 100644 --- a/app/src/main/java/app/pachli/view/PreviewCardView.kt +++ b/app/src/main/java/app/pachli/view/PreviewCardView.kt @@ -86,7 +86,7 @@ class PreviewCardView @JvmOverloads constructor( when { card.description.isNotBlank() -> card.description - card.authorName.isNotBlank() -> card.authorName + card.authorName.orEmpty().isNotBlank() -> card.authorName else -> null }?.let { cardDescription.text = it } ?: cardDescription.hide() diff --git a/core/network/src/main/kotlin/app/pachli/core/network/model/TrendsLink.kt b/core/network/src/main/kotlin/app/pachli/core/network/model/TrendsLink.kt index 5888a149d..bffdc4fae 100644 --- a/core/network/src/main/kotlin/app/pachli/core/network/model/TrendsLink.kt +++ b/core/network/src/main/kotlin/app/pachli/core/network/model/TrendsLink.kt @@ -41,7 +41,7 @@ interface PreviewCard { val title: String val description: String val kind: PreviewCardKind - val authorName: String + val authorName: String? // Not supposed to be null, per API, but seen null in the wild val authorUrl: String val providerName: String val providerUrl: String