Mastodon
/
pachli-android
mirror of https://github.com/pachli/pachli-android.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
pachli-android/app/lint-baseline.xml

2685 lines
132 KiB
XML
Raw Normal View History

Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<?xml version="1.0" encoding="UTF-8"?>
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
<issues format="6" by="lint 8.5.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.5.0)" variant="all" version="8.5.0">
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<issue
id="InvalidPackage"
message="Invalid package reference in org.bouncycastle:bcprov-jdk15on; not included in Android: `javax.naming.directory`. Referenced from `org.bouncycastle.jce.provider.CrlCache`.">
<location
file="$GRADLE_USER_HOME/caches/modules-2/files-2.1/org.bouncycastle/bcprov-jdk15on/1.70/4636a0d01f74acaf28082fb62b317f1080118371/bcprov-jdk15on-1.70.jar"/>
</issue>
<issue
id="InvalidPackage"
message="Invalid package reference in org.bouncycastle:bcprov-jdk15on; not included in Android: `javax.naming`. Referenced from `org.bouncycastle.jce.provider.X509LDAPCertStoreSpi`.">
<location
file="$GRADLE_USER_HOME/caches/modules-2/files-2.1/org.bouncycastle/bcprov-jdk15on/1.70/4636a0d01f74acaf28082fb62b317f1080118371/bcprov-jdk15on-1.70.jar"/>
</issue>
add lint to ci checks (#3462) * add lint to ci checks * update lint baseline
2023-03-21 18:56:11 +01:00
<issue
id="InvalidPackage"
message="Invalid package reference in org.pageseeder.diffx:pso-diffx; not included in Android: `javax.xml.stream.events`. Referenced from `org.pageseeder.diffx.load.XMLEventLoader`.">
<location
file="$GRADLE_USER_HOME/caches/modules-2/files-2.1/org.pageseeder.diffx/pso-diffx/1.1.1/b655ebc87588a857a4f3d88cf98bcefa87a6105b/pso-diffx-1.1.1.jar"/>
</issue>
<issue
id="InvalidPackage"
message="Invalid package reference in org.pageseeder.diffx:pso-diffx; not included in Android: `javax.xml.stream`. Referenced from `org.pageseeder.diffx.format.StrictXMLDiffOutput`.">
<location
file="$GRADLE_USER_HOME/caches/modules-2/files-2.1/org.pageseeder.diffx/pso-diffx/1.1.1/b655ebc87588a857a4f3d88cf98bcefa87a6105b/pso-diffx-1.1.1.jar"/>
</issue>
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<issue
id="UnusedAttribute"
message="Attribute `appCategory` is only used in API level 26 and higher (current min is 23)"
errorLine1=" android:appCategory=&quot;social&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/AndroidManifest.xml"
docs: Add a privacy policy (#2) While drafting the policy I noticed that the `READ_MEDIA_*` permissions could be added (for newer devices), the `ACCESS_NETWORK_STATE` permission was missing, and `VIBRATE` was unnecessary.
2023-09-05 15:35:06 +02:00
line="17"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="9"/>
</issue>
<issue
id="UnusedAttribute"
message="Attribute `localeConfig` is only used in API level 33 and higher (current min is 23)"
feat: Use Let's Encrypt certificates on API 23 devices (#640) Android 7 devices no longer trust certificates issued by Let's Encrypt (see https://letsencrypt.org/2020/11/06/own-two-feet and https://letsencrypt.org/2023/07/10/cross-sign-expiration.html for details). To work around that provide the Let's Encrypt root certs as resources. On API 24+ devices add those via network_security_config.xml. On API 23 devices they need to be installed manually for OkHttp SSL connections, and checked when there is an SSL error in LoginWebViewActivity. The root certificates were downloaded from https://letsencrypt.org/certificates/: - https://letsencrypt.org/certs/isrgrootx1.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x1-cross-signed.der (cross-signed) - https://letsencrypt.org/certs/isrg-root-x2.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x2-cross-signed.der (cross-signed) Fixes #638
2024-04-24 10:32:50 +02:00
errorLine1=" android:localeConfig=&quot;@xml/locales_config&quot;"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/AndroidManifest.xml"
docs: Add a privacy policy (#2) While drafting the policy I noticed that the `READ_MEDIA_*` permissions could be added (for newer devices), the `ACCESS_NETWORK_STATE` permission was missing, and `VIBRATE` was unnecessary.
2023-09-05 15:35:06 +02:00
line="24"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="9"/>
</issue>
feat: Use Let's Encrypt certificates on API 23 devices (#640) Android 7 devices no longer trust certificates issued by Let's Encrypt (see https://letsencrypt.org/2020/11/06/own-two-feet and https://letsencrypt.org/2023/07/10/cross-sign-expiration.html for details). To work around that provide the Let's Encrypt root certs as resources. On API 24+ devices add those via network_security_config.xml. On API 23 devices they need to be installed manually for OkHttp SSL connections, and checked when there is an SSL error in LoginWebViewActivity. The root certificates were downloaded from https://letsencrypt.org/certificates/: - https://letsencrypt.org/certs/isrgrootx1.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x1-cross-signed.der (cross-signed) - https://letsencrypt.org/certs/isrg-root-x2.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x2-cross-signed.der (cross-signed) Fixes #638
2024-04-24 10:32:50 +02:00
<issue
id="UnusedAttribute"
message="Attribute `networkSecurityConfig` is only used in API level 24 and higher (current min is 23)"
feat: Update activity transitions, prepare for predictive-back (#650) Previous code used a single animation type (slide) when transitioning, the transition was quite slow, and didn't behave appropriately if the device was set to a RTL writing system. In addition, handling the back affordance didn't work well with the new "Predictive Back" feature in Android 14 (https://developer.android.com/guide/navigation/custom-back/predictive-back-gesture). Fix this. ## Transitions To update the transitions the `startActivityWithSlideInAnimation()` implementation (and associated `finishWithoutSlideOutAnimation()`) have been replaced. There are three transitions; `default`, `slide`, and `explode`, represented as an enum passed to the activity intent. The `default` transition is the activity transition from Android 14, from the Android open source project (https://cs.android.com/android/platform/superproject/+/android-14.0.0_r18:frameworks/base/core/res/res/anim/;bpv=1). This is used for most transitions. The `slide` transition is the pre-existing slide transition, with a shorter transition time so it feels more responsive, and an RTL implementation. This is used when there is a strong spatial component to the navigation, for example, when going from: - a status to its thread - a preference menu item to its subscreen - a filter in a list to the "edit filter" screen - viewing your profile to editing your profile The `explode` transition is used when the state of the app changes significantly, such as when switching accounts. Activities are now started with `startActivityWithTransition()` which sets the intent and prepares the transition. `BaseActivity` checks the intent for the transition type and makes further changes to the transition as necessary. ## Predictive back "Predictive back" needs to know what the back button would do before the user interacts with it with an `onBackPressedCallback` that is either enabled or disabled. This required refactoring some code (particularly in `ComposeActivity`) to gather data ahead of time and enable/disable the callback appropriately. ## Fixed bugs - Back button wasn't stepping back through the tabs in AccountActivity - Modifying a filter and pressing back without saving wasn't prompting the user to save the changes - Writing a content warning and then hiding it would still count the text of the content warning toward's the post's length ## Other cleanups - Use `ViewCompat.setTransitionName()` instead of setting the `transitionName` property - Delete the unused `fade_in` and `fade_out` animations. - Use androidx-activity 1.9.0 to get the latest predictive back support library code - Show validation errors when creating / editing filters
2024-04-26 23:18:30 +02:00
errorLine1=" android:networkSecurityConfig=&quot;@xml/network_security_config&quot;"
feat: Use Let's Encrypt certificates on API 23 devices (#640) Android 7 devices no longer trust certificates issued by Let's Encrypt (see https://letsencrypt.org/2020/11/06/own-two-feet and https://letsencrypt.org/2023/07/10/cross-sign-expiration.html for details). To work around that provide the Let's Encrypt root certs as resources. On API 24+ devices add those via network_security_config.xml. On API 23 devices they need to be installed manually for OkHttp SSL connections, and checked when there is an SSL error in LoginWebViewActivity. The root certificates were downloaded from https://letsencrypt.org/certificates/: - https://letsencrypt.org/certs/isrgrootx1.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x1-cross-signed.der (cross-signed) - https://letsencrypt.org/certs/isrg-root-x2.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x2-cross-signed.der (cross-signed) Fixes #638
2024-04-24 10:32:50 +02:00
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/AndroidManifest.xml"
line="25"
column="9"/>
</issue>
feat: Update activity transitions, prepare for predictive-back (#650) Previous code used a single animation type (slide) when transitioning, the transition was quite slow, and didn't behave appropriately if the device was set to a RTL writing system. In addition, handling the back affordance didn't work well with the new "Predictive Back" feature in Android 14 (https://developer.android.com/guide/navigation/custom-back/predictive-back-gesture). Fix this. ## Transitions To update the transitions the `startActivityWithSlideInAnimation()` implementation (and associated `finishWithoutSlideOutAnimation()`) have been replaced. There are three transitions; `default`, `slide`, and `explode`, represented as an enum passed to the activity intent. The `default` transition is the activity transition from Android 14, from the Android open source project (https://cs.android.com/android/platform/superproject/+/android-14.0.0_r18:frameworks/base/core/res/res/anim/;bpv=1). This is used for most transitions. The `slide` transition is the pre-existing slide transition, with a shorter transition time so it feels more responsive, and an RTL implementation. This is used when there is a strong spatial component to the navigation, for example, when going from: - a status to its thread - a preference menu item to its subscreen - a filter in a list to the "edit filter" screen - viewing your profile to editing your profile The `explode` transition is used when the state of the app changes significantly, such as when switching accounts. Activities are now started with `startActivityWithTransition()` which sets the intent and prepares the transition. `BaseActivity` checks the intent for the transition type and makes further changes to the transition as necessary. ## Predictive back "Predictive back" needs to know what the back button would do before the user interacts with it with an `onBackPressedCallback` that is either enabled or disabled. This required refactoring some code (particularly in `ComposeActivity`) to gather data ahead of time and enable/disable the callback appropriately. ## Fixed bugs - Back button wasn't stepping back through the tabs in AccountActivity - Modifying a filter and pressing back without saving wasn't prompting the user to save the changes - Writing a content warning and then hiding it would still count the text of the content warning toward's the post's length ## Other cleanups - Use `ViewCompat.setTransitionName()` instead of setting the `transitionName` property - Delete the unused `fade_in` and `fade_out` animations. - Use androidx-activity 1.9.0 to get the latest predictive back support library code - Show validation errors when creating / editing filters
2024-04-26 23:18:30 +02:00
<issue
id="UnusedAttribute"
message="Attribute `enableOnBackInvokedCallback` is only used in API level 33 and higher (current min is 23)"
errorLine1=" android:enableOnBackInvokedCallback=&quot;true&quot;>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/AndroidManifest.xml"
line="26"
column="9"/>
</issue>
fix(deps): update agp to v8.3.0, lint to 31.3.0 (#483) New lint rules highlighted a potential crash; the use of named match groups (used here when extracting server versions) requires API >= 26 or throws an exception. Use the group numbers instead of names when extracting the value, but keep the group names in the regular expressions for readability.
2024-03-01 23:07:14 +01:00
<issue
id="SelectedPhotoAccess"
message="Your app is currently not handling Selected Photos Access introduced in Android 14+"
errorLine1=" &lt;uses-permission android:name=&quot;android.permission.READ_MEDIA_IMAGES&quot; />"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/AndroidManifest.xml"
line="9"
column="36"/>
</issue>
<issue
id="SelectedPhotoAccess"
message="Your app is currently not handling Selected Photos Access introduced in Android 14+"
errorLine1=" &lt;uses-permission android:name=&quot;android.permission.READ_MEDIA_VIDEO&quot; />"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/AndroidManifest.xml"
line="10"
column="36"/>
</issue>
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
<issue
id="StringFormatInvalid"
message="Format string &apos;`app_name`&apos; is not a valid format string so it should not be passed to `String.format`"
refactor: Improve IO performance and simplify code with Okio (#769) `ImageDownsizer.downsizeImage()`: - Remove the return value, it was ignored - Throw `FileNotFoundException` when `openInputStream` returns null `ImageDownsizer.getImageOrientation()`: - Throw `FileNotFoundException` when `openInputStream` returns null `MediaUploader.prepareMedia()`: - Copy URI contents using Okio buffers / source / sink `UriExtensions`: - Rename from `IOUtils` - Implement `Uri.copyToFile()` using Okio buffers / source / sink - Replace `ProgressRequestBody()` with `Uri.asRequestBody()` using Okio buffers / source / sink `DraftHelper.copyToFolder()` - Use Okio buffers / source / sink `CompositeWithOpaqueBackground` - Use constants `SIZE_BYTES` and `CHARSET` instead of magic values - Use `Objects.hash` when hashing multiple objects Based on work by Christophe Beyls in - https://github.com/tuskyapp/Tusky/pull/4366 - https://github.com/tuskyapp/Tusky/pull/4372
2024-06-20 13:18:58 +02:00
errorLine1=" val filename = &quot;%s_%d_%s.%s&quot;.format("
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
errorLine2=" ^">
<location
file="src/main/java/app/pachli/components/compose/MediaUploader.kt"
feat: Provide more detail in errors, especially media upload errors (#801) Previous code assumed server responses would always be JSON, and had no special handling for mis-configured servers that sometimes return HTML; for example, if the server has a bug, or there's a reverse proxy in front of the server issuing DoS-prevention challenges. This could cause errors to show with no useful debugging information. Update `ApiResult` to check the content-type in the response and return one of two new errors if the content-type is missing or wrong. Also include the HTTP code in `ApiResponse` for use elsewhere. Update `ThrowableExtensions` to pull the `error` and optional `description` out of the error body. Update `PachliError` so `formatArgs` can be an array of arbitrary types, not just strings. Update `MediaUploader`; expose the different errors as new `MediaUploaderError` types instead of `Exception` subclasses, and return `Result<V, E>` where appropriate. Update `ComposeViewModel` to use the new `MediaUploaderError` types and create new `PickMediaError` to report issues there, replacing `VideoOrImageException`. Update `ComposeActivity` to use the new error types and show errors until the user dismisses them, so they're better able to see and report problems. Fixes #704.
2024-07-04 19:16:24 +02:00
line="388"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
column="28"/>
<location
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
file="${:core:activity*buildDir}/generated/res/resValues/blueFdroid/debug/values/gradleResValues.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="7"
column="5"
message="This definition does not require arguments"/>
</issue>
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<issue
id="MissingQuantity"
message="For locale &quot;bn&quot; (Bangla) the following quantity should also be defined: `one` (e.g. &quot;সসে 1টি আপেল খেল, সেটা ভাল&quot;)"
errorLine1=" &lt;plurals name=&quot;hint_describe_for_visually_impaired&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-bn-rBD/strings.xml"
refactor: Remove obsolete emoji-related resources (#526)
2024-03-13 11:29:45 +01:00
line="48"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
<issue
id="MissingQuantity"
message="For locale &quot;bg&quot; (Bulgarian) the following quantity should also be defined: `one` (e.g. &quot;1 ден&quot;)"
errorLine1=" &lt;plurals name=&quot;hint_describe_for_visually_impaired&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-bg/strings.xml"
refactor: Remove unnecessary whitespace in poll_info_format resource (#595)
2024-04-05 16:46:38 +02:00
line="121"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
change: Increase compileSdk and targetSdk to 34 (#150) Associated changes: - Handle new null/non-null type signatures in overriden methods - Configure Robolectric to use SDK 33 (current highest supported version)
2023-10-11 12:28:45 +02:00
<issue
id="MissingQuantity"
message="For locale &quot;ca&quot; (Catalan) the following quantity should also be defined: `many`"
errorLine1=" &lt;plurals name=&quot;notification_title_summary&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-ca/strings.xml"
refactor: Use the PachliError type for ApiError (#739) In the previous code `PachliError` could correctly chain errors and generate error messages, `ApiError` didn't, which is why there was the temporary `ApiError.fmt()` extension function. Rewrite `ApiError` to implement `PachliError` so it gets these benefits and to reduce the number of different error-handling mechanisms in the code. Main changes: - `PachliError` is now an interface so it can be extended by other error interfaces. - All the `ApiError` subclasses implement `PachliError`, and can specify the error string and interpolated variables at the point of declaration. - Update `ListsRepository` and `ServerRepository` to return `PachliError` subclasses.
2024-06-12 10:22:27 +02:00
line="132"
change: Increase compileSdk and targetSdk to 34 (#150) Associated changes: - Handle new null/non-null type signatures in overriden methods - Configure Robolectric to use SDK 33 (current highest supported version)
2023-10-11 12:28:45 +02:00
column="5"/>
</issue>
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<issue
id="MissingQuantity"
message="For locale &quot;ta&quot; (Tamil) the following quantity should also be defined: `one` (e.g. &quot;1&quot;)"
errorLine1=" &lt;plurals name=&quot;notification_title_summary&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-ta/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="154"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
<issue
id="MissingQuantity"
refactor: Extract user list functionality to `feature:lists` (#537) Move `ListsActivity`, along with fragments and viewmodels, to a new `feature:lists` module. Previous code used the `item_follow_request` layout, which was not ideal, so update it to use a dedicated layout, `item_account_in_list`. The UI uses strings and views originally defined in the main app, so move them elsewhere so they can be re-used. - `BackgroundMessageView` moves to `core.ui`. - `Lazy` moves to `core.common`. - `ThrowableExtensions` split; the extensions specific to throwables from network activity move to `core.network`, others move to `core.ui`. - `BindingHolder` moves to `core.ui` - Shared drawables and strings move to `core.ui`.
2024-03-16 18:42:11 +01:00
message="For locale &quot;bg&quot; (Bulgarian) the following quantity should also be defined: `one` (e.g. &quot;1 ден&quot;)"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
errorLine1=" &lt;plurals name=&quot;notification_title_summary&quot;>"
errorLine2=" ^">
<location
refactor: Extract user list functionality to `feature:lists` (#537) Move `ListsActivity`, along with fragments and viewmodels, to a new `feature:lists` module. Previous code used the `item_follow_request` layout, which was not ideal, so update it to use a dedicated layout, `item_account_in_list`. The UI uses strings and views originally defined in the main app, so move them elsewhere so they can be re-used. - `BackgroundMessageView` moves to `core.ui`. - `Lazy` moves to `core.common`. - `ThrowableExtensions` split; the extensions specific to throwables from network activity move to `core.network`, others move to `core.ui`. - `BindingHolder` moves to `core.ui` - Shared drawables and strings move to `core.ui`.
2024-03-16 18:42:11 +01:00
file="src/main/res/values-bg/strings.xml"
refactor: Remove unnecessary whitespace in poll_info_format resource (#595)
2024-04-05 16:46:38 +02:00
line="161"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
<issue
id="MissingQuantity"
refactor: Extract user list functionality to `feature:lists` (#537) Move `ListsActivity`, along with fragments and viewmodels, to a new `feature:lists` module. Previous code used the `item_follow_request` layout, which was not ideal, so update it to use a dedicated layout, `item_account_in_list`. The UI uses strings and views originally defined in the main app, so move them elsewhere so they can be re-used. - `BackgroundMessageView` moves to `core.ui`. - `Lazy` moves to `core.common`. - `ThrowableExtensions` split; the extensions specific to throwables from network activity move to `core.network`, others move to `core.ui`. - `BindingHolder` moves to `core.ui` - Shared drawables and strings move to `core.ui`.
2024-03-16 18:42:11 +01:00
message="For locale &quot;ga&quot; (Irish) the following quantities should also be defined: `few` (e.g. &quot;3 cinn, 3 huaire, 3 chat, 3 éan, 3 bhróg&quot;), `many` (e.g. &quot;7 gcinn, 7 n-uaire, 7 gcat, 7 n-éan, 7 mbróg&quot;), `one` (e.g. &quot;1 cheann, 1 uair, 1 chat, 1 éan, 1 bhróg&quot;), `two` (e.g. &quot;2 cheann, 2 uair, 2 chat, 2 éan, 2 bhróig&quot;)"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
errorLine1=" &lt;plurals name=&quot;notification_title_summary&quot;>"
errorLine2=" ^">
<location
refactor: Extract user list functionality to `feature:lists` (#537) Move `ListsActivity`, along with fragments and viewmodels, to a new `feature:lists` module. Previous code used the `item_follow_request` layout, which was not ideal, so update it to use a dedicated layout, `item_account_in_list`. The UI uses strings and views originally defined in the main app, so move them elsewhere so they can be re-used. - `BackgroundMessageView` moves to `core.ui`. - `Lazy` moves to `core.common`. - `ThrowableExtensions` split; the extensions specific to throwables from network activity move to `core.network`, others move to `core.ui`. - `BindingHolder` moves to `core.ui` - Shared drawables and strings move to `core.ui`.
2024-03-16 18:42:11 +01:00
file="src/main/res/values-ga/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="162"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
<issue
id="MissingQuantity"
refactor: Modularise "about" activities (#405) Continue modularisation by moving activities in the "About" feature to a new `feature.about` module. Implement `feature.about: - Move `AboutActivity`, `LicenseActivity`, and `PrivacyPolicyActivity` here. - Update `markdown2resource` plugin to work with libraries Implement `core.data`: - Types and repositories used through the app - Move `InstanceInfo` and `InstanceInfoRepository` here so they are available to `feature.about`. Implement `core.ui`: - App-specific views, spans, and other UI content - Move `ClickableSpanTextView` and `NoUnderlineURLSpan` here so they are available to `feature.about`.
2024-02-02 15:14:31 +01:00
message="For locale &quot;sl&quot; (Slovenian) the following quantities should also be defined: `few` (e.g. &quot;3 dnevi&quot;), `one` (e.g. &quot;1 dan&quot;), `two` (e.g. &quot;2 dneva&quot;)"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
errorLine1=" &lt;plurals name=&quot;notification_title_summary&quot;>"
errorLine2=" ^">
<location
refactor: Modularise "about" activities (#405) Continue modularisation by moving activities in the "About" feature to a new `feature.about` module. Implement `feature.about: - Move `AboutActivity`, `LicenseActivity`, and `PrivacyPolicyActivity` here. - Update `markdown2resource` plugin to work with libraries Implement `core.data`: - Types and repositories used through the app - Move `InstanceInfo` and `InstanceInfoRepository` here so they are available to `feature.about`. Implement `core.ui`: - App-specific views, spans, and other UI content - Move `ClickableSpanTextView` and `NoUnderlineURLSpan` here so they are available to `feature.about`.
2024-02-02 15:14:31 +01:00
file="src/main/res/values-sl/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="174"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
<issue
id="MissingQuantity"
message="For locale &quot;cs&quot; (Czech) the following quantity should also be defined: `many` (e.g. &quot;10.0 dne&quot;)"
errorLine1=" &lt;plurals name=&quot;notification_title_summary&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-cs/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="188"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
<issue
id="MissingQuantity"
message="For locale &quot;bn&quot; (Bangla) the following quantity should also be defined: `one` (e.g. &quot;সসে 1টি আপেল খেল, সেটা ভাল&quot;)"
errorLine1=" &lt;plurals name=&quot;notification_title_summary&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-bn-rIN/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="195"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
<issue
id="MissingQuantity"
message="For locale &quot;eu&quot; (Basque) the following quantity should also be defined: `one` (e.g. &quot;1 lagun etorri da&quot;)"
errorLine1=" &lt;plurals name=&quot;hint_describe_for_visually_impaired&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-eu/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="202"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
<issue
id="MissingQuantity"
message="For locale &quot;sl&quot; (Slovenian) the following quantities should also be defined: `few` (e.g. &quot;3 dnevi&quot;), `one` (e.g. &quot;1 dan&quot;), `two` (e.g. &quot;2 dneva&quot;)"
errorLine1=" &lt;plurals name=&quot;hint_describe_for_visually_impaired&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-sl/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="208"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
<issue
id="MissingQuantity"
refactor: Modularise "about" activities (#405) Continue modularisation by moving activities in the "About" feature to a new `feature.about` module. Implement `feature.about: - Move `AboutActivity`, `LicenseActivity`, and `PrivacyPolicyActivity` here. - Update `markdown2resource` plugin to work with libraries Implement `core.data`: - Types and repositories used through the app - Move `InstanceInfo` and `InstanceInfoRepository` here so they are available to `feature.about`. Implement `core.ui`: - App-specific views, spans, and other UI content - Move `ClickableSpanTextView` and `NoUnderlineURLSpan` here so they are available to `feature.about`.
2024-02-02 15:14:31 +01:00
message="For locale &quot;ca&quot; (Catalan) the following quantity should also be defined: `many`"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
errorLine1=" &lt;plurals name=&quot;hint_describe_for_visually_impaired&quot;>"
errorLine2=" ^">
<location
refactor: Modularise "about" activities (#405) Continue modularisation by moving activities in the "About" feature to a new `feature.about` module. Implement `feature.about: - Move `AboutActivity`, `LicenseActivity`, and `PrivacyPolicyActivity` here. - Update `markdown2resource` plugin to work with libraries Implement `core.data`: - Types and repositories used through the app - Move `InstanceInfo` and `InstanceInfoRepository` here so they are available to `feature.about`. Implement `core.ui`: - App-specific views, spans, and other UI content - Move `ClickableSpanTextView` and `NoUnderlineURLSpan` here so they are available to `feature.about`.
2024-02-02 15:14:31 +01:00
file="src/main/res/values-ca/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="230"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
change: Increase compileSdk and targetSdk to 34 (#150) Associated changes: - Handle new null/non-null type signatures in overriden methods - Configure Robolectric to use SDK 33 (current highest supported version)
2023-10-11 12:28:45 +02:00
<issue
id="MissingQuantity"
refactor: Modularise "about" activities (#405) Continue modularisation by moving activities in the "About" feature to a new `feature.about` module. Implement `feature.about: - Move `AboutActivity`, `LicenseActivity`, and `PrivacyPolicyActivity` here. - Update `markdown2resource` plugin to work with libraries Implement `core.data`: - Types and repositories used through the app - Move `InstanceInfo` and `InstanceInfoRepository` here so they are available to `feature.about`. Implement `core.ui`: - App-specific views, spans, and other UI content - Move `ClickableSpanTextView` and `NoUnderlineURLSpan` here so they are available to `feature.about`.
2024-02-02 15:14:31 +01:00
message="For locale &quot;cs&quot; (Czech) the following quantity should also be defined: `many` (e.g. &quot;10.0 dne&quot;)"
change: Increase compileSdk and targetSdk to 34 (#150) Associated changes: - Handle new null/non-null type signatures in overriden methods - Configure Robolectric to use SDK 33 (current highest supported version)
2023-10-11 12:28:45 +02:00
errorLine1=" &lt;plurals name=&quot;hint_describe_for_visually_impaired&quot;>"
errorLine2=" ^">
<location
refactor: Modularise "about" activities (#405) Continue modularisation by moving activities in the "About" feature to a new `feature.about` module. Implement `feature.about: - Move `AboutActivity`, `LicenseActivity`, and `PrivacyPolicyActivity` here. - Update `markdown2resource` plugin to work with libraries Implement `core.data`: - Types and repositories used through the app - Move `InstanceInfo` and `InstanceInfoRepository` here so they are available to `feature.about`. Implement `core.ui`: - App-specific views, spans, and other UI content - Move `ClickableSpanTextView` and `NoUnderlineURLSpan` here so they are available to `feature.about`.
2024-02-02 15:14:31 +01:00
file="src/main/res/values-cs/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="231"
change: Increase compileSdk and targetSdk to 34 (#150) Associated changes: - Handle new null/non-null type signatures in overriden methods - Configure Robolectric to use SDK 33 (current highest supported version)
2023-10-11 12:28:45 +02:00
column="5"/>
</issue>
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<issue
id="MissingQuantity"
refactor: Modularise "about" activities (#405) Continue modularisation by moving activities in the "About" feature to a new `feature.about` module. Implement `feature.about: - Move `AboutActivity`, `LicenseActivity`, and `PrivacyPolicyActivity` here. - Update `markdown2resource` plugin to work with libraries Implement `core.data`: - Types and repositories used through the app - Move `InstanceInfo` and `InstanceInfoRepository` here so they are available to `feature.about`. Implement `core.ui`: - App-specific views, spans, and other UI content - Move `ClickableSpanTextView` and `NoUnderlineURLSpan` here so they are available to `feature.about`.
2024-02-02 15:14:31 +01:00
message="For locale &quot;bn&quot; (Bangla) the following quantity should also be defined: `one` (e.g. &quot;সসে 1টি আপেল খেল, সেটা ভাল&quot;)"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
errorLine1=" &lt;plurals name=&quot;hint_describe_for_visually_impaired&quot;>"
errorLine2=" ^">
<location
refactor: Modularise "about" activities (#405) Continue modularisation by moving activities in the "About" feature to a new `feature.about` module. Implement `feature.about: - Move `AboutActivity`, `LicenseActivity`, and `PrivacyPolicyActivity` here. - Update `markdown2resource` plugin to work with libraries Implement `core.data`: - Types and repositories used through the app - Move `InstanceInfo` and `InstanceInfoRepository` here so they are available to `feature.about`. Implement `core.ui`: - App-specific views, spans, and other UI content - Move `ClickableSpanTextView` and `NoUnderlineURLSpan` here so they are available to `feature.about`.
2024-02-02 15:14:31 +01:00
file="src/main/res/values-bn-rIN/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="236"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
<issue
id="MissingQuantity"
refactor: Extract user list functionality to `feature:lists` (#537) Move `ListsActivity`, along with fragments and viewmodels, to a new `feature:lists` module. Previous code used the `item_follow_request` layout, which was not ideal, so update it to use a dedicated layout, `item_account_in_list`. The UI uses strings and views originally defined in the main app, so move them elsewhere so they can be re-used. - `BackgroundMessageView` moves to `core.ui`. - `Lazy` moves to `core.common`. - `ThrowableExtensions` split; the extensions specific to throwables from network activity move to `core.network`, others move to `core.ui`. - `BindingHolder` moves to `core.ui` - Shared drawables and strings move to `core.ui`.
2024-03-16 18:42:11 +01:00
message="For locale &quot;ga&quot; (Irish) the following quantities should also be defined: `few` (e.g. &quot;3 cinn, 3 huaire, 3 chat, 3 éan, 3 bhróg&quot;), `many` (e.g. &quot;7 gcinn, 7 n-uaire, 7 gcat, 7 n-éan, 7 mbróg&quot;), `one` (e.g. &quot;1 cheann, 1 uair, 1 chat, 1 éan, 1 bhróg&quot;), `two` (e.g. &quot;2 cheann, 2 uair, 2 chat, 2 éan, 2 bhróig&quot;)"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
errorLine1=" &lt;plurals name=&quot;hint_describe_for_visually_impaired&quot;>"
errorLine2=" ^">
<location
refactor: Extract user list functionality to `feature:lists` (#537) Move `ListsActivity`, along with fragments and viewmodels, to a new `feature:lists` module. Previous code used the `item_follow_request` layout, which was not ideal, so update it to use a dedicated layout, `item_account_in_list`. The UI uses strings and views originally defined in the main app, so move them elsewhere so they can be re-used. - `BackgroundMessageView` moves to `core.ui`. - `Lazy` moves to `core.common`. - `ThrowableExtensions` split; the extensions specific to throwables from network activity move to `core.network`, others move to `core.ui`. - `BindingHolder` moves to `core.ui` - Shared drawables and strings move to `core.ui`.
2024-03-16 18:42:11 +01:00
file="src/main/res/values-ga/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="263"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
<issue
id="MissingQuantity"
refactor: Extract user list functionality to `feature:lists` (#537) Move `ListsActivity`, along with fragments and viewmodels, to a new `feature:lists` module. Previous code used the `item_follow_request` layout, which was not ideal, so update it to use a dedicated layout, `item_account_in_list`. The UI uses strings and views originally defined in the main app, so move them elsewhere so they can be re-used. - `BackgroundMessageView` moves to `core.ui`. - `Lazy` moves to `core.common`. - `ThrowableExtensions` split; the extensions specific to throwables from network activity move to `core.network`, others move to `core.ui`. - `BindingHolder` moves to `core.ui` - Shared drawables and strings move to `core.ui`.
2024-03-16 18:42:11 +01:00
message="For locale &quot;hi&quot; (Hindi) the following quantity should also be defined: `one` (e.g. &quot;1 घंटा&quot;)"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
errorLine1=" &lt;plurals name=&quot;hint_describe_for_visually_impaired&quot;>"
errorLine2=" ^">
<location
refactor: Extract user list functionality to `feature:lists` (#537) Move `ListsActivity`, along with fragments and viewmodels, to a new `feature:lists` module. Previous code used the `item_follow_request` layout, which was not ideal, so update it to use a dedicated layout, `item_account_in_list`. The UI uses strings and views originally defined in the main app, so move them elsewhere so they can be re-used. - `BackgroundMessageView` moves to `core.ui`. - `Lazy` moves to `core.common`. - `ThrowableExtensions` split; the extensions specific to throwables from network activity move to `core.network`, others move to `core.ui`. - `BindingHolder` moves to `core.ui` - Shared drawables and strings move to `core.ui`.
2024-03-16 18:42:11 +01:00
file="src/main/res/values-hi/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="265"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
change: Increase compileSdk and targetSdk to 34 (#150) Associated changes: - Handle new null/non-null type signatures in overriden methods - Configure Robolectric to use SDK 33 (current highest supported version)
2023-10-11 12:28:45 +02:00
<issue
id="MissingQuantity"
message="For locale &quot;ca&quot; (Catalan) the following quantity should also be defined: `many`"
errorLine1=" &lt;plurals name=&quot;favs&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-ca/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="267"
change: Increase compileSdk and targetSdk to 34 (#150) Associated changes: - Handle new null/non-null type signatures in overriden methods - Configure Robolectric to use SDK 33 (current highest supported version)
2023-10-11 12:28:45 +02:00
column="5"/>
</issue>
<issue
id="MissingQuantity"
refactor: Modularise "about" activities (#405) Continue modularisation by moving activities in the "About" feature to a new `feature.about` module. Implement `feature.about: - Move `AboutActivity`, `LicenseActivity`, and `PrivacyPolicyActivity` here. - Update `markdown2resource` plugin to work with libraries Implement `core.data`: - Types and repositories used through the app - Move `InstanceInfo` and `InstanceInfoRepository` here so they are available to `feature.about`. Implement `core.ui`: - App-specific views, spans, and other UI content - Move `ClickableSpanTextView` and `NoUnderlineURLSpan` here so they are available to `feature.about`.
2024-02-02 15:14:31 +01:00
message="For locale &quot;ca&quot; (Catalan) the following quantity should also be defined: `many`"
errorLine1=" &lt;plurals name=&quot;reblogs&quot;>"
change: Increase compileSdk and targetSdk to 34 (#150) Associated changes: - Handle new null/non-null type signatures in overriden methods - Configure Robolectric to use SDK 33 (current highest supported version)
2023-10-11 12:28:45 +02:00
errorLine2=" ^">
<location
refactor: Modularise "about" activities (#405) Continue modularisation by moving activities in the "About" feature to a new `feature.about` module. Implement `feature.about: - Move `AboutActivity`, `LicenseActivity`, and `PrivacyPolicyActivity` here. - Update `markdown2resource` plugin to work with libraries Implement `core.data`: - Types and repositories used through the app - Move `InstanceInfo` and `InstanceInfoRepository` here so they are available to `feature.about`. Implement `core.ui`: - App-specific views, spans, and other UI content - Move `ClickableSpanTextView` and `NoUnderlineURLSpan` here so they are available to `feature.about`.
2024-02-02 15:14:31 +01:00
file="src/main/res/values-ca/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="271"
change: Increase compileSdk and targetSdk to 34 (#150) Associated changes: - Handle new null/non-null type signatures in overriden methods - Configure Robolectric to use SDK 33 (current highest supported version)
2023-10-11 12:28:45 +02:00
column="5"/>
</issue>
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<issue
id="MissingQuantity"
refactor: Modularise "about" activities (#405) Continue modularisation by moving activities in the "About" feature to a new `feature.about` module. Implement `feature.about: - Move `AboutActivity`, `LicenseActivity`, and `PrivacyPolicyActivity` here. - Update `markdown2resource` plugin to work with libraries Implement `core.data`: - Types and repositories used through the app - Move `InstanceInfo` and `InstanceInfoRepository` here so they are available to `feature.about`. Implement `core.ui`: - App-specific views, spans, and other UI content - Move `ClickableSpanTextView` and `NoUnderlineURLSpan` here so they are available to `feature.about`.
2024-02-02 15:14:31 +01:00
message="For locale &quot;cs&quot; (Czech) the following quantity should also be defined: `many` (e.g. &quot;10.0 dne&quot;)"
errorLine1=" &lt;plurals name=&quot;favs&quot;>"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
errorLine2=" ^">
<location
refactor: Modularise "about" activities (#405) Continue modularisation by moving activities in the "About" feature to a new `feature.about` module. Implement `feature.about: - Move `AboutActivity`, `LicenseActivity`, and `PrivacyPolicyActivity` here. - Update `markdown2resource` plugin to work with libraries Implement `core.data`: - Types and repositories used through the app - Move `InstanceInfo` and `InstanceInfoRepository` here so they are available to `feature.about`. Implement `core.ui`: - App-specific views, spans, and other UI content - Move `ClickableSpanTextView` and `NoUnderlineURLSpan` here so they are available to `feature.about`.
2024-02-02 15:14:31 +01:00
file="src/main/res/values-cs/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="272"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
<issue
id="MissingQuantity"
message="For locale &quot;cs&quot; (Czech) the following quantity should also be defined: `many` (e.g. &quot;10.0 dne&quot;)"
errorLine1=" &lt;plurals name=&quot;reblogs&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-cs/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="277"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
change: Increase compileSdk and targetSdk to 34 (#150) Associated changes: - Handle new null/non-null type signatures in overriden methods - Configure Robolectric to use SDK 33 (current highest supported version)
2023-10-11 12:28:45 +02:00
<issue
id="MissingQuantity"
message="For locale &quot;ca&quot; (Catalan) the following quantity should also be defined: `many`"
errorLine1=" &lt;plurals name=&quot;poll_info_votes&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-ca/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="296"
change: Increase compileSdk and targetSdk to 34 (#150) Associated changes: - Handle new null/non-null type signatures in overriden methods - Configure Robolectric to use SDK 33 (current highest supported version)
2023-10-11 12:28:45 +02:00
column="5"/>
</issue>
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<issue
id="MissingQuantity"
message="For locale &quot;cs&quot; (Czech) the following quantity should also be defined: `many` (e.g. &quot;10.0 dne&quot;)"
errorLine1=" &lt;plurals name=&quot;poll_info_votes&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-cs/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="307"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
<issue
id="MissingQuantity"
message="For locale &quot;cs&quot; (Czech) the following quantity should also be defined: `many` (e.g. &quot;10.0 dne&quot;)"
errorLine1=" &lt;plurals name=&quot;poll_timespan_days&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-cs/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="321"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
<issue
id="MissingQuantity"
message="For locale &quot;cs&quot; (Czech) the following quantity should also be defined: `many` (e.g. &quot;10.0 dne&quot;)"
errorLine1=" &lt;plurals name=&quot;poll_timespan_minutes&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-cs/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="326"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
<issue
id="MissingQuantity"
message="For locale &quot;cs&quot; (Czech) the following quantity should also be defined: `many` (e.g. &quot;10.0 dne&quot;)"
errorLine1=" &lt;plurals name=&quot;poll_timespan_seconds&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-cs/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="331"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
<issue
id="MissingQuantity"
refactor: Remove unnecessary whitespace in poll_info_format resource (#595)
2024-04-05 16:46:38 +02:00
message="For locale &quot;bg&quot; (Bulgarian) the following quantity should also be defined: `one` (e.g. &quot;1 ден&quot;)"
errorLine1=" &lt;plurals name=&quot;error_upload_max_media_reached&quot;>"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
errorLine2=" ^">
<location
refactor: Remove unnecessary whitespace in poll_info_format resource (#595)
2024-04-05 16:46:38 +02:00
file="src/main/res/values-bg/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="363"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
change: Increase compileSdk and targetSdk to 34 (#150) Associated changes: - Handle new null/non-null type signatures in overriden methods - Configure Robolectric to use SDK 33 (current highest supported version)
2023-10-11 12:28:45 +02:00
<issue
id="MissingQuantity"
refactor: Remove unnecessary whitespace in poll_info_format resource (#595)
2024-04-05 16:46:38 +02:00
message="For locale &quot;ca&quot; (Catalan) the following quantity should also be defined: `many`"
errorLine1=" &lt;plurals name=&quot;poll_info_people&quot;>"
change: Increase compileSdk and targetSdk to 34 (#150) Associated changes: - Handle new null/non-null type signatures in overriden methods - Configure Robolectric to use SDK 33 (current highest supported version)
2023-10-11 12:28:45 +02:00
errorLine2=" ^">
<location
refactor: Remove unnecessary whitespace in poll_info_format resource (#595)
2024-04-05 16:46:38 +02:00
file="src/main/res/values-ca/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="363"
change: Increase compileSdk and targetSdk to 34 (#150) Associated changes: - Handle new null/non-null type signatures in overriden methods - Configure Robolectric to use SDK 33 (current highest supported version)
2023-10-11 12:28:45 +02:00
column="5"/>
</issue>
<issue
id="MissingQuantity"
message="For locale &quot;ca&quot; (Catalan) the following quantity should also be defined: `many`"
errorLine1=" &lt;plurals name=&quot;poll_timespan_seconds&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-ca/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="391"
change: Increase compileSdk and targetSdk to 34 (#150) Associated changes: - Handle new null/non-null type signatures in overriden methods - Configure Robolectric to use SDK 33 (current highest supported version)
2023-10-11 12:28:45 +02:00
column="5"/>
</issue>
<issue
id="MissingQuantity"
message="For locale &quot;ca&quot; (Catalan) the following quantity should also be defined: `many`"
errorLine1=" &lt;plurals name=&quot;poll_timespan_minutes&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-ca/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="395"
change: Increase compileSdk and targetSdk to 34 (#150) Associated changes: - Handle new null/non-null type signatures in overriden methods - Configure Robolectric to use SDK 33 (current highest supported version)
2023-10-11 12:28:45 +02:00
column="5"/>
</issue>
<issue
id="MissingQuantity"
message="For locale &quot;ca&quot; (Catalan) the following quantity should also be defined: `many`"
errorLine1=" &lt;plurals name=&quot;poll_timespan_hours&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-ca/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="399"
change: Increase compileSdk and targetSdk to 34 (#150) Associated changes: - Handle new null/non-null type signatures in overriden methods - Configure Robolectric to use SDK 33 (current highest supported version)
2023-10-11 12:28:45 +02:00
column="5"/>
</issue>
<issue
id="MissingQuantity"
message="For locale &quot;ca&quot; (Catalan) the following quantity should also be defined: `many`"
errorLine1=" &lt;plurals name=&quot;poll_timespan_days&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-ca/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="403"
change: Increase compileSdk and targetSdk to 34 (#150) Associated changes: - Handle new null/non-null type signatures in overriden methods - Configure Robolectric to use SDK 33 (current highest supported version)
2023-10-11 12:28:45 +02:00
column="5"/>
</issue>
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<issue
id="MissingQuantity"
message="For locale &quot;cs&quot; (Czech) the following quantity should also be defined: `many` (e.g. &quot;10.0 dne&quot;)"
errorLine1=" &lt;plurals name=&quot;poll_info_people&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-cs/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="411"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
<issue
id="MissingQuantity"
message="For locale &quot;cs&quot; (Czech) the following quantity should also be defined: `many` (e.g. &quot;10.0 dne&quot;)"
errorLine1=" &lt;plurals name=&quot;poll_timespan_hours&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-cs/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="416"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
change: Increase compileSdk and targetSdk to 34 (#150) Associated changes: - Handle new null/non-null type signatures in overriden methods - Configure Robolectric to use SDK 33 (current highest supported version)
2023-10-11 12:28:45 +02:00
<issue
id="MissingQuantity"
refactor: Modularise "about" activities (#405) Continue modularisation by moving activities in the "About" feature to a new `feature.about` module. Implement `feature.about: - Move `AboutActivity`, `LicenseActivity`, and `PrivacyPolicyActivity` here. - Update `markdown2resource` plugin to work with libraries Implement `core.data`: - Types and repositories used through the app - Move `InstanceInfo` and `InstanceInfoRepository` here so they are available to `feature.about`. Implement `core.ui`: - App-specific views, spans, and other UI content - Move `ClickableSpanTextView` and `NoUnderlineURLSpan` here so they are available to `feature.about`.
2024-02-02 15:14:31 +01:00
message="For locale &quot;ca&quot; (Catalan) the following quantity should also be defined: `many`"
change: Increase compileSdk and targetSdk to 34 (#150) Associated changes: - Handle new null/non-null type signatures in overriden methods - Configure Robolectric to use SDK 33 (current highest supported version)
2023-10-11 12:28:45 +02:00
errorLine1=" &lt;plurals name=&quot;error_upload_max_media_reached&quot;>"
errorLine2=" ^">
<location
refactor: Modularise "about" activities (#405) Continue modularisation by moving activities in the "About" feature to a new `feature.about` module. Implement `feature.about: - Move `AboutActivity`, `LicenseActivity`, and `PrivacyPolicyActivity` here. - Update `markdown2resource` plugin to work with libraries Implement `core.data`: - Types and repositories used through the app - Move `InstanceInfo` and `InstanceInfoRepository` here so they are available to `feature.about`. Implement `core.ui`: - App-specific views, spans, and other UI content - Move `ClickableSpanTextView` and `NoUnderlineURLSpan` here so they are available to `feature.about`.
2024-02-02 15:14:31 +01:00
file="src/main/res/values-ca/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="419"
change: Increase compileSdk and targetSdk to 34 (#150) Associated changes: - Handle new null/non-null type signatures in overriden methods - Configure Robolectric to use SDK 33 (current highest supported version)
2023-10-11 12:28:45 +02:00
column="5"/>
</issue>
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<issue
id="MissingQuantity"
refactor: Modularise "about" activities (#405) Continue modularisation by moving activities in the "About" feature to a new `feature.about` module. Implement `feature.about: - Move `AboutActivity`, `LicenseActivity`, and `PrivacyPolicyActivity` here. - Update `markdown2resource` plugin to work with libraries Implement `core.data`: - Types and repositories used through the app - Move `InstanceInfo` and `InstanceInfoRepository` here so they are available to `feature.about`. Implement `core.ui`: - App-specific views, spans, and other UI content - Move `ClickableSpanTextView` and `NoUnderlineURLSpan` here so they are available to `feature.about`.
2024-02-02 15:14:31 +01:00
message="For locale &quot;cs&quot; (Czech) the following quantity should also be defined: `many` (e.g. &quot;10.0 dne&quot;)"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
errorLine1=" &lt;plurals name=&quot;error_upload_max_media_reached&quot;>"
errorLine2=" ^">
<location
refactor: Modularise "about" activities (#405) Continue modularisation by moving activities in the "About" feature to a new `feature.about` module. Implement `feature.about: - Move `AboutActivity`, `LicenseActivity`, and `PrivacyPolicyActivity` here. - Update `markdown2resource` plugin to work with libraries Implement `core.data`: - Types and repositories used through the app - Move `InstanceInfo` and `InstanceInfoRepository` here so they are available to `feature.about`. Implement `core.ui`: - App-specific views, spans, and other UI content - Move `ClickableSpanTextView` and `NoUnderlineURLSpan` here so they are available to `feature.about`.
2024-02-02 15:14:31 +01:00
file="src/main/res/values-cs/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="421"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
<issue
id="Typos"
message="&quot;media&quot; is a common misspelling; did you mean &quot;medier&quot;?"
errorLine1=" &lt;string name=&quot;error_media_upload_permission&quot;>Trenger tillatelse til å lese media.&lt;/string>"
errorLine2=" ^">
<location
file="src/main/res/values-nb-rNO/strings.xml"
refactor: Extract user list functionality to `feature:lists` (#537) Move `ListsActivity`, along with fragments and viewmodels, to a new `feature:lists` module. Previous code used the `item_follow_request` layout, which was not ideal, so update it to use a dedicated layout, `item_account_in_list`. The UI uses strings and views originally defined in the main app, so move them elsewhere so they can be re-used. - `BackgroundMessageView` moves to `core.ui`. - `Lazy` moves to `core.common`. - `ThrowableExtensions` split; the extensions specific to throwables from network activity move to `core.network`, others move to `core.ui`. - `BindingHolder` moves to `core.ui` - Shared drawables and strings move to `core.ui`.
2024-03-16 18:42:11 +01:00
line="8"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="80"/>
</issue>
<issue
id="Typos"
message="&quot;media&quot; is a common misspelling; did you mean &quot;medier&quot;?"
errorLine1=" &lt;string name=&quot;error_media_download_permission&quot;>Trenger tillatelse for å lagre media.&lt;/string>"
errorLine2=" ^">
<location
file="src/main/res/values-nb-rNO/strings.xml"
refactor: Extract user list functionality to `feature:lists` (#537) Move `ListsActivity`, along with fragments and viewmodels, to a new `feature:lists` module. Previous code used the `item_follow_request` layout, which was not ideal, so update it to use a dedicated layout, `item_account_in_list`. The UI uses strings and views originally defined in the main app, so move them elsewhere so they can be re-used. - `BackgroundMessageView` moves to `core.ui`. - `Lazy` moves to `core.common`. - `ThrowableExtensions` split; the extensions specific to throwables from network activity move to `core.network`, others move to `core.ui`. - `BindingHolder` moves to `core.ui` - Shared drawables and strings move to `core.ui`.
2024-03-16 18:42:11 +01:00
line="9"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="83"/>
</issue>
<issue
id="Typos"
message="&quot;Media&quot; is a common misspelling; did you mean &quot;Medier&quot;?"
errorLine1=" &lt;string name=&quot;post_media_hidden_title&quot;>Media skjult&lt;/string>"
errorLine2=" ^">
<location
file="src/main/res/values-nb-rNO/strings.xml"
refactor: Use the PachliError type for ApiError (#739) In the previous code `PachliError` could correctly chain errors and generate error messages, `ApiError` didn't, which is why there was the temporary `ApiError.fmt()` extension function. Rewrite `ApiError` to implement `PachliError` so it gets these benefits and to reduce the number of different error-handling mechanisms in the code. Main changes: - `PachliError` is now an interface so it can be extended by other error interfaces. - All the `ApiError` subclasses implement `PachliError`, and can specify the error string and interpolated variables at the point of declaration. - Update `ListsRepository` and `ServerRepository` to return `PachliError` subclasses.
2024-06-12 10:22:27 +02:00
line="33"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="44"/>
</issue>
<issue
id="Typos"
message="&quot;birşey&quot; is a common misspelling; did you mean &quot;bir şey&quot;?"
errorLine1=" &lt;string name=&quot;footer_empty&quot;>Burada henüz hiç birşey yok. Yenilemek için aşağıya çekin!&lt;/string>"
errorLine2=" ^">
<location
file="src/main/res/values-tr/strings.xml"
refactor: Use the PachliError type for ApiError (#739) In the previous code `PachliError` could correctly chain errors and generate error messages, `ApiError` didn't, which is why there was the temporary `ApiError.fmt()` extension function. Rewrite `ApiError` to implement `PachliError` so it gets these benefits and to reduce the number of different error-handling mechanisms in the code. Main changes: - `PachliError` is now an interface so it can be extended by other error interfaces. - All the `ApiError` subclasses implement `PachliError`, and can specify the error string and interpolated variables at the point of declaration. - Update `ListsRepository` and `ServerRepository` to return `PachliError` subclasses.
2024-06-12 10:22:27 +02:00
line="39"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="50"/>
</issue>
<issue
id="Typos"
message="&quot;hiç birşey&quot; is a common misspelling; did you mean &quot;hiçbir şey&quot;?"
errorLine1=" &lt;string name=&quot;footer_empty&quot;>Burada henüz hiç birşey yok. Yenilemek için aşağıya çekin!&lt;/string>"
errorLine2=" ^">
<location
file="src/main/res/values-tr/strings.xml"
refactor: Use the PachliError type for ApiError (#739) In the previous code `PachliError` could correctly chain errors and generate error messages, `ApiError` didn't, which is why there was the temporary `ApiError.fmt()` extension function. Rewrite `ApiError` to implement `PachliError` so it gets these benefits and to reduce the number of different error-handling mechanisms in the code. Main changes: - `PachliError` is now an interface so it can be extended by other error interfaces. - All the `ApiError` subclasses implement `PachliError`, and can specify the error string and interpolated variables at the point of declaration. - Update `ListsRepository` and `ServerRepository` to return `PachliError` subclasses.
2024-06-12 10:22:27 +02:00
line="39"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="46"/>
</issue>
<issue
id="Typos"
message="&quot;Media&quot; is a common misspelling; did you mean &quot;Medier&quot;?"
errorLine1=" &lt;string name=&quot;action_view_media&quot;>Media&lt;/string>"
errorLine2=" ^">
<location
file="src/main/res/values-nb-rNO/strings.xml"
refactor: Use the PachliError type for ApiError (#739) In the previous code `PachliError` could correctly chain errors and generate error messages, `ApiError` didn't, which is why there was the temporary `ApiError.fmt()` extension function. Rewrite `ApiError` to implement `PachliError` so it gets these benefits and to reduce the number of different error-handling mechanisms in the code. Main changes: - `PachliError` is now an interface so it can be extended by other error interfaces. - All the `ApiError` subclasses implement `PachliError`, and can specify the error string and interpolated variables at the point of declaration. - Update `ListsRepository` and `ServerRepository` to return `PachliError` subclasses.
2024-06-12 10:22:27 +02:00
line="70"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="38"/>
</issue>
<issue
id="Typos"
message="&quot;media&quot; is a common misspelling; did you mean &quot;medier&quot;?"
errorLine1=" &lt;string name=&quot;action_add_media&quot;>Legg til media&lt;/string>"
errorLine2=" ^">
<location
file="src/main/res/values-nb-rNO/strings.xml"
refactor: Use the PachliError type for ApiError (#739) In the previous code `PachliError` could correctly chain errors and generate error messages, `ApiError` didn't, which is why there was the temporary `ApiError.fmt()` extension function. Rewrite `ApiError` to implement `PachliError` so it gets these benefits and to reduce the number of different error-handling mechanisms in the code. Main changes: - `PachliError` is now an interface so it can be extended by other error interfaces. - All the `ApiError` subclasses implement `PachliError`, and can specify the error string and interpolated variables at the point of declaration. - Update `ListsRepository` and `ServerRepository` to return `PachliError` subclasses.
2024-06-12 10:22:27 +02:00
line="72"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="46"/>
</issue>
<issue
id="Typos"
message="&quot;media&quot; is a common misspelling; did you mean &quot;medier&quot;?"
errorLine1=" &lt;string name=&quot;action_hide_media&quot;>Skjul media&lt;/string>"
errorLine2=" ^">
<location
file="src/main/res/values-nb-rNO/strings.xml"
refactor: Use the PachliError type for ApiError (#739) In the previous code `PachliError` could correctly chain errors and generate error messages, `ApiError` didn't, which is why there was the temporary `ApiError.fmt()` extension function. Rewrite `ApiError` to implement `PachliError` so it gets these benefits and to reduce the number of different error-handling mechanisms in the code. Main changes: - `PachliError` is now an interface so it can be extended by other error interfaces. - All the `ApiError` subclasses implement `PachliError`, and can specify the error string and interpolated variables at the point of declaration. - Update `ListsRepository` and `ServerRepository` to return `PachliError` subclasses.
2024-06-12 10:22:27 +02:00
line="78"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="44"/>
</issue>
<issue
id="Typos"
message="&quot;media&quot; is a common misspelling; did you mean &quot;medier&quot;?"
errorLine1=" &lt;string name=&quot;action_open_media_n&quot;>Åpne media #%d&lt;/string>"
errorLine2=" ^">
<location
file="src/main/res/values-nb-rNO/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="96"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="45"/>
</issue>
<issue
id="Typos"
message="&quot;media&quot; is a common misspelling; did you mean &quot;medier&quot;?"
errorLine1=" &lt;string name=&quot;download_media&quot;>Last ned media&lt;/string>"
errorLine2=" ^">
<location
file="src/main/res/values-nb-rNO/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="100"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="44"/>
</issue>
<issue
id="Typos"
message="&quot;media&quot; is a common misspelling; did you mean &quot;medier&quot;?"
errorLine1=" &lt;string name=&quot;downloading_media&quot;>Laster ned media&lt;/string>"
errorLine2=" ^">
<location
file="src/main/res/values-nb-rNO/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="101"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="49"/>
</issue>
<issue
id="Typos"
message="&quot;media&quot; is a common misspelling; did you mean &quot;medier&quot;?"
errorLine1=" &lt;string name=&quot;send_media_to&quot;>Del media til…&lt;/string>"
errorLine2=" ^">
<location
file="src/main/res/values-nb-rNO/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="104"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="38"/>
</issue>
<issue
id="Typos"
message="&quot;media&quot; is a common misspelling; did you mean &quot;medier&quot;?"
errorLine1=" &lt;string name=&quot;dialog_title_finishing_media_upload&quot;>Opplasting av media er ferdig&lt;/string>"
errorLine2=" ^">
<location
file="src/main/res/values-nb-rNO/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="119"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="70"/>
</issue>
<issue
id="Typos"
message="&quot;media&quot; is a common misspelling; did you mean &quot;medier&quot;?"
errorLine1=" &lt;string name=&quot;pref_title_show_media_preview&quot;>Last ned forhåndsvisning av media&lt;/string>"
errorLine2=" ^">
<location
file="src/main/res/values-nb-rNO/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="152"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="78"/>
</issue>
<issue
id="Typos"
message="&quot;media&quot; is a common misspelling; did you mean &quot;medier&quot;?"
errorLine1=" &lt;string name=&quot;pref_default_media_sensitivity&quot;>Marker alltid media som sensitivt&lt;/string>"
errorLine2=" ^">
<location
file="src/main/res/values-nb-rNO/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="158"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="65"/>
</issue>
<issue
id="Typos"
message="&quot;Media&quot; is a common misspelling; did you mean &quot;Medier&quot;?"
errorLine1=" &lt;string name=&quot;title_media&quot;>Media&lt;/string>"
errorLine2=" ^">
<location
file="src/main/res/values-nb-rNO/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="194"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="32"/>
</issue>
<issue
id="Typos"
message="&quot;Media&quot; is a common misspelling; did you mean &quot;Medier&quot;?"
errorLine1=" &lt;string name=&quot;description_post_media&quot;>Media: %s&lt;/string>"
errorLine2=" ^">
<location
file="src/main/res/values-nb-rNO/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="262"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="43"/>
</issue>
<issue
id="Typos"
message="&quot;media&quot; is a common misspelling; did you mean &quot;medier&quot;?"
errorLine1=" &lt;string name=&quot;pref_title_gradient_for_media&quot;>Vis fargerike gradienter for skjult media&lt;/string>"
errorLine2=" ^">
<location
file="src/main/res/values-nb-rNO/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="390"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="86"/>
</issue>
<issue
id="Typos"
message="Repeated word &quot;tek&quot; in message: possible typo"
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
errorLine1=" &lt;string name=&quot;dialog_push_notification_migration_other_accounts&quot;>Pachli\&apos;ye bildirim aboneliği izni vermek için mevcut hesabınıza yeniden giriş yaptınız. Ancak, yine de bu şekilde geçirilmemiş başka hesaplarınız var. UnifiedPush bildirimleri desteğini etkinleştirmek için bunlara geçin ve tek tek yeniden giriş yapın.&lt;/string>"
errorLine2=" ^">
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<location
file="src/main/res/values-tr/strings.xml"
feat: Provide more detail in errors, especially media upload errors (#801) Previous code assumed server responses would always be JSON, and had no special handling for mis-configured servers that sometimes return HTML; for example, if the server has a bug, or there's a reverse proxy in front of the server issuing DoS-prevention challenges. This could cause errors to show with no useful debugging information. Update `ApiResult` to check the content-type in the response and return one of two new errors if the content-type is missing or wrong. Also include the HTTP code in `ApiResponse` for use elsewhere. Update `ThrowableExtensions` to pull the `error` and optional `description` out of the error body. Update `PachliError` so `formatArgs` can be an array of arbitrary types, not just strings. Update `MediaUploader`; expose the different errors as new `MediaUploaderError` types instead of `Exception` subclasses, and return `Result<V, E>` where appropriate. Update `ComposeViewModel` to use the new `MediaUploaderError` types and create new `PickMediaError` to report issues there, replacing `VideoOrImageException`. Update `ComposeActivity` to use the new error types and show errors until the user dismisses them, so they're better able to see and report problems. Fixes #704.
2024-07-04 19:16:24 +02:00
line="497"
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
column="294"/>
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
</issue>
Use lint version 8.1.0 to fix erroneous warning about forEach (#3903) Android lint was erroneously warning that the forEach construct in Kotlin required API 24+, which is incorrect, see https://issuetracker.google.com/issues/185418482. Work around that by forcing the Android lint version to 8.1.0. This triggered some additional checks, which have been ignored, and a new baseline.
2023-07-30 21:45:43 +02:00
<issue
id="Typos"
message="&quot;Media&quot; is a common misspelling; did you mean &quot;Medier&quot;?"
errorLine1=" &lt;string name=&quot;hint_media_description_missing&quot;>Media bør ha en beskrivelse.&lt;/string>"
errorLine2=" ^">
<location
file="src/main/res/values-nb-rNO/strings.xml"
feat: Provide more detail in errors, especially media upload errors (#801) Previous code assumed server responses would always be JSON, and had no special handling for mis-configured servers that sometimes return HTML; for example, if the server has a bug, or there's a reverse proxy in front of the server issuing DoS-prevention challenges. This could cause errors to show with no useful debugging information. Update `ApiResult` to check the content-type in the response and return one of two new errors if the content-type is missing or wrong. Also include the HTTP code in `ApiResponse` for use elsewhere. Update `ThrowableExtensions` to pull the `error` and optional `description` out of the error body. Update `PachliError` so `formatArgs` can be an array of arbitrary types, not just strings. Update `MediaUploader`; expose the different errors as new `MediaUploaderError` types instead of `Exception` subclasses, and return `Result<V, E>` where appropriate. Update `ComposeViewModel` to use the new `MediaUploaderError` types and create new `PickMediaError` to report issues there, replacing `VideoOrImageException`. Update `ComposeActivity` to use the new error types and show errors until the user dismisses them, so they're better able to see and report problems. Fixes #704.
2024-07-04 19:16:24 +02:00
line="519"
Use lint version 8.1.0 to fix erroneous warning about forEach (#3903) Android lint was erroneously warning that the forEach construct in Kotlin required API 24+, which is incorrect, see https://issuetracker.google.com/issues/185418482. Work around that by forcing the Android lint version to 8.1.0. This triggered some additional checks, which have been ignored, and a new baseline.
2023-07-30 21:45:43 +02:00
column="51"/>
</issue>
fix: Correctly punctuate a status content description (#808) Previous code blindly inserted commas and semi-colons as separators between the components of a content description. If some of those components were null you could have a content description that looked like "... , , , ..." or similar, and the repeated reading of "comma" by screen readers was jarring and reduced accessibility. Fix this by inserting punctuation only where necessary, building up the string piece by piece instead of using a string resource with hardcoded punctuation. Fixes #791.
2024-07-06 19:29:02 +02:00
<issue
id="Typos"
message="Repeated word &quot;til&quot; in message: possible typo"
errorLine1=" &lt;string name=&quot;action_add_to_tab&quot;>Legg til til fane&lt;/string>"
errorLine2=" ^">
<location
file="src/main/res/values-nb-rNO/strings.xml"
line="649"
column="43"/>
</issue>
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<issue
id="ImpliedQuantity"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
message="The quantity `&apos;one&apos;` matches more than one specific number in this locale (0, 1), but the message did not include a formatting argument (such as `%d`). This is usually an internationalization error. See full issue explanation for more."
Show notifications from workers (#3760) Fix a crash where workers, in some conditions, should show a notification. These are sent to a dedicated channel with no importance. Convert NotificationWorker to a CoroutineWorker and remove its use of `runBlocking`. Fixes #3754
2023-06-29 18:37:27 +02:00
errorLine1=" &lt;item quantity=&quot;one&quot;>برهم‌کنشی جدید&lt;/item>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<location
file="src/main/res/values-fa/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="171"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="9"/>
</issue>
<issue
id="ImpliedQuantity"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
message="The quantity `&apos;one&apos;` matches more than one specific number in this locale (0, 1), but the message did not include a formatting argument (such as `%d`). This is usually an internationalization error. See full issue explanation for more."
Show notifications from workers (#3760) Fix a crash where workers, in some conditions, should show a notification. These are sent to a dedicated channel with no importance. Convert NotificationWorker to a CoroutineWorker and remove its use of `runBlocking`. Fixes #3754
2023-06-29 18:37:27 +02:00
errorLine1=" &lt;item quantity=&quot;one&quot;>توصیف محتوا برای کم‌بینایان (کران ۱ نویسه)&lt;/item>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<location
file="src/main/res/values-fa/strings.xml"
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
line="200"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="9"/>
</issue>
<issue
id="PluralsCandidate"
message="Formatting %d followed by words (&quot;posts&quot;): This should probably be a plural rather than a string"
errorLine1=" &lt;string name=&quot;notification_summary_report_format&quot;>%s · %d posts attached&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Provide more detail in errors, especially media upload errors (#801) Previous code assumed server responses would always be JSON, and had no special handling for mis-configured servers that sometimes return HTML; for example, if the server has a bug, or there's a reverse proxy in front of the server issuing DoS-prevention challenges. This could cause errors to show with no useful debugging information. Update `ApiResult` to check the content-type in the response and return one of two new errors if the content-type is missing or wrong. Also include the HTTP code in `ApiResponse` for use elsewhere. Update `ThrowableExtensions` to pull the `error` and optional `description` out of the error body. Update `PachliError` so `formatArgs` can be an array of arbitrary types, not just strings. Update `MediaUploader`; expose the different errors as new `MediaUploaderError` types instead of `Exception` subclasses, and return `Result<V, E>` where appropriate. Update `ComposeViewModel` to use the new `MediaUploaderError` types and create new `PickMediaError` to report issues there, replacing `VideoOrImageException`. Update `ComposeActivity` to use the new error types and show errors until the user dismisses them, so they're better able to see and report problems. Fixes #704.
2024-07-04 19:16:24 +02:00
line="99"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
<issue
id="PluralsCandidate"
message="Formatting %d followed by words (&quot;and&quot;): This should probably be a plural rather than a string"
errorLine1=" &lt;string name=&quot;pref_title_http_proxy_port_message&quot;>Port should be between %d and %d&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="283"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
<issue
id="PluralsCandidate"
message="Formatting %d followed by words (&quot;others&quot;): This should probably be a plural rather than a string"
errorLine1=" &lt;string name=&quot;notification_summary_large&quot;>%1$s, %2$s, %3$s and %4$d others&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="334"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
<issue
Use lint version 8.1.0 to fix erroneous warning about forEach (#3903) Android lint was erroneously warning that the forEach construct in Kotlin required API 24+, which is incorrect, see https://issuetracker.google.com/issues/185418482. Work around that by forcing the Android lint version to 8.1.0. This triggered some additional checks, which have been ignored, and a new baseline.
2023-07-30 21:45:43 +02:00
id="PluralsCandidate"
message="Formatting %d followed by words (&quot;more&quot;): This should probably be a plural rather than a string"
errorLine1=" &lt;string name=&quot;conversation_more_recipients&quot;>%1$s, %2$s and %3$d more&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<location
Use lint version 8.1.0 to fix erroneous warning about forEach (#3903) Android lint was erroneously warning that the forEach construct in Kotlin required API 24+, which is incorrect, see https://issuetracker.google.com/issues/185418482. Work around that by forcing the Android lint version to 8.1.0. This triggered some additional checks, which have been ignored, and a new baseline.
2023-07-30 21:45:43 +02:00
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="453"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
<issue
Use lint version 8.1.0 to fix erroneous warning about forEach (#3903) Android lint was erroneously warning that the forEach construct in Kotlin required API 24+, which is incorrect, see https://issuetracker.google.com/issues/185418482. Work around that by forcing the Android lint version to 8.1.0. This triggered some additional checks, which have been ignored, and a new baseline.
2023-07-30 21:45:43 +02:00
id="PluralsCandidate"
message="Formatting %d followed by words (&quot;people&quot;): This should probably be a plural rather than a string"
errorLine1=" &lt;string name=&quot;accessibility_talking_about_tag&quot;>%1$d people are talking about hashtag %2$s&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<location
Use lint version 8.1.0 to fix erroneous warning about forEach (#3903) Android lint was erroneously warning that the forEach construct in Kotlin required API 24+, which is incorrect, see https://issuetracker.google.com/issues/185418482. Work around that by forcing the Android lint version to 8.1.0. This triggered some additional checks, which have been ignored, and a new baseline.
2023-07-30 21:45:43 +02:00
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="629"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="5"/>
</issue>
<issue
id="UnusedTranslation"
message="The language `ber (Berber languages)` is present in this project, but not declared in the `localeConfig` resource"
feat: Use Let's Encrypt certificates on API 23 devices (#640) Android 7 devices no longer trust certificates issued by Let's Encrypt (see https://letsencrypt.org/2020/11/06/own-two-feet and https://letsencrypt.org/2023/07/10/cross-sign-expiration.html for details). To work around that provide the Let's Encrypt root certs as resources. On API 24+ devices add those via network_security_config.xml. On API 23 devices they need to be installed manually for OkHttp SSL connections, and checked when there is an SSL error in LoginWebViewActivity. The root certificates were downloaded from https://letsencrypt.org/certificates/: - https://letsencrypt.org/certs/isrgrootx1.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x1-cross-signed.der (cross-signed) - https://letsencrypt.org/certs/isrg-root-x2.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x2-cross-signed.der (cross-signed) Fixes #638
2024-04-24 10:32:50 +02:00
errorLine1=" android:localeConfig=&quot;@xml/locales_config&quot;"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/AndroidManifest.xml"
docs: Add a privacy policy (#2) While drafting the policy I noticed that the `READ_MEDIA_*` permissions could be added (for newer devices), the `ACCESS_NETWORK_STATE` permission was missing, and `VIBRATE` was unnecessary.
2023-09-05 15:35:06 +02:00
line="24"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="31"/>
</issue>
<issue
id="UnusedTranslation"
message="The language `el (Greek)` is present in this project, but not declared in the `localeConfig` resource"
feat: Use Let's Encrypt certificates on API 23 devices (#640) Android 7 devices no longer trust certificates issued by Let's Encrypt (see https://letsencrypt.org/2020/11/06/own-two-feet and https://letsencrypt.org/2023/07/10/cross-sign-expiration.html for details). To work around that provide the Let's Encrypt root certs as resources. On API 24+ devices add those via network_security_config.xml. On API 23 devices they need to be installed manually for OkHttp SSL connections, and checked when there is an SSL error in LoginWebViewActivity. The root certificates were downloaded from https://letsencrypt.org/certificates/: - https://letsencrypt.org/certs/isrgrootx1.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x1-cross-signed.der (cross-signed) - https://letsencrypt.org/certs/isrg-root-x2.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x2-cross-signed.der (cross-signed) Fixes #638
2024-04-24 10:32:50 +02:00
errorLine1=" android:localeConfig=&quot;@xml/locales_config&quot;"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/AndroidManifest.xml"
docs: Add a privacy policy (#2) While drafting the policy I noticed that the `READ_MEDIA_*` permissions could be added (for newer devices), the `ACCESS_NETWORK_STATE` permission was missing, and `VIBRATE` was unnecessary.
2023-09-05 15:35:06 +02:00
line="24"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="31"/>
</issue>
<issue
id="UnusedTranslation"
message="The language `fi (Finnish)` is present in this project, but not declared in the `localeConfig` resource"
feat: Use Let's Encrypt certificates on API 23 devices (#640) Android 7 devices no longer trust certificates issued by Let's Encrypt (see https://letsencrypt.org/2020/11/06/own-two-feet and https://letsencrypt.org/2023/07/10/cross-sign-expiration.html for details). To work around that provide the Let's Encrypt root certs as resources. On API 24+ devices add those via network_security_config.xml. On API 23 devices they need to be installed manually for OkHttp SSL connections, and checked when there is an SSL error in LoginWebViewActivity. The root certificates were downloaded from https://letsencrypt.org/certificates/: - https://letsencrypt.org/certs/isrgrootx1.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x1-cross-signed.der (cross-signed) - https://letsencrypt.org/certs/isrg-root-x2.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x2-cross-signed.der (cross-signed) Fixes #638
2024-04-24 10:32:50 +02:00
errorLine1=" android:localeConfig=&quot;@xml/locales_config&quot;"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/AndroidManifest.xml"
docs: Add a privacy policy (#2) While drafting the policy I noticed that the `READ_MEDIA_*` permissions could be added (for newer devices), the `ACCESS_NETWORK_STATE` permission was missing, and `VIBRATE` was unnecessary.
2023-09-05 15:35:06 +02:00
line="24"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="31"/>
</issue>
<issue
id="UnusedTranslation"
message="The language `fy (Western Frisian)` is present in this project, but not declared in the `localeConfig` resource"
feat: Use Let's Encrypt certificates on API 23 devices (#640) Android 7 devices no longer trust certificates issued by Let's Encrypt (see https://letsencrypt.org/2020/11/06/own-two-feet and https://letsencrypt.org/2023/07/10/cross-sign-expiration.html for details). To work around that provide the Let's Encrypt root certs as resources. On API 24+ devices add those via network_security_config.xml. On API 23 devices they need to be installed manually for OkHttp SSL connections, and checked when there is an SSL error in LoginWebViewActivity. The root certificates were downloaded from https://letsencrypt.org/certificates/: - https://letsencrypt.org/certs/isrgrootx1.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x1-cross-signed.der (cross-signed) - https://letsencrypt.org/certs/isrg-root-x2.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x2-cross-signed.der (cross-signed) Fixes #638
2024-04-24 10:32:50 +02:00
errorLine1=" android:localeConfig=&quot;@xml/locales_config&quot;"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/AndroidManifest.xml"
docs: Add a privacy policy (#2) While drafting the policy I noticed that the `READ_MEDIA_*` permissions could be added (for newer devices), the `ACCESS_NETWORK_STATE` permission was missing, and `VIBRATE` was unnecessary.
2023-09-05 15:35:06 +02:00
line="24"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="31"/>
</issue>
<issue
id="UnusedTranslation"
message="The language `in (Indonesian)` is present in this project, but not declared in the `localeConfig` resource"
feat: Use Let's Encrypt certificates on API 23 devices (#640) Android 7 devices no longer trust certificates issued by Let's Encrypt (see https://letsencrypt.org/2020/11/06/own-two-feet and https://letsencrypt.org/2023/07/10/cross-sign-expiration.html for details). To work around that provide the Let's Encrypt root certs as resources. On API 24+ devices add those via network_security_config.xml. On API 23 devices they need to be installed manually for OkHttp SSL connections, and checked when there is an SSL error in LoginWebViewActivity. The root certificates were downloaded from https://letsencrypt.org/certificates/: - https://letsencrypt.org/certs/isrgrootx1.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x1-cross-signed.der (cross-signed) - https://letsencrypt.org/certs/isrg-root-x2.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x2-cross-signed.der (cross-signed) Fixes #638
2024-04-24 10:32:50 +02:00
errorLine1=" android:localeConfig=&quot;@xml/locales_config&quot;"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/AndroidManifest.xml"
docs: Add a privacy policy (#2) While drafting the policy I noticed that the `READ_MEDIA_*` permissions could be added (for newer devices), the `ACCESS_NETWORK_STATE` permission was missing, and `VIBRATE` was unnecessary.
2023-09-05 15:35:06 +02:00
line="24"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="31"/>
</issue>
<issue
id="UnusedTranslation"
message="The language `lv (Latvian)` is present in this project, but not declared in the `localeConfig` resource"
feat: Use Let's Encrypt certificates on API 23 devices (#640) Android 7 devices no longer trust certificates issued by Let's Encrypt (see https://letsencrypt.org/2020/11/06/own-two-feet and https://letsencrypt.org/2023/07/10/cross-sign-expiration.html for details). To work around that provide the Let's Encrypt root certs as resources. On API 24+ devices add those via network_security_config.xml. On API 23 devices they need to be installed manually for OkHttp SSL connections, and checked when there is an SSL error in LoginWebViewActivity. The root certificates were downloaded from https://letsencrypt.org/certificates/: - https://letsencrypt.org/certs/isrgrootx1.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x1-cross-signed.der (cross-signed) - https://letsencrypt.org/certs/isrg-root-x2.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x2-cross-signed.der (cross-signed) Fixes #638
2024-04-24 10:32:50 +02:00
errorLine1=" android:localeConfig=&quot;@xml/locales_config&quot;"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/AndroidManifest.xml"
docs: Add a privacy policy (#2) While drafting the policy I noticed that the `READ_MEDIA_*` permissions could be added (for newer devices), the `ACCESS_NETWORK_STATE` permission was missing, and `VIBRATE` was unnecessary.
2023-09-05 15:35:06 +02:00
line="24"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="31"/>
</issue>
<issue
id="UnusedTranslation"
message="The language `ml (Malayalam)` is present in this project, but not declared in the `localeConfig` resource"
feat: Use Let's Encrypt certificates on API 23 devices (#640) Android 7 devices no longer trust certificates issued by Let's Encrypt (see https://letsencrypt.org/2020/11/06/own-two-feet and https://letsencrypt.org/2023/07/10/cross-sign-expiration.html for details). To work around that provide the Let's Encrypt root certs as resources. On API 24+ devices add those via network_security_config.xml. On API 23 devices they need to be installed manually for OkHttp SSL connections, and checked when there is an SSL error in LoginWebViewActivity. The root certificates were downloaded from https://letsencrypt.org/certificates/: - https://letsencrypt.org/certs/isrgrootx1.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x1-cross-signed.der (cross-signed) - https://letsencrypt.org/certs/isrg-root-x2.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x2-cross-signed.der (cross-signed) Fixes #638
2024-04-24 10:32:50 +02:00
errorLine1=" android:localeConfig=&quot;@xml/locales_config&quot;"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/AndroidManifest.xml"
docs: Add a privacy policy (#2) While drafting the policy I noticed that the `READ_MEDIA_*` permissions could be added (for newer devices), the `ACCESS_NETWORK_STATE` permission was missing, and `VIBRATE` was unnecessary.
2023-09-05 15:35:06 +02:00
line="24"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="31"/>
</issue>
<issue
id="UnusedTranslation"
message="The language `si (Sinhala)` is present in this project, but not declared in the `localeConfig` resource"
feat: Use Let's Encrypt certificates on API 23 devices (#640) Android 7 devices no longer trust certificates issued by Let's Encrypt (see https://letsencrypt.org/2020/11/06/own-two-feet and https://letsencrypt.org/2023/07/10/cross-sign-expiration.html for details). To work around that provide the Let's Encrypt root certs as resources. On API 24+ devices add those via network_security_config.xml. On API 23 devices they need to be installed manually for OkHttp SSL connections, and checked when there is an SSL error in LoginWebViewActivity. The root certificates were downloaded from https://letsencrypt.org/certificates/: - https://letsencrypt.org/certs/isrgrootx1.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x1-cross-signed.der (cross-signed) - https://letsencrypt.org/certs/isrg-root-x2.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x2-cross-signed.der (cross-signed) Fixes #638
2024-04-24 10:32:50 +02:00
errorLine1=" android:localeConfig=&quot;@xml/locales_config&quot;"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/AndroidManifest.xml"
docs: Add a privacy policy (#2) While drafting the policy I noticed that the `READ_MEDIA_*` permissions could be added (for newer devices), the `ACCESS_NETWORK_STATE` permission was missing, and `VIBRATE` was unnecessary.
2023-09-05 15:35:06 +02:00
line="24"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="31"/>
</issue>
<issue
id="UnusedTranslation"
message="The language `sk (Slovak)` is present in this project, but not declared in the `localeConfig` resource"
feat: Use Let's Encrypt certificates on API 23 devices (#640) Android 7 devices no longer trust certificates issued by Let's Encrypt (see https://letsencrypt.org/2020/11/06/own-two-feet and https://letsencrypt.org/2023/07/10/cross-sign-expiration.html for details). To work around that provide the Let's Encrypt root certs as resources. On API 24+ devices add those via network_security_config.xml. On API 23 devices they need to be installed manually for OkHttp SSL connections, and checked when there is an SSL error in LoginWebViewActivity. The root certificates were downloaded from https://letsencrypt.org/certificates/: - https://letsencrypt.org/certs/isrgrootx1.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x1-cross-signed.der (cross-signed) - https://letsencrypt.org/certs/isrg-root-x2.der (self-signed) - https://letsencrypt.org/certs/isrg-root-x2-cross-signed.der (cross-signed) Fixes #638
2024-04-24 10:32:50 +02:00
errorLine1=" android:localeConfig=&quot;@xml/locales_config&quot;"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/AndroidManifest.xml"
docs: Add a privacy policy (#2) While drafting the policy I noticed that the `READ_MEDIA_*` permissions could be added (for newer devices), the `ACCESS_NETWORK_STATE` permission was missing, and `VIBRATE` was unnecessary.
2023-09-05 15:35:06 +02:00
line="24"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="31"/>
</issue>
<issue
id="DataExtractionRules"
message="The attribute `android:allowBackup` is deprecated from Android 12 and higher and may be removed in future versions. Consider adding the attribute `android:dataExtractionRules` specifying an `@xml` resource which configures cloud backups and device transfers on Android 12 and higher."
errorLine1=" android:allowBackup=&quot;false&quot;"
errorLine2=" ~~~~~">
<location
file="src/main/AndroidManifest.xml"
docs: Add a privacy policy (#2) While drafting the policy I noticed that the `READ_MEDIA_*` permissions could be added (for newer devices), the `ACCESS_NETWORK_STATE` permission was missing, and `VIBRATE` was unnecessary.
2023-09-05 15:35:06 +02:00
line="18"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="30"/>
</issue>
<issue
id="NotifyDataSetChanged"
message="It will always be more efficient to use more specific change events if you can. Rely on `notifyDataSetChanged` as a last resort."
errorLine1=" accountFieldAdapter.notifyDataSetChanged()"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
file="src/main/java/app/pachli/components/account/AccountActivity.kt"
fix: Prevent crash when Pachli is a share target (#659) Crash was occuring because the instance info hadn't been fetched, trying to take the last item of an empty list. To fix: - Expose the instance info as a state flow, with a default. New instance info is fetched whenever the active account changes. - Do the same for the emojis supported by the server. - Update call sites as appropriate. - Mark `InstanceInfoRepository` as `@Singleton` so it isn't repeatedly created causing fresh content fetches. The tests needed updating to get this to work. - Extract the network fake modules in to a network-test module so multiple other modules can use them. - Rewrite `InstanceInfoRepositoryTest` to use Hilt and use Turbine to test the new flows. Checking this showed cosmetic bugs in the About layout when instance info is missing, clean those up.
2024-04-28 18:19:13 +02:00
line="516"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="9"/>
</issue>
<issue
id="NotifyDataSetChanged"
message="It will always be more efficient to use more specific change events if you can. Rely on `notifyDataSetChanged` as a last resort."
errorLine1=" notifyDataSetChanged()"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
<location
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
file="src/main/java/app/pachli/components/accountlist/adapter/AccountAdapter.kt"
fix: Prevent potential crash when filters are slow to load (#205) This previous code could crash if `filterModel.kind` (marked `lateinit`) had not been set before the filters are loaded. This could happen in rare cases. Fix this by rewriting `FilterModel`. Instead of creating a half-empty object that still needs further initialisation, delay the creation until all the necessary information is available, and pass it in the `FilterModel` constructor. This also forces code that uses `FilterModel` to properly handle the case where it might be null at the point where filtering decisions have to be made. This means that `TimelineViewModel` (and subclasses) no longer need the `init()` function to complete their construction, which was another significant code smell. Pass the `TimelineKind` to the view models via their `SavedStateHandle`. This showed that changing filters wasn't causing the timelines to update without a manual refresh, so fix that too. Editing filters sends change events for the old and new contexts (in case a context is removed from a filter), and deleting a filter sends a change event too.
2023-10-28 19:54:46 +02:00
line="81"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="9"/>
</issue>
<issue
id="NotifyDataSetChanged"
message="It will always be more efficient to use more specific change events if you can. Rely on `notifyDataSetChanged` as a last resort."
errorLine1=" notifyDataSetChanged()"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
<location
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
file="src/main/java/app/pachli/adapter/AccountFieldEditAdapter.kt"
feat: Update activity transitions, prepare for predictive-back (#650) Previous code used a single animation type (slide) when transitioning, the transition was quite slow, and didn't behave appropriately if the device was set to a RTL writing system. In addition, handling the back affordance didn't work well with the new "Predictive Back" feature in Android 14 (https://developer.android.com/guide/navigation/custom-back/predictive-back-gesture). Fix this. ## Transitions To update the transitions the `startActivityWithSlideInAnimation()` implementation (and associated `finishWithoutSlideOutAnimation()`) have been replaced. There are three transitions; `default`, `slide`, and `explode`, represented as an enum passed to the activity intent. The `default` transition is the activity transition from Android 14, from the Android open source project (https://cs.android.com/android/platform/superproject/+/android-14.0.0_r18:frameworks/base/core/res/res/anim/;bpv=1). This is used for most transitions. The `slide` transition is the pre-existing slide transition, with a shorter transition time so it feels more responsive, and an RTL implementation. This is used when there is a strong spatial component to the navigation, for example, when going from: - a status to its thread - a preference menu item to its subscreen - a filter in a list to the "edit filter" screen - viewing your profile to editing your profile The `explode` transition is used when the state of the app changes significantly, such as when switching accounts. Activities are now started with `startActivityWithTransition()` which sets the intent and prepares the transition. `BaseActivity` checks the intent for the transition type and makes further changes to the transition as necessary. ## Predictive back "Predictive back" needs to know what the back button would do before the user interacts with it with an `onBackPressedCallback` that is either enabled or disabled. This required refactoring some code (particularly in `ComposeActivity`) to gather data ahead of time and enable/disable the callback appropriately. ## Fixed bugs - Back button wasn't stepping back through the tabs in AccountActivity - Modifying a filter and pressing back without saving wasn't prompting the user to save the changes - Writing a content warning and then hiding it would still count the text of the content warning toward's the post's length ## Other cleanups - Use `ViewCompat.setTransitionName()` instead of setting the `transitionName` property - Delete the unused `fade_in` and `fade_out` animations. - Use androidx-activity 1.9.0 to get the latest predictive back support library code - Show validation errors when creating / editing filters
2024-04-26 23:18:30 +02:00
line="49"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="9"/>
</issue>
<issue
id="NotifyDataSetChanged"
message="It will always be more efficient to use more specific change events if you can. Rely on `notifyDataSetChanged` as a last resort."
errorLine1=" notifyDataSetChanged()"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
<location
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
file="src/main/java/app/pachli/adapter/AccountFieldEditAdapter.kt"
feat: Update activity transitions, prepare for predictive-back (#650) Previous code used a single animation type (slide) when transitioning, the transition was quite slow, and didn't behave appropriately if the device was set to a RTL writing system. In addition, handling the back affordance didn't work well with the new "Predictive Back" feature in Android 14 (https://developer.android.com/guide/navigation/custom-back/predictive-back-gesture). Fix this. ## Transitions To update the transitions the `startActivityWithSlideInAnimation()` implementation (and associated `finishWithoutSlideOutAnimation()`) have been replaced. There are three transitions; `default`, `slide`, and `explode`, represented as an enum passed to the activity intent. The `default` transition is the activity transition from Android 14, from the Android open source project (https://cs.android.com/android/platform/superproject/+/android-14.0.0_r18:frameworks/base/core/res/res/anim/;bpv=1). This is used for most transitions. The `slide` transition is the pre-existing slide transition, with a shorter transition time so it feels more responsive, and an RTL implementation. This is used when there is a strong spatial component to the navigation, for example, when going from: - a status to its thread - a preference menu item to its subscreen - a filter in a list to the "edit filter" screen - viewing your profile to editing your profile The `explode` transition is used when the state of the app changes significantly, such as when switching accounts. Activities are now started with `startActivityWithTransition()` which sets the intent and prepares the transition. `BaseActivity` checks the intent for the transition type and makes further changes to the transition as necessary. ## Predictive back "Predictive back" needs to know what the back button would do before the user interacts with it with an `onBackPressedCallback` that is either enabled or disabled. This required refactoring some code (particularly in `ComposeActivity`) to gather data ahead of time and enable/disable the callback appropriately. ## Fixed bugs - Back button wasn't stepping back through the tabs in AccountActivity - Modifying a filter and pressing back without saving wasn't prompting the user to save the changes - Writing a content warning and then hiding it would still count the text of the content warning toward's the post's length ## Other cleanups - Use `ViewCompat.setTransitionName()` instead of setting the `transitionName` property - Delete the unused `fade_in` and `fade_out` animations. - Use androidx-activity 1.9.0 to get the latest predictive back support library code - Show validation errors when creating / editing filters
2024-04-26 23:18:30 +02:00
line="55"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="9"/>
</issue>
<issue
id="NotifyDataSetChanged"
message="It will always be more efficient to use more specific change events if you can. Rely on `notifyDataSetChanged` as a last resort."
errorLine1=" notifyDataSetChanged()"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
<location
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
file="src/main/java/app/pachli/components/announcements/AnnouncementAdapter.kt"
fix: Disable filter functionality if unsupported by the server (#366) The previous code unilaterally enabled filter functionality. Some Mastodon-like servers -- like GoToSocial -- do not support filters, and this resulted in user visible error messages when connecting to those servers. To fix this: - Extend the set of supported server capabilities to include client and server side filtering. - Disable the filter preferences if the server does not support filters and show a message explaining why it's disabled. Extend the capabilities model to support this: - Fetch server software name and version from the nodeinfo endpoints (implementing the nodeinfo API and schema) - Extend the use of kotlin-result to provide hierarchies of Error classes and demonstrate how to chain errors and display more informative messages without using exceptions. Fixes #343
2024-01-18 21:44:30 +01:00
line="169"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="9"/>
</issue>
<issue
id="NotifyDataSetChanged"
message="It will always be more efficient to use more specific change events if you can. Rely on `notifyDataSetChanged` as a last resort."
errorLine1=" notifyDataSetChanged()"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
<location
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
file="src/main/java/app/pachli/components/accountlist/adapter/MutesAdapter.kt"
refactor: Modularise core activity classes, (#393) Continue modularisation by moving core activity classes that almost all activities depende on to a `core.activity` module. This includes core "helper" classes as well. Implement core.activity: - Contains BaseActivity, BottomSheetActivity - Contains LinkHelper and other utility classes used by activities Implement core.common.extensions: - Move ViewBindingExtensions and ViewExtensions here Implement core.common.util: - Move BlurHashDecoder and VersionName here Implement core.designsystem: - Holds common resources (animations, colours, drawables, etc) used through the app - Import "core.designsystem.R as DR" through the app to distinguish from the module's own resources Implement feature.login: - Move the LoginActivity and related code/resources to its own module Implement tools/mvstring - Moves string resources (and all translations) from one module to another
2024-01-30 11:37:00 +01:00
line="109"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="9"/>
</issue>
<issue
id="NotifyDataSetChanged"
message="It will always be more efficient to use more specific change events if you can. Rely on `notifyDataSetChanged` as a last resort."
errorLine1=" notifyDataSetChanged()"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
<location
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
file="src/main/java/app/pachli/adapter/PreviewPollOptionsAdapter.kt"
fix: Prevent potential crash when filters are slow to load (#205) This previous code could crash if `filterModel.kind` (marked `lateinit`) had not been set before the filters are loaded. This could happen in rare cases. Fix this by rewriting `FilterModel`. Instead of creating a half-empty object that still needs further initialisation, delay the creation until all the necessary information is available, and pass it in the `FilterModel` constructor. This also forces code that uses `FilterModel` to properly handle the case where it might be null at the point where filtering decisions have to be made. This means that `TimelineViewModel` (and subclasses) no longer need the `init()` function to complete their construction, which was another significant code smell. Pass the `TimelineKind` to the view models via their `SavedStateHandle`. This showed that changing filters wasn't causing the timelines to update without a manual refresh, so fix that too. Editing filters sends change events for the old and new contexts (in case a context is removed from a filter), and deleting a filter sends a change event too.
2023-10-28 19:54:46 +02:00
line="36"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="9"/>
</issue>
<issue
id="NotifyDataSetChanged"
message="It will always be more efficient to use more specific change events if you can. Rely on `notifyDataSetChanged` as a last resort."
errorLine1=" notifyDataSetChanged()"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
<location
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
file="src/main/java/app/pachli/adapter/TabAdapter.kt"
feat: Simplify adding/removing timelines from tabs (#587) Previously, modifying any tabs meant opening the left-side nav, opening Account preferences > Tabs, and then adding / removing tabs. This is time consuming, and difficult for new users to discover. In addition, it was possible to remove the Home tab, and there was a hardcoded minimum of at least two tabs. Fix this. When viewing a timeline that is not already in a tab an "Add to tab" menu item is enabled, which appends the timeline to the list of existing tabs. When viewing a timeline in a tab (that is not the Home timeline) a "Remove tab" menu item is enabled, which removes the tab from the list of existing tabs. If the user removes the active tab (either with this menu item, or through preferences) the tab to the left of the active tab becomes the new active tab. A new "Manage tabs" menu item is also provided, as a shortcut to the existing Account preferences > Tabs screen. When managing tabs the Home timeline can not be removed; the button to remove it is removed, and swiping is disabled on that list item. The restriction of "at least two tabs" has also been removed. `NotificationsActivity` has been removed, as `TimelineActivity` can display `NotificationsFragment`. To make the three "Trending" types (hashtags, links, and posts) more visually distinct add two new icons for links (ic_newspaper) and posts (ic_whatshot). Fixes #572, #584, #585, #569
2024-04-03 00:10:09 +02:00
line="53"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="9"/>
</issue>
<issue
id="VectorPath"
message="Very long vector path (2783 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector."
errorLine1=" android:pathData=&quot;M464.58,257.93c9,-0.87 16.14,-4.1 22.16,-9.94 0.35,-0.35 0.6,-0.8 0.9,-1.17 2.6,-3.1 4.94,-7.18 9.7,-6 8.63,2.17 9.46,19.48 8.04,27.45 -2.27,12.7 -15.7,28.74 -32.62,35.6 -12.25,4.96 -24.58,7.38 -37.55,7.56 -3.2,0.05 -5.85,1.06 -7.62,3.62 -11.13,16.1 -27.1,24.06 -45.85,27.12 -4.9,0.8 -6.02,2.84 -6.35,7.64 -1.16,16.88 4.23,31.18 14.22,44.6 7.1,9.5 12.35,20.34 19.04,30.18 10.18,14.96 17.16,31.45 23.9,48.05 2.45,6 3.75,12.48 5.46,18.75 2.57,9.45 -3.48,19.32 -14.44,25.83 -12.1,7.18 -25.26,10.55 -39.16,10.48 -5.64,-0.02 -9.43,3.12 -13.65,5.57 -3.18,1.85 -6,4.53 -8.57,7.23 -12.92,13.6 -28.9,20.17 -47.43,21.3 -8.83,0.53 -59.78,16.9 -123.24,8.78 -21.94,-2.82 -46.9,-7.1 -65.27,-15.48 -13.75,-6.3 -34.63,-21.73 -39.26,-36 -1.2,-3.7 -1.98,-3.43 -4.3,-2.18 -7.3,3.93 -15.16,4.83 -23.26,4.33 -14.96,-0.9 -26.27,-7.77 -33.72,-20.9 -5.6,-9.83 -9.05,-20.23 -8.48,-31.68 0.1,-2.2 -1.33,-2.7 -2.8,-3.43 -4.3,-2.08 -7.4,-5.33 -9.3,-9.68 -2.25,-5.15 -1.1,-8.83 3.95,-11.24 2.32,-1.1 2.5,-2.5 2.26,-4.65 -0.88,-8.4 2.67,-14.56 9.92,-18.62 6.56,-3.68 12.47,-1.43 14.5,5.84 1.18,4.23 2.5,6.9 7.75,6.54 4.86,-0.33 8.34,2.58 9.86,7.3 1.4,4.3 -1.13,10.6 -5.2,13.4 -1.88,1.28 -3.72,2.73 -5.8,3.6 -4.46,1.84 -4.5,5.17 -3.25,8.88 1.77,5.3 4.23,10.28 7.58,14.76 4.47,6 12.88,6.42 17.92,0.98 4.64,-5 5.95,-10.86 5.1,-17.6 -1.64,-13.3 -1.74,-26.68 0.23,-40 1.1,-7.43 3.4,-14.64 5.9,-21.7 7.34,-20.78 14.77,-41.55 30.63,-57.9 4.12,-4.24 8.4,-8.16 13.42,-11.32 1.3,-0.84 3.36,-1.62 0.95,-3.5 -6.4,-5.02 -7.04,-12.57 -8.6,-19.7 -0.43,-1.9 -0.85,-3.86 -0.8,-5.8 0.05,-3.8 -1,-6.2 -5.08,-7.56 -3.14,-1.04 -3.9,-4.64 -4,-7.85 -0.75,-23.95 4.8,-46.1 17.6,-66.64 10.64,-17.05 21.42,-33.95 33.88,-49.72 2.43,-3.07 5.1,-6.94 8.3,-9.25 2.47,-2.42 4.02,-5.3 3.25,-9.43 -2.45,-13.18 -4.05,-25.76 -2.9,-38.73 1.16,-12.8 12.96,-25.3 28.64,-18.68 2.1,0.88 3.03,-0.28 3.8,-1.85 5.56,-11.32 25.42,-26.14 35.6,-27.08 5.4,-0.5 11.06,3.56 12.63,10.08 1.06,4.38 2.12,6.15 7.37,4.7 5.6,-1.57 11.84,-1.57 15.74,4.57 1.37,2.14 2.5,4.48 1.77,6.92 -2.34,6.77 0.22,6.7 4.22,6.64 19.47,-0.34 36.57,11.34 52.55,22.58 4.43,3.12 7.88,7.36 11.35,11.43 9.5,11.2 18.47,22.87 29.36,32.8 8.34,7.58 17.73,13.18 29.46,13.54 1.8,0.06 3.6,0.16 5.38,0 9.7,-0.88 13.12,-7.9 8.15,-16.43 -3.77,-6.46 -9.08,-12 -11.58,-19.24 -3.07,-8.9 -4.93,-17.73 1.06,-26.2 1.36,-1.94 0.78,-3.72 0.17,-5.6 -1.98,-6.1 -0.9,-12.03 1.47,-17.67 1.57,-3.76 4.62,-6.53 9,-6.6 4.3,-0.04 8.12,1.35 10.13,5.58 1.33,2.8 2.57,5.65 3.64,8.55 1.63,4.44 5.64,6.35 9.57,3.78 2.73,-1.77 3.28,-4.88 5.76,-7 3.8,-3.24 7.8,-4.04 12.02,-1 4.23,3.04 6.86,7 6,12.5 -0.33,2.25 -0.96,4.45 -2.46,6.32 -3.24,4.02 -2.96,7.96 0.14,12.03 2.95,3.9 5.88,7.86 9,11.57C473.3,155 480.12,170 483.53,186.44c2.06,9.93 1.8,20.08 -0.46,30.13 -3.2,14.18 -8.4,27.4 -17.4,38.95 -0.37,0.48 -0.52,1.12 -1.1,2.4z&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/drawable/elephant_friend.xml"
line="7"
column="25"/>
</issue>
<issue
id="VectorPath"
message="Very long vector path (1503 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector."
errorLine1=" android:pathData=&quot;M434.05,70.75c-4.33,1.58 -7.75,1.33 -10.1,-1.72 -2.36,-3.08 -2.15,-7.75 0.5,-10.18 2.44,-2.23 6.73,-3.17 6.73,-3.17s-5.97,-18.84 -7.52,-24.82c-0.6,-2.52 -0.92,-5.7 4.3,-8.72 7.68,-4.42 15.2,-7.8 24.1,-10.7 3.28,-1.06 7.05,-0.3 8.7,2.68 4.12,11.28 7,21.06 10.66,32.28 3.1,9.54 -1.33,10.92 -4.82,13 -2.74,1.63 -6.45,2.92 -9.94,0.64 -3,-1.96 -3.2,-6.7 -2.07,-9.67 1.95,-3.74 8.18,-5.2 8.18,-5.2s-2.03,-6.4 -3.1,-9.5c-4.27,-12.07 -4.44,-9.3 -16.1,-4.23 -10.4,4.52 -9.9,5.07 -6.54,15.98 0.76,2.48 2.74,7.93 3.74,11.88 2.02,7.9 -1.32,9.48 -6.73,11.45zM357.86,54.52c-0.06,-6.67 9.1,-15.55 15.24,-15.43 2.4,0.03 4.03,1.26 5.13,3.2 5.96,10.4 11.24,21.16 17.7,31.3 2.23,3.47 1.18,6.97 -1.84,10.06 -3.42,3.48 -6.68,4.82 -11,1.6 -7.96,-5.9 -25.96,-26.6 -25.24,-30.74zM506.52,73.77c0.53,2.86 -2.1,4.22 -6.44,6.7 -5.93,3.4 -14.07,6.7 -20.86,10.55 -3.48,1.98 -7.18,4.66 -10.96,0.57 -3.46,-3.75 -3.74,-11.26 -0.4,-14.8 8.26,-8.74 16.8,-17.2 26.12,-24.83 3.9,-3.2 6.88,-2.52 8.86,2.1 2.4,5.6 3.3,11.57 3.68,19.7zM485.48,119.2c-10.47,0.63 -11.15,0.1 -12.55,-10.14 -0.86,-6.2 0.57,-8.46 6.56,-9.66 9.93,-2 19.34,-5.8 29.12,-8.33 6.37,-1.65 8.36,-0.26 8.5,6.3 0.17,6.6 -2.64,12.2 -6.38,17.08 -3.2,4.18 -24.45,4.7 -25.26,4.75zM405.4,26.1c0.38,7.18 1.68,23.77 1.65,24.9 -0.1,3.47 -0.96,6.85 -4.7,7.7 -3.56,0.83 -5.83,-2.2 -7.2,-4.75 -3.84,-7.16 -6.7,-14.8 -8.8,-22.66 -0.68,-2.53 -1.16,-5.1 -1.98,-7.55 -2.1,-6.2 -1.5,-9.24 3.5,-13.36 2.86,-2.38 5.83,-4.8 9.43,-6 4.92,-1.64 7.73,0.03 8.03,5.1 0.33,5.52 0.08,11.07 0.08,16.6z&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/drawable/elephant_friend.xml"
line="11"
column="25"/>
</issue>
<issue
id="VectorPath"
message="Very long vector path (5207 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector."
errorLine1=" android:pathData=&quot;M237.55,461.68c-3.74,-4.52 -5.68,-10.24 -9.82,-14.5 -8.22,-8.45 -18.98,-11.4 -29.97,-12.43 -13.3,-1.25 -25.84,2.5 -37.3,9.43 -1.23,0.75 -4.1,1 -2.96,3.46 1.12,2.44 3.37,1.07 5.2,0.6 0.63,-0.17 1.3,-0.3 1.84,-0.64 12.76,-7.84 26.86,-6.72 39.83,-2.92 12.03,3.52 22.96,10.7 28.42,23.56 7.16,16.86 10.88,34.32 10.7,52.63 0,2.65 -0.3,4.42 -3.3,5.6 -7.93,3.1 -10.82,10.33 -7.84,18.34 0.33,0.87 0.67,1.73 1,2.6 -1.97,0.64 -2.25,-0.7 -2.8,-1.58 -3.06,-4.83 -7.6,-6.5 -13.04,-5.87 -5.22,0.6 -7.82,4.27 -9.36,8.86 -1.05,3.13 -1.84,6.34 -1.14,9.63 0.37,1.73 0.28,2.84 -1.7,3.23 -1.8,0.35 -2.7,-0.2 -3.1,-2.07 -0.83,-3.67 -3.48,-6 -6.05,-8.6 -7.77,-7.88 -17.46,-2.88 -19.98,6.12 -0.96,3.38 -2.3,3.72 -5.05,2.9 -2.5,-0.72 -5.07,-1.22 -7.54,-2.04 -11.78,-3.97 -14.72,-13.16 -14.2,-24.34 0.17,-3.45 -0.14,-6.85 -1.16,-10.15 -0.4,-1.32 -1.14,-2.53 -2.7,-2.4 -1.6,0.16 -2.1,1.5 -2,2.9 0.28,3.7 -1.95,9.37 -7.6,10.37C121,537 97.3,525.3 92.73,505.8c-1.64,-1.5 -3.04,-1.64 -4.8,-0.98 -1.07,0.4 -2.16,0.86 -3.04,1.55 -9.6,7.47 -20.4,8.52 -32.02,6.66 -6.1,-0.98 -11.44,-3.3 -15.46,-7.65 -9.14,-9.86 -13.94,-21.8 -14.97,-35.23 -0.2,-2.55 0.46,-4.92 2.46,-6.64 2.48,-2.13 4.33,-2.62 6.5,1.02 3.45,5.8 3.97,12.56 7.33,18.4 7.13,12.36 22.7,17.5 35,2.98 4.64,-5.47 4.54,-10.5 3.78,-16.98 -2.33,-20.22 -1.35,-40.16 4.53,-60.02 5.46,-18.4 13.88,-35.12 23.95,-51.2 5.25,-8.37 12.45,-15.13 20.4,-20.88 4.24,-3.1 10.25,-2.7 14.76,-5.88 1.4,-1 2.28,0.94 2.98,1.85 4.92,6.36 11.94,8.28 19.36,9.05 9.7,1 15.67,-4.7 19.8,-12.45 2.16,-4.04 3.35,-4.27 6.72,-1.1 3.13,2.94 6.97,5.32 11.15,6.9 1.4,0.54 2.73,1.28 4.2,0.65 1.43,-0.6 3.6,-0.34 4,-2.33 0.44,-2.22 -1.8,-2.45 -3.1,-3.13 -5.34,-2.84 -10.44,-6.04 -15.34,-9.6 -1.9,-1.4 -2.3,-2.74 -1.52,-4.94 3.85,-10.7 2.88,-21.9 2.96,-32.94 0,-2.66 -1.03,-5.73 -4.37,-5.4 -3.42,0.34 -2.4,3.4 -2.48,5.83 -0.34,10.57 0.2,48.52 -20.4,51.8 -5.6,0.88 -11.72,-3.87 -14.97,-7.55 -1.05,-1.2 -1.6,-2.82 -2.3,-4.3 -1.9,-3.97 -4.7,-4.7 -8.32,-2.28 -1.6,1.1 -3.16,2.3 -4.77,3.42 -6.07,4.18 -11.02,2.55 -13,-4.62 -2.12,-7.58 -2.73,-15.4 -2.9,-23.25 -0.18,-7.1 -0.37,-7.44 -7.23,-7.38 -3.63,0.02 -3.4,-2.65 -3.34,-4.76 0.3,-7.84 1.16,-15.63 3.16,-23.24 5.44,-20.78 15.25,-39.46 27.34,-57.06 9.98,-14.53 20.6,-28.52 32.6,-41.46 1.35,-1.46 2.53,-3.08 1.88,-5.25 -3.8,-12.62 -4.97,-25.52 -4.34,-38.64 0.18,-3.68 1.14,-7.06 3.14,-10.16 4.82,-7.47 11.9,-8.46 18.45,-2.54 4.23,3.82 5.38,3.75 7.42,-1.7 4.34,-11.62 13.95,-18.16 23.3,-25 1.14,-0.85 2.63,-1.3 4.03,-1.74 8.2,-2.65 11.25,-0.47 11.25,8.02 0,1.15 -0.07,2.3 -0.03,3.43 0.13,4.47 1.23,5.28 5.4,3.6 3.7,-1.5 7.53,-2.1 11.46,-2.12 2.42,0 5.3,-0.08 6.36,2.63 1,2.62 -0.22,5.13 -1.9,7.25 -1.02,1.28 -2.27,2.37 -3.23,3.67 -1.26,1.72 -1.58,3.66 -0.2,5.45 1.3,1.7 3.07,1.46 4.9,0.9 2.35,-0.7 4.7,-1.3 7.08,-1.85 5.5,-1.3 10.67,-0.84 16.25,0.93 22.57,7.14 39.55,21.56 53.67,39.85 10.63,13.77 21.63,27.04 37.92,34.54 8.35,3.85 16.9,6.37 26.37,6.2 15.5,-0.27 22.1,-14.73 14.75,-28.12 -2.35,-4.27 -5.4,-8.16 -8.04,-12.27 -3.88,-6 -10.2,-16.04 -5.6,-23.58 3.3,-5.45 5.37,-11.58 2.52,-18.9 -0.08,-1.6 -0.05,-3.35 0.46,-4.83 1.42,-4.12 5.42,-4.9 8.47,-1.8 1.54,1.56 2.3,3.5 2.8,5.62 0.98,4.25 2.27,8.28 7.44,9.2 5.6,0.97 10.84,0.58 14.68,-4.23 1.48,-1.85 3.28,-3.16 5.2,-4.4 1.44,-0.92 2.98,-1.45 4.56,-0.33 1.6,1.12 1.42,2.82 1.23,4.46 -0.2,1.65 -0.9,3.1 -1.9,4.44 -5.77,7.8 -5.23,16.43 2.02,22.87 23.06,20.5 30.33,46.86 26.25,76.12 -2.65,18.97 -11.78,35.84 -25.73,49.58 -2.2,2.18 -4.45,4.3 -6.68,6.46 -2.33,2.23 -3.93,2.15 -4.3,-1.4 -0.36,-3.5 -1.98,-6.5 -3.52,-9.58 -2.34,-4.65 -6.03,-6.72 -11.1,-6.17 -3.3,0.34 -8.26,5.75 -9.05,9.47 -3.08,14.45 -13.34,23.87 -27.43,26.86 -15.9,3.36 -30.32,1.14 -43.77,-8.18 -3.5,-2.43 -7,-4.17 -9.73,-8 -5.08,-7.13 -16.4,-6.98 -23.1,-0.75 -0.6,0.56 -1.48,1 -1.12,1.93 0.48,1.22 1.7,0.8 2.55,0.65 0.94,-0.16 1.8,-0.77 2.72,-1.1 5.43,-1.83 7.9,-1.44 13.27,2.3 -3.13,1.38 -6.1,2.42 -8.8,3.9 -15.9,8.8 -23.13,20.6 -18.48,36.6 1.56,5.37 3.22,10.8 8.85,13.87 3.24,1.77 2.84,3.92 -0.62,5.42 -3.44,1.5 -6.83,3.12 -10.25,4.65 -0.87,0.4 -2.22,0.47 -2.1,1.67 0.17,1.43 1.6,1.47 2.7,1.43 5.
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<location
file="src/main/res/drawable/elephant_friend.xml"
line="15"
column="25"/>
</issue>
<issue
id="VectorPath"
message="Very long vector path (1229 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector."
errorLine1=" android:pathData=&quot;M320.74,552.86c0,-3.62 1.58,-6.17 3.95,-8.34 1.97,-1.8 4.1,-1.73 6.32,-0.54 2.6,1.4 3.5,4.16 3.66,6.55 0.17,2.4 -2.78,2.16 -4.55,2.68 -2.18,0.65 -4.42,1.1 -6.62,1.7 -2.04,0.53 -3.18,0.08 -2.76,-2.04zM211.12,555.75c0.62,-7.63 5.97,-12.05 11,-9.22 1.87,1.04 3.73,2.48 3.63,4.83 -0.1,2.32 -9,5.34 -11.57,6.4 -2,0.8 -3.7,0.78 -3.06,-2zM190.44,562.93c-1.76,-0.23 -10.18,0.22 -10.6,-2.52 -0.35,-2.33 1.4,-4.48 3.5,-6 2.27,-1.65 4.47,-1.77 6.75,-0.26 1.06,0.7 2.23,1.4 3.02,2.37 1.1,1.33 3.2,2.64 2.36,4.47 -0.8,1.78 -2.98,2.23 -5.04,1.96zM391.17,519.44c2.04,-6.24 7,-9.52 11.73,-8.35 2.15,0.53 3.55,2.03 3.88,3.9 0.42,2.34 -2.14,1.87 -3.42,2.47 -3.73,1.76 -7.83,1.28 -12.2,1.97zM302.64,557.6c-3.28,-0.47 -11.57,-0.97 -11.9,-2.4 -0.42,-1.8 1.33,-3.16 2.75,-4.2 4.6,-3.4 8.78,-2.1 10.7,3.23 1,2.82 0.55,3.43 -1.56,3.36zM420.1,510.42c-1.2,-5.6 0.16,-9.25 4.92,-11.44 1.9,-0.88 3.66,-0.63 4.82,0.74 1.2,1.43 -0.37,2.67 -1.28,3.7 -2.34,2.63 -4.96,4.94 -8.47,7zM356.97,530.9c-0.27,4.6 -2,7.9 -5.37,10.37 -0.64,0.46 -1.24,1.42 -2,0.94 -0.53,-0.33 -0.82,-1.35 -0.9,-2.1 -0.38,-4.45 3.08,-8.4 8.27,-9.2zM242.28,535.5c-0.73,3.33 -1.4,6.46 -4.55,7.58 -0.62,0.22 -0.98,-2.36 -0.68,-3.82 0.53,-2.58 1.12,-5.3 4.13,-5.85 1.8,-0.32 0.86,1.56 1.1,2.1z&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/drawable/elephant_friend.xml"
line="35"
column="25"/>
</issue>
<issue
id="VectorPath"
message="Very long vector path (1455 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector."
errorLine1=" android:pathData=&quot;M369.34,395.2c-0.36,10.82 -7.26,15.35 -17.1,11.05 -1.5,-0.65 -2.08,-0.66 -3.2,0.53 -7.24,7.7 -14.98,6.93 -20.1,-2.23 -1.5,-2.67 -2.45,-3.12 -5.43,-1.97 -7.26,2.82 -11.64,-0.6 -11.53,-8.5 0.06,-4.7 1.6,-8.96 4.12,-12.87 0.8,-1.26 2,-2.45 3.64,-1.64 1.92,0.95 0.28,2.3 -0.08,3.3 -1.25,3.6 -2.2,7.2 -2.02,11 0.18,3.53 2.2,3.96 4.5,2.1 2.1,-1.7 3.7,-4.08 5.5,-6.2 0.75,-0.88 1.4,-1.87 2.8,-1.45 1.32,0.4 1.52,1.5 1.67,2.7 0.63,4.87 2.5,9.06 6.5,12.16 2.58,2 4.4,1.93 5.47,-1.45 0.74,-2.32 1.6,-4.6 2.26,-6.96 0.8,-2.9 2.17,-3.03 4,-0.92 2.32,2.68 5.2,5.96 8.57,3.67 3.46,-2.35 1.47,-6.54 0.3,-9.9 -0.9,-2.64 -2.05,-5.16 -4,-7.24 -0.8,-0.84 -1.68,-1.75 -0.73,-2.96 0.7,-0.9 1.7,-0.6 2.7,-0.43 4.32,0.73 7.47,2.7 9.14,7.06 1.4,3.65 3.27,7.1 3.04,11.17zM257.8,234.95c0,3.1 0.06,5.4 -0.03,7.67 -0.05,1.25 -0.75,2.13 -2.06,2.38 -1.4,0.27 -2.43,-0.06 -3.33,-1.34 -8.95,-12.77 -2.18,-30.7 12.84,-33.9 7.24,-1.53 18.57,3.32 22.34,9.53 1.63,2.66 0.77,5.45 -0.96,7.1 -2.03,1.94 -3.08,-1.2 -4.62,-2.1 -3.3,-1.95 -6.58,-4.33 -10.2,-5.3 -6.54,-1.75 -12.92,3.24 -13.6,9.93 -0.24,2.27 -0.28,4.56 -0.36,6.02zM335.63,182.77c-0.4,3.9 0.7,6.67 1.5,9.5 0.5,1.72 0.1,3.34 -1.5,4.28 -1.32,0.8 -2.77,0.04 -3.48,-0.96 -3.8,-5.36 -6.13,-11.28 -4.57,-17.9 1.37,-5.78 5.48,-9.1 11.26,-10.22 7.58,-1.47 16.86,5.04 17.3,12.13 0.1,1.34 0.82,3.13 -1.05,3.9 -1.44,0.58 -2.48,-0.47 -3.45,-1.34 -1.58,-1.4 -3,-3.04 -4.72,-4.25 -2.7,-1.88 -5.8,-2.27 -8.88,-1.06 -3.2,1.27 -2.16,4.37 -2.42,5.93z&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/drawable/elephant_friend.xml"
line="39"
column="25"/>
</issue>
<issue
id="VectorPath"
message="Very long vector path (1421 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector."
errorLine1=" android:pathData=&quot;M334.32,456.65c0.4,3.22 -0.48,5.42 -2.9,6.2 -2.62,0.85 -4.6,-1 -5.16,-3.3 -1.23,-5.03 -2.02,-10.18 -2.83,-15.3 -0.3,-1.87 0.14,-3.75 2.42,-4.15 2.12,-0.36 3.48,1 4.1,2.76 1.63,4.77 3.06,9.6 4.38,13.8zM346.88,497.52c-0.37,3.22 -1.74,5.15 -4.26,5.35 -2.76,0.2 -4.25,-2.07 -4.25,-4.42 -0.02,-5.18 0.42,-10.37 0.83,-15.55 0.15,-1.88 1,-3.6 3.32,-3.45 2.14,0.14 3.16,1.77 3.33,3.64 0.48,5 0.73,10.04 1.03,14.42zM111.33,405.23c-1.5,2.88 -3.47,4.2 -5.9,3.47 -2.64,-0.8 -3.22,-3.44 -2.4,-5.64 1.85,-4.85 4.12,-9.54 6.35,-14.23 0.82,-1.7 2.23,-3 4.34,-2.03 1.95,0.9 2.3,2.78 1.8,4.6 -1.34,4.84 -2.9,9.64 -4.2,13.83zM125.06,433.6c-1.18,3.04 -3,4.56 -5.47,4.1 -2.74,-0.5 -3.6,-3.06 -3,-5.34 1.28,-5.02 3.02,-9.93 4.73,-14.83 0.62,-1.78 1.9,-3.23 4.1,-2.5 2.03,0.68 2.6,2.52 2.3,4.37 -0.82,4.97 -1.85,9.9 -2.67,14.22zM318.95,487.36c-0.07,3.25 -1.26,5.3 -3.74,5.72 -2.73,0.47 -4.42,-1.66 -4.64,-4 -0.5,-5.16 -0.55,-10.37 -0.6,-15.56 -0.04,-1.88 0.65,-3.68 2.97,-3.74 2.15,-0.07 3.3,1.47 3.66,3.3 0.92,4.96 1.65,9.95 2.35,14.28zM220.34,466.9c2.03,2.55 2.43,4.9 0.8,6.8 -1.8,2.1 -4.47,1.56 -6.14,-0.1 -3.7,-3.63 -7.06,-7.6 -10.44,-11.54 -1.23,-1.44 -1.85,-3.26 -0.1,-4.8 1.6,-1.42 3.47,-0.98 4.92,0.2 3.9,3.2 7.65,6.58 10.96,9.45zM218.05,505.25c0.7,3.18 0.02,5.45 -2.3,6.45 -2.54,1.1 -4.7,-0.58 -5.46,-2.8 -1.7,-4.9 -2.98,-9.95 -4.26,-14.98 -0.47,-1.83 -0.22,-3.74 2.02,-4.34 2.07,-0.57 3.56,0.65 4.33,2.36 2.07,4.6 3.94,9.27 5.65,13.3z&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/drawable/elephant_friend.xml"
line="43"
column="25"/>
</issue>
<issue
id="VectorPath"
message="Very long vector path (1757 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector."
errorLine1=" android:pathData=&quot;M8.9987,3.9987C6.7925,3.9987 5,5.7913 5,7.9975C5,10.21 6.7925,12.0025 8.9987,12.0025C11.2113,12.0025 12.9975,10.21 12.9975,7.9975C12.9975,5.7913 11.2113,3.9987 8.9987,3.9987ZM8.9987,13.9987C6.3288,13.9987 1.0013,15.3325 1.0013,17.9975L1.0013,20L12.08,20C12.0262,19.6675 12.0025,19.3362 12.0025,18.9988C12.0025,17.485 12.495,16.0113 13.4087,14.8C11.88,14.2775 10.1813,13.9987 8.9987,13.9987ZM17.9887,13.9987C17.8712,13.9987 17.7588,14.0912 17.7388,14.2087L17.5487,15.5275C17.2512,15.6588 16.9575,15.82 16.6988,16.02L15.4587,15.5175C15.3512,15.4787 15.22,15.5225 15.1512,15.63L14.15,17.3587C14.0913,17.4713 14.1112,17.5975 14.2087,17.6812L15.2688,18.5113C15.2487,18.6712 15.2388,18.8275 15.2388,18.9988C15.2388,19.17 15.2487,19.3312 15.2688,19.4925L14.2087,20.3225C14.1212,20.4 14.0913,20.5325 14.15,20.64L15.1512,22.3687C15.21,22.48 15.3413,22.52 15.4587,22.48L16.6988,21.9825C16.9575,22.1825 17.2412,22.3488 17.5487,22.4713L17.7388,23.7888C17.7588,23.9113 17.8612,23.9988 17.9887,23.9988L19.99,23.9988C20.1123,23.9988 20.22,23.9113 20.2393,23.7888L20.4297,22.4713C20.7275,22.3387 21.0205,22.1825 21.27,21.9825L22.52,22.48C22.6312,22.52 22.7588,22.48 22.8325,22.3687L23.8288,20.64C23.8913,20.5325 23.8575,20.4 23.77,20.3225L22.7002,19.4925C22.72,19.3312 22.7393,19.17 22.7393,18.9988C22.7393,18.8275 22.7295,18.6712 22.7002,18.5113L23.76,17.6812C23.8475,17.5975 23.8812,17.4713 23.8188,17.3587L22.8225,15.63C22.7588,15.5225 22.6312,15.4787 22.51,15.5175L21.27,16.02C21.0107,15.82 20.7275,15.65 20.42,15.5275L20.2295,14.2087C20.22,14.0912 20.1123,13.9987 19.99,13.9987M18.9888,17.5C19.8188,17.5 20.4888,18.1687 20.4888,18.9988C20.4888,19.8288 19.8188,20.4975 18.9888,20.4975C18.1588,20.4975 17.49,19.8288 17.49,18.9988C17.49,18.1687 18.1588,17.5 18.9888,17.5Z&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/drawable/ic_account_settings.xml"
line="10"
column="27"/>
</issue>
<issue
id="Overdraw"
fix: Update themes to correct poll/black theme issues (#255) `Theme.Pachli` was being overriden on v29+ devices which meant that poll options were showing with too much padding. Fix that by using `AppTheme` as the final theme, and basing that off `Theme.Pachli`. Black themes were using dark grey for toolbar and tab backgrounds, so fix that too for a seamless experience with the black theme.
2023-11-15 15:59:01 +01:00
message="Possible overdraw: Root element paints background `@color/black` with a theme that also paints a background (inferred theme is `@style/AppTheme`)"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
errorLine1=" android:background=&quot;@color/black&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/activity_view_media.xml"
line="6"
column="5"/>
</issue>
<issue
add lint to ci checks (#3462) * add lint to ci checks * update lint baseline
2023-03-21 18:56:11 +01:00
id="UnusedResources"
message="The resource `R.menu.activity_scheduled_status` appears to be unused"
errorLine1="&lt;menu xmlns:android=&quot;http://schemas.android.com/apk/res/android&quot;"
errorLine2="^">
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<location
add lint to ci checks (#3462) * add lint to ci checks * update lint baseline
2023-03-21 18:56:11 +01:00
file="src/main/res/menu/activity_scheduled_status.xml"
style: Require trailing comma, and break lines Requiring trailing commas on multi-line lists of items (declarations and call sites) reduces future repository churn when those lines are changed, but introduces additional churn now. Bite the bullet and make the change, as well as adjusting lines that were too long / indented incorrectly. The changes were performed automatically, using the `ktlintFormat` task. Based on https://github.com/tuskyapp/Tusky/pull/3968 by https://github.com/tinsukE
2023-09-02 23:16:29 +02:00
line="19"
add lint to ci checks (#3462) * add lint to ci checks * update lint baseline
2023-03-21 18:56:11 +01:00
column="1"/>
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
</issue>
<issue
id="UnusedResources"
message="The resource `R.array.app_theme_values` appears to be unused"
errorLine1=" &lt;string-array name=&quot;app_theme_values&quot;>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/donottranslate.xml"
refactor: Modularise "about" activities (#405) Continue modularisation by moving activities in the "About" feature to a new `feature.about` module. Implement `feature.about: - Move `AboutActivity`, `LicenseActivity`, and `PrivacyPolicyActivity` here. - Update `markdown2resource` plugin to work with libraries Implement `core.data`: - Types and repositories used through the app - Move `InstanceInfo` and `InstanceInfoRepository` here so they are available to `feature.about`. Implement `core.ui`: - App-specific views, spans, and other UI content - Move `ClickableSpanTextView` and `NoUnderlineURLSpan` here so they are available to `feature.about`.
2024-02-02 15:14:31 +01:00
line="47"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="19"/>
</issue>
add lint to ci checks (#3462) * add lint to ci checks * update lint baseline
2023-03-21 18:56:11 +01:00
<issue
id="UnusedResources"
message="The resource `R.array.filter_action_values` appears to be unused"
errorLine1=" &lt;string-array name=&quot;filter_action_values&quot;>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/donottranslate.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="275"
add lint to ci checks (#3462) * add lint to ci checks * update lint baseline
2023-03-21 18:56:11 +01:00
column="19"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.array.filter_context_values` appears to be unused"
errorLine1=" &lt;string-array name=&quot;filter_context_values&quot;>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/donottranslate.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="280"
add lint to ci checks (#3462) * add lint to ci checks * update lint baseline
2023-03-21 18:56:11 +01:00
column="19"/>
</issue>
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
<issue
id="UnusedResources"
message="The resource `R.drawable.elephant_friend` appears to be unused"
errorLine1="&lt;vector xmlns:android=&quot;http://schemas.android.com/apk/res/android&quot;"
errorLine2="^">
<location
file="src/main/res/drawable/elephant_friend.xml"
line="1"
column="1"/>
</issue>
add lint to ci checks (#3462) * add lint to ci checks * update lint baseline
2023-03-21 18:56:11 +01:00
<issue
id="UnusedResources"
message="The resource `R.menu.fragment_search` appears to be unused"
errorLine1="&lt;menu xmlns:android=&quot;http://schemas.android.com/apk/res/android&quot;"
errorLine2="^">
<location
file="src/main/res/menu/fragment_search.xml"
style: Require trailing comma, and break lines Requiring trailing commas on multi-line lists of items (declarations and call sites) reduces future repository churn when those lines are changed, but introduces additional churn now. Bite the bullet and make the change, as well as adjusting lines that were too long / indented incorrectly. The changes were performed automatically, using the `ktlintFormat` task. Based on https://github.com/tuskyapp/Tusky/pull/3968 by https://github.com/tinsukE
2023-09-02 23:16:29 +02:00
line="19"
add lint to ci checks (#3462) * add lint to ci checks * update lint baseline
2023-03-21 18:56:11 +01:00
column="1"/>
</issue>
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<issue
id="UnusedResources"
message="The resource `R.drawable.ic_notifications_off_24dp` appears to be unused"
errorLine1="&lt;vector xmlns:android=&quot;http://schemas.android.com/apk/res/android&quot;"
errorLine2="^">
<location
file="src/main/res/drawable/ic_notifications_off_24dp.xml"
line="1"
column="1"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.drawable.ic_notoemoji` appears to be unused"
errorLine1="&lt;vector android:height=&quot;34dp&quot;"
errorLine2="^">
<location
refactor: Remove obsolete emoji-related resources (#526)
2024-03-13 11:29:45 +01:00
file="src/main/res/drawable-v24/ic_notoemoji.xml"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
line="1"
column="1"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.color.launcher_shadow_gradient` appears to be unused"
errorLine1="&lt;gradient xmlns:android=&quot;http://schemas.android.com/apk/res/android&quot;"
errorLine2="^">
<location
file="src/main/res/color-v24/launcher_shadow_gradient.xml"
line="2"
column="1"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.layout.material_drawer_header` appears to be unused"
errorLine1="&lt;merge xmlns:android=&quot;http://schemas.android.com/apk/res/android&quot;"
errorLine2="^">
<location
file="src/main/res/layout/material_drawer_header.xml"
line="2"
column="1"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.error_no_web_browser_found` appears to be unused"
errorLine1=" &lt;string name=&quot;error_no_web_browser_found&quot;>Couldn\&apos;t find a web browser to use.&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
refactor: Extract user list functionality to `feature:lists` (#537) Move `ListsActivity`, along with fragments and viewmodels, to a new `feature:lists` module. Previous code used the `item_follow_request` layout, which was not ideal, so update it to use a dedicated layout, `item_account_in_list`. The UI uses strings and views originally defined in the main app, so move them elsewhere so they can be re-used. - `BackgroundMessageView` moves to `core.ui`. - `Lazy` moves to `core.common`. - `ThrowableExtensions` split; the extensions specific to throwables from network activity move to `core.network`, others move to `core.ui`. - `BindingHolder` moves to `core.ui` - Shared drawables and strings move to `core.ui`.
2024-03-16 18:42:11 +01:00
line="19"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.error_media_upload_type` appears to be unused"
errorLine1=" &lt;string name=&quot;error_media_upload_type&quot;>That type of file cannot be uploaded.&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Provide more detail in errors, especially media upload errors (#801) Previous code assumed server responses would always be JSON, and had no special handling for mis-configured servers that sometimes return HTML; for example, if the server has a bug, or there's a reverse proxy in front of the server issuing DoS-prevention challenges. This could cause errors to show with no useful debugging information. Update `ApiResult` to check the content-type in the response and return one of two new errors if the content-type is missing or wrong. Also include the HTTP code in `ApiResponse` for use elsewhere. Update `ThrowableExtensions` to pull the `error` and optional `description` out of the error body. Update `PachliError` so `formatArgs` can be an array of arbitrary types, not just strings. Update `MediaUploader`; expose the different errors as new `MediaUploaderError` types instead of `Exception` subclasses, and return `Result<V, E>` where appropriate. Update `ComposeViewModel` to use the new `MediaUploaderError` types and create new `PickMediaError` to report issues there, replacing `VideoOrImageException`. Update `ComposeActivity` to use the new error types and show errors until the user dismisses them, so they're better able to see and report problems. Fixes #704.
2024-07-04 19:16:24 +02:00
line="22"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.error_following_hashtags_unsupported` appears to be unused"
errorLine1=" &lt;string name=&quot;error_following_hashtags_unsupported&quot;>This instance does not support following hashtags.&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Provide more detail in errors, especially media upload errors (#801) Previous code assumed server responses would always be JSON, and had no special handling for mis-configured servers that sometimes return HTML; for example, if the server has a bug, or there's a reverse proxy in front of the server issuing DoS-prevention challenges. This could cause errors to show with no useful debugging information. Update `ApiResult` to check the content-type in the response and return one of two new errors if the content-type is missing or wrong. Also include the HTTP code in `ApiResponse` for use elsewhere. Update `ThrowableExtensions` to pull the `error` and optional `description` out of the error body. Update `PachliError` so `formatArgs` can be an array of arbitrary types, not just strings. Update `MediaUploader`; expose the different errors as new `MediaUploaderError` types instead of `Exception` subclasses, and return `Result<V, E>` where appropriate. Update `ComposeViewModel` to use the new `MediaUploaderError` types and create new `PickMediaError` to report issues there, replacing `VideoOrImageException`. Update `ComposeActivity` to use the new error types and show errors until the user dismisses them, so they're better able to see and report problems. Fixes #704.
2024-07-04 19:16:24 +02:00
line="32"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.post_sensitive_media_directions` appears to be unused"
errorLine1=" &lt;string name=&quot;post_sensitive_media_directions&quot;>Click to view&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Provide more detail in errors, especially media upload errors (#801) Previous code assumed server responses would always be JSON, and had no special handling for mis-configured servers that sometimes return HTML; for example, if the server has a bug, or there's a reverse proxy in front of the server issuing DoS-prevention challenges. This could cause errors to show with no useful debugging information. Update `ApiResult` to check the content-type in the response and return one of two new errors if the content-type is missing or wrong. Also include the HTTP code in `ApiResponse` for use elsewhere. Update `ThrowableExtensions` to pull the `error` and optional `description` out of the error body. Update `PachliError` so `formatArgs` can be an array of arbitrary types, not just strings. Update `MediaUploader`; expose the different errors as new `MediaUploaderError` types instead of `Exception` subclasses, and return `Result<V, E>` where appropriate. Update `ComposeViewModel` to use the new `MediaUploaderError` types and create new `PickMediaError` to report issues there, replacing `VideoOrImageException`. Update `ComposeActivity` to use the new error types and show errors until the user dismisses them, so they're better able to see and report problems. Fixes #704.
2024-07-04 19:16:24 +02:00
line="74"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.footer_empty` appears to be unused"
errorLine1=" &lt;string name=&quot;footer_empty&quot;>Nothing here. Pull down to refresh!&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Provide more detail in errors, especially media upload errors (#801) Previous code assumed server responses would always be JSON, and had no special handling for mis-configured servers that sometimes return HTML; for example, if the server has a bug, or there's a reverse proxy in front of the server issuing DoS-prevention challenges. This could cause errors to show with no useful debugging information. Update `ApiResult` to check the content-type in the response and return one of two new errors if the content-type is missing or wrong. Also include the HTTP code in `ApiResponse` for use elsewhere. Update `ThrowableExtensions` to pull the `error` and optional `description` out of the error body. Update `PachliError` so `formatArgs` can be an array of arbitrary types, not just strings. Update `MediaUploader`; expose the different errors as new `MediaUploaderError` types instead of `Exception` subclasses, and return `Result<V, E>` where appropriate. Update `ComposeViewModel` to use the new `MediaUploaderError` types and create new `PickMediaError` to report issues there, replacing `VideoOrImageException`. Update `ComposeActivity` to use the new error types and show errors until the user dismisses them, so they're better able to see and report problems. Fixes #704.
2024-07-04 19:16:24 +02:00
line="80"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.report_comment_hint` appears to be unused"
errorLine1=" &lt;string name=&quot;report_comment_hint&quot;>Additional comments?&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Provide more detail in errors, especially media upload errors (#801) Previous code assumed server responses would always be JSON, and had no special handling for mis-configured servers that sometimes return HTML; for example, if the server has a bug, or there's a reverse proxy in front of the server issuing DoS-prevention challenges. This could cause errors to show with no useful debugging information. Update `ApiResult` to check the content-type in the response and return one of two new errors if the content-type is missing or wrong. Also include the HTTP code in `ApiResponse` for use elsewhere. Update `ThrowableExtensions` to pull the `error` and optional `description` out of the error body. Update `PachliError` so `formatArgs` can be an array of arbitrary types, not just strings. Update `MediaUploader`; expose the different errors as new `MediaUploaderError` types instead of `Exception` subclasses, and return `Result<V, E>` where appropriate. Update `ComposeViewModel` to use the new `MediaUploaderError` types and create new `PickMediaError` to report issues there, replacing `VideoOrImageException`. Update `ComposeActivity` to use the new error types and show errors until the user dismisses them, so they're better able to see and report problems. Fixes #704.
2024-07-04 19:16:24 +02:00
line="101"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.action_unbookmark` appears to be unused"
errorLine1=" &lt;string name=&quot;action_unbookmark&quot;>Remove bookmark&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Provide more detail in errors, especially media upload errors (#801) Previous code assumed server responses would always be JSON, and had no special handling for mis-configured servers that sometimes return HTML; for example, if the server has a bug, or there's a reverse proxy in front of the server issuing DoS-prevention challenges. This could cause errors to show with no useful debugging information. Update `ApiResult` to check the content-type in the response and return one of two new errors if the content-type is missing or wrong. Also include the HTTP code in `ApiResponse` for use elsewhere. Update `ThrowableExtensions` to pull the `error` and optional `description` out of the error body. Update `PachliError` so `formatArgs` can be an array of arbitrary types, not just strings. Update `MediaUploader`; expose the different errors as new `MediaUploaderError` types instead of `Exception` subclasses, and return `Result<V, E>` where appropriate. Update `ComposeViewModel` to use the new `MediaUploaderError` types and create new `PickMediaError` to report issues there, replacing `VideoOrImageException`. Update `ComposeActivity` to use the new error types and show errors until the user dismisses them, so they're better able to see and report problems. Fixes #704.
2024-07-04 19:16:24 +02:00
line="109"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.action_view_domain_mutes` appears to be unused"
errorLine1=" &lt;string name=&quot;action_view_domain_mutes&quot;>Hidden domains&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Provide more detail in errors, especially media upload errors (#801) Previous code assumed server responses would always be JSON, and had no special handling for mis-configured servers that sometimes return HTML; for example, if the server has a bug, or there's a reverse proxy in front of the server issuing DoS-prevention challenges. This could cause errors to show with no useful debugging information. Update `ApiResult` to check the content-type in the response and return one of two new errors if the content-type is missing or wrong. Also include the HTTP code in `ApiResponse` for use elsewhere. Update `ThrowableExtensions` to pull the `error` and optional `description` out of the error body. Update `PachliError` so `formatArgs` can be an array of arbitrary types, not just strings. Update `MediaUploader`; expose the different errors as new `MediaUploaderError` types instead of `Exception` subclasses, and return `Result<V, E>` where appropriate. Update `ComposeViewModel` to use the new `MediaUploaderError` types and create new `PickMediaError` to report issues there, replacing `VideoOrImageException`. Update `ComposeActivity` to use the new error types and show errors until the user dismisses them, so they're better able to see and report problems. Fixes #704.
2024-07-04 19:16:24 +02:00
line="143"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.confirmation_reported` appears to be unused"
errorLine1=" &lt;string name=&quot;confirmation_reported&quot;>Sent!&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="199"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.dialog_title_finishing_media_upload` appears to be unused"
errorLine1=" &lt;string name=&quot;dialog_title_finishing_media_upload&quot;>Finishing Media Upload&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="220"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.dialog_message_uploading_media` appears to be unused"
errorLine1=" &lt;string name=&quot;dialog_message_uploading_media&quot;>Uploading…&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="221"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.pref_title_notification_filter_mentions` appears to be unused"
errorLine1=" &lt;string name=&quot;pref_title_notification_filter_mentions&quot;>mentioned&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="244"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.pref_title_post_filter` appears to be unused"
errorLine1=" &lt;string name=&quot;pref_title_post_filter&quot;>Timeline filtering&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="273"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
message="The resource `R.string.about_pachli_version` appears to be unused"
errorLine1=" &lt;string name=&quot;about_pachli_version&quot;>Pachli %s&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~">
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="344"
add lint to ci checks (#3462) * add lint to ci checks * update lint baseline
2023-03-21 18:56:11 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.filter_dialog_remove_button` appears to be unused"
errorLine1=" &lt;string name=&quot;filter_dialog_remove_button&quot;>Remove&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="384"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.download_fonts` appears to be unused"
errorLine1=" &lt;string name=&quot;download_fonts&quot;>You\&apos;ll need to download these emoji sets first&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="420"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.restart_required` appears to be unused"
errorLine1=" &lt;string name=&quot;restart_required&quot;>App restart required&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="423"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.restart_emoji` appears to be unused"
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
errorLine1=" &lt;string name=&quot;restart_emoji&quot;>You\&apos;ll need to restart Pachli in order to apply these changes&lt;/string>"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="424"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.later` appears to be unused"
errorLine1=" &lt;string name=&quot;later&quot;>Later&lt;/string>"
errorLine2=" ~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="425"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.restart` appears to be unused"
errorLine1=" &lt;string name=&quot;restart&quot;>Restart&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="426"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.download_failed` appears to be unused"
errorLine1=" &lt;string name=&quot;download_failed&quot;>Download failed&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="427"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
fix: Generate useful error messages for all errors (#719) Previous code was inconsistent about using getServerErrorMessage() and whether or not the case where getServerErrorMessage() returns null was handled. Switch to using getErrorString() which does handle the null case and always returns a usable string. Some string resources are rendered temporarily unused by this change. They will be used again soon, so configure lint to ignore them at the moment.
2024-05-30 19:14:43 +02:00
<issue
id="UnusedResources"
message="The resource `R.string.failed_to_pin` appears to be unused"
errorLine1=" &lt;string name=&quot;failed_to_pin&quot;>Failed to Pin&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="439"
fix: Generate useful error messages for all errors (#719) Previous code was inconsistent about using getServerErrorMessage() and whether or not the case where getServerErrorMessage() returns null was handled. Switch to using getErrorString() which does handle the null case and always returns a usable string. Some string resources are rendered temporarily unused by this change. They will be used again soon, so configure lint to ignore them at the moment.
2024-05-30 19:14:43 +02:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.failed_to_unpin` appears to be unused"
errorLine1=" &lt;string name=&quot;failed_to_unpin&quot;>Failed to Unpin&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="440"
fix: Generate useful error messages for all errors (#719) Previous code was inconsistent about using getServerErrorMessage() and whether or not the case where getServerErrorMessage() returns null was handled. Switch to using getErrorString() which does handle the null case and always returns a usable string. Some string resources are rendered temporarily unused by this change. They will be used again soon, so configure lint to ignore them at the moment.
2024-05-30 19:14:43 +02:00
column="13"/>
</issue>
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<issue
id="UnusedResources"
message="The resource `R.string.description_login` appears to be unused"
errorLine1=" &lt;string name=&quot;description_login&quot;>Works in most cases. No data is leaked to other apps.&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="491"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.description_browser_login` appears to be unused"
errorLine1=" &lt;string name=&quot;description_browser_login&quot;>May support additional authentication methods, but requires a supported browser.&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="492"
add lint to ci checks (#3462) * add lint to ci checks * update lint baseline
2023-03-21 18:56:11 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.filter_apply` appears to be unused"
errorLine1=" &lt;string name=&quot;filter_apply&quot;>Apply&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="503"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.compose_shortcut_long_label` appears to be unused"
errorLine1=" &lt;string name=&quot;compose_shortcut_long_label&quot;>Compose post&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="504"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.compose_shortcut_short_label` appears to be unused"
errorLine1=" &lt;string name=&quot;compose_shortcut_short_label&quot;>Compose&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="505"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.compose_preview_image_description` appears to be unused"
errorLine1=" &lt;string name=&quot;compose_preview_image_description&quot;>Actions for image %s&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="508"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.failed_report` appears to be unused"
errorLine1=" &lt;string name=&quot;failed_report&quot;>Failed to report&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="546"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.wellbeing_mode_notice` appears to be unused"
errorLine1=" &lt;string name=&quot;wellbeing_mode_notice&quot;>Some information that might affect your mental wellbeing will be hidden. This includes:\n\n"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="587"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.review_notifications` appears to be unused"
errorLine1=" &lt;string name=&quot;review_notifications&quot;>Review Notifications&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="593"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.action_unfollow_hashtag_format` appears to be unused"
errorLine1=" &lt;string name=&quot;action_unfollow_hashtag_format&quot;>Unfollow #%s?&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="621"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="13"/>
</issue>
<issue
id="UnusedResources"
add lint to ci checks (#3462) * add lint to ci checks * update lint baseline
2023-03-21 18:56:11 +01:00
message="The resource `R.string.hint_filter_title` appears to be unused"
errorLine1=" &lt;string name=&quot;hint_filter_title&quot;>My filter&lt;/string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/strings.xml"
feat: Toggle display of search operators with toolbar action (#836) Default to hiding the search operators, and provide a new toolbar icon (always visible) to show them. The toolbar icon is displayed with a badge if any operators are present. Adjust the operator display to three horizontal scrolling rows, to further limit the maximum amount of vertical space the operators use.
2024-07-24 18:51:00 +02:00
line="647"
add lint to ci checks (#3462) * add lint to ci checks * update lint baseline
2023-03-21 18:56:11 +01:00
column="13"/>
</issue>
Replace deprecated getParcelable* methods with compat versions (#3633)
2023-06-11 12:58:55 +02:00
<issue
id="ConvertToWebp"
message="One or more images in this project can be converted to the WebP format which typically results in smaller file sizes, even for lossless conversion">
<location
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
file="src/main/res/drawable-xxhdpi/ic_notify.png"/>
Replace deprecated getParcelable* methods with compat versions (#3633)
2023-06-11 12:58:55 +02:00
</issue>
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/activity_account.xml"
fix: Label the header and avatar on the account screen
2023-09-20 16:24:49 +02:00
line="117"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="22"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/activity_account.xml"
refactor: Convert Java viewholders to Kotlin (#200)
2023-10-26 16:22:18 +02:00
line="129"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="22"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/activity_account.xml"
fix: Calculate length of posts and polls with emojis correctly (#315) Mastodon counts post lengths by considering emojis to be single characters, no matter how many unicode code points they are composed of. So "😜" has length 1. Pachli was using `String.length`, which considers "😜" as length 2. Correct the calculation by using a BreakIterator to count the characters in the string, which treats multi-character emojis as a length 1. Poll options had a similar problem, exacerbated by the Mastodon web UI also having the same problem, see https://github.com/mastodon/mastodon/issues/28336. Fix that by creating `MastodonLengthFilter`, an `InputFilter` that does the right thing for regular text that may contain emojis. See also https://github.com/tuskyapp/Tusky/pull/4152, which has the fix for status length but not polls. --------- Co-authored-by: Konrad Pozniak <opensource@connyduck.at>
2023-12-12 16:53:09 +01:00
line="243"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="22"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/activity_account.xml"
fix: Calculate length of posts and polls with emojis correctly (#315) Mastodon counts post lengths by considering emojis to be single characters, no matter how many unicode code points they are composed of. So "😜" has length 1. Pachli was using `String.length`, which considers "😜" as length 2. Correct the calculation by using a BreakIterator to count the characters in the string, which treats multi-character emojis as a length 1. Poll options had a similar problem, exacerbated by the Mastodon web UI also having the same problem, see https://github.com/mastodon/mastodon/issues/28336. Fix that by creating `MastodonLengthFilter`, an `InputFilter` that does the right thing for regular text that may contain emojis. See also https://github.com/tuskyapp/Tusky/pull/4152, which has the fix for status length but not polls. --------- Co-authored-by: Konrad Pozniak <opensource@connyduck.at>
2023-12-12 16:53:09 +01:00
line="279"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="26"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/activity_account.xml"
fix: Calculate length of posts and polls with emojis correctly (#315) Mastodon counts post lengths by considering emojis to be single characters, no matter how many unicode code points they are composed of. So "😜" has length 1. Pachli was using `String.length`, which considers "😜" as length 2. Correct the calculation by using a BreakIterator to count the characters in the string, which treats multi-character emojis as a length 1. Poll options had a similar problem, exacerbated by the Mastodon web UI also having the same problem, see https://github.com/mastodon/mastodon/issues/28336. Fix that by creating `MastodonLengthFilter`, an `InputFilter` that does the right thing for regular text that may contain emojis. See also https://github.com/tuskyapp/Tusky/pull/4152, which has the fix for status length but not polls. --------- Co-authored-by: Konrad Pozniak <opensource@connyduck.at>
2023-12-12 16:53:09 +01:00
line="306"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="26"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/activity_account.xml"
fix: Calculate length of posts and polls with emojis correctly (#315) Mastodon counts post lengths by considering emojis to be single characters, no matter how many unicode code points they are composed of. So "😜" has length 1. Pachli was using `String.length`, which considers "😜" as length 2. Correct the calculation by using a BreakIterator to count the characters in the string, which treats multi-character emojis as a length 1. Poll options had a similar problem, exacerbated by the Mastodon web UI also having the same problem, see https://github.com/mastodon/mastodon/issues/28336. Fix that by creating `MastodonLengthFilter`, an `InputFilter` that does the right thing for regular text that may contain emojis. See also https://github.com/tuskyapp/Tusky/pull/4152, which has the fix for status length but not polls. --------- Co-authored-by: Konrad Pozniak <opensource@connyduck.at>
2023-12-12 16:53:09 +01:00
line="321"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="26"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/activity_account.xml"
fix: Calculate length of posts and polls with emojis correctly (#315) Mastodon counts post lengths by considering emojis to be single characters, no matter how many unicode code points they are composed of. So "😜" has length 1. Pachli was using `String.length`, which considers "😜" as length 2. Correct the calculation by using a BreakIterator to count the characters in the string, which treats multi-character emojis as a length 1. Poll options had a similar problem, exacerbated by the Mastodon web UI also having the same problem, see https://github.com/mastodon/mastodon/issues/28336. Fix that by creating `MastodonLengthFilter`, an `InputFilter` that does the right thing for regular text that may contain emojis. See also https://github.com/tuskyapp/Tusky/pull/4152, which has the fix for status length but not polls. --------- Co-authored-by: Konrad Pozniak <opensource@connyduck.at>
2023-12-12 16:53:09 +01:00
line="348"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="26"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/activity_account.xml"
fix: Calculate length of posts and polls with emojis correctly (#315) Mastodon counts post lengths by considering emojis to be single characters, no matter how many unicode code points they are composed of. So "😜" has length 1. Pachli was using `String.length`, which considers "😜" as length 2. Correct the calculation by using a BreakIterator to count the characters in the string, which treats multi-character emojis as a length 1. Poll options had a similar problem, exacerbated by the Mastodon web UI also having the same problem, see https://github.com/mastodon/mastodon/issues/28336. Fix that by creating `MastodonLengthFilter`, an `InputFilter` that does the right thing for regular text that may contain emojis. See also https://github.com/tuskyapp/Tusky/pull/4152, which has the fix for status length but not polls. --------- Co-authored-by: Konrad Pozniak <opensource@connyduck.at>
2023-12-12 16:53:09 +01:00
line="379"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="26"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/activity_account.xml"
fix: Calculate length of posts and polls with emojis correctly (#315) Mastodon counts post lengths by considering emojis to be single characters, no matter how many unicode code points they are composed of. So "😜" has length 1. Pachli was using `String.length`, which considers "😜" as length 2. Correct the calculation by using a BreakIterator to count the characters in the string, which treats multi-character emojis as a length 1. Poll options had a similar problem, exacerbated by the Mastodon web UI also having the same problem, see https://github.com/mastodon/mastodon/issues/28336. Fix that by creating `MastodonLengthFilter`, an `InputFilter` that does the right thing for regular text that may contain emojis. See also https://github.com/tuskyapp/Tusky/pull/4152, which has the fix for status length but not polls. --------- Co-authored-by: Konrad Pozniak <opensource@connyduck.at>
2023-12-12 16:53:09 +01:00
line="409"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="26"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/activity_compose.xml"
fix: Improve accessibility of ComposeActivity bottomsheets and buttons (#548) The previous bottomsheets did set a minimum height for the menu items, so they were less than the recommended 48dp minimum. Fix that to improve the overall accessibility. Always highlight the "visibilty" icon, to make it clear that it's something that is set (even if to the default). Show the visibility icon on the "Toot" button as an additional reminder to the user. Other changes: - Use the "filled" style for all icons (the visibility icons had the "outlined" style) - Use the `makeIcon` helper function. - Use the `Status.Visibility` extension functions to determine the icon for each visibility type, reducing code duplication.
2024-03-21 16:24:31 +01:00
line="368"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="10"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView android:id=&quot;@+id/warning&quot;"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/dialog_mute_account.xml"
line="12"
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout-land/fragment_report_done.xml"
line="35"
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/fragment_report_done.xml"
line="35"
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/fragment_view_video.xml"
line="11"
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_account.xml"
line="37"
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_account.xml"
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
line="53"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_account_field.xml"
line="10"
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_autocomplete_emoji.xml"
line="19"
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_blocked_user.xml"
line="30"
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_blocked_user.xml"
line="46"
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_conversation.xml"
line="14"
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_conversation.xml"
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
line="81"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_conversation.xml"
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
line="99"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_conversation.xml"
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
line="111"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_draft.xml"
line="31"
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_draft.xml"
line="45"
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_follow.xml"
line="12"
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_follow.xml"
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
line="41"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_follow.xml"
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
line="57"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_follow_request.xml"
Refactor "trending hashtags" code (#3595) - Fix codeformatting - Add new refreshing state - Disable LogConditional lint rule - Update lint-baseline
2023-06-10 19:47:07 +02:00
line="11"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_follow_request.xml"
Refactor "trending hashtags" code (#3595) - Fix codeformatting - Add new refreshing state - Disable LogConditional lint rule - Update lint-baseline
2023-06-10 19:47:07 +02:00
line="49"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_follow_request.xml"
Refactor "trending hashtags" code (#3595) - Fix codeformatting - Add new refreshing state - Disable LogConditional lint rule - Update lint-baseline
2023-06-10 19:47:07 +02:00
line="65"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_followed_hashtag.xml"
Fix lint issues in AppDatabase.java (#3809)
2023-07-06 19:37:51 +02:00
line="14"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
feat: Remove explicit "Load more", load on demand Prior to this change the user had to repeatedly tap "Load more" when scrolling. This is tedious for the user. In addition, the previous code had bugs that meant that not all statuses were being loaded. Users could leave the app for a while (overnight, say), and when returning would discover far fewer statuses than had actually been posted. Fix this, following the architecture first introduced for notifications (Fragment -> ViewModel -> Repository -> Source/Mediator). - Load statuses for cached and non-cached timelines using Paging3 - Show Failures during a load, and the user can retry - Delete the "Reading order" preference, it is no longer necessary
2023-09-02 17:47:43 +02:00
file="src/main/res/layout/item_load_state_footer_view.xml"
line="30"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
feat: Remove explicit "Load more", load on demand Prior to this change the user had to repeatedly tap "Load more" when scrolling. This is tedious for the user. In addition, the previous code had bugs that meant that not all statuses were being loaded. Users could leave the app for a while (overnight, say), and when returning would discover far fewer statuses than had actually been posted. Fix this, following the architecture first introduced for notifications (Fragment -> ViewModel -> Repository -> Source/Mediator). - Load statuses for cached and non-cached timelines using Paging3 - Show Failures during a load, and the user can retry - Delete the "Reading order" preference, it is no longer necessary
2023-09-02 17:47:43 +02:00
file="src/main/res/layout/item_muted_domain.xml"
line="27"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_muted_user.xml"
feat: Remove explicit "Load more", load on demand Prior to this change the user had to repeatedly tap "Load more" when scrolling. This is tedious for the user. In addition, the previous code had bugs that meant that not all statuses were being loaded. Users could leave the app for a while (overnight, say), and when returning would discover far fewer statuses than had actually been posted. Fix this, following the architecture first introduced for notifications (Fragment -> ViewModel -> Repository -> Source/Mediator). - Load statuses for cached and non-cached timelines using Paging3 - Show Failures during a load, and the user can retry - Delete the "Reading order" preference, it is no longer necessary
2023-09-02 17:47:43 +02:00
line="31"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
feat: Remove explicit "Load more", load on demand Prior to this change the user had to repeatedly tap "Load more" when scrolling. This is tedious for the user. In addition, the previous code had bugs that meant that not all statuses were being loaded. Users could leave the app for a while (overnight, say), and when returning would discover far fewer statuses than had actually been posted. Fix this, following the architecture first introduced for notifications (Fragment -> ViewModel -> Repository -> Source/Mediator). - Load statuses for cached and non-cached timelines using Paging3 - Show Failures during a load, and the user can retry - Delete the "Reading order" preference, it is no longer necessary
2023-09-02 17:47:43 +02:00
file="src/main/res/layout/item_muted_user.xml"
line="48"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
feat: Remove explicit "Load more", load on demand Prior to this change the user had to repeatedly tap "Load more" when scrolling. This is tedious for the user. In addition, the previous code had bugs that meant that not all statuses were being loaded. Users could leave the app for a while (overnight, say), and when returning would discover far fewer statuses than had actually been posted. Fix this, following the architecture first introduced for notifications (Fragment -> ViewModel -> Repository -> Source/Mediator). - Load statuses for cached and non-cached timelines using Paging3 - Show Failures during a load, and the user can retry - Delete the "Reading order" preference, it is no longer necessary
2023-09-02 17:47:43 +02:00
file="src/main/res/layout/item_network_state.xml"
line="8"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
add lint to ci checks (#3462) * add lint to ci checks * update lint baseline
2023-03-21 18:56:11 +01:00
file="src/main/res/layout/item_poll.xml"
line="8"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
add lint to ci checks (#3462) * add lint to ci checks * update lint baseline
2023-03-21 18:56:11 +01:00
file="src/main/res/layout/item_removable.xml"
line="9"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
add lint to ci checks (#3462) * add lint to ci checks * update lint baseline
2023-03-21 18:56:11 +01:00
file="src/main/res/layout/item_removable.xml"
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
line="23"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
add lint to ci checks (#3462) * add lint to ci checks * update lint baseline
2023-03-21 18:56:11 +01:00
file="src/main/res/layout/item_report_notification.xml"
line="12"
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_report_notification.xml"
line="50"
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_report_notification.xml"
line="65"
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_report_status.xml"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
line="52"
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_report_status.xml"
Improve account switching intents (#3732) Before, intent creation was scattered across multiple sites, with account switching logic in both `ComposeActivity` and `MainActivity`. Now, intents are only created in `MainActivity` Companion, and account switching only occurs in `MainActivity` Fixes #3695
2023-08-19 12:31:47 +02:00
line="241"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_report_status.xml"
Improve account switching intents (#3732) Before, intent creation was scattered across multiple sites, with account switching logic in both `ComposeActivity` and `MainActivity`. Now, intents are only created in `MainActivity` Companion, and account switching only occurs in `MainActivity` Fixes #3695
2023-08-19 12:31:47 +02:00
line="261"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_report_status.xml"
Improve account switching intents (#3732) Before, intent creation was scattered across multiple sites, with account switching logic in both `ComposeActivity` and `MainActivity`. Now, intents are only created in `MainActivity` Companion, and account switching only occurs in `MainActivity` Fixes #3695
2023-08-19 12:31:47 +02:00
line="281"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_report_status.xml"
Improve account switching intents (#3732) Before, intent creation was scattered across multiple sites, with account switching logic in both `ComposeActivity` and `MainActivity`. Now, intents are only created in `MainActivity` Companion, and account switching only occurs in `MainActivity` Fixes #3695
2023-08-19 12:31:47 +02:00
line="301"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_report_status.xml"
Improve account switching intents (#3732) Before, intent creation was scattered across multiple sites, with account switching logic in both `ComposeActivity` and `MainActivity`. Now, intents are only created in `MainActivity` Companion, and account switching only occurs in `MainActivity` Fixes #3695
2023-08-19 12:31:47 +02:00
line="321"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_report_status.xml"
Improve account switching intents (#3732) Before, intent creation was scattered across multiple sites, with account switching logic in both `ComposeActivity` and `MainActivity`. Now, intents are only created in `MainActivity` Companion, and account switching only occurs in `MainActivity` Fixes #3695
2023-08-19 12:31:47 +02:00
line="340"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_scheduled_status.xml"
line="8"
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_status.xml"
line="13"
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_status.xml"
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
line="58"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_status.xml"
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
line="77"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_status.xml"
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
line="90"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_status.xml"
feat: Experimental preference to reverse home timeline (#867) Add a new set of preferences, "Lab experiments", to control features that are under investigation and may never make it into the mainstream. Add the first experimental feature, which reverses the order of the home timeline, so posts are shown oldest first instead of newest first.
2024-08-05 15:48:14 +02:00
line="246"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
add lint to ci checks (#3462) * add lint to ci checks * update lint baseline
2023-03-21 18:56:11 +01:00
file="src/main/res/layout/item_status.xml"
feat: Experimental preference to reverse home timeline (#867) Add a new set of preferences, "Lab experiments", to control features that are under investigation and may never make it into the mainstream. Add the first experimental feature, which reverses the order of the home timeline, so posts are shown oldest first instead of newest first.
2024-08-05 15:48:14 +02:00
line="274"
add lint to ci checks (#3462) * add lint to ci checks * update lint baseline
2023-03-21 18:56:11 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_status.xml"
feat: Experimental preference to reverse home timeline (#867) Add a new set of preferences, "Lab experiments", to control features that are under investigation and may never make it into the mainstream. Add the first experimental feature, which reverses the order of the home timeline, so posts are shown oldest first instead of newest first.
2024-08-05 15:48:14 +02:00
line="302"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_status_detailed.xml"
add lint to ci checks (#3462) * add lint to ci checks * update lint baseline
2023-03-21 18:56:11 +01:00
line="38"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_status_detailed.xml"
add lint to ci checks (#3462) * add lint to ci checks * update lint baseline
2023-03-21 18:56:11 +01:00
line="61"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_status_detailed.xml"
feat: Translate statuses on cached timelines (#220) Implement some support for server-side status translation. Do this by: - Implement support for the `api/v1/instance` endpoint to determine if the remote server supports translation. - Create new `ServerCapabilities` to allow the app to query the remote capabilities in a server-agnostic way. Use this to query if the remote server supports the Mastodon implementation of server-side translation - If translation is supported then show a translate/undo translate option on the status "..." menu. - Fetch translated content from the server if requested, and store it locally as a new Room entity. - Update displaying a status to check if the translated version should be displayed; if it should then new code is used to show translated content, content warning, poll options, and media descriptions. - Add a `TextView` to show an "in progress" message while translation is happening, and to show the translation provider (generally required by agreements with them). Partially fixes #62 --------- Co-authored-by: sanao <naosak1006@gmail.com>
2023-11-12 19:51:46 +01:00
line="194"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_status_detailed.xml"
feat: Translate statuses on cached timelines (#220) Implement some support for server-side status translation. Do this by: - Implement support for the `api/v1/instance` endpoint to determine if the remote server supports translation. - Create new `ServerCapabilities` to allow the app to query the remote capabilities in a server-agnostic way. Use this to query if the remote server supports the Mastodon implementation of server-side translation - If translation is supported then show a translate/undo translate option on the status "..." menu. - Fetch translated content from the server if requested, and store it locally as a new Room entity. - Update displaying a status to check if the translated version should be displayed; if it should then new code is used to show translated content, content warning, poll options, and media descriptions. - Add a `TextView` to show an "in progress" message while translation is happening, and to show the translation provider (generally required by agreements with them). Partially fixes #62 --------- Co-authored-by: sanao <naosak1006@gmail.com>
2023-11-12 19:51:46 +01:00
line="223"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_status_detailed.xml"
feat: Translate statuses on cached timelines (#220) Implement some support for server-side status translation. Do this by: - Implement support for the `api/v1/instance` endpoint to determine if the remote server supports translation. - Create new `ServerCapabilities` to allow the app to query the remote capabilities in a server-agnostic way. Use this to query if the remote server supports the Mastodon implementation of server-side translation - If translation is supported then show a translate/undo translate option on the status "..." menu. - Fetch translated content from the server if requested, and store it locally as a new Room entity. - Update displaying a status to check if the translated version should be displayed; if it should then new code is used to show translated content, content warning, poll options, and media descriptions. - Add a `TextView` to show an "in progress" message while translation is happening, and to show the translation provider (generally required by agreements with them). Partially fixes #62 --------- Co-authored-by: sanao <naosak1006@gmail.com>
2023-11-12 19:51:46 +01:00
line="237"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_status_edit.xml"
Show notifications from workers (#3760) Fix a crash where workers, in some conditions, should show a notification. These are sent to a dedicated channel with no importance. Convert NotificationWorker to a CoroutineWorker and remove its use of `runBlocking`. Fixes #3754
2023-06-29 18:37:27 +02:00
line="13"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_status_edit.xml"
Show notifications from workers (#3760) Fix a crash where workers, in some conditions, should show a notification. These are sent to a dedicated channel with no importance. Convert NotificationWorker to a CoroutineWorker and remove its use of `runBlocking`. Fixes #3754
2023-06-29 18:37:27 +02:00
line="55"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_status_notification.xml"
Refactor "trending hashtags" code (#3595) - Fix codeformatting - Add new refreshing state - Disable LogConditional lint rule - Update lint-baseline
2023-06-10 19:47:07 +02:00
line="12"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
Disable lint checks for unused resource IDs (#3557) * Disable lint checks for unused resource IDs The check doesn't catch some instances where resources are used through viewbinding, and has too many false positives to be useful. * Regenerate lint baseline Delete the existing file, then regenerated with `.\gradlew lintBlueDebug -Dlint.baselines.continue=true`
2023-04-24 09:20:03 +02:00
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<location
file="src/main/res/layout/item_status_notification.xml"
fix: Set the contentDescription for avatars
2023-09-20 16:23:21 +02:00
line="50"
Disable lint checks for unused resource IDs (#3557) * Disable lint checks for unused resource IDs The check doesn't catch some instances where resources are used through viewbinding, and has too many false positives to be useful. * Regenerate lint baseline Delete the existing file, then regenerated with `.\gradlew lintBlueDebug -Dlint.baselines.continue=true`
2023-04-24 09:20:03 +02:00
column="6"/>
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
Disable lint checks for unused resource IDs (#3557) * Disable lint checks for unused resource IDs The check doesn't catch some instances where resources are used through viewbinding, and has too many false positives to be useful. * Regenerate lint baseline Delete the existing file, then regenerated with `.\gradlew lintBlueDebug -Dlint.baselines.continue=true`
2023-04-24 09:20:03 +02:00
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<location
file="src/main/res/layout/item_status_notification.xml"
fix: Set the contentDescription for avatars
2023-09-20 16:23:21 +02:00
line="71"
Disable lint checks for unused resource IDs (#3557) * Disable lint checks for unused resource IDs The check doesn't catch some instances where resources are used through viewbinding, and has too many false positives to be useful. * Regenerate lint baseline Delete the existing file, then regenerated with `.\gradlew lintBlueDebug -Dlint.baselines.continue=true`
2023-04-24 09:20:03 +02:00
column="6"/>
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
Disable lint checks for unused resource IDs (#3557) * Disable lint checks for unused resource IDs The check doesn't catch some instances where resources are used through viewbinding, and has too many false positives to be useful. * Regenerate lint baseline Delete the existing file, then regenerated with `.\gradlew lintBlueDebug -Dlint.baselines.continue=true`
2023-04-24 09:20:03 +02:00
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<location
file="src/main/res/layout/item_status_notification.xml"
fix: Set the contentDescription for avatars
2023-09-20 16:23:21 +02:00
line="85"
Disable lint checks for unused resource IDs (#3557) * Disable lint checks for unused resource IDs The check doesn't catch some instances where resources are used through viewbinding, and has too many false positives to be useful. * Regenerate lint baseline Delete the existing file, then regenerated with `.\gradlew lintBlueDebug -Dlint.baselines.continue=true`
2023-04-24 09:20:03 +02:00
column="6"/>
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_tab_preference.xml"
refactor: Use AppCompatResources.getDrawable() (#671) Replace `ContextCompat.getDrawable()`, as the app-compat version has platform fixes and backports. appcompat-lint warns about bare `context.getDrawable()`, but does not cover `ContextCompat` (https://issuetracker.google.com/issues/337905331)
2024-04-30 13:30:19 +02:00
line="28"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1="&lt;TextView xmlns:android=&quot;http://schemas.android.com/apk/res/android&quot;"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_tab_preference_small.xml"
line="2"
column="2"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout-land/item_trending_cell.xml"
fix: Show correct trending tag values at the end of the chart lines (#380) The previous code incorrectly showed the trending tag usage data twice next to the end of the trending tag lines, instead of one entry for the usage data and one entry for the account data. Fix that. As part of this fix change how the data is displayed. Instead of using two distinct `TextView`, fixed to the bottom end of the chart, draw the text directly on the chart. The text is accurately position so that it is next to the end of the relevant line. If both lines overlap the label positions are adjusted appropriately. The chart now uses Pachli blue and orange for the line colours. While doing this I discovered that the mechanism used to fall back to particular chart colours if none were specified was incorrect, so fix that too.
2024-01-25 00:50:50 +01:00
line="41"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="10"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_trending_cell.xml"
fix: Show correct trending tag values at the end of the chart lines (#380) The previous code incorrectly showed the trending tag usage data twice next to the end of the trending tag lines, instead of one entry for the usage data and one entry for the account data. Fix that. As part of this fix change how the data is displayed. Instead of using two distinct `TextView`, fixed to the bottom end of the chart, draw the text directly on the chart. The text is accurately position so that it is next to the end of the relevant line. If both lines overlap the label positions are adjusted appropriately. The chart now uses Pachli blue and orange for the line colours. While doing this I discovered that the mechanism used to fall back to particular chart colours if none were specified was incorrect, so fix that too.
2024-01-25 00:50:50 +01:00
line="41"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="10"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout-land/item_trending_cell.xml"
fix: Show correct trending tag values at the end of the chart lines (#380) The previous code incorrectly showed the trending tag usage data twice next to the end of the trending tag lines, instead of one entry for the usage data and one entry for the account data. Fix that. As part of this fix change how the data is displayed. Instead of using two distinct `TextView`, fixed to the bottom end of the chart, draw the text directly on the chart. The text is accurately position so that it is next to the end of the relevant line. If both lines overlap the label positions are adjusted appropriately. The chart now uses Pachli blue and orange for the line colours. While doing this I discovered that the mechanism used to fall back to particular chart colours if none were specified was incorrect, so fix that too.
2024-01-25 00:50:50 +01:00
line="56"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="10"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_trending_cell.xml"
fix: Show correct trending tag values at the end of the chart lines (#380) The previous code incorrectly showed the trending tag usage data twice next to the end of the trending tag lines, instead of one entry for the usage data and one entry for the account data. Fix that. As part of this fix change how the data is displayed. Instead of using two distinct `TextView`, fixed to the bottom end of the chart, draw the text directly on the chart. The text is accurately position so that it is next to the end of the relevant line. If both lines overlap the label positions are adjusted appropriately. The chart now uses Pachli blue and orange for the line colours. While doing this I discovered that the mechanism used to fall back to particular chart colours if none were specified was incorrect, so fix that too.
2024-01-25 00:50:50 +01:00
line="56"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="10"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout-land/item_trending_cell.xml"
fix: Show correct trending tag values at the end of the chart lines (#380) The previous code incorrectly showed the trending tag usage data twice next to the end of the trending tag lines, instead of one entry for the usage data and one entry for the account data. Fix that. As part of this fix change how the data is displayed. Instead of using two distinct `TextView`, fixed to the bottom end of the chart, draw the text directly on the chart. The text is accurately position so that it is next to the end of the relevant line. If both lines overlap the label positions are adjusted appropriately. The chart now uses Pachli blue and orange for the line colours. While doing this I discovered that the mechanism used to fall back to particular chart colours if none were specified was incorrect, so fix that too.
2024-01-25 00:50:50 +01:00
line="87"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="10"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_trending_cell.xml"
fix: Show correct trending tag values at the end of the chart lines (#380) The previous code incorrectly showed the trending tag usage data twice next to the end of the trending tag lines, instead of one entry for the usage data and one entry for the account data. Fix that. As part of this fix change how the data is displayed. Instead of using two distinct `TextView`, fixed to the bottom end of the chart, draw the text directly on the chart. The text is accurately position so that it is next to the end of the relevant line. If both lines overlap the label positions are adjusted appropriately. The chart now uses Pachli blue and orange for the line colours. While doing this I discovered that the mechanism used to fall back to particular chart colours if none were specified was incorrect, so fix that too.
2024-01-25 00:50:50 +01:00
line="88"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="10"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1="&lt;TextView xmlns:android=&quot;http://schemas.android.com/apk/res/android&quot;"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/item_trending_date.xml"
line="2"
column="2"/>
</issue>
add lint to ci checks (#3462) * add lint to ci checks * update lint baseline
2023-03-21 18:56:11 +01:00
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1="&lt;TextView xmlns:android=&quot;http://schemas.android.com/apk/res/android&quot;"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/simple_list_item_1.xml"
line="19"
column="2"/>
</issue>
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/view_compose_schedule.xml"
line="16"
column="6"/>
</issue>
<issue
id="SelectableText"
message="Consider making the text value selectable by specifying `android:textIsSelectable=&quot;true&quot;`"
errorLine1=" &lt;TextView"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/view_poll_preview.xml"
line="30"
column="6"/>
</issue>
<issue
id="BackButton"
message="Back buttons are not standard on Android; see design guide&apos;s navigation section"
errorLine1=" &lt;Button"
errorLine2=" ~~~~~~">
<location
file="src/main/res/layout/fragment_report_note.xml"
line="108"
column="6"/>
</issue>
<issue
id="TextFields"
message="This text field does not specify an `inputType`"
errorLine1=" &lt;EditText"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/dialog_filter.xml"
line="9"
column="6"/>
</issue>
<issue
id="NegativeMargin"
message="Margin values should not be negative"
errorLine1=" android:layout_marginTop=&quot;-4dp&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/item_report_notification.xml"
line="54"
column="9"/>
</issue>
<issue
id="NegativeMargin"
message="Margin values should not be negative"
errorLine1=" android:layout_marginStart=&quot;-14dp&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/item_status.xml"
feat: Experimental preference to reverse home timeline (#867) Add a new set of preferences, "Lab experiments", to control features that are under investigation and may never make it into the mainstream. Add the first experimental feature, which reverses the order of the home timeline, so posts are shown oldest first instead of newest first.
2024-08-05 15:48:14 +02:00
line="236"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="9"/>
</issue>
<issue
id="Autofill"
message="Missing `autofillHints` attribute"
errorLine1=" &lt;EditText"
errorLine2=" ~~~~~~~~">
<location
file="src/main/res/layout/dialog_filter.xml"
line="9"
column="6"/>
</issue>
Use lint version 8.1.0 to fix erroneous warning about forEach (#3903) Android lint was erroneously warning that the forEach construct in Kotlin required API 24+, which is incorrect, see https://issuetracker.google.com/issues/185418482. Work around that by forcing the Android lint version to 8.1.0. This triggered some additional checks, which have been ignored, and a new baseline.
2023-07-30 21:45:43 +02:00
<issue
id="ReportShortcutUsage"
message="Calling this method indicates use of dynamic shortcuts, but there are no calls to methods that track shortcut usage, such as `pushDynamicShortcut` or `reportShortcutUsed`. Calling these methods is recommended, as they track shortcut usage and allow launchers to adjust which shortcuts appear based on activation history. Please see https://developer.android.com/develop/ui/views/launch/shortcuts/managing-shortcuts#track-usage"
fix: Don't exceed the maximum number of created shortcuts (#771) Previous code created one shortcut per account, which could exceed the maximum number of shortcuts allowed, causing a crash. Fix this by creating no more than the max number of shortcuts while ensuring that the active account is always included. Fixes #752
2024-06-20 13:26:31 +02:00
errorLine1=" ShortcutManagerCompat.setDynamicShortcuts(context, shortcuts)"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
Use lint version 8.1.0 to fix erroneous warning about forEach (#3903) Android lint was erroneously warning that the forEach construct in Kotlin required API 24+, which is incorrect, see https://issuetracker.google.com/issues/185418482. Work around that by forcing the Android lint version to 8.1.0. This triggered some additional checks, which have been ignored, and a new baseline.
2023-07-30 21:45:43 +02:00
<location
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
file="src/main/java/app/pachli/util/ShareShortcutHelper.kt"
refactor: Remove `TabData` type (#576) `TabData` recorded the type of the timeline the user had added to a tab. `TimelineKind` is another type that records general information about configured timelines, with identical properties. There's no need for both, so remove `TabData` and use `TimelineKind` in its place. `TimelineKind` is itself mis-named; it's not just the timeline's kind but also holds data necessary to display that timeline (e.g., the list ID if it's a `.UserList`, or the hashtags if it's a `.Hashtags`) so rename to `Timeline` to better reflect its usage. Move it to a new `core.model` module.
2024-03-30 23:27:25 +01:00
line="96"
feat: Show user's lists in the left-side navigation menu (#514) Previously to view a list the user either had to add it to a tab, or tap through "Lists" in the navigation menu to their list of lists, and then tap the list they want. Fix that, and show all their lists in a dedicated section in the menu, with a new "Manage lists" entry that's functionality identical to the old "Lists" entry (i.e., it shows their lists and allows them to create, delete, and edit list settings). To do that: - Implement a proper `ListsRepository` as the single source of truth for list implementation throughout the app. Expose the current list of lists as a flow, with methods to perform operations on the lists. - Collect the `ListsRepository` flow in `MainActivity` and use that to populate the menu and update it whenever the user's lists change. - Rewrite the activities and fragments that manipulate lists to use `ListRepository`. - Always show error snackbars when list operations fail. In particular, the HTTP code and error are always shown. - Delete the custom `Either` implementation, it's no longer used. - Add types for modelling API responses and errors, `ApiResponse` and `ApiError` respectively. The response includes the headers as well as the body, so it can replace the use of `NetworkResult` and `Response`. The actual result of the operation is expected to be carried in a `com.github.michaelbull.result.Result` type. Implement a Retrofit call adapter for these types. Unit tests for these borrow heavily from https://github.com/connyduck/networkresult-calladapter Additional user-visible changes: - Add an accessible "Refresh" menu item to `ListsActivity`. - Adding a list to a tab has a dialog with a "Manage lists" option. Previously that would close the dialog when clicked, so the user had to re-open it on returning from list management. Now the dialog stays open. - The soft keyboard automatically opens when creating or editing a list.
2024-03-10 23:14:21 +01:00
column="5"/>
Use lint version 8.1.0 to fix erroneous warning about forEach (#3903) Android lint was erroneously warning that the forEach construct in Kotlin required API 24+, which is incorrect, see https://issuetracker.google.com/issues/185418482. Work around that by forcing the Android lint version to 8.1.0. This triggered some additional checks, which have been ignored, and a new baseline.
2023-07-30 21:45:43 +02:00
</issue>
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<issue
id="KeyboardInaccessibleWidget"
message="&apos;clickable&apos; attribute found, please also add &apos;focusable&apos;"
errorLine1=" android:clickable=&quot;true&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/material_drawer_header.xml"
line="8"
column="5"/>
</issue>
chore(deps): update agp to v8.5.0, lint to 31.5.0 (#756) New lint checks mean: - Some trivial uses of String.format() are replaced with templates - Use a string resource for the scheduled date and time Some reported SetTextI18n warnings have been ignored, as they relate to e.g., clearing a view's text by setting it to "".
2024-06-18 13:58:37 +02:00
<issue
id="SetTextI18n"
message="Do not concatenate text displayed with `setText`. Use resource string with placeholders."
errorLine1=" binding.scheduledDateTime.text = &quot;&quot;"
errorLine2=" ~~">
<location
file="src/main/java/app/pachli/components/compose/view/ComposeScheduleView.kt"
line="79"
column="46"/>
</issue>
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<issue
id="RtlSymmetry"
message="When you define `paddingStart` you should probably also define `paddingEnd` for right-to-left symmetry"
errorLine1=" android:paddingStart=&quot;8dp&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/activity_edit_profile.xml"
line="118"
column="21"/>
</issue>
<issue
id="RtlSymmetry"
message="When you define `paddingStart` you should probably also define `paddingEnd` for right-to-left symmetry"
errorLine1=" android:paddingStart=&quot;40dp&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/activity_edit_profile.xml"
line="129"
column="21"/>
</issue>
<issue
id="RtlSymmetry"
message="When you define `paddingEnd` you should probably also define `paddingStart` for right-to-left symmetry"
errorLine1=" android:paddingEnd=&quot;@dimen/status_display_name_padding_end&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/item_conversation.xml"
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
line="89"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="9"/>
</issue>
<issue
id="RtlSymmetry"
message="When you define `paddingStart` you should probably also define `paddingEnd` for right-to-left symmetry"
errorLine1=" android:paddingStart=&quot;28dp&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/item_follow.xml"
line="22"
column="9"/>
</issue>
feat: Allow user to see poll results before voting (#543) Show a labelled checkbox to the bottom-right of polls that the user has not voted in and that have votes. If checked the current vote tally (as percentages) will be shown, along with a bar showing the relative value of each option.
2024-03-19 13:23:21 +01:00
<issue
id="RtlSymmetry"
message="When you define `paddingEnd` you should probably also define `paddingStart` for right-to-left symmetry"
errorLine1=" android:paddingEnd=&quot;6dp&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/item_poll.xml"
chore: Update lint, mark item_status_filtered text non-selectable (#677)
2024-04-30 17:18:18 +02:00
line="37"
feat: Allow user to see poll results before voting (#543) Show a labelled checkbox to the bottom-right of polls that the user has not voted in and that have votes. If checked the current vote tally (as percentages) will be shown, along with a bar showing the relative value of each option.
2024-03-19 13:23:21 +01:00
column="9"/>
</issue>
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
<issue
id="RtlSymmetry"
message="When you define `paddingStart` you should probably also define `paddingEnd` for right-to-left symmetry"
errorLine1=" android:paddingStart=&quot;28dp&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/item_report_notification.xml"
line="23"
column="9"/>
</issue>
<issue
id="RtlSymmetry"
message="When you define `paddingEnd` you should probably also define `paddingStart` for right-to-left symmetry"
errorLine1=" android:paddingEnd=&quot;@dimen/status_display_name_padding_end&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/item_status.xml"
refactor: Transition from Tusky to Pachli - Rename packages to app.pachli.* - Switch to Pachli icons (blue / orange) - Reset database schema version to 1 - Reset versionCode to 1 and versionName to "1.0" - Update colour scheme, use colorPrimary etc through the app - Use Material UI components for toolbars - Use "Pachli" in strings (UI, constants, etc) - Update copyright on code I contributed - Update README - Update fastlane metadata
2023-09-05 13:28:56 +02:00
line="67"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="9"/>
</issue>
<issue
id="RtlSymmetry"
message="When you define `paddingStart` you should probably also define `paddingEnd` for right-to-left symmetry"
errorLine1=" android:paddingStart=&quot;28dp&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/item_status_notification.xml"
Refactor "trending hashtags" code (#3595) - Fix codeformatting - Add new refreshing state - Disable LogConditional lint rule - Update lint-baseline
2023-06-10 19:47:07 +02:00
line="22"
Enforce lint cleanliness when building (#3363) * Enforce lint cleanliness when building The volume of lintable issues is growing. To stem the tide: 1. Add `app/lint-baseline.xml`, which contains the current set of lint issues. Any issue appearing here will not cause the build to fail. 2. Move lint configuration settings in to `lint.xml`. 3. Update the lint configuration so that any issue (i.e., any issue not in lint-baseline.xml) causes a build failure. 4. Add the lint tasks as depedency when assembling an APK, to ensure the lint checks are run. * lint: Convert launcher images to webp * Move lint.xml location * Don't lint when assembling * Update baseline
2023-03-13 10:23:42 +01:00
column="9"/>
</issue>
<issue
id="RtlSymmetry"
message="When you define `paddingStart` you should probably also define `paddingEnd` for right-to-left symmetry"
errorLine1=" android:paddingStart=&quot;4dp&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/view_compose_schedule.xml"
line="21"
column="9"/>
</issue>
<issue
id="RtlSymmetry"
message="When you define `paddingStart` you should probably also define `paddingEnd` for right-to-left symmetry"
errorLine1=" android:paddingStart=&quot;4dp&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/view_compose_schedule.xml"
line="38"
column="9"/>
</issue>
</issues>