Mastodon
/
moshidon
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix akkoma crash on list edit 

closes sk22#352
This commit is contained in:
sk 2023-01-23 10:51:24 +01:00
parent a26ddfe70f
commit 5914ef8fad
5 changed files with 217 additions and 213 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mastodon/src/main/java/org/joinmastodon/android/fragments/HomeTabFragment.java
View File

@ -423,7 +423,7 @@ public class HomeTabFragment extends MastodonToolbarFragment implements Scrollab
} else if ((list = listItems.get(id)) != null) { } else if ((list = listItems.get(id)) != null) {
args.putString("listID", list.id); args.putString("listID", list.id);
args.putString("listTitle", list.title); args.putString("listTitle", list.title);
args.putInt("repliesPolicy", list.repliesPolicy.ordinal()); if (list.repliesPolicy != null) args.putInt("repliesPolicy", list.repliesPolicy.ordinal());
Nav.go(getActivity(), ListTimelineFragment.class, args); Nav.go(getActivity(), ListTimelineFragment.class, args);
} else if ((hashtag = hashtagsItems.get(id)) != null) { } else if ((hashtag = hashtagsItems.get(id)) != null) {
args.putString("hashtag", hashtag.name); args.putString("hashtag", hashtag.name);

48
mastodon/src/main/java/org/joinmastodon/android/fragments/ListTimelineFragment.java
View File

@ -2,16 +2,15 @@ package org.joinmastodon.android.fragments;
import android.app.Activity; import android.app.Activity;
import android.os.Bundle; import android.os.Bundle;
import android.view.HapticFeedbackConstants;
import android.view.Menu; import android.view.Menu;
import android.view.MenuInflater; import android.view.MenuInflater;
import android.view.MenuItem; import android.view.MenuItem;
import android.view.View; import android.view.View;
import android.view.ViewGroup; import android.view.ViewGroup;
import android.widget.ImageButton; import android.widget.ImageButton;
import android.widget.Toast;
import org.joinmastodon.android.GlobalUserPreferences; import androidx.annotation.Nullable;
import org.joinmastodon.android.R; import org.joinmastodon.android.R;
import org.joinmastodon.android.api.requests.lists.GetList; import org.joinmastodon.android.api.requests.lists.GetList;
import org.joinmastodon.android.api.requests.lists.UpdateList; import org.joinmastodon.android.api.requests.lists.UpdateList;
@ -23,7 +22,6 @@ import org.joinmastodon.android.ui.M3AlertDialogBuilder;
import org.joinmastodon.android.ui.utils.UiUtils; import org.joinmastodon.android.ui.utils.UiUtils;
import org.joinmastodon.android.ui.views.ListTimelineEditor; import org.joinmastodon.android.ui.views.ListTimelineEditor;
import java.util.ArrayList;
import java.util.List; import java.util.List;
import me.grishka.appkit.Nav; import me.grishka.appkit.Nav;
@ -36,6 +34,7 @@ import me.grishka.appkit.utils.V;
public class ListTimelineFragment extends PinnableStatusListFragment { public class ListTimelineFragment extends PinnableStatusListFragment {
private String listID; private String listID;
private String listTitle; private String listTitle;
@Nullable
private ListTimeline.RepliesPolicy repliesPolicy; private ListTimeline.RepliesPolicy repliesPolicy;
private ImageButton fab; private ImageButton fab;
@ -59,7 +58,9 @@ public class ListTimelineFragment extends PinnableStatusListFragment {
public void onSuccess(ListTimeline listTimeline) { public void onSuccess(ListTimeline listTimeline) {
// TODO: save updated info // TODO: save updated info
if (!listTimeline.title.equals(listTitle)) setTitle(listTimeline.title); if (!listTimeline.title.equals(listTitle)) setTitle(listTimeline.title);
if (!listTimeline.repliesPolicy.equals(repliesPolicy)) repliesPolicy = listTimeline.repliesPolicy; if (listTimeline.repliesPolicy != null && !listTimeline.repliesPolicy.equals(repliesPolicy)) {
repliesPolicy = listTimeline.repliesPolicy;
}
} }
@Override @Override
@ -86,26 +87,25 @@ public class ListTimelineFragment extends PinnableStatusListFragment {
.setTitle(R.string.sk_edit_list_title) .setTitle(R.string.sk_edit_list_title)
.setIcon(R.drawable.ic_fluent_people_list_28_regular) .setIcon(R.drawable.ic_fluent_people_list_28_regular)
.setView(editor) .setView(editor)
.setPositiveButton(R.string.save, (d, which) -> { .setPositiveButton(R.string.save, (d, which) ->
new UpdateList(listID, editor.getTitle(), editor.getRepliesPolicy()).setCallback(new Callback<>() { new UpdateList(listID, editor.getTitle(), editor.getRepliesPolicy()).setCallback(new Callback<>() {
@Override @Override
public void onSuccess(ListTimeline list) { public void onSuccess(ListTimeline list) {
setTitle(list.title); setTitle(list.title);
listTitle = list.title; listTitle = list.title;
repliesPolicy = list.repliesPolicy; repliesPolicy = list.repliesPolicy;
Bundle result = new Bundle(); Bundle result = new Bundle();
result.putString("listID", listID); result.putString("listID", listID);
result.putString("listTitle", listTitle); result.putString("listTitle", listTitle);
result.putInt("repliesPolicy", repliesPolicy.ordinal()); if (repliesPolicy != null) result.putInt("repliesPolicy", repliesPolicy.ordinal());
setResult(true, result); setResult(true, result);
} }
@Override @Override
public void onError(ErrorResponse error) { public void onError(ErrorResponse error) {
error.showToast(getContext()); error.showToast(getContext());
} }
}).exec(accountID); }).exec(accountID))
})
.setNegativeButton(R.string.cancel, (d, which) -> {}) .setNegativeButton(R.string.cancel, (d, which) -> {})
.show(); .show();
} else if (item.getItemId() == R.id.delete) { } else if (item.getItemId() == R.id.delete) {

367
mastodon/src/main/java/org/joinmastodon/android/fragments/ListTimelinesFragment.java
View File

@ -21,7 +21,6 @@ import org.joinmastodon.android.api.requests.lists.RemoveAccountsFromList;
import org.joinmastodon.android.model.ListTimeline; import org.joinmastodon.android.model.ListTimeline;
import org.joinmastodon.android.ui.DividerItemDecoration; import org.joinmastodon.android.ui.DividerItemDecoration;
import org.joinmastodon.android.ui.M3AlertDialogBuilder; import org.joinmastodon.android.ui.M3AlertDialogBuilder;
import org.joinmastodon.android.ui.utils.UiUtils;
import org.joinmastodon.android.ui.views.ListTimelineEditor; import org.joinmastodon.android.ui.views.ListTimelineEditor;
import java.util.ArrayList; import java.util.ArrayList;
@ -38,210 +37,210 @@ import me.grishka.appkit.utils.BindableViewHolder;
import me.grishka.appkit.views.UsableRecyclerView; import me.grishka.appkit.views.UsableRecyclerView;
public class ListTimelinesFragment extends BaseRecyclerFragment<ListTimeline> implements ScrollableToTop { public class ListTimelinesFragment extends BaseRecyclerFragment<ListTimeline> implements ScrollableToTop {
private static final int LIST_CHANGED_RESULT = 987; private static final int LIST_CHANGED_RESULT = 987;
private String accountId; private String accountId;
private String profileAccountId; private String profileAccountId;
private String profileDisplayUsername; private final HashMap<String, Boolean> userInListBefore = new HashMap<>();
private HashMap<String, Boolean> userInListBefore = new HashMap<>(); private final HashMap<String, Boolean> userInList = new HashMap<>();
private HashMap<String, Boolean> userInList = new HashMap<>(); private ListsAdapter adapter;
private int inProgress = 0;
private ListsAdapter adapter;
public ListTimelinesFragment() { public ListTimelinesFragment() {
super(10); super(10);
} }
@Override @Override
public void onCreate(Bundle savedInstanceState) { public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState); super.onCreate(savedInstanceState);
Bundle args=getArguments(); Bundle args=getArguments();
accountId=args.getString("account"); accountId=args.getString("account");
setHasOptionsMenu(true); setHasOptionsMenu(true);
if(args.containsKey("profileAccount")){ if(args.containsKey("profileAccount")){
profileAccountId=args.getString("profileAccount"); profileAccountId=args.getString("profileAccount");
profileDisplayUsername=args.getString("profileDisplayUsername"); String profileDisplayUsername = args.getString("profileDisplayUsername");
setTitle(getString(R.string.sk_lists_with_user, profileDisplayUsername)); setTitle(getString(R.string.sk_lists_with_user, profileDisplayUsername));
} else { } else {
setTitle(R.string.sk_your_lists); setTitle(R.string.sk_your_lists);
} }
} }
@Override @Override
protected void onShown(){ protected void onShown(){
super.onShown(); super.onShown();
if(!getArguments().getBoolean("noAutoLoad") && !loaded && !dataLoading) if(!getArguments().getBoolean("noAutoLoad") && !loaded && !dataLoading)
loadData(); loadData();
} }
@Override @Override
public void onViewCreated(View view, Bundle savedInstanceState) { public void onViewCreated(View view, Bundle savedInstanceState) {
super.onViewCreated(view, savedInstanceState); super.onViewCreated(view, savedInstanceState);
list.addItemDecoration(new DividerItemDecoration(getActivity(), R.attr.colorPollVoted, 0.5f, 56, 16)); list.addItemDecoration(new DividerItemDecoration(getActivity(), R.attr.colorPollVoted, 0.5f, 56, 16));
} }
@Override @Override
public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) { public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
inflater.inflate(R.menu.menu_list, menu); inflater.inflate(R.menu.menu_list, menu);
} }
@Override @Override
public boolean onOptionsItemSelected(MenuItem item) { public boolean onOptionsItemSelected(MenuItem item) {
if (item.getItemId() == R.id.create) { if (item.getItemId() == R.id.create) {
ListTimelineEditor editor = new ListTimelineEditor(getContext()); ListTimelineEditor editor = new ListTimelineEditor(getContext());
new M3AlertDialogBuilder(getActivity()) new M3AlertDialogBuilder(getActivity())
.setTitle(R.string.sk_create_list_title) .setTitle(R.string.sk_create_list_title)
.setIcon(R.drawable.ic_fluent_people_add_28_regular) .setIcon(R.drawable.ic_fluent_people_add_28_regular)
.setView(editor) .setView(editor)
.setPositiveButton(R.string.sk_create, (d, which) -> { .setPositiveButton(R.string.sk_create, (d, which) ->
new CreateList(editor.getTitle(), editor.getRepliesPolicy()).setCallback(new Callback<>() { new CreateList(editor.getTitle(), editor.getRepliesPolicy()).setCallback(new Callback<>() {
@Override @Override
public void onSuccess(ListTimeline list) { public void onSuccess(ListTimeline list) {
saveListMembership(list.id, true); saveListMembership(list.id, true);
data.add(0, list); data.add(0, list);
adapter.notifyItemRangeInserted(0, 1); adapter.notifyItemRangeInserted(0, 1);
} }
@Override @Override
public void onError(ErrorResponse error) { public void onError(ErrorResponse error) {
error.showToast(getContext()); error.showToast(getContext());
} }
}).exec(accountId); }).exec(accountId)
}) )
.setNegativeButton(R.string.cancel, (d, which) -> {}) .setNegativeButton(R.string.cancel, (d, which) -> {})
.show(); .show();
} }
return true; return true;
} }
private void saveListMembership(String listId, boolean isMember) { private void saveListMembership(String listId, boolean isMember) {
userInList.put(listId, isMember); userInList.put(listId, isMember);
List<String> accountIdList = Collections.singletonList(profileAccountId); List<String> accountIdList = Collections.singletonList(profileAccountId);
MastodonAPIRequest<Object> req = isMember ? new AddAccountsToList(listId, accountIdList) : new RemoveAccountsFromList(listId, accountIdList); MastodonAPIRequest<Object> req = isMember ? new AddAccountsToList(listId, accountIdList) : new RemoveAccountsFromList(listId, accountIdList);
req.setCallback(new SimpleCallback<>(this) { req.setCallback(new SimpleCallback<>(this) {
@Override @Override
public void onSuccess(Object o) {} public void onSuccess(Object o) {}
}).exec(accountId); }).exec(accountId);
} }
@Override @Override
protected void doLoadData(int offset, int count){ protected void doLoadData(int offset, int count){
userInListBefore.clear(); userInListBefore.clear();
userInList.clear(); userInList.clear();
currentRequest=(profileAccountId != null ? new GetLists(profileAccountId) : new GetLists()) currentRequest=(profileAccountId != null ? new GetLists(profileAccountId) : new GetLists())
.setCallback(new SimpleCallback<>(this) { .setCallback(new SimpleCallback<>(this) {
@Override @Override
public void onSuccess(List<ListTimeline> lists) { public void onSuccess(List<ListTimeline> lists) {
for (ListTimeline l : lists) userInListBefore.put(l.id, true); for (ListTimeline l : lists) userInListBefore.put(l.id, true);
userInList.putAll(userInListBefore); userInList.putAll(userInListBefore);
if (profileAccountId == null || !lists.isEmpty()) onDataLoaded(lists, false); if (profileAccountId == null || !lists.isEmpty()) onDataLoaded(lists, false);
if (profileAccountId == null) return; if (profileAccountId == null) return;
currentRequest=new GetLists().setCallback(new SimpleCallback<>(ListTimelinesFragment.this) { currentRequest=new GetLists().setCallback(new SimpleCallback<>(ListTimelinesFragment.this) {
@Override @Override
public void onSuccess(List<ListTimeline> allLists) { public void onSuccess(List<ListTimeline> allLists) {
List<ListTimeline> newLists = new ArrayList<>(); List<ListTimeline> newLists = new ArrayList<>();
for (ListTimeline l : allLists) { for (ListTimeline l : allLists) {
if (lists.stream().noneMatch(e -> e.id.equals(l.id))) newLists.add(l); if (lists.stream().noneMatch(e -> e.id.equals(l.id))) newLists.add(l);
if (!userInListBefore.containsKey(l.id)) { if (!userInListBefore.containsKey(l.id)) {
userInListBefore.put(l.id, false); userInListBefore.put(l.id, false);
} }
} }
userInList.putAll(userInListBefore); userInList.putAll(userInListBefore);
onDataLoaded(newLists, false); onDataLoaded(newLists, false);
} }
}).exec(accountId); }).exec(accountId);
} }
}) })
.exec(accountId); .exec(accountId);
} }
@Override @Override
public void onFragmentResult(int reqCode, boolean listChanged, Bundle result){ public void onFragmentResult(int reqCode, boolean listChanged, Bundle result){
if (reqCode == LIST_CHANGED_RESULT && listChanged) { if (reqCode == LIST_CHANGED_RESULT && listChanged) {
String listID = result.getString("listID"); String listID = result.getString("listID");
for (int i = 0; i < data.size(); i++) { for (int i = 0; i < data.size(); i++) {
ListTimeline item = data.get(i); ListTimeline item = data.get(i);
if (item.id.equals(listID)) { if (item.id.equals(listID)) {
if (result.getBoolean("deleted")) { if (result.getBoolean("deleted")) {
data.remove(i); data.remove(i);
adapter.notifyItemRemoved(i); adapter.notifyItemRemoved(i);
} else { } else {
item.title = result.getString("listTitle", item.title); item.title = result.getString("listTitle", item.title);
item.repliesPolicy = ListTimeline.RepliesPolicy.values()[result.getInt("repliesPolicy")]; if (result.containsKey("repliesPolicy")) {
adapter.notifyItemChanged(i); item.repliesPolicy = ListTimeline.RepliesPolicy.values()[result.getInt("repliesPolicy")];
} }
break; adapter.notifyItemChanged(i);
} }
} break;
} }
} }
}
}
@Override @Override
protected RecyclerView.Adapter<ListViewHolder> getAdapter() { protected RecyclerView.Adapter<ListViewHolder> getAdapter() {
return adapter = new ListsAdapter(); return adapter = new ListsAdapter();
} }
@Override @Override
public void scrollToTop() { public void scrollToTop() {
smoothScrollRecyclerViewToTop(list); smoothScrollRecyclerViewToTop(list);
} }
private class ListsAdapter extends RecyclerView.Adapter<ListViewHolder>{ private class ListsAdapter extends RecyclerView.Adapter<ListViewHolder>{
@NonNull @NonNull
@Override @Override
public ListViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType){ public ListViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType){
return new ListViewHolder(); return new ListViewHolder();
} }
@Override @Override
public void onBindViewHolder(@NonNull ListViewHolder holder, int position) { public void onBindViewHolder(@NonNull ListViewHolder holder, int position) {
holder.bind(data.get(position)); holder.bind(data.get(position));
} }
@Override @Override
public int getItemCount() { public int getItemCount() {
return data.size(); return data.size();
} }
} }
private class ListViewHolder extends BindableViewHolder<ListTimeline> implements UsableRecyclerView.Clickable{ private class ListViewHolder extends BindableViewHolder<ListTimeline> implements UsableRecyclerView.Clickable{
private final TextView title; private final TextView title;
private final CheckBox listToggle; private final CheckBox listToggle;
public ListViewHolder(){ public ListViewHolder(){
super(getActivity(), R.layout.item_text, list); super(getActivity(), R.layout.item_text, list);
title=findViewById(R.id.title); title=findViewById(R.id.title);
listToggle=findViewById(R.id.list_toggle); listToggle=findViewById(R.id.list_toggle);
} }
@Override @Override
public void onBind(ListTimeline item) { public void onBind(ListTimeline item) {
title.setText(item.title); title.setText(item.title);
title.setCompoundDrawablesRelativeWithIntrinsicBounds(itemView.getContext().getDrawable(R.drawable.ic_fluent_people_list_24_regular), null, null, null); title.setCompoundDrawablesRelativeWithIntrinsicBounds(itemView.getContext().getDrawable(R.drawable.ic_fluent_people_list_24_regular), null, null, null);
if (profileAccountId != null) { if (profileAccountId != null) {
Boolean checked = userInList.get(item.id); Boolean checked = userInList.get(item.id);
listToggle.setVisibility(View.VISIBLE); listToggle.setVisibility(View.VISIBLE);
listToggle.setChecked(userInList.containsKey(item.id) && checked != null && checked); listToggle.setChecked(userInList.containsKey(item.id) && checked != null && checked);
listToggle.setOnClickListener(this::onClickToggle); listToggle.setOnClickListener(this::onClickToggle);
} else { } else {
listToggle.setVisibility(View.GONE); listToggle.setVisibility(View.GONE);
} }
} }
private void onClickToggle(View view) { private void onClickToggle(View view) {
saveListMembership(item.id, listToggle.isChecked()); saveListMembership(item.id, listToggle.isChecked());
} }
@Override @Override
public void onClick() { public void onClick() {
Bundle args=new Bundle(); Bundle args=new Bundle();
args.putString("account", accountId); args.putString("account", accountId);
args.putString("listID", item.id); args.putString("listID", item.id);
args.putString("listTitle", item.title); args.putString("listTitle", item.title);
args.putInt("repliesPolicy", item.repliesPolicy.ordinal()); if (item.repliesPolicy != null) args.putInt("repliesPolicy", item.repliesPolicy.ordinal());
Nav.goForResult(getActivity(), ListTimelineFragment.class, args, LIST_CHANGED_RESULT, ListTimelinesFragment.this); Nav.goForResult(getActivity(), ListTimelineFragment.class, args, LIST_CHANGED_RESULT, ListTimelinesFragment.this);
} }
} }
} }

4
mastodon/src/main/java/org/joinmastodon/android/model/ListTimeline.java
View File

@ -1,5 +1,7 @@
package org.joinmastodon.android.model; package org.joinmastodon.android.model;
import androidx.annotation.NonNull;
import com.google.gson.annotations.SerializedName; import com.google.gson.annotations.SerializedName;
import org.joinmastodon.android.api.RequiredField; import org.joinmastodon.android.api.RequiredField;
@ -11,9 +13,9 @@ public class ListTimeline extends BaseModel {
public String id; public String id;
@RequiredField @RequiredField
public String title; public String title;
@RequiredField
public RepliesPolicy repliesPolicy; public RepliesPolicy repliesPolicy;
@NonNull
@Override @Override
public String toString() { public String toString() {
return "List{" + return "List{" +

9
mastodon/src/main/java/org/joinmastodon/android/ui/views/ListTimelineEditor.java
View File

@ -10,6 +10,9 @@ import android.widget.Button;
import android.widget.LinearLayout; import android.widget.LinearLayout;
import android.widget.PopupMenu; import android.widget.PopupMenu;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import org.joinmastodon.android.R; import org.joinmastodon.android.R;
import org.joinmastodon.android.model.ListTimeline; import org.joinmastodon.android.model.ListTimeline;
@ -37,9 +40,9 @@ public class ListTimelineEditor extends LinearLayout {
setRepliesPolicy(ListTimeline.RepliesPolicy.LIST); setRepliesPolicy(ListTimeline.RepliesPolicy.LIST);
} }
public void applyList(String title, ListTimeline.RepliesPolicy policy) { public void applyList(String title, @Nullable ListTimeline.RepliesPolicy policy) {
input.getEditText().setText(title); input.getEditText().setText(title);
setRepliesPolicy(policy); if (policy != null) setRepliesPolicy(policy);
} }
public String getTitle() { public String getTitle() {
@ -50,7 +53,7 @@ public class ListTimelineEditor extends LinearLayout {
return policy; return policy;
} }
public void setRepliesPolicy(ListTimeline.RepliesPolicy policy) { public void setRepliesPolicy(@NonNull ListTimeline.RepliesPolicy policy) {
this.policy = policy; this.policy = policy;
switch (policy) { switch (policy) {
case FOLLOWED -> button.setText(R.string.sk_list_replies_policy_followed); case FOLLOWED -> button.setText(R.string.sk_list_replies_policy_followed);