diff --git a/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/MediaGridStatusDisplayItem.java b/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/MediaGridStatusDisplayItem.java index eb0fb9056..bd1c7c06f 100644 --- a/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/MediaGridStatusDisplayItem.java +++ b/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/MediaGridStatusDisplayItem.java @@ -1,7 +1,5 @@ package org.joinmastodon.android.ui.displayitems; -import static org.joinmastodon.android.ui.utils.MediaAttachmentViewController.altWrapPadding; - import android.animation.Animator; import android.animation.AnimatorListenerAdapter; import android.animation.AnimatorSet; @@ -202,15 +200,16 @@ public class MediaGridStatusDisplayItem extends StatusDisplayItem{ btnL-=loc[0]; btnT-=loc[1]; + ViewGroup.MarginLayoutParams margins = (ViewGroup.MarginLayoutParams) altTextWrapper.getLayoutParams(); ArrayList anims=new ArrayList<>(); anims.add(ObjectAnimator.ofFloat(altTextButton, View.ALPHA, 1, 0)); anims.add(ObjectAnimator.ofFloat(noAltTextButton, View.ALPHA, 1, 0)); anims.add(ObjectAnimator.ofFloat(altTextScroller, View.ALPHA, 0, 1)); anims.add(ObjectAnimator.ofFloat(altTextClose, View.ALPHA, 0, 1)); - anims.add(ObjectAnimator.ofInt(altTextWrapper, "left", btnL+altWrapPadding[0], altTextWrapper.getLeft())); - anims.add(ObjectAnimator.ofInt(altTextWrapper, "top", btnT+altWrapPadding[1], altTextWrapper.getTop())); - anims.add(ObjectAnimator.ofInt(altTextWrapper, "right", btnL+v.getWidth()-altWrapPadding[2], altTextWrapper.getRight())); - anims.add(ObjectAnimator.ofInt(altTextWrapper, "bottom", btnT+v.getHeight()-altWrapPadding[3], altTextWrapper.getBottom())); + anims.add(ObjectAnimator.ofInt(altTextWrapper, "left", btnL+margins.leftMargin, altTextWrapper.getLeft())); + anims.add(ObjectAnimator.ofInt(altTextWrapper, "top", btnT+margins.topMargin, altTextWrapper.getTop())); + anims.add(ObjectAnimator.ofInt(altTextWrapper, "right", btnL+v.getWidth()-margins.rightMargin, altTextWrapper.getRight())); + anims.add(ObjectAnimator.ofInt(altTextWrapper, "bottom", btnT+v.getHeight()-margins.bottomMargin, altTextWrapper.getBottom())); for(Animator a:anims) a.setDuration(300); @@ -265,15 +264,16 @@ public class MediaGridStatusDisplayItem extends StatusDisplayItem{ btnL-=loc[0]; btnT-=loc[1]; + ViewGroup.MarginLayoutParams margins = (ViewGroup.MarginLayoutParams) altTextWrapper.getLayoutParams(); ArrayList anims=new ArrayList<>(); anims.add(ObjectAnimator.ofFloat(altTextButton, View.ALPHA, 1)); anims.add(ObjectAnimator.ofFloat(noAltTextButton, View.ALPHA, 1)); anims.add(ObjectAnimator.ofFloat(altTextScroller, View.ALPHA, 0)); anims.add(ObjectAnimator.ofFloat(altTextClose, View.ALPHA, 0)); - anims.add(ObjectAnimator.ofInt(altTextWrapper, "left", btnL+altWrapPadding[0])); - anims.add(ObjectAnimator.ofInt(altTextWrapper, "top", btnT+altWrapPadding[1])); - anims.add(ObjectAnimator.ofInt(altTextWrapper, "right", btnL+btn.getWidth()-altWrapPadding[2])); - anims.add(ObjectAnimator.ofInt(altTextWrapper, "bottom", btnT+btn.getHeight()-altWrapPadding[3])); + anims.add(ObjectAnimator.ofInt(altTextWrapper, "left", btnL+margins.leftMargin)); + anims.add(ObjectAnimator.ofInt(altTextWrapper, "top", btnT+margins.topMargin)); + anims.add(ObjectAnimator.ofInt(altTextWrapper, "right", btnL+btn.getWidth()-margins.rightMargin)); + anims.add(ObjectAnimator.ofInt(altTextWrapper, "bottom", btnT+btn.getHeight()-margins.bottomMargin)); for(Animator a:anims) a.setDuration(300); diff --git a/mastodon/src/main/java/org/joinmastodon/android/ui/utils/MediaAttachmentViewController.java b/mastodon/src/main/java/org/joinmastodon/android/ui/utils/MediaAttachmentViewController.java index db0d9653f..c1d293583 100644 --- a/mastodon/src/main/java/org/joinmastodon/android/ui/utils/MediaAttachmentViewController.java +++ b/mastodon/src/main/java/org/joinmastodon/android/ui/utils/MediaAttachmentViewController.java @@ -19,7 +19,6 @@ public class MediaAttachmentViewController{ public final MediaGridStatusDisplayItem.GridItemType type; public final ImageView photo; public final View altButton, noAltButton, btnsWrap; - public static int[] altWrapPadding = null; private BlurhashCrossfadeDrawable crossfadeDrawable=new BlurhashCrossfadeDrawable(); private final Context context; private boolean didClear; @@ -37,9 +36,6 @@ public class MediaAttachmentViewController{ btnsWrap=view.findViewById(R.id.alt_badges); this.type=type; this.context=context; - if (altWrapPadding == null) { - altWrapPadding = new int[] { btnsWrap.getPaddingLeft(), btnsWrap.getPaddingTop(), btnsWrap.getPaddingRight(), btnsWrap.getPaddingBottom() }; - } } public void bind(Attachment attachment, Status status){ diff --git a/mastodon/src/main/res/layout/alt_badge.xml b/mastodon/src/main/res/layout/alt_badge.xml index 955f8f5cb..d4996e868 100644 --- a/mastodon/src/main/res/layout/alt_badge.xml +++ b/mastodon/src/main/res/layout/alt_badge.xml @@ -27,7 +27,7 @@ android:gravity="center" android:includeFontPadding="false" android:paddingHorizontal="5dp" - android:paddingVertical="1dp" + android:paddingVertical="2dp" android:background="@drawable/bg_image_alt_overlay" android:text="@string/sk_alt_button"/> diff --git a/mastodon/src/main/res/layout/overlay_image_alt_text.xml b/mastodon/src/main/res/layout/overlay_image_alt_text.xml index f092abd87..713926ea8 100644 --- a/mastodon/src/main/res/layout/overlay_image_alt_text.xml +++ b/mastodon/src/main/res/layout/overlay_image_alt_text.xml @@ -26,7 +26,7 @@ android:gravity="center" android:includeFontPadding="false" android:paddingHorizontal="5dp" - android:paddingVertical="1dp" + android:paddingVertical="2dp" android:text="@string/sk_alt_button"/>