Mastodon
/
mastodon-app-ufficiale-iphone-ios
mirror of https://github.com/mastodon/mastodon-ios.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #488 from j-f1/compose-a11y 

Fix accessibility for the Compose button
This commit is contained in:
CMK 2022-11-01 11:59:19 +08:00 committed by GitHub
parent 28267fe6d8 da3a83d387
commit 70789a0c90
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
Mastodon/Scene/Root/MainTab/MainTabBarController.swift
View File

@ -33,6 +33,7 @@ class MainTabBarController: UITabBarController {
button.layer.masksToBounds = true button.layer.masksToBounds = true
button.layer.cornerCurve = .continuous button.layer.cornerCurve = .continuous
button.layer.cornerRadius = 8 button.layer.cornerRadius = 8
button.isAccessibilityElement = false
return button return button
}() }()
@ -185,14 +186,6 @@ extension MainTabBarController {
viewController.tabBarItem.largeContentSizeImage = tab.largeImage.imageWithoutBaseline() viewController.tabBarItem.largeContentSizeImage = tab.largeImage.imageWithoutBaseline()
viewController.tabBarItem.accessibilityLabel = tab.title viewController.tabBarItem.accessibilityLabel = tab.title
viewController.tabBarItem.imageInsets = UIEdgeInsets(top: 6, left: 0, bottom: -6, right: 0) viewController.tabBarItem.imageInsets = UIEdgeInsets(top: 6, left: 0, bottom: -6, right: 0)
switch tab {
case .compose:
viewController.tabBarItem.isEnabled = false
default:
break
}
return viewController return viewController
} }
_viewControllers = viewControllers _viewControllers = viewControllers
@ -363,7 +356,7 @@ extension MainTabBarController {
extension MainTabBarController { extension MainTabBarController {
@objc private func composeButtonDidPressed(_ sender: UIButton) { @objc private func composeButtonDidPressed(_ sender: Any) {
logger.log(level: .debug, "\((#file as NSString).lastPathComponent, privacy: .public)[\(#line, privacy: .public)], \(#function, privacy: .public)") logger.log(level: .debug, "\((#file as NSString).lastPathComponent, privacy: .public)[\(#line, privacy: .public)], \(#function, privacy: .public)")
guard let authenticationBox = context.authenticationService.activeMastodonAuthenticationBox.value else { return } guard let authenticationBox = context.authenticationService.activeMastodonAuthenticationBox.value else { return }
let composeViewModel = ComposeViewModel( let composeViewModel = ComposeViewModel(
@ -504,6 +497,14 @@ extension MainTabBarController {
// MARK: - UITabBarControllerDelegate // MARK: - UITabBarControllerDelegate
extension MainTabBarController: UITabBarControllerDelegate { extension MainTabBarController: UITabBarControllerDelegate {
func tabBarController(_ tabBarController: UITabBarController, shouldSelect viewController: UIViewController) -> Bool {
if let tab = Tab(rawValue: viewController.tabBarItem.tag), tab == .compose {
composeButtonDidPressed(tabBarController)
return false
}
return true
}
func tabBarController(_ tabBarController: UITabBarController, didSelect viewController: UIViewController) { func tabBarController(_ tabBarController: UITabBarController, didSelect viewController: UIViewController) {
os_log(.info, log: .debug, "%{public}s[%{public}ld], %{public}s: select %s", ((#file as NSString).lastPathComponent), #line, #function, viewController.debugDescription) os_log(.info, log: .debug, "%{public}s[%{public}ld], %{public}s: select %s", ((#file as NSString).lastPathComponent), #line, #function, viewController.debugDescription)
defer { defer {