Mastodon/mastodon-app-ufficiale-iphone-ios
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Bump FaviconFinder to 4.5.0 (IOS-289) (#1343)

Browse Source 
Upgrades dependency to fix crash related to it.
This commit is contained in:
Marcus Kida 2024-09-11 12:01:26 +02:00 committed by GitHub
commit 69187b9540
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 9 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
AppVersion.xcconfig
View File

@ -1 +1 @@
MARKETING_VERSION = 2024.8
MARKETING_VERSION = 2024.9

2
MastodonSDK/Package.swift
View File

@ -35,7 +35,7 @@ let package = Package(
],
dependencies: [
.package(name: "ArkanaKeys", path: "../dependencies/ArkanaKeys"),
.package(url: "https://github.com/will-lumley/FaviconFinder.git", from: "3.2.2"),
.package(url: "https://github.com/will-lumley/FaviconFinder.git", from: "4.5.0"),
.package(url: "https://github.com/MainasuK/UITextView-Placeholder.git", from: "1.4.1"),
.package(url: "https://github.com/Alamofire/Alamofire.git", from: "5.4.0"),
.package(url: "https://github.com/Alamofire/AlamofireImage.git", from: "4.1.0"),

18
MastodonSDK/Sources/MastodonUI/View/Content/NewsView+Configuration.swift
View File

@ -18,17 +18,13 @@ extension NewsView {
providerFaviconImageView.image = faviconPlaceholder
if let url = URL(string: link.url) {
let token = providerFaviconImageView.tag
FaviconFinder(url: url).downloadFavicon { [weak self] result in
guard let self = self else { return }
switch result {
case .success(let favicon):
DispatchQueue.main.async { [weak self] in
guard let self = self else { return }
guard self.providerFaviconImageView.tag == token else { return }
self.providerFaviconImageView.image = favicon.image
}
case .failure:
break
Task {
do {
let favicon = try await FaviconFinder(url: url).downloadFavicon()
guard self.providerFaviconImageView.tag == token else { return }
self.providerFaviconImageView.image = favicon.image
} catch {
// no-op
}
}
}