From 326aea36cdd2b894c996ceb2caebadc8be1b18b4 Mon Sep 17 00:00:00 2001
From: sunxiaojian <snxiaojian@gmail.com>
Date: Thu, 22 Apr 2021 15:45:32 +0800
Subject: [PATCH] fix: The empty view should not display when the user just
 sign-in the first time

---
 .../Section/RecommendAccountSection.swift     |  2 +-
 .../HomeTimelineViewController.swift          | 22 ++++++++++---------
 ...omeTimelineViewModel+LoadLatestState.swift |  1 +
 .../HomeTimeline/HomeTimelineViewModel.swift  |  1 +
 4 files changed, 15 insertions(+), 11 deletions(-)

diff --git a/Mastodon/Diffiable/Section/RecommendAccountSection.swift b/Mastodon/Diffiable/Section/RecommendAccountSection.swift
index 1732be29f..92def9156 100644
--- a/Mastodon/Diffiable/Section/RecommendAccountSection.swift
+++ b/Mastodon/Diffiable/Section/RecommendAccountSection.swift
@@ -36,7 +36,7 @@ extension RecommendAccountSection {
         viewModel: SuggestionAccountViewModel,
         delegate: SuggestionAccountTableViewCellDelegate
     ) -> UITableViewDiffableDataSource<RecommendAccountSection, NSManagedObjectID> {
-        UITableViewDiffableDataSource(tableView: tableView) { [weak viewModel,weak delegate] (tableView, indexPath, objectID) -> UITableViewCell? in
+        UITableViewDiffableDataSource(tableView: tableView) { [weak viewModel, weak delegate] (tableView, indexPath, objectID) -> UITableViewCell? in
             guard let viewModel = viewModel else { return nil }
             let cell = tableView.dequeueReusableCell(withIdentifier: String(describing: SuggestionAccountTableViewCell.self)) as! SuggestionAccountTableViewCell
             let user = managedObjectContext.object(with: objectID) as! MastodonUser
diff --git a/Mastodon/Scene/HomeTimeline/HomeTimelineViewController.swift b/Mastodon/Scene/HomeTimeline/HomeTimelineViewController.swift
index 2734b33e1..bd559eed5 100644
--- a/Mastodon/Scene/HomeTimeline/HomeTimelineViewController.swift
+++ b/Mastodon/Scene/HomeTimeline/HomeTimelineViewController.swift
@@ -151,16 +151,7 @@ extension HomeTimelineViewController {
                     UIView.animate(withDuration: 0.5) { [weak self] in
                         guard let self = self else { return }
                         self.refreshControl.endRefreshing()
-                    } completion: { [weak self] _ in
-                        guard let self = self else { return }
-                        if (self.viewModel.fetchedResultsController.fetchedObjects ?? []).isEmpty {
-                            self.showEmptyView()
-                        } else {
-                            self.emptyView.removeFromSuperview()
-                        }
-                    }
-                } else {
-                    self.emptyView.removeFromSuperview()
+                    } completion: { _ in }
                 }
             }
             .store(in: &disposeBag)
@@ -191,6 +182,17 @@ extension HomeTimelineViewController {
                 self.publishProgressView.setProgress(progress, animated: true)
             }
             .store(in: &disposeBag)
+        
+        viewModel.timelineIsEmpty
+            .receive(on: DispatchQueue.main)
+            .sink { [weak self] isEmpty in
+                if isEmpty {
+                    self?.showEmptyView()
+                } else {
+                    self?.emptyView.removeFromSuperview()
+                }
+            }
+            .store(in: &disposeBag)
     }
     
     override func viewWillAppear(_ animated: Bool) {
diff --git a/Mastodon/Scene/HomeTimeline/HomeTimelineViewModel+LoadLatestState.swift b/Mastodon/Scene/HomeTimeline/HomeTimelineViewModel+LoadLatestState.swift
index 640d9df3b..425eb9aa0 100644
--- a/Mastodon/Scene/HomeTimeline/HomeTimelineViewModel+LoadLatestState.swift
+++ b/Mastodon/Scene/HomeTimeline/HomeTimelineViewModel+LoadLatestState.swift
@@ -107,6 +107,7 @@ extension HomeTimelineViewModel.LoadLatestState {
                                 viewModel.homeTimelineNavigationBarTitleViewModel.newPostsIncoming()
                             }
                         }
+                        viewModel.timelineIsEmpty.value = latestStatusIDs.isEmpty && statuses.isEmpty
                     }
                     .store(in: &viewModel.disposeBag)
             }
diff --git a/Mastodon/Scene/HomeTimeline/HomeTimelineViewModel.swift b/Mastodon/Scene/HomeTimeline/HomeTimelineViewModel.swift
index a81056d0f..26ef485ee 100644
--- a/Mastodon/Scene/HomeTimeline/HomeTimelineViewModel.swift
+++ b/Mastodon/Scene/HomeTimeline/HomeTimelineViewModel.swift
@@ -34,6 +34,7 @@ final class HomeTimelineViewModel: NSObject {
     weak var tableView: UITableView?
     weak var timelineMiddleLoaderTableViewCellDelegate: TimelineMiddleLoaderTableViewCellDelegate?
     
+    let timelineIsEmpty = CurrentValueSubject<Bool, Never>(false)
     let homeTimelineNeedRefresh = PassthroughSubject<Void, Never>()
     // output
     // top loader