Fix notification filters touches plural string (#1334)

This PR fixes the following issues:

* Pluralized string on Notification Filters is not showing fallback
value
* Taps on avatar or user/username labels are intercepted on notification
filters list
This commit is contained in:
Marcus Kida 2024-07-30 15:09:30 +02:00 committed by GitHub
commit 2d318407cb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 2 deletions

View File

@ -53,7 +53,8 @@ class NotificationRequestTableViewCell: UITableViewCell {
labelStackView.axis = .vertical labelStackView.axis = .vertical
labelStackView.alignment = .leading labelStackView.alignment = .leading
labelStackView.spacing = 4 labelStackView.spacing = 4
labelStackView.isUserInteractionEnabled = false
acceptNotificationRequestButton = HighlightDimmableButton() acceptNotificationRequestButton = HighlightDimmableButton()
acceptNotificationRequestButton.translatesAutoresizingMaskIntoConstraints = false acceptNotificationRequestButton.translatesAutoresizingMaskIntoConstraints = false
acceptNotificationRequestButton.titleLabel?.font = UIFont.systemFont(ofSize: 17, weight: .semibold) acceptNotificationRequestButton.titleLabel?.font = UIFont.systemFont(ofSize: 17, weight: .semibold)
@ -117,6 +118,7 @@ class NotificationRequestTableViewCell: UITableViewCell {
avatarStackView.axis = .horizontal avatarStackView.axis = .horizontal
avatarStackView.alignment = .center avatarStackView.alignment = .center
avatarStackView.spacing = 12 avatarStackView.spacing = 12
avatarStackView.isUserInteractionEnabled = false
contentStackView = UIStackView(arrangedSubviews: [avatarStackView, buttonStackView]) contentStackView = UIStackView(arrangedSubviews: [avatarStackView, buttonStackView])
contentStackView.translatesAutoresizingMaskIntoConstraints = false contentStackView.translatesAutoresizingMaskIntoConstraints = false

View File

@ -1993,7 +1993,7 @@ public enum L10n {
public enum FilteredNotificationBanner { public enum FilteredNotificationBanner {
/// Plural format key: "%#@number_of_requests@" /// Plural format key: "%#@number_of_requests@"
public static func subtitle(_ p1: Int) -> String { public static func subtitle(_ p1: Int) -> String {
return L10n.tr("Localizable", "plural.filtered_notification_banner.subtitle", p1, fallback: "Plural format key: \"%#@number_of_requests@\"") return L10n.tr("Localizable", "plural.filtered_notification_banner.subtitle", p1, fallback: "%ld people you may know")
} }
} }
} }