From bfc0076429fb10ee99dc16cbb9e95dda2ec14194 Mon Sep 17 00:00:00 2001 From: shimura233 <2763221922@qq.com> Date: Sun, 21 Apr 2024 20:29:15 +0800 Subject: [PATCH] opti: avoid leaking response body when it's not used. --- .../org/joinmastodon/android/api/MastodonAPIController.java | 4 +++- .../android/fragments/onboarding/InstanceCatalogFragment.java | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/mastodon/src/main/java/org/joinmastodon/android/api/MastodonAPIController.java b/mastodon/src/main/java/org/joinmastodon/android/api/MastodonAPIController.java index 384378df..9ea3bb76 100644 --- a/mastodon/src/main/java/org/joinmastodon/android/api/MastodonAPIController.java +++ b/mastodon/src/main/java/org/joinmastodon/android/api/MastodonAPIController.java @@ -113,8 +113,10 @@ public class MastodonAPIController{ @Override public void onResponse(@NonNull Call call, @NonNull Response response) throws IOException{ - if(req.canceled) + if(req.canceled){ + response.close(); return; + } if(BuildConfig.DEBUG) Log.d(TAG, logTag(session)+hreq+" received response: "+response); synchronized(req){ diff --git a/mastodon/src/main/java/org/joinmastodon/android/fragments/onboarding/InstanceCatalogFragment.java b/mastodon/src/main/java/org/joinmastodon/android/fragments/onboarding/InstanceCatalogFragment.java index 22790395..78365f6f 100644 --- a/mastodon/src/main/java/org/joinmastodon/android/fragments/onboarding/InstanceCatalogFragment.java +++ b/mastodon/src/main/java/org/joinmastodon/android/fragments/onboarding/InstanceCatalogFragment.java @@ -316,8 +316,10 @@ abstract class InstanceCatalogFragment extends BaseRecyclerFragment{