From 09a0bde33124ac53fe214e085eedf8f263f2ba81 Mon Sep 17 00:00:00 2001 From: Marquis Kurt Date: Sun, 28 Jul 2019 11:04:52 -0400 Subject: [PATCH] Fix build error for Win32, add notarization clause to README Signed-off-by: Marquis Kurt --- README.md | 4 ++++ desktop/notarize.js | 2 ++ package.json | 2 +- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index d886274..471211f 100644 --- a/README.md +++ b/README.md @@ -81,6 +81,10 @@ You can run any of the following commands to build a release for the desktop: > > While the command will run without needing the signature, it is recommended that you make a signed copy to protect users. +> ⚠️ **Notarization**: If you are building the macOS version of Hyperspace, you will also need to set up notarization processes. Hyperspace will _not_ run on devices running macOS Catalina or later without this notarization; please ensure you have the correct certificates and updated notarization scripts in `desktop/notarize.js`. +> +> When building, the script will aotumatically notarize the app for you after signing it. + The built files will be available under `dist` that can be uploaded to your app distributor or website. ## Contribute diff --git a/desktop/notarize.js b/desktop/notarize.js index 38f1d41..d96632d 100644 --- a/desktop/notarize.js +++ b/desktop/notarize.js @@ -15,6 +15,8 @@ exports.default = async function notarizing(context) { return; } + console.log("Notarizing Hyperspace..."); + const appName = context.packager.appInfo.productFilename; return await notarize({ diff --git a/package.json b/package.json index fb04752..acbc7d4 100644 --- a/package.json +++ b/package.json @@ -50,7 +50,7 @@ "build": "react-scripts build", "create-mac-icon": "cd desktop; iconutil -c icns app.iconset; cd ..", "build-desktop": "npm run build; npm run create-mac-icon; electron-builder -mwl deb AppImage snap", - "build-desktop-win": "build -w", + "build-desktop-win": "electron-builder -w", "build-desktop-darwin": "npm run create-mac-icon; electron-builder -m", "build-desktop-linux": "electron-builder -l deb AppImage snap", "build-desktop-linux-select": "electron-builder -l ",