diff --git a/twidere.component.common/src/main/java/org/mariotaku/twidere/TwidereConstants.java b/twidere.component.common/src/main/java/org/mariotaku/twidere/TwidereConstants.java
index 892e69d51..4182d4001 100644
--- a/twidere.component.common/src/main/java/org/mariotaku/twidere/TwidereConstants.java
+++ b/twidere.component.common/src/main/java/org/mariotaku/twidere/TwidereConstants.java
@@ -19,6 +19,8 @@
package org.mariotaku.twidere;
+import android.content.ContentResolver;
+
import org.mariotaku.twidere.constant.IntentConstants;
import org.mariotaku.twidere.constant.SharedPreferenceConstants;
@@ -30,7 +32,6 @@ import org.mariotaku.twidere.constant.SharedPreferenceConstants;
public interface TwidereConstants extends SharedPreferenceConstants, IntentConstants {
String TWIDERE_APP_NAME = "Twidere";
- String TWIDERE_PACKAGE_NAME = "org.mariotaku.twidere";
String TWIDERE_PROJECT_URL = "https://github.com/mariotaku/twidere";
String TWIDERE_PROJECT_EMAIL = "twidere.project@gmail.com";
@@ -57,10 +58,9 @@ public interface TwidereConstants extends SharedPreferenceConstants, IntentConst
String SCHEME_HTTP = "http";
String SCHEME_HTTPS = "https";
- String SCHEME_CONTENT = "content";
+ String SCHEME_CONTENT = ContentResolver.SCHEME_CONTENT;
String SCHEME_TWIDERE = "twidere";
String SCHEME_DATA = "data";
- String SCHEME_FILE = "file";
String PROTOCOL_HTTP = SCHEME_HTTP + "://";
String PROTOCOL_HTTPS = SCHEME_HTTPS + "://";
@@ -71,9 +71,6 @@ public interface TwidereConstants extends SharedPreferenceConstants, IntentConst
String AUTHORITY_TWIDERE_CACHE = "twidere.cache";
String AUTHORITY_USER = "user";
- String AUTHORITY_HOME = "home";
- String AUTHORITY_MENTIONS = "mentions";
- String AUTHORITY_DIRECT_MESSAGES = "direct_messages";
String AUTHORITY_USERS = "users";
String AUTHORITY_USER_TIMELINE = "user_timeline";
String AUTHORITY_USER_MEDIA_TIMELINE = "user_media_timeline";
@@ -228,12 +225,6 @@ public interface TwidereConstants extends SharedPreferenceConstants, IntentConst
String TASK_TAG_GET_TRENDS = "get_trends";
String TASK_TAG_STORE_TRENDS = "store_trends";
- String SERVICE_COMMAND_REFRESH_ALL = "refresh_all";
- String SERVICE_COMMAND_GET_HOME_TIMELINE = "get_home_timeline";
- String SERVICE_COMMAND_GET_MENTIONS = "get_mentions";
- String SERVICE_COMMAND_GET_SENT_DIRECT_MESSAGES = "get_sent_direct_messages";
- String SERVICE_COMMAND_GET_RECEIVED_DIRECT_MESSAGES = "get_received_direct_messages";
-
String METADATA_KEY_EXTENSION = "org.mariotaku.twidere.extension";
String METADATA_KEY_EXTENSION_PERMISSIONS = "org.mariotaku.twidere.extension.permissions";
String METADATA_KEY_EXTENSION_SETTINGS = "org.mariotaku.twidere.extension.settings";
@@ -251,19 +242,6 @@ public interface TwidereConstants extends SharedPreferenceConstants, IntentConst
String PERMISSION_ACCOUNTS = "accounts";
String PERMISSION_PREFERENCES = "preferences";
- String TAB_TYPE_HOME_TIMELINE = "home_timeline";
- String TAB_TYPE_NOTIFICATIONS_TIMELINE = "notifications_timeline";
- String TAB_TYPE_TRENDS_SUGGESTIONS = "trends_suggestions";
- String TAB_TYPE_DIRECT_MESSAGES = "direct_messages";
- String TAB_TYPE_FAVORITES = "favorites";
- String TAB_TYPE_USER_TIMELINE = "user_timeline";
- String TAB_TYPE_SEARCH_STATUSES = "search_statuses";
- String TAB_TYPE_LIST_TIMELINE = "list_timeline";
- String TAB_TYPE_ACTIVITIES_ABOUT_ME = "activities_about_me";
- String TAB_TYPE_ACTIVITIES_BY_FRIENDS = "activities_by_friends";
- String TAB_TYPE_RETWEETS_OF_ME = "retweets_of_me";
-
-
int TAB_CODE_HOME_TIMELINE = 1;
int TAB_CODE_NOTIFICATIONS_TIMELINE = 2;
int TAB_CODE_DIRECT_MESSAGES = 4;
diff --git a/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/auth/OAuthToken.java b/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/auth/OAuthToken.java
index f5a2d6b08..de768c697 100644
--- a/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/auth/OAuthToken.java
+++ b/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/auth/OAuthToken.java
@@ -30,7 +30,6 @@ import org.mariotaku.twidere.api.twitter.TwitterException;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
-import java.lang.reflect.Type;
import java.nio.charset.Charset;
import java.text.ParseException;
diff --git a/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/model/CreateCardData.java b/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/model/CreateCardData.java
index f214ceb19..d008dcad0 100644
--- a/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/model/CreateCardData.java
+++ b/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/model/CreateCardData.java
@@ -19,12 +19,6 @@
package org.mariotaku.twidere.api.twitter.model;
-import com.bluelinelabs.logansquare.LoganSquare;
-
-import java.io.IOException;
-import java.util.LinkedHashMap;
-import java.util.Map;
-
/**
* Example
*
diff --git a/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/model/GeoQuery.java b/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/model/GeoQuery.java
index 3c28150e3..16d11fb2a 100644
--- a/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/model/GeoQuery.java
+++ b/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/model/GeoQuery.java
@@ -39,7 +39,7 @@ public final class GeoQuery implements ValueMap {
/**
* Creates a GeoQuery with the specified location
*
- * @param location
+ * @param location Query location
*/
public GeoQuery(final GeoLocation location) {
this.location = location;
diff --git a/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/model/MediaEntity.java b/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/model/MediaEntity.java
index 3d29f0ede..2ae979af6 100644
--- a/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/model/MediaEntity.java
+++ b/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/model/MediaEntity.java
@@ -22,8 +22,6 @@ package org.mariotaku.twidere.api.twitter.model;
import com.bluelinelabs.logansquare.annotation.JsonField;
import com.bluelinelabs.logansquare.annotation.JsonObject;
-import org.mariotaku.twidere.api.gnusocial.model.Attachment;
-
import java.util.Arrays;
import java.util.HashMap;
import java.util.Map;
diff --git a/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/model/TimeZone.java b/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/model/TimeZone.java
index b4ba5d25d..72682deb6 100644
--- a/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/model/TimeZone.java
+++ b/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/model/TimeZone.java
@@ -22,8 +22,6 @@ package org.mariotaku.twidere.api.twitter.model;
import com.bluelinelabs.logansquare.annotation.JsonField;
import com.bluelinelabs.logansquare.annotation.JsonObject;
-import org.mariotaku.twidere.api.twitter.model.TimeZone;
-
/**
* Created by mariotaku on 15/5/13.
*/
diff --git a/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/model/Warning.java b/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/model/Warning.java
index dc64ffc65..1f9ad90e8 100644
--- a/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/model/Warning.java
+++ b/twidere.component.common/src/main/java/org/mariotaku/twidere/api/twitter/model/Warning.java
@@ -21,8 +21,6 @@ package org.mariotaku.twidere.api.twitter.model;
import com.bluelinelabs.logansquare.annotation.JsonObject;
-import org.mariotaku.twidere.api.twitter.model.Warning;
-
/**
* Created by mariotaku on 15/5/26.
*/
diff --git a/twidere.component.common/src/main/java/org/mariotaku/twidere/model/ParcelableAccount.java b/twidere.component.common/src/main/java/org/mariotaku/twidere/model/ParcelableAccount.java
index 2d4a3db53..a0d83f361 100644
--- a/twidere.component.common/src/main/java/org/mariotaku/twidere/model/ParcelableAccount.java
+++ b/twidere.component.common/src/main/java/org/mariotaku/twidere/model/ParcelableAccount.java
@@ -199,13 +199,17 @@ public class ParcelableAccount implements Parcelable {
public static ParcelableCredentials getCredentials(final Context context, final long accountId) {
if (context == null) return null;
- try (Cursor cur = ContentResolverUtils.query(context.getContentResolver(), Accounts.CONTENT_URI,
- Accounts.COLUMNS, Accounts.ACCOUNT_ID + " = " + accountId, null, null)) {
- if (cur != null && cur.moveToFirst()) {
+ Cursor cur = ContentResolverUtils.query(context.getContentResolver(), Accounts.CONTENT_URI,
+ Accounts.COLUMNS, Accounts.ACCOUNT_ID + " = " + accountId, null, null);
+ if (cur == null) return null;
+ try {
+ if (cur.moveToFirst()) {
return ParcelableCredentialsCursorIndices.fromCursor(cur);
}
- return null;
+ } finally {
+ cur.close();
}
+ return null;
}
public static List getCredentialsList(final Context context, final boolean activatedOnly) {
diff --git a/twidere.component.common/src/main/java/org/mariotaku/twidere/model/ParcelableStatus.java b/twidere.component.common/src/main/java/org/mariotaku/twidere/model/ParcelableStatus.java
index e6f2bb544..b09ec3d41 100644
--- a/twidere.component.common/src/main/java/org/mariotaku/twidere/model/ParcelableStatus.java
+++ b/twidere.component.common/src/main/java/org/mariotaku/twidere/model/ParcelableStatus.java
@@ -44,7 +44,6 @@ import org.mariotaku.twidere.util.HtmlEscapeHelper;
import org.mariotaku.twidere.util.TwitterContentUtils;
import java.io.IOException;
-import java.util.Arrays;
import java.util.Comparator;
import java.util.Date;
diff --git a/twidere.component.common/src/main/java/org/mariotaku/twidere/model/ParcelableUserList.java b/twidere.component.common/src/main/java/org/mariotaku/twidere/model/ParcelableUserList.java
index d5f2a4439..d8dfedbfe 100644
--- a/twidere.component.common/src/main/java/org/mariotaku/twidere/model/ParcelableUserList.java
+++ b/twidere.component.common/src/main/java/org/mariotaku/twidere/model/ParcelableUserList.java
@@ -108,7 +108,7 @@ public class ParcelableUserList implements Parcelable, Comparable grabLinks(final String html) {
- final Vector result = new Vector();
+ final Vector result = new Vector<>();
final Matcher matcherTag = patternTag.matcher(html);
while (matcherTag.find()) {
final String href = matcherTag.group(1); // href
diff --git a/twidere.component.common/src/main/java/org/mariotaku/twidere/util/ParseUtils.java b/twidere.component.common/src/main/java/org/mariotaku/twidere/util/ParseUtils.java
index 4bf20acaf..c6cda19a2 100644
--- a/twidere.component.common/src/main/java/org/mariotaku/twidere/util/ParseUtils.java
+++ b/twidere.component.common/src/main/java/org/mariotaku/twidere/util/ParseUtils.java
@@ -32,10 +32,6 @@ import org.mariotaku.twidere.constant.IntentConstants;
import java.io.IOException;
import java.io.StringWriter;
-import java.net.MalformedURLException;
-import java.net.URI;
-import java.net.URISyntaxException;
-import java.net.URL;
import java.util.Iterator;
import java.util.Locale;
import java.util.Set;
diff --git a/twidere.component.common/src/main/java/org/mariotaku/twidere/util/TwidereArrayUtils.java b/twidere.component.common/src/main/java/org/mariotaku/twidere/util/TwidereArrayUtils.java
index 9320ee065..728327495 100644
--- a/twidere.component.common/src/main/java/org/mariotaku/twidere/util/TwidereArrayUtils.java
+++ b/twidere.component.common/src/main/java/org/mariotaku/twidere/util/TwidereArrayUtils.java
@@ -46,8 +46,8 @@ public final class TwidereArrayUtils {
if (array1 == null || array2 == null) return array1 == array2;
if (array1.length != array2.length) return false;
final int length = array1.length;
- for (int i = 0; i < length; i++) {
- if (!ArrayUtils.contains(array2, array1[i])) return false;
+ for (long anArray1 : array1) {
+ if (!ArrayUtils.contains(array2, anArray1)) return false;
}
return true;
}
@@ -55,9 +55,8 @@ public final class TwidereArrayUtils {
public static boolean contentMatch(final Object[] array1, final Object[] array2) {
if (array1 == null || array2 == null) return array1 == array2;
if (array1.length != array2.length) return false;
- final int length = array1.length;
- for (int i = 0; i < length; i++) {
- if (!ArrayUtils.contains(array2, array1[i])) return false;
+ for (Object item : array1) {
+ if (!ArrayUtils.contains(array2, item)) return false;
}
return true;
}
@@ -75,11 +74,11 @@ public final class TwidereArrayUtils {
public static long[] intersection(final long[] array1, final long[] array2) {
if (array1 == null || array2 == null) return new long[0];
- final List list1 = new ArrayList();
+ final List list1 = new ArrayList<>();
for (final long item : array1) {
list1.add(item);
}
- final List list2 = new ArrayList();
+ final List list2 = new ArrayList<>();
for (final long item : array2) {
list2.add(item);
}
diff --git a/twidere.component.common/src/main/java/org/mariotaku/twidere/util/media/preview/provider/TwitterPicProvider.java b/twidere.component.common/src/main/java/org/mariotaku/twidere/util/media/preview/provider/TwitterPicProvider.java
index 82811c10a..92ab04da3 100644
--- a/twidere.component.common/src/main/java/org/mariotaku/twidere/util/media/preview/provider/TwitterPicProvider.java
+++ b/twidere.component.common/src/main/java/org/mariotaku/twidere/util/media/preview/provider/TwitterPicProvider.java
@@ -8,7 +8,6 @@ import org.mariotaku.restfu.http.RestHttpClient;
import org.mariotaku.twidere.model.ParcelableMedia;
import org.mariotaku.twidere.util.media.preview.PreviewMediaExtractor;
-import java.util.List;
import java.util.Locale;
/**
diff --git a/twidere.component.nyan/src/main/java/org/mariotaku/twidere/nyan/NyanDrawingHelper.java b/twidere.component.nyan/src/main/java/org/mariotaku/twidere/nyan/NyanDrawingHelper.java
index 69fd360cc..a3582079b 100644
--- a/twidere.component.nyan/src/main/java/org/mariotaku/twidere/nyan/NyanDrawingHelper.java
+++ b/twidere.component.nyan/src/main/java/org/mariotaku/twidere/nyan/NyanDrawingHelper.java
@@ -294,7 +294,7 @@ public class NyanDrawingHelper {
private final Paint mPaint;
- private final ArrayList mStars = new ArrayList();
+ private final ArrayList mStars = new ArrayList<>();
private final Random mRandom = new Random();
diff --git a/twidere/src/main/java/org/mariotaku/twidere/Constants.java b/twidere/src/main/java/org/mariotaku/twidere/Constants.java
index 180f9110e..d18fe2136 100644
--- a/twidere/src/main/java/org/mariotaku/twidere/Constants.java
+++ b/twidere/src/main/java/org/mariotaku/twidere/Constants.java
@@ -105,5 +105,4 @@ public interface Constants extends TwidereConstants {
@Preference(type = STRING, exportable = false)
String KEY_DEVICE_SERIAL = "device_serial";
- String READ_POSITION_TAG_ACTIVITIES_ABOUT_ME = "activities_about_me";
}
diff --git a/twidere/src/main/java/org/mariotaku/twidere/activity/ImageCropperActivity.java b/twidere/src/main/java/org/mariotaku/twidere/activity/ImageCropperActivity.java
index dbae37a6f..53d5f9206 100644
--- a/twidere/src/main/java/org/mariotaku/twidere/activity/ImageCropperActivity.java
+++ b/twidere/src/main/java/org/mariotaku/twidere/activity/ImageCropperActivity.java
@@ -23,9 +23,7 @@ import android.content.res.Resources;
import android.os.Build;
import android.os.Bundle;
import android.support.annotation.NonNull;
-import android.support.v4.view.MarginLayoutParamsCompat;
import android.support.v4.view.ViewCompat;
-import android.support.v4.view.WindowCompat;
import android.view.View;
import android.view.WindowManager;
diff --git a/twidere/src/main/java/org/mariotaku/twidere/activity/NyanActivity.java b/twidere/src/main/java/org/mariotaku/twidere/activity/NyanActivity.java
index 5afc78b32..d7a6133b9 100644
--- a/twidere/src/main/java/org/mariotaku/twidere/activity/NyanActivity.java
+++ b/twidere/src/main/java/org/mariotaku/twidere/activity/NyanActivity.java
@@ -38,7 +38,6 @@ import org.mariotaku.twidere.R;
import org.mariotaku.twidere.nyan.NyanDaydreamService;
import org.mariotaku.twidere.nyan.NyanSurfaceHelper;
import org.mariotaku.twidere.nyan.NyanWallpaperService;
-import org.mariotaku.twidere.util.DebugModeUtils;
public class NyanActivity extends Activity implements Constants, OnLongClickListener, OnSharedPreferenceChangeListener {
diff --git a/twidere/src/main/java/org/mariotaku/twidere/activity/SettingsWizardActivity.java b/twidere/src/main/java/org/mariotaku/twidere/activity/SettingsWizardActivity.java
index 0f45fc1db..79d50bb6d 100644
--- a/twidere/src/main/java/org/mariotaku/twidere/activity/SettingsWizardActivity.java
+++ b/twidere/src/main/java/org/mariotaku/twidere/activity/SettingsWizardActivity.java
@@ -50,6 +50,7 @@ import org.mariotaku.twidere.R;
import org.mariotaku.twidere.activity.support.DataImportActivity;
import org.mariotaku.twidere.activity.support.HomeActivity;
import org.mariotaku.twidere.adapter.TabsAdapter;
+import org.mariotaku.twidere.annotation.CustomTabType;
import org.mariotaku.twidere.fragment.BaseDialogFragment;
import org.mariotaku.twidere.fragment.BaseFragment;
import org.mariotaku.twidere.fragment.BasePreferenceFragment;
@@ -536,9 +537,9 @@ public class SettingsWizardActivity extends Activity implements Constants {
private static final String FRAGMENT_TAG = "initial_settings_dialog";
- private static final String[] DEFAULT_TAB_TYPES = {TAB_TYPE_HOME_TIMELINE,
- TAB_TYPE_NOTIFICATIONS_TIMELINE, TAB_TYPE_TRENDS_SUGGESTIONS,
- TAB_TYPE_DIRECT_MESSAGES};
+ private static final String[] DEFAULT_TAB_TYPES = {CustomTabType.HOME_TIMELINE,
+ CustomTabType.NOTIFICATIONS_TIMELINE, CustomTabType.TRENDS_SUGGESTIONS,
+ CustomTabType.DIRECT_MESSAGES};
private final SettingsWizardActivity mActivity;
diff --git a/twidere/src/main/java/org/mariotaku/twidere/activity/support/BrowserSignInActivity.java b/twidere/src/main/java/org/mariotaku/twidere/activity/support/BrowserSignInActivity.java
index 03d3af41b..4ab7431ef 100644
--- a/twidere/src/main/java/org/mariotaku/twidere/activity/support/BrowserSignInActivity.java
+++ b/twidere/src/main/java/org/mariotaku/twidere/activity/support/BrowserSignInActivity.java
@@ -41,7 +41,6 @@ import android.webkit.WebViewClient;
import android.widget.Toast;
import org.attoparser.AttoParseException;
-import org.mariotaku.restfu.Pair;
import org.mariotaku.restfu.http.Authorization;
import org.mariotaku.twidere.R;
import org.mariotaku.twidere.api.twitter.TwitterOAuth;
diff --git a/twidere/src/main/java/org/mariotaku/twidere/activity/support/HomeActivity.java b/twidere/src/main/java/org/mariotaku/twidere/activity/support/HomeActivity.java
index 89fa45f3d..16b47baaa 100644
--- a/twidere/src/main/java/org/mariotaku/twidere/activity/support/HomeActivity.java
+++ b/twidere/src/main/java/org/mariotaku/twidere/activity/support/HomeActivity.java
@@ -45,6 +45,7 @@ import android.support.v4.view.ViewPager.OnPageChangeListener;
import android.support.v4.widget.DrawerLayout;
import android.support.v4.widget.DrawerLayoutAccessor;
import android.support.v7.widget.Toolbar;
+import android.util.SparseIntArray;
import android.view.Gravity;
import android.view.KeyEvent;
import android.view.MenuItem;
@@ -71,6 +72,7 @@ import org.mariotaku.twidere.activity.SettingsActivity;
import org.mariotaku.twidere.activity.SettingsWizardActivity;
import org.mariotaku.twidere.activity.UsageStatisticsActivity;
import org.mariotaku.twidere.adapter.support.SupportTabsAdapter;
+import org.mariotaku.twidere.annotation.CustomTabType;
import org.mariotaku.twidere.fragment.CustomTabsFragment;
import org.mariotaku.twidere.fragment.iface.RefreshScrollTopInterface;
import org.mariotaku.twidere.fragment.iface.SupportFragmentCallback;
@@ -107,10 +109,7 @@ import org.mariotaku.twidere.view.TintedStatusFrameLayout;
import org.mariotaku.twidere.view.iface.IHomeActionButton;
import java.util.Collections;
-import java.util.HashMap;
import java.util.List;
-import java.util.Map;
-import java.util.Map.Entry;
import static org.mariotaku.twidere.util.CompareUtils.classEquals;
import static org.mariotaku.twidere.util.Utils.cleanDatabasesByItemLimit;
@@ -723,8 +722,6 @@ public class HomeActivity extends BaseAppCompatActivity implements OnClickListen
}
}
}
- if (initialTab != -1 && mViewPager != null) {
- }
final Intent extraIntent = intent.getParcelableExtra(EXTRA_EXTRA_INTENT);
if (extraIntent != null && firstCreate) {
extraIntent.setExtrasClassLoader(getClassLoader());
@@ -924,13 +921,14 @@ public class HomeActivity extends BaseAppCompatActivity implements OnClickListen
}
}
- private static class UpdateUnreadCountTask extends AsyncTask