Tusky-App-Android/app/src/main/java/com/keylesspalace/tusky
Konrad Pozniak 004659a54d
fix Glide IllegalArgumentException in DrawerImageLoader (#4189)
Turns out that the crash I thought will not occur with #4153 did occur
again. 😒
But this time I managed to reproduce it (faking a slow network for that
one request only and then quickly switching activities to get it
destroyed) so I'm sure it is fixed, and I did a check for possible side
effects but it seems Glide is clever enough to cancel all requests by
itself.

<details>
<summary>stacktrace</summary>

```
Exception java.lang.IllegalArgumentException: You cannot start a load for a destroyed activity
  at com.bumptech.glide.manager.RequestManagerRetriever.assertNotDestroyed (RequestManagerRetriever.java:236)
  at com.bumptech.glide.manager.RequestManagerRetriever.get (RequestManagerRetriever.java:110)
  at com.bumptech.glide.manager.RequestManagerRetriever.get (RequestManagerRetriever.java:176)
  at com.bumptech.glide.Glide.with (Glide.java:634)
  at com.keylesspalace.tusky.MainActivity$setupDrawer$2.cancel (MainActivity.kt:573)
  at com.mikepenz.materialdrawer.util.DrawerImageLoader.cancelImage (DrawerImageLoader.java:56)
  at com.mikepenz.materialdrawer.model.BaseDescribeableDrawerItem.unbindView (BaseDescribeableDrawerItem.kt:95)
  at com.mikepenz.materialdrawer.model.BaseDescribeableDrawerItem.unbindView (BaseDescribeableDrawerItem.kt:20)
  at com.mikepenz.fastadapter.listeners.OnBindViewHolderListenerImpl.unBindViewHolder (OnBindViewHolderListenerImpl.java:36)
  at com.mikepenz.fastadapter.FastAdapter.onViewRecycled (FastAdapter.kt:410)
  at androidx.recyclerview.widget.RecyclerView$Recycler.dispatchViewRecycled (RecyclerView.java:7346)
  at androidx.recyclerview.widget.RecyclerView$Recycler.addViewHolderToRecycledViewPool (RecyclerView.java:7108)
  at androidx.recyclerview.widget.RecyclerView$Recycler.recycleViewHolderInternal (RecyclerView.java:7059)
  at androidx.recyclerview.widget.RecyclerView.removeAnimatingView (RecyclerView.java:1556)
  at androidx.recyclerview.widget.RecyclerView$ItemAnimatorRestoreListener.onAnimationFinished (RecyclerView.java:13564)
  at androidx.recyclerview.widget.RecyclerView$ItemAnimator.dispatchAnimationFinished (RecyclerView.java:14066)
  at androidx.recyclerview.widget.SimpleItemAnimator.dispatchChangeFinished (SimpleItemAnimator.java:328)
  at androidx.recyclerview.widget.DefaultItemAnimator.endChangeAnimationIfNecessary (DefaultItemAnimator.java:437)
  at androidx.recyclerview.widget.DefaultItemAnimator.endChangeAnimationIfNecessary (DefaultItemAnimator.java:418)
  at androidx.recyclerview.widget.DefaultItemAnimator.endAnimations (DefaultItemAnimator.java:588)
  at androidx.recyclerview.widget.RecyclerView.onDetachedFromWindow (RecyclerView.java:3383)
  at android.view.View.dispatchDetachedFromWindow (View.java:20898)
  at android.view.ViewGroup.dispatchDetachedFromWindow (ViewGroup.java:3956)
  at android.view.ViewGroup.dispatchDetachedFromWindow (ViewGroup.java:3948)
  at android.view.ViewGroup.dispatchDetachedFromWindow (ViewGroup.java:3948)
  at android.view.ViewGroup.dispatchDetachedFromWindow (ViewGroup.java:3948)
  at android.view.ViewGroup.dispatchDetachedFromWindow (ViewGroup.java:3948)
  at android.view.ViewGroup.dispatchDetachedFromWindow (ViewGroup.java:3948)
  at android.view.ViewGroup.dispatchDetachedFromWindow (ViewGroup.java:3948)
  at android.view.ViewGroup.dispatchDetachedFromWindow (ViewGroup.java:3948)
  at android.view.ViewRootImpl.dispatchDetachedFromWindow (ViewRootImpl.java:5114)
  at android.view.ViewRootImpl.doDie (ViewRootImpl.java:8309)
  at android.view.ViewRootImpl.die (ViewRootImpl.java:8286)
  at android.view.WindowManagerGlobal.removeViewLocked (WindowManagerGlobal.java:538)
  at android.view.WindowManagerGlobal.removeView (WindowManagerGlobal.java:479)
  at android.view.WindowManagerImpl.removeViewImmediate (WindowManagerImpl.java:162)
  at android.app.ActivityThread.handleDestroyActivity (ActivityThread.java:5564)
  at android.app.ActivityThread.handleRelaunchActivityInner (ActivityThread.java:5842)
  at android.app.ActivityThread.handleRelaunchActivity (ActivityThread.java:5758)
  at android.app.servertransaction.ActivityRelaunchItem.execute (ActivityRelaunchItem.java:71)
  at android.app.servertransaction.ActivityTransactionItem.execute (ActivityTransactionItem.java:45)
  at android.app.servertransaction.TransactionExecutor.executeCallbacks (TransactionExecutor.java:135)
  at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:95)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:2293)
  at android.os.Handler.dispatchMessage (Handler.java:106)
  at android.os.Looper.loopOnce (Looper.java:226)
  at android.os.Looper.loop (Looper.java:329)
  at android.app.ActivityThread.main (ActivityThread.java:8058)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:548)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1026)
```

</details>
2023-12-24 09:19:08 +01:00
..
adapter fix memory leak in CompositeWithOpaqueBackground (#4150) 2023-12-10 07:37:54 +01:00
appstore 3532: Show badge on conversations tab on new conversations (#3890) 2023-10-15 21:39:38 +02:00
components fix ANR caused by direct message badge (#4182) 2023-12-21 19:02:28 +01:00
db don't rehide filtered posts on interaction (#4130) 2023-12-05 19:29:01 +01:00
di Remove unneeded code 2023-09-11 21:58:56 +02:00
entity Fix deserialization of the response from friendica on api/v2/instance (#4103) 2023-11-13 10:05:28 +01:00
fragment fix image scaling after swipe down gesture ended in ViewImageFragment (#4135) 2023-12-05 19:28:52 +01:00
interfaces Fix lint warnings (#4019) 2023-09-13 09:20:53 +02:00
json update ktlint plugin to 11.3.1, format code (#3442) 2023-03-13 13:16:39 +01:00
network Support "replies policy" for lists (#4072) 2023-10-26 11:21:04 +02:00
pager Keep the tabs adapter over the life of the viewpager (#3255) 2023-02-15 19:17:59 +01:00
receiver Fix lint warnings (#4019) 2023-09-13 09:20:53 +02:00
service Add copyright notices in source file headers (Fixes issue #4188) (#4190) 2023-12-24 09:18:09 +01:00
settings feat: Hide self-boosts (#3534) (#4101) 2023-11-13 10:04:39 +01:00
usecase fix boost button not updating when boosting (#4048) 2023-10-07 08:59:36 +02:00
util fix icon alignment in help text of empty timelines (#4179) 2023-12-16 15:26:22 +01:00
view fix ClassCastException in ClickableSpanTextView (#4185) 2023-12-23 15:23:16 +01:00
viewdata update minSdk to 24, cleanup code (#4014) 2023-09-12 19:25:45 +02:00
viewmodel Support "replies policy" for lists (#4072) 2023-10-26 11:21:04 +02:00
worker Show notifications from workers (#3760) 2023-06-29 18:37:27 +02:00
AboutActivity.kt Show additional bug report info in AboutActivity (#3802) 2023-08-03 12:20:35 +02:00
AccountsInListFragment.kt Simplify repeated code that shows errors (#3762) 2023-06-19 23:49:20 +02:00
BaseActivity.java fix theme preference defaults (#4061) 2023-10-14 14:20:20 +02:00
BottomSheetActivity.kt Use case-insensitive checks when comparing account URLs in search (#3931) 2023-08-06 13:45:48 +02:00
EditProfileActivity.kt Apply PR suggestions: 2023-08-24 10:06:25 +02:00
LicenseActivity.kt update ktlint plugin to 11.3.1, format code (#3442) 2023-03-13 13:16:39 +01:00
ListsActivity.kt Support "replies policy" for lists (#4072) 2023-10-26 11:21:04 +02:00
MainActivity.kt fix Glide IllegalArgumentException in DrawerImageLoader (#4189) 2023-12-24 09:19:08 +01:00
SplashActivity.kt remove legacy notification channel cleanup (#2550) 2022-05-25 20:54:25 +02:00
StatusListActivity.kt Add support for v2/instance (#4062) 2023-10-25 12:53:10 +02:00
TabData.kt Add "Trending posts" (statuses) feed (#4007) 2023-09-14 22:37:41 +02:00
TabPreferenceActivity.kt 2512: Allow more than 5 tabs (#4051) 2023-10-11 09:54:01 +02:00
TuskyApplication.kt fix theme preference defaults (#4061) 2023-10-14 14:20:20 +02:00
ViewMediaActivity.kt fix crash when opening profile image (#4172) 2023-12-15 07:41:38 +01:00