fix media permissions on Android 10+ (#2837)

app/src/main/AndroidManifest.xml

@@ -5,8 +5,8 @@
 
     <uses-permission android:name="android.permission.INTERNET" />
     <uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
-    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
+    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" android:maxSdkVersion="28" />
-    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
+    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" android:maxSdkVersion="28"/>
     <uses-permission android:name="android.permission.VIBRATE" /> <!-- For notifications -->
     <uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
 

app/src/main/java/com/keylesspalace/tusky/ViewMediaActivity.kt

@@ -27,6 +27,7 @@ import android.content.pm.PackageManager
 import android.graphics.Bitmap
 import android.graphics.Color
 import android.net.Uri
+import android.os.Build
 import android.os.Bundle
 import android.os.Environment
 import android.transition.Transition
@@ -212,13 +213,21 @@ class ViewMediaActivity : BaseActivity(), ViewImageFragment.PhotoActionsListener
     }
 
     private fun requestDownloadMedia() {
+        if (Build.VERSION.SDK_INT < Build.VERSION_CODES.Q) {
             requestPermissions(arrayOf(Manifest.permission.WRITE_EXTERNAL_STORAGE)) { _, grantResults ->
                 if (grantResults.isNotEmpty() && grantResults[0] == PackageManager.PERMISSION_GRANTED) {
                     downloadMedia()
                 } else {
-                showErrorDialog(binding.toolbar, R.string.error_media_download_permission, R.string.action_retry) { requestDownloadMedia() }
+                    showErrorDialog(
+                        binding.toolbar,
+                        R.string.error_media_download_permission,
+                        R.string.action_retry
+                    ) { requestDownloadMedia() }
                 }
             }
+        } else {
+            downloadMedia()
+        }
     }
 
     private fun onOpenStatus() {

app/src/main/java/com/keylesspalace/tusky/components/compose/ComposeActivity.kt

@@ -803,7 +803,7 @@ class ComposeActivity :
                 // Wait until bottom sheet is not collapsed and show next screen after
                 if (newState == BottomSheetBehavior.STATE_COLLAPSED) {
                     addMediaBehavior.removeBottomSheetCallback(this)
-                    if (ContextCompat.checkSelfPermission(this@ComposeActivity, Manifest.permission.READ_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED) {
+                    if (Build.VERSION.SDK_INT < Build.VERSION_CODES.Q && ContextCompat.checkSelfPermission(this@ComposeActivity, Manifest.permission.READ_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED) {
                         ActivityCompat.requestPermissions(
                             this@ComposeActivity,
                             arrayOf(Manifest.permission.READ_EXTERNAL_STORAGE),

app/src/main/java/com/keylesspalace/tusky/components/search/fragments/SearchStatusesFragment.kt

@@ -23,6 +23,7 @@ import android.content.Context
 import android.content.Intent
 import android.content.pm.PackageManager
 import android.net.Uri
+import android.os.Build
 import android.os.Environment
 import android.util.Log
 import android.view.View
@@ -408,14 +409,22 @@ class SearchStatusesFragment : SearchFragment<StatusViewData.Concrete>(), Status
     }
 
     private fun requestDownloadAllMedia(status: Status) {
+        if (Build.VERSION.SDK_INT < Build.VERSION_CODES.Q) {
             val permissions = arrayOf(Manifest.permission.WRITE_EXTERNAL_STORAGE)
             (activity as BaseActivity).requestPermissions(permissions) { _, grantResults ->
                 if (grantResults.isNotEmpty() && grantResults[0] == PackageManager.PERMISSION_GRANTED) {
                     downloadAllMedia(status)
                 } else {
-                Toast.makeText(context, R.string.error_media_download_permission, Toast.LENGTH_SHORT).show()
+                    Toast.makeText(
+                        context,
+                        R.string.error_media_download_permission,
+                        Toast.LENGTH_SHORT
+                    ).show()
                 }
             }
+        } else {
+            downloadAllMedia(status)
+        }
     }
 
     private fun openReportPage(accountId: String, accountUsername: String, statusId: String) {

app/src/main/java/com/keylesspalace/tusky/fragment/SFragment.java

@@ -25,6 +25,7 @@ import android.content.Context;
 import android.content.Intent;
 import android.content.pm.PackageManager;
 import android.net.Uri;
+import android.os.Build;
 import android.os.Environment;
 import android.util.Log;
 import android.view.Menu;
@@ -474,6 +475,7 @@ public abstract class SFragment extends Fragment implements Injectable {
     }
 
     private void requestDownloadAllMedia(Status status) {
+        if (Build.VERSION.SDK_INT < Build.VERSION_CODES.Q) {
             String[] permissions = new String[]{Manifest.permission.WRITE_EXTERNAL_STORAGE};
             ((BaseActivity) getActivity()).requestPermissions(permissions, (permissions1, grantResults) -> {
                 if (grantResults.length > 0 && grantResults[0] == PackageManager.PERMISSION_GRANTED) {
@@ -482,5 +484,8 @@ public abstract class SFragment extends Fragment implements Injectable {
                     Toast.makeText(getContext(), R.string.error_media_download_permission, Toast.LENGTH_SHORT).show();
                 }
             });
+        } else {
+            downloadAllMedia(status);
+        }
     }
 }