Fix some warnings & recreate lint-baseline.xml (#4278)
This commit is contained in:
parent
c666a6b534
commit
6249b53718
|
@ -1,5 +1,27 @@
|
|||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
<issues format="6" by="lint 8.1.2" type="baseline" client="gradle" dependencies="false" name="AGP (8.1.2)" variant="all" version="8.1.2">
|
||||
<issues format="6" by="lint 8.2.2" type="baseline" client="gradle" dependencies="false" name="AGP (8.2.2)" variant="all" version="8.2.2">
|
||||
|
||||
<issue
|
||||
id="GestureBackNavigation"
|
||||
message="If intercepting back events, this should be handled through the registration of callbacks on the window level; Please see https://developer.android.com/about/versions/13/features/predictive-back-gesture"
|
||||
errorLine1=" if (keyCode == KeyEvent.KEYCODE_BACK) {"
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/java/com/keylesspalace/tusky/components/compose/ComposeActivity.kt"
|
||||
line="1314"
|
||||
column="28"/>
|
||||
</issue>
|
||||
|
||||
<issue
|
||||
id="DefaultLocale"
|
||||
message="Implicitly using the default locale is a common source of bugs: Use `toUpperCase(Locale)` instead. For strings meant to be internal use `Locale.ROOT`, otherwise `Locale.getDefault()`."
|
||||
errorLine1=" sb.append(language.toUpperCase());"
|
||||
errorLine2=" ~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/java/com/keylesspalace/tusky/adapter/StatusDetailedViewHolder.java"
|
||||
line="101"
|
||||
column="32"/>
|
||||
</issue>
|
||||
|
||||
<issue
|
||||
id="InvalidPackage"
|
||||
|
@ -31,14 +53,14 @@
|
|||
|
||||
<issue
|
||||
id="PrivateResource"
|
||||
message="Overriding `@layout/exo_player_control_view` which is marked as private in androidx.media3:media3-ui:1.1.1. If deliberate, use tools:override="true", otherwise pick a different name.">
|
||||
message="Overriding `@layout/exo_player_control_view` which is marked as private in androidx.media3:media3-ui:1.2.1. If deliberate, use tools:override="true", otherwise pick a different name.">
|
||||
<location
|
||||
file="src/main/res/layout/exo_player_control_view.xml"/>
|
||||
</issue>
|
||||
|
||||
<issue
|
||||
id="PrivateResource"
|
||||
message="The resource `@color/exo_bottom_bar_background` is marked as private in androidx.media3:media3-ui:1.1.1"
|
||||
message="The resource `@color/exo_bottom_bar_background` is marked as private in androidx.media3:media3-ui:1.2.1"
|
||||
errorLine1=" android:background="@color/exo_bottom_bar_background""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
|
@ -49,7 +71,7 @@
|
|||
|
||||
<issue
|
||||
id="PrivateResource"
|
||||
message="The resource `@dimen/exo_styled_controls_padding` is marked as private in androidx.media3:media3-ui:1.1.1"
|
||||
message="The resource `@dimen/exo_styled_controls_padding` is marked as private in androidx.media3:media3-ui:1.2.1"
|
||||
errorLine1=" android:padding="@dimen/exo_styled_controls_padding""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
|
@ -60,7 +82,7 @@
|
|||
|
||||
<issue
|
||||
id="PrivateResource"
|
||||
message="The resource `@layout/exo_player_control_rewind_button` is marked as private in androidx.media3:media3-ui:1.1.1"
|
||||
message="The resource `@layout/exo_player_control_rewind_button` is marked as private in androidx.media3:media3-ui:1.2.1"
|
||||
errorLine1=" <include layout="@layout/exo_player_control_rewind_button" />"
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
|
@ -71,7 +93,7 @@
|
|||
|
||||
<issue
|
||||
id="PrivateResource"
|
||||
message="The resource `@layout/exo_player_control_ffwd_button` is marked as private in androidx.media3:media3-ui:1.1.1"
|
||||
message="The resource `@layout/exo_player_control_ffwd_button` is marked as private in androidx.media3:media3-ui:1.2.1"
|
||||
errorLine1=" <include layout="@layout/exo_player_control_ffwd_button" />"
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
|
@ -82,7 +104,7 @@
|
|||
|
||||
<issue
|
||||
id="PrivateResource"
|
||||
message="The resource `@dimen/exo_styled_bottom_bar_height` is marked as private in androidx.media3:media3-ui:1.1.1"
|
||||
message="The resource `@dimen/exo_styled_bottom_bar_height` is marked as private in androidx.media3:media3-ui:1.2.1"
|
||||
errorLine1=" android:layout_height="@dimen/exo_styled_bottom_bar_height""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
|
@ -93,7 +115,7 @@
|
|||
|
||||
<issue
|
||||
id="PrivateResource"
|
||||
message="The resource `@dimen/exo_styled_bottom_bar_margin_top` is marked as private in androidx.media3:media3-ui:1.1.1"
|
||||
message="The resource `@dimen/exo_styled_bottom_bar_margin_top` is marked as private in androidx.media3:media3-ui:1.2.1"
|
||||
errorLine1=" android:layout_marginTop="@dimen/exo_styled_bottom_bar_margin_top""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
|
@ -104,7 +126,7 @@
|
|||
|
||||
<issue
|
||||
id="PrivateResource"
|
||||
message="The resource `@color/exo_bottom_bar_background` is marked as private in androidx.media3:media3-ui:1.1.1"
|
||||
message="The resource `@color/exo_bottom_bar_background` is marked as private in androidx.media3:media3-ui:1.2.1"
|
||||
errorLine1=" android:background="@color/exo_bottom_bar_background""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
|
@ -115,7 +137,7 @@
|
|||
|
||||
<issue
|
||||
id="PrivateResource"
|
||||
message="The resource `@dimen/exo_styled_bottom_bar_time_padding` is marked as private in androidx.media3:media3-ui:1.1.1"
|
||||
message="The resource `@dimen/exo_styled_bottom_bar_time_padding` is marked as private in androidx.media3:media3-ui:1.2.1"
|
||||
errorLine1=" android:paddingStart="@dimen/exo_styled_bottom_bar_time_padding""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
|
@ -126,7 +148,7 @@
|
|||
|
||||
<issue
|
||||
id="PrivateResource"
|
||||
message="The resource `@dimen/exo_styled_bottom_bar_time_padding` is marked as private in androidx.media3:media3-ui:1.1.1"
|
||||
message="The resource `@dimen/exo_styled_bottom_bar_time_padding` is marked as private in androidx.media3:media3-ui:1.2.1"
|
||||
errorLine1=" android:paddingEnd="@dimen/exo_styled_bottom_bar_time_padding""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
|
@ -137,7 +159,7 @@
|
|||
|
||||
<issue
|
||||
id="PrivateResource"
|
||||
message="The resource `@dimen/exo_styled_bottom_bar_time_padding` is marked as private in androidx.media3:media3-ui:1.1.1"
|
||||
message="The resource `@dimen/exo_styled_bottom_bar_time_padding` is marked as private in androidx.media3:media3-ui:1.2.1"
|
||||
errorLine1=" android:paddingLeft="@dimen/exo_styled_bottom_bar_time_padding""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
|
@ -148,7 +170,7 @@
|
|||
|
||||
<issue
|
||||
id="PrivateResource"
|
||||
message="The resource `@dimen/exo_styled_bottom_bar_time_padding` is marked as private in androidx.media3:media3-ui:1.1.1"
|
||||
message="The resource `@dimen/exo_styled_bottom_bar_time_padding` is marked as private in androidx.media3:media3-ui:1.2.1"
|
||||
errorLine1=" android:paddingRight="@dimen/exo_styled_bottom_bar_time_padding""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
|
@ -159,7 +181,7 @@
|
|||
|
||||
<issue
|
||||
id="PrivateResource"
|
||||
message="The resource `@dimen/exo_styled_progress_layout_height` is marked as private in androidx.media3:media3-ui:1.1.1"
|
||||
message="The resource `@dimen/exo_styled_progress_layout_height` is marked as private in androidx.media3:media3-ui:1.2.1"
|
||||
errorLine1=" android:layout_height="@dimen/exo_styled_progress_layout_height""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
|
@ -170,7 +192,7 @@
|
|||
|
||||
<issue
|
||||
id="PrivateResource"
|
||||
message="The resource `@dimen/exo_styled_progress_margin_bottom` is marked as private in androidx.media3:media3-ui:1.1.1"
|
||||
message="The resource `@dimen/exo_styled_progress_margin_bottom` is marked as private in androidx.media3:media3-ui:1.2.1"
|
||||
errorLine1=" android:layout_marginBottom="@dimen/exo_styled_progress_margin_bottom"/>"
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
|
@ -181,7 +203,7 @@
|
|||
|
||||
<issue
|
||||
id="PrivateResource"
|
||||
message="The resource `@dimen/exo_styled_minimal_controls_margin_bottom` is marked as private in androidx.media3:media3-ui:1.1.1"
|
||||
message="The resource `@dimen/exo_styled_minimal_controls_margin_bottom` is marked as private in androidx.media3:media3-ui:1.2.1"
|
||||
errorLine1=" android:layout_marginBottom="@dimen/exo_styled_minimal_controls_margin_bottom""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
|
@ -208,7 +230,7 @@
|
|||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/res/values/strings.xml"
|
||||
line="328"
|
||||
line="329"
|
||||
column="5"/>
|
||||
</issue>
|
||||
|
||||
|
@ -219,7 +241,7 @@
|
|||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/res/values/strings.xml"
|
||||
line="386"
|
||||
line="387"
|
||||
column="5"/>
|
||||
</issue>
|
||||
|
||||
|
@ -230,7 +252,7 @@
|
|||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/res/values/strings.xml"
|
||||
line="562"
|
||||
line="565"
|
||||
column="5"/>
|
||||
</issue>
|
||||
|
||||
|
@ -241,106 +263,106 @@
|
|||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/res/values/strings.xml"
|
||||
line="783"
|
||||
line="785"
|
||||
column="5"/>
|
||||
</issue>
|
||||
|
||||
<issue
|
||||
id="UnusedTranslation"
|
||||
message="The language `ber (Berber languages)` is present in this project, but not declared in the `localeConfig` resource"
|
||||
errorLine1=" android:localeConfig="@xml/locales_config">"
|
||||
errorLine1=" android:localeConfig="@xml/locales_config""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/AndroidManifest.xml"
|
||||
line="21"
|
||||
line="22"
|
||||
column="31"/>
|
||||
</issue>
|
||||
|
||||
<issue
|
||||
id="UnusedTranslation"
|
||||
message="The language `el (Greek)` is present in this project, but not declared in the `localeConfig` resource"
|
||||
errorLine1=" android:localeConfig="@xml/locales_config">"
|
||||
errorLine1=" android:localeConfig="@xml/locales_config""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/AndroidManifest.xml"
|
||||
line="21"
|
||||
line="22"
|
||||
column="31"/>
|
||||
</issue>
|
||||
|
||||
<issue
|
||||
id="UnusedTranslation"
|
||||
message="The language `fi (Finnish)` is present in this project, but not declared in the `localeConfig` resource"
|
||||
errorLine1=" android:localeConfig="@xml/locales_config">"
|
||||
errorLine1=" android:localeConfig="@xml/locales_config""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/AndroidManifest.xml"
|
||||
line="21"
|
||||
line="22"
|
||||
column="31"/>
|
||||
</issue>
|
||||
|
||||
<issue
|
||||
id="UnusedTranslation"
|
||||
message="The language `fy (Western Frisian)` is present in this project, but not declared in the `localeConfig` resource"
|
||||
errorLine1=" android:localeConfig="@xml/locales_config">"
|
||||
errorLine1=" android:localeConfig="@xml/locales_config""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/AndroidManifest.xml"
|
||||
line="21"
|
||||
line="22"
|
||||
column="31"/>
|
||||
</issue>
|
||||
|
||||
<issue
|
||||
id="UnusedTranslation"
|
||||
message="The language `in (Indonesian)` is present in this project, but not declared in the `localeConfig` resource"
|
||||
errorLine1=" android:localeConfig="@xml/locales_config">"
|
||||
errorLine1=" android:localeConfig="@xml/locales_config""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/AndroidManifest.xml"
|
||||
line="21"
|
||||
line="22"
|
||||
column="31"/>
|
||||
</issue>
|
||||
|
||||
<issue
|
||||
id="UnusedTranslation"
|
||||
message="The language `lv (Latvian)` is present in this project, but not declared in the `localeConfig` resource"
|
||||
errorLine1=" android:localeConfig="@xml/locales_config">"
|
||||
errorLine1=" android:localeConfig="@xml/locales_config""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/AndroidManifest.xml"
|
||||
line="21"
|
||||
line="22"
|
||||
column="31"/>
|
||||
</issue>
|
||||
|
||||
<issue
|
||||
id="UnusedTranslation"
|
||||
message="The language `ml (Malayalam)` is present in this project, but not declared in the `localeConfig` resource"
|
||||
errorLine1=" android:localeConfig="@xml/locales_config">"
|
||||
errorLine1=" android:localeConfig="@xml/locales_config""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/AndroidManifest.xml"
|
||||
line="21"
|
||||
line="22"
|
||||
column="31"/>
|
||||
</issue>
|
||||
|
||||
<issue
|
||||
id="UnusedTranslation"
|
||||
message="The language `si (Sinhala)` is present in this project, but not declared in the `localeConfig` resource"
|
||||
errorLine1=" android:localeConfig="@xml/locales_config">"
|
||||
errorLine1=" android:localeConfig="@xml/locales_config""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/AndroidManifest.xml"
|
||||
line="21"
|
||||
line="22"
|
||||
column="31"/>
|
||||
</issue>
|
||||
|
||||
<issue
|
||||
id="UnusedTranslation"
|
||||
message="The language `sk (Slovak)` is present in this project, but not declared in the `localeConfig` resource"
|
||||
errorLine1=" android:localeConfig="@xml/locales_config">"
|
||||
errorLine1=" android:localeConfig="@xml/locales_config""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/AndroidManifest.xml"
|
||||
line="21"
|
||||
line="22"
|
||||
column="31"/>
|
||||
</issue>
|
||||
|
||||
|
@ -351,7 +373,7 @@
|
|||
errorLine2=" ~~~~~">
|
||||
<location
|
||||
file="src/main/AndroidManifest.xml"
|
||||
line="15"
|
||||
line="16"
|
||||
column="30"/>
|
||||
</issue>
|
||||
|
||||
|
@ -362,7 +384,7 @@
|
|||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/java/com/keylesspalace/tusky/components/account/AccountActivity.kt"
|
||||
line="481"
|
||||
line="523"
|
||||
column="9"/>
|
||||
</issue>
|
||||
|
||||
|
@ -373,7 +395,7 @@
|
|||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/java/com/keylesspalace/tusky/components/accountlist/adapter/AccountAdapter.kt"
|
||||
line="80"
|
||||
line="78"
|
||||
column="9"/>
|
||||
</issue>
|
||||
|
||||
|
@ -384,7 +406,7 @@
|
|||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/java/com/keylesspalace/tusky/adapter/AccountFieldEditAdapter.kt"
|
||||
line="43"
|
||||
line="45"
|
||||
column="9"/>
|
||||
</issue>
|
||||
|
||||
|
@ -395,7 +417,7 @@
|
|||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/java/com/keylesspalace/tusky/adapter/AccountFieldEditAdapter.kt"
|
||||
line="49"
|
||||
line="51"
|
||||
column="9"/>
|
||||
</issue>
|
||||
|
||||
|
@ -406,7 +428,7 @@
|
|||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/java/com/keylesspalace/tusky/components/announcements/AnnouncementAdapter.kt"
|
||||
line="140"
|
||||
line="157"
|
||||
column="9"/>
|
||||
</issue>
|
||||
|
||||
|
@ -417,7 +439,7 @@
|
|||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/java/com/keylesspalace/tusky/components/accountlist/adapter/MutesAdapter.kt"
|
||||
line="107"
|
||||
line="118"
|
||||
column="9"/>
|
||||
</issue>
|
||||
|
||||
|
@ -472,7 +494,7 @@
|
|||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/java/com/keylesspalace/tusky/adapter/TabAdapter.kt"
|
||||
line="157"
|
||||
line="161"
|
||||
column="13"/>
|
||||
</issue>
|
||||
|
||||
|
@ -483,7 +505,7 @@
|
|||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/java/com/keylesspalace/tusky/fragment/ViewVideoFragment.kt"
|
||||
line="280"
|
||||
line="288"
|
||||
column="13"/>
|
||||
</issue>
|
||||
|
||||
|
@ -494,7 +516,7 @@
|
|||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/java/com/keylesspalace/tusky/fragment/ViewVideoFragment.kt"
|
||||
line="289"
|
||||
line="297"
|
||||
column="13"/>
|
||||
</issue>
|
||||
|
||||
|
@ -505,7 +527,7 @@
|
|||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/java/com/keylesspalace/tusky/fragment/ViewVideoFragment.kt"
|
||||
line="310"
|
||||
line="318"
|
||||
column="13"/>
|
||||
</issue>
|
||||
|
||||
|
@ -516,7 +538,7 @@
|
|||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/java/com/keylesspalace/tusky/fragment/ViewVideoFragment.kt"
|
||||
line="322"
|
||||
line="330"
|
||||
column="13"/>
|
||||
</issue>
|
||||
|
||||
|
@ -593,7 +615,7 @@
|
|||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/java/com/keylesspalace/tusky/util/ShareShortcutHelper.kt"
|
||||
line="86"
|
||||
line="91"
|
||||
column="9"/>
|
||||
</issue>
|
||||
|
||||
|
@ -604,7 +626,7 @@
|
|||
errorLine2=" ^">
|
||||
<location
|
||||
file="src/main/java/com/keylesspalace/tusky/adapter/TabAdapter.kt"
|
||||
line="91"
|
||||
line="95"
|
||||
column="13"/>
|
||||
</issue>
|
||||
|
||||
|
@ -615,7 +637,7 @@
|
|||
errorLine2=" ^">
|
||||
<location
|
||||
file="src/main/java/com/keylesspalace/tusky/adapter/TabAdapter.kt"
|
||||
line="91"
|
||||
line="95"
|
||||
column="50"/>
|
||||
</issue>
|
||||
|
||||
|
@ -895,14 +917,36 @@
|
|||
</issue>
|
||||
|
||||
<issue
|
||||
id="UnknownNullness"
|
||||
message="Should explicitly declare type here since implicit type does not specify nullness"
|
||||
errorLine1=" override fun onCreateView("
|
||||
errorLine2=" ~~~~~~~~~~~~">
|
||||
id="RtlHardcoded"
|
||||
message="Consider replacing `android:layout_marginLeft` with `android:layout_marginStart="8dp"` to better support right-to-left layouts"
|
||||
errorLine1=" android:layout_marginLeft="8dp""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/java/com/keylesspalace/tusky/components/compose/dialog/CaptionDialog.kt"
|
||||
line="53"
|
||||
column="18"/>
|
||||
file="src/main/res/layout/item_list.xml"
|
||||
line="37"
|
||||
column="9"/>
|
||||
</issue>
|
||||
|
||||
<issue
|
||||
id="RtlHardcoded"
|
||||
message="Consider replacing `android:layout_marginLeft` with `android:layout_marginStart="8dp"` to better support right-to-left layouts"
|
||||
errorLine1=" android:layout_marginLeft="8dp""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/res/layout/item_list.xml"
|
||||
line="48"
|
||||
column="9"/>
|
||||
</issue>
|
||||
|
||||
<issue
|
||||
id="RtlHardcoded"
|
||||
message="Consider replacing `android:layout_marginLeft` with `android:layout_marginStart="8dp"` to better support right-to-left layouts"
|
||||
errorLine1=" android:layout_marginLeft="8dp""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="src/main/res/layout/item_list.xml"
|
||||
line="59"
|
||||
column="9"/>
|
||||
</issue>
|
||||
|
||||
<issue
|
||||
|
|
|
@ -36,6 +36,7 @@
|
|||
|
||||
<!-- Newer dependencies are handled by Renovate, and don't need a warning -->
|
||||
<issue id="GradleDependency" severity="ignore" />
|
||||
<issue id="NewerVersionAvailable" severity="ignore" />
|
||||
|
||||
<!-- Typographical punctuation is not something we care about at the moment -->
|
||||
<issue id="TypographyQuotes" severity="ignore" />
|
||||
|
|
|
@ -59,7 +59,7 @@ class AccountMediaRemoteMediator(
|
|||
}
|
||||
|
||||
val attachments = statuses.flatMap { status ->
|
||||
AttachmentViewData.list(status, activeAccount.alwaysShowSensitiveMedia ?: false)
|
||||
AttachmentViewData.list(status, activeAccount.alwaysShowSensitiveMedia)
|
||||
}
|
||||
|
||||
if (loadType == LoadType.REFRESH) {
|
||||
|
|
|
@ -27,7 +27,7 @@ import com.keylesspalace.tusky.viewdata.AttachmentViewData
|
|||
import javax.inject.Inject
|
||||
|
||||
class AccountMediaViewModel @Inject constructor(
|
||||
private val accountManager: AccountManager,
|
||||
accountManager: AccountManager,
|
||||
api: MastodonApi
|
||||
) : ViewModel() {
|
||||
|
||||
|
|
|
@ -966,7 +966,7 @@ class ComposeActivity :
|
|||
|
||||
private fun onMediaPick() {
|
||||
addMediaBehavior.addBottomSheetCallback(
|
||||
object : BottomSheetBehavior.BottomSheetCallback() {
|
||||
object : BottomSheetCallback() {
|
||||
override fun onStateChanged(bottomSheet: View, newState: Int) {
|
||||
// Wait until bottom sheet is not collapsed and show next screen after
|
||||
if (newState == BottomSheetBehavior.STATE_COLLAPSED) {
|
||||
|
|
|
@ -54,7 +54,7 @@ class CaptionDialog : DialogFragment() {
|
|||
inflater: LayoutInflater,
|
||||
container: ViewGroup?,
|
||||
savedInstanceState: Bundle?
|
||||
) = inflater.inflate(R.layout.dialog_image_description, container, false)
|
||||
): View = inflater.inflate(R.layout.dialog_image_description, container, false)
|
||||
|
||||
override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
|
||||
val imageView = binding.imageDescriptionView
|
||||
|
|
|
@ -41,7 +41,7 @@ data class Links(val next: String?, val prev: String?) {
|
|||
*
|
||||
* Should only be called by a worker thread.
|
||||
*
|
||||
* @see NotificationWorker
|
||||
* @see com.keylesspalace.tusky.worker.NotificationWorker
|
||||
* @see <a href="https://developer.android.com/guide/background/persistent/threading/worker">Background worker</a>
|
||||
*/
|
||||
@WorkerThread
|
||||
|
|
|
@ -40,7 +40,6 @@ import org.xml.sax.XMLReader
|
|||
|
||||
class ViewEditsAdapter(
|
||||
private val edits: List<StatusEdit>,
|
||||
private val animateAvatars: Boolean,
|
||||
private val animateEmojis: Boolean,
|
||||
private val useBlurhash: Boolean,
|
||||
private val listener: LinkListener
|
||||
|
|
|
@ -135,7 +135,6 @@ class ViewEditsFragment :
|
|||
|
||||
binding.recyclerView.adapter = ViewEditsAdapter(
|
||||
edits = uiState.edits,
|
||||
animateAvatars = animateAvatars,
|
||||
animateEmojis = animateEmojis,
|
||||
useBlurhash = useBlurhash,
|
||||
listener = this@ViewEditsFragment
|
||||
|
|
|
@ -21,7 +21,7 @@ data class Filter(
|
|||
HIDE("hide");
|
||||
|
||||
companion object {
|
||||
fun from(action: String): Action = values().firstOrNull { it.action == action } ?: WARN
|
||||
fun from(action: String): Action = entries.firstOrNull { it.action == action } ?: WARN
|
||||
}
|
||||
}
|
||||
enum class Kind(val kind: String) {
|
||||
|
@ -32,7 +32,7 @@ data class Filter(
|
|||
ACCOUNT("account");
|
||||
|
||||
companion object {
|
||||
fun from(kind: String): Kind = values().firstOrNull { it.kind == kind } ?: PUBLIC
|
||||
fun from(kind: String): Kind = entries.firstOrNull { it.kind == kind } ?: PUBLIC
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
@ -35,7 +35,7 @@ data class MastoList(
|
|||
|
||||
companion object {
|
||||
fun from(policy: String?): ReplyPolicy =
|
||||
values().firstOrNull { it.policy == policy } ?: LIST
|
||||
entries.firstOrNull { it.policy == policy } ?: LIST
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
@ -69,7 +69,7 @@ data class Notification(
|
|||
companion object {
|
||||
@JvmStatic
|
||||
fun byString(s: String): Type {
|
||||
values().forEach {
|
||||
entries.forEach {
|
||||
if (s == it.presentation) {
|
||||
return it
|
||||
}
|
||||
|
|
|
@ -15,6 +15,7 @@
|
|||
|
||||
package com.keylesspalace.tusky.service
|
||||
|
||||
import android.annotation.SuppressLint
|
||||
import android.app.PendingIntent
|
||||
import android.content.Intent
|
||||
import android.os.Build
|
||||
|
@ -28,6 +29,8 @@ import com.keylesspalace.tusky.components.compose.ComposeActivity
|
|||
*/
|
||||
class TuskyTileService : TileService() {
|
||||
|
||||
@SuppressLint("StartActivityAndCollapseDeprecated")
|
||||
@Suppress("DEPRECATION")
|
||||
override fun onClick() {
|
||||
val intent = MainActivity.composeIntent(this, ComposeActivity.ComposeOptions())
|
||||
intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)
|
||||
|
@ -36,7 +39,6 @@ class TuskyTileService : TileService() {
|
|||
val pendingIntent = PendingIntent.getActivity(this, 1, intent, PendingIntent.FLAG_IMMUTABLE)
|
||||
startActivityAndCollapse(pendingIntent)
|
||||
} else {
|
||||
@Suppress("DEPRECATION")
|
||||
startActivityAndCollapse(intent)
|
||||
}
|
||||
}
|
||||
|
|
|
@ -9,7 +9,7 @@ enum class AppTheme(val value: String) {
|
|||
AUTO_SYSTEM_BLACK("auto_system_black");
|
||||
|
||||
companion object {
|
||||
fun stringValues() = values().map { it.value }.toTypedArray()
|
||||
fun stringValues() = entries.map { it.value }.toTypedArray()
|
||||
|
||||
@JvmField
|
||||
val DEFAULT = AUTO_SYSTEM
|
||||
|
|
|
@ -35,7 +35,7 @@ suspend fun AlertDialog.await(
|
|||
positiveText: String,
|
||||
negativeText: String? = null,
|
||||
neutralText: String? = null
|
||||
) = suspendCancellableCoroutine<Int> { cont ->
|
||||
) = suspendCancellableCoroutine { cont ->
|
||||
val listener = DialogInterface.OnClickListener { _, which ->
|
||||
cont.resume(which) { dismiss() }
|
||||
}
|
||||
|
|
|
@ -41,7 +41,6 @@ import androidx.appcompat.content.res.AppCompatResources
|
|||
import androidx.browser.customtabs.CustomTabColorSchemeParams
|
||||
import androidx.browser.customtabs.CustomTabsIntent
|
||||
import androidx.core.net.toUri
|
||||
import androidx.core.text.getSpans
|
||||
import androidx.preference.PreferenceManager
|
||||
import at.connyduck.sparkbutton.helpers.Utils
|
||||
import com.google.android.material.color.MaterialColors
|
||||
|
|
Loading…
Reference in New Issue