From 13a9e9eb376ce651bdaf6a59d413cc128f777d5b Mon Sep 17 00:00:00 2001 From: Konrad Pozniak Date: Fri, 27 Sep 2024 16:20:22 +0200 Subject: [PATCH] fix crash in ViewImageFragment (#4686) From Play console crash logs. Well, let's put another band aid on this code.... ``` Exception java.lang.IllegalStateException: at androidx.fragment.app.Fragment.requireActivity (Fragment.java:1005) at com.keylesspalace.tusky.fragment.ViewImageFragment.getPhotoActionsListener (ViewImageFragment.java:59) at com.keylesspalace.tusky.fragment.ViewImageFragment.access$getPhotoActionsListener (ViewImageFragment.java:49) at com.keylesspalace.tusky.fragment.ViewImageFragment$onViewCreated$singleTapDetector$1.onSingleTapConfirmed (ViewImageFragment.kt:116) at android.view.GestureDetector$GestureHandler.handleMessage (GestureDetector.java:379) at android.os.Handler.dispatchMessage (Handler.java:106) at android.os.Looper.loopOnce (Looper.java:230) at android.os.Looper.loop (Looper.java:319) at android.app.ActivityThread.main (ActivityThread.java:8919) at java.lang.reflect.Method.invoke at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:578) at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1103) ``` --- .../com/keylesspalace/tusky/fragment/ViewImageFragment.kt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/com/keylesspalace/tusky/fragment/ViewImageFragment.kt b/app/src/main/java/com/keylesspalace/tusky/fragment/ViewImageFragment.kt index c3a176cb0..a386d5524 100644 --- a/app/src/main/java/com/keylesspalace/tusky/fragment/ViewImageFragment.kt +++ b/app/src/main/java/com/keylesspalace/tusky/fragment/ViewImageFragment.kt @@ -112,7 +112,9 @@ class ViewImageFragment : ViewMediaFragment() { object : GestureDetector.SimpleOnGestureListener() { override fun onDown(e: MotionEvent) = true override fun onSingleTapConfirmed(e: MotionEvent): Boolean { - photoActionsListener.onPhotoTap() + if (isAdded) { + photoActionsListener.onPhotoTap() + } return false } }