From ed3ab20e46faefe7566cbedf862ec70ce765bde6 Mon Sep 17 00:00:00 2001 From: NudeDude Date: Mon, 26 Mar 2018 23:30:12 +0200 Subject: [PATCH] Performance Bugfix --- .../main/java/org/nuclearfog/twidda/backend/StatusLoader.java | 2 +- .../java/org/nuclearfog/twidda/backend/TwitterEngine.java | 4 ++++ .../java/org/nuclearfog/twidda/database/DatabaseAdapter.java | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/nuclearfog/twidda/backend/StatusLoader.java b/app/src/main/java/org/nuclearfog/twidda/backend/StatusLoader.java index b33c329e..101403cb 100644 --- a/app/src/main/java/org/nuclearfog/twidda/backend/StatusLoader.java +++ b/app/src/main/java/org/nuclearfog/twidda/backend/StatusLoader.java @@ -136,7 +136,7 @@ public class StatusLoader extends AsyncTask implements View.On answers = mTwitter.getAnswers(replyname, tweetID, sinceId); answers.addAll(tlAdp.getData()); } else { - answers = mTwitter.getAnswers(replyname, tweetID, 1); + answers = mTwitter.getAnswers(replyname, tweetID, tweetID); } tlAdp = new TimelineRecycler(answers,ui.get()); tlAdp.setColor(highlight, font); diff --git a/app/src/main/java/org/nuclearfog/twidda/backend/TwitterEngine.java b/app/src/main/java/org/nuclearfog/twidda/backend/TwitterEngine.java index 821e88dc..6a6de6f0 100644 --- a/app/src/main/java/org/nuclearfog/twidda/backend/TwitterEngine.java +++ b/app/src/main/java/org/nuclearfog/twidda/backend/TwitterEngine.java @@ -465,6 +465,8 @@ public class TwitterEngine { */ private List convertUserList(List users) { List result = new ArrayList<>(); + if(users.isEmpty()) + return result; try { for(User user : users) { TwitterUser item = getUser(user); @@ -485,6 +487,8 @@ public class TwitterEngine { */ private List convertStatusList(List statuses) { List result = new ArrayList<>(); + if(statuses.isEmpty()) + return result; try { for(Status status : statuses) { Status embedded = status.getRetweetedStatus(); diff --git a/app/src/main/java/org/nuclearfog/twidda/database/DatabaseAdapter.java b/app/src/main/java/org/nuclearfog/twidda/database/DatabaseAdapter.java index df1ff9ae..a8737730 100644 --- a/app/src/main/java/org/nuclearfog/twidda/database/DatabaseAdapter.java +++ b/app/src/main/java/org/nuclearfog/twidda/database/DatabaseAdapter.java @@ -73,7 +73,7 @@ public class DatabaseAdapter { } else if(mode == MENT) { SQL_GET_HOME = "SELECT * FROM mention " + "INNER JOIN tweet ON mention.tweetID = tweet.tweetID " + - "INNER JOIN user ON tweet.userID = user.userID ORDER BY tweetID ASC"; + "INNER JOIN user ON tweet.userID = user.userID ORDER BY tweetID DESC"; } else if(mode == TWEET) { SQL_GET_HOME = "SELECT * FROM user " +