diff --git a/app/src/main/java/org/nuclearfog/twidda/activity/MediaActivity.java b/app/src/main/java/org/nuclearfog/twidda/activity/MediaActivity.java
index 4f54b254..fa0043ca 100644
--- a/app/src/main/java/org/nuclearfog/twidda/activity/MediaActivity.java
+++ b/app/src/main/java/org/nuclearfog/twidda/activity/MediaActivity.java
@@ -145,10 +145,10 @@ public abstract class MediaActivity extends AppCompatActivity implements Locatio
}
// location permission granted
else if (PERMISSIONS[1][0].equals(permissions[0])) {
- getLocation();
+ getLocation(false);
}
// Write storage permissions granted
- else if ((PERMISSIONS[2][0].equals(permissions[0]))) {
+ else if (PERMISSIONS[2][0].equals(permissions[0])) {
if (grantResults[0] == PERMISSION_GRANTED) {
saveImage();
}
@@ -256,19 +256,22 @@ public abstract class MediaActivity extends AppCompatActivity implements Locatio
/**
* Ask for GPS location
+ *
+ * @param ask set true to ask for permission
*/
- protected void getLocation() {
+ protected void getLocation(boolean ask) {
if (Build.VERSION.SDK_INT < Build.VERSION_CODES.M || checkSelfPermission(PERMISSIONS[1][0]) == PERMISSION_GRANTED) {
LocationManager locationManager = (LocationManager) getSystemService(Context.LOCATION_SERVICE);
if (locationManager != null && locationManager.isProviderEnabled(LocationManager.GPS_PROVIDER)) {
locationManager.requestSingleUpdate(LocationManager.GPS_PROVIDER, this, null);
locationPending = true;
- } else {
- onAttachLocation(null);
+ return;
}
- } else {
+ } else if (ask) {
requestPermissions(PERMISSIONS[1], REQ_CHECK_PERM);
+ return;
}
+ onAttachLocation(null);
}
/**
@@ -347,6 +350,7 @@ public abstract class MediaActivity extends AppCompatActivity implements Locatio
/**
* called when location information was successfully fetched
+ * it isn't safe to update views over this method
*
* @param location location information
*/
diff --git a/app/src/main/java/org/nuclearfog/twidda/activity/TweetEditor.java b/app/src/main/java/org/nuclearfog/twidda/activity/TweetEditor.java
index 9ea9be1f..b49777b5 100644
--- a/app/src/main/java/org/nuclearfog/twidda/activity/TweetEditor.java
+++ b/app/src/main/java/org/nuclearfog/twidda/activity/TweetEditor.java
@@ -133,6 +133,19 @@ public class TweetEditor extends MediaActivity implements OnClickListener, OnPro
}
+ @Override
+ protected void onResume() {
+ super.onResume();
+ if (isLocating()) {
+ locationPending.setVisibility(VISIBLE);
+ locationBtn.setVisibility(INVISIBLE);
+ } else {
+ locationPending.setVisibility(INVISIBLE);
+ locationBtn.setVisibility(VISIBLE);
+ }
+ }
+
+
@Override
protected void onDestroy() {
if (uploaderAsync != null && uploaderAsync.getStatus() == RUNNING)
@@ -197,7 +210,7 @@ public class TweetEditor extends MediaActivity implements OnClickListener, OnPro
else if (v.getId() == R.id.tweet_add_location) {
locationPending.setVisibility(VISIBLE);
locationBtn.setVisibility(INVISIBLE);
- getLocation();
+ getLocation(true);
}
}
@@ -209,8 +222,6 @@ public class TweetEditor extends MediaActivity implements OnClickListener, OnPro
} else {
Toast.makeText(this, R.string.error_gps, LENGTH_LONG).show();
}
- locationPending.setVisibility(INVISIBLE);
- locationBtn.setVisibility(VISIBLE);
this.location = location;
}
diff --git a/app/src/main/res/values/colors.xml b/app/src/main/res/values/colors.xml
index 14559b43..b3f896ce 100644
--- a/app/src/main/res/values/colors.xml
+++ b/app/src/main/res/values/colors.xml
@@ -3,6 +3,4 @@
#40000000
#80000000
#afffffff
- #ffff4000
- #ff0040ff
\ No newline at end of file
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 651bde57..3180dbb7 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -118,6 +118,10 @@
Favorite
Request icon
Follow icon
+ Accounts
+ Remove account from list?
+ User ID:
+ \'unnamed\'
User removed from list
@@ -227,6 +231,8 @@
enter @name to mute
enter @name to block
refresh exclude list
+ select account
+ add account
Yes
@@ -235,11 +241,5 @@
OK
Link preview image
close link preview
- Accounts
- Remove account from list?
- select account
- add account
- User ID:
- \'unnamed\'
\ No newline at end of file