bug fix, removed unused strings

Signed-off-by: nuclearfog <hatespirit666@gmail.com>

app/src/main/java/org/nuclearfog/twidda/activity/TweetActivity.java

@@ -311,7 +311,7 @@ public class TweetActivity extends AppCompatActivity implements OnClickListener,
                 Intent tweetPopup = new Intent(this, TweetEditor.class);
                 tweetPopup.putExtra(KEY_TWEETPOPUP_REPLYID, clickedTweet.getId());
                 if (!tweetPrefix.isEmpty())
-                    tweetPopup.putExtra(KEY_TWEETPOPUP_TEXT, tweetPrefix + " ");
+                    tweetPopup.putExtra(KEY_TWEETPOPUP_TEXT, tweetPrefix);
                 startActivity(tweetPopup);
             }
             // show user retweeting this tweet

app/src/main/java/org/nuclearfog/twidda/backend/model/Tweet.java

@@ -397,18 +397,18 @@ public class Tweet implements Serializable {
             this.tweet = tweet.toString();
         }
         // remove xml tag from source string
-        if (status.getSource() != null) {
-            source = "" + status.getSource();
+        String source = status.getSource();
+        if (source != null) {
             int start = source.indexOf('>') + 1;
             int end = source.lastIndexOf('<');
             if (start > 0 && end > start)
-                source = source.substring(start, end);
+                this.source = source.substring(start, end);
         }
         // add reply mention
-        StringBuilder userMentions = new StringBuilder();
+        StringBuilder userMentions = new StringBuilder(17 /*max screen name length*/);
         if (!user.isCurrentUser()) {
             // prevent self mentioning
-            userMentions.append(user.getScreenname());
+            userMentions.append(user.getScreenname()).append(' ');
         }
         // add user mentions
         UserMentionEntity[] mentionedUsers = status.getUserMentionEntities();
@@ -416,7 +416,7 @@ public class Tweet implements Serializable {
             for (UserMentionEntity mention : mentionedUsers) {
                 if (mention.getId() != twitterId && userMentions.indexOf(mention.getScreenName()) < 0) {
                     // filter out current user's screen name and duplicates
-                    userMentions.append(" @").append(mention.getScreenName());
+                    userMentions.append('@').append(mention.getScreenName()).append(' ');
                 }
             }
         }
@@ -436,15 +436,19 @@ public class Tweet implements Serializable {
             switch (mediaEntities[0].getType()) {
                 case PHOTO:
                     mediaType = MediaType.IMAGE;
-                    for (int i = 0; i < mediaEntities.length; i++)
+                    for (int i = 0; i < mediaEntities.length; i++) {
                         medias[i] = mediaEntities[i].getMediaURLHttps();
+                    }
                     break;
 
                 case VIDEO:
                     mediaType = MediaType.VIDEO;
                     for (MediaEntity.Variant type : mediaEntities[0].getVideoVariants()) {
-                        if (type.getContentType().equals(MEDIA_VIDEO))
+                        if (type.getContentType().equals(MEDIA_VIDEO)) {
+                            // get link with selected video format
+                            // a tweet can only have one video
                             medias[0] = type.getUrl();
+                        }
                     }
                     break;
 

app/src/main/res/values-de-rDE/strings.xml

@@ -74,7 +74,6 @@
     <string name="error_empty_name">Name leer!</string>
     <string name="confirm_discard">Änderungen verwerfen?</string>
     <string name="user_data">Nutzerdaten</string>
-    <string name="error_request_token">API Schlüssel abgelaufen, bitte App aktualisieren!</string>
     <string name="follows_you">folgt dir</string>
     <string name="error_image_save">Fehler beim Speichern!</string>
     <string name="error_not_authorized">Keine Berechtigung!</string>
@@ -170,8 +169,6 @@
     <string name="info_user_added_to_list">wurde zur Liste hinzugefügt!</string>
     <string name="error_username_format">Nutzername falsch!</string>
     <string name="error_not_defined">Undefinierter Fehler!</string>
-    <string name="dialog_button_yes">Ja</string>
-    <string name="dialog_button_no">Nein</string>
     <string name="dialog_button_cancel">Abbrechen</string>
     <string name="dialog_button_ok">OK</string>
     <string name="error_cant_reply_to_tweet">Tweet ist nicht für Antworten freigegeben!</string>

app/src/main/res/values-zh-rCN/strings.xml

@@ -150,7 +150,6 @@
     <string name="error_image_save">无法保存该图片</string>
     <string name="error_not_authorized">未取得授权！</string>
     <string name="error_file_format">不支持该文件格式！</string>
-    <string name="error_request_token">错误，API 密钥已过期！请更新应用！</string>
     <string name="error_empty_name">用户名为空！</string>
     <string name="error_user_not_found">未找到该用户！</string>
     <string name="error_send_dm_to_user">无法给用户发送消息！</string>
@@ -194,8 +193,6 @@
     <string name="menu_user_unfollow">取消关注</string>
     <string name="menu_user_unblock">取消屏蔽</string>
 
-    <string name="dialog_button_yes">是</string>
-    <string name="dialog_button_no">否</string>
     <string name="dialog_button_cancel">取消</string>
     <string name="dialog_button_ok">好的</string>
 </resources>

app/src/main/res/values/strings.xml

@@ -183,7 +183,6 @@
     <string name="error_image_save">could not save Image</string>
     <string name="error_not_authorized">Not authorized!</string>
     <string name="error_file_format">File format not supported!</string>
-    <string name="error_request_token">API Keys are expired! please update app!</string>
     <string name="error_empty_name">Empty user name!</string>
     <string name="error_user_not_found">User not found!</string>
     <string name="error_send_dm_to_user">cannot send dm to user!</string>
@@ -238,8 +237,6 @@
     <string name="menu_add_account">add account</string>
 
     <!--dialog strings-->
-    <string name="dialog_button_yes">Yes</string>
-    <string name="dialog_button_no">No</string>
     <string name="dialog_button_cancel">Cancel</string>
     <string name="dialog_button_ok">OK</string>
     <string name="dialog_link_image_preview">Link preview image</string>