diff --git a/app/src/main/java/org/nuclearfog/twidda/backend/async/StatusLoader.java b/app/src/main/java/org/nuclearfog/twidda/backend/async/StatusLoader.java index 5c729211..b05aa3e9 100644 --- a/app/src/main/java/org/nuclearfog/twidda/backend/async/StatusLoader.java +++ b/app/src/main/java/org/nuclearfog/twidda/backend/async/StatusLoader.java @@ -97,7 +97,7 @@ public class StatusLoader extends AsyncExecutor 0) { if (!status.getReplyName().isEmpty()) replyName.setText(status.getReplyName()); else replyName.setText(R.string.status_replyname_empty); - replyName.setVisibility(VISIBLE); + replyName.setVisibility(View.VISIBLE); } else { - replyName.setVisibility(GONE); + replyName.setVisibility(View.GONE); } if (status.isSensitive()) { - sensitive_media.setVisibility(VISIBLE); + sensitive_media.setVisibility(View.VISIBLE); } else { - sensitive_media.setVisibility(GONE); + sensitive_media.setVisibility(View.GONE); } String profileImageUrl = author.getProfileImageThumbnailUrl(); if (settings.imagesEnabled() && !profileImageUrl.isEmpty()) { @@ -865,37 +845,32 @@ public class StatusActivity extends AppCompatActivity implements OnClickListener } if (location != null) { if (!location.getPlace().isEmpty()) { - locationName.setVisibility(VISIBLE); + locationName.setVisibility(View.VISIBLE); locationName.setText(location.getFullName()); } else { - locationName.setVisibility(GONE); + locationName.setVisibility(View.GONE); } if (!location.getCoordinates().isEmpty()) { - locationButton.setVisibility(VISIBLE); + locationButton.setVisibility(View.VISIBLE); locationButton.setText(location.getCoordinates()); } else { - locationButton.setVisibility(GONE); + locationButton.setVisibility(View.GONE); } } else { - locationName.setVisibility(GONE); - locationButton.setVisibility(GONE); + locationName.setVisibility(View.GONE); + locationButton.setVisibility(View.GONE); } - if (repostButton.getVisibility() != VISIBLE) { - if (settings.getLogin().getConfiguration() == Configuration.MASTODON) { - bookmarkButton.setVisibility(VISIBLE); - } else { - bookmarkButton.setVisibility(GONE); - } - repostButton.setVisibility(VISIBLE); - likeButton.setVisibility(VISIBLE); - replyButton.setVisibility(VISIBLE); + if (repostButton.getVisibility() != View.VISIBLE) { + repostButton.setVisibility(View.VISIBLE); + likeButton.setVisibility(View.VISIBLE); + replyButton.setVisibility(View.VISIBLE); } if ((status.getCards().length > 0 || status.getMedia().length > 0) || status.getPoll() != null) { - cardList.setVisibility(VISIBLE); + cardList.setVisibility(View.VISIBLE); adapter.replaceAll(status); statusText.setMaxLines(5); } else { - cardList.setVisibility(GONE); + cardList.setVisibility(View.GONE); statusText.setMaxLines(10); } } @@ -916,50 +891,50 @@ public class StatusActivity extends AppCompatActivity implements OnClickListener break; case StatusResult.REPOST: - Toast.makeText(getApplicationContext(), R.string.info_status_reposted, LENGTH_SHORT).show(); + Toast.makeText(getApplicationContext(), R.string.info_status_reposted, Toast.LENGTH_SHORT).show(); break; case StatusResult.UNREPOST: - Toast.makeText(getApplicationContext(), R.string.info_status_unreposted, LENGTH_SHORT).show(); + Toast.makeText(getApplicationContext(), R.string.info_status_unreposted, Toast.LENGTH_SHORT).show(); break; case StatusResult.FAVORITE: if (settings.likeEnabled()) - Toast.makeText(getApplicationContext(), R.string.info_status_liked, LENGTH_SHORT).show(); + Toast.makeText(getApplicationContext(), R.string.info_status_liked, Toast.LENGTH_SHORT).show(); else - Toast.makeText(getApplicationContext(), R.string.info_status_favored, LENGTH_SHORT).show(); + Toast.makeText(getApplicationContext(), R.string.info_status_favored, Toast.LENGTH_SHORT).show(); break; case StatusResult.UNFAVORITE: if (settings.likeEnabled()) - Toast.makeText(getApplicationContext(), R.string.info_status_unliked, LENGTH_SHORT).show(); + Toast.makeText(getApplicationContext(), R.string.info_status_unliked, Toast.LENGTH_SHORT).show(); else - Toast.makeText(getApplicationContext(), R.string.info_status_unfavored, LENGTH_SHORT).show(); + Toast.makeText(getApplicationContext(), R.string.info_status_unfavored, Toast.LENGTH_SHORT).show(); break; case StatusResult.BOOKMARK: - Toast.makeText(getApplicationContext(), R.string.info_status_bookmarked, LENGTH_SHORT).show(); + Toast.makeText(getApplicationContext(), R.string.info_status_bookmarked, Toast.LENGTH_SHORT).show(); break; case StatusResult.UNBOOKMARK: - Toast.makeText(getApplicationContext(), R.string.info_status_unbookmarked, LENGTH_SHORT).show(); + Toast.makeText(getApplicationContext(), R.string.info_status_unbookmarked, Toast.LENGTH_SHORT).show(); break; case StatusResult.HIDE: hidden = true; invalidateOptionsMenu(); - Toast.makeText(getApplicationContext(), R.string.info_reply_hidden, LENGTH_SHORT).show(); + Toast.makeText(getApplicationContext(), R.string.info_reply_hidden, Toast.LENGTH_SHORT).show(); break; case StatusResult.UNHIDE: hidden = false; invalidateOptionsMenu(); - Toast.makeText(getApplicationContext(), R.string.info_reply_unhidden, LENGTH_SHORT).show(); + Toast.makeText(getApplicationContext(), R.string.info_reply_unhidden, Toast.LENGTH_SHORT).show(); break; case StatusResult.DELETE: if (status != null) { - Toast.makeText(getApplicationContext(), R.string.info_status_removed, LENGTH_SHORT).show(); + Toast.makeText(getApplicationContext(), R.string.info_status_removed, Toast.LENGTH_SHORT).show(); Intent intent = new Intent(); if (status.getEmbeddedStatus() != null) intent.putExtra(INTENT_STATUS_REMOVED_ID, status.getEmbeddedStatus().getId()); @@ -1014,7 +989,7 @@ public class StatusActivity extends AppCompatActivity implements OnClickListener intent.putExtra(INTENT_NOTIFICATION_REMOVED_ID, notification.getId()); setResult(RETURN_NOTIFICATION_REMOVED, intent); } - Toast.makeText(getApplicationContext(), R.string.info_notification_dismiss, LENGTH_SHORT).show(); + Toast.makeText(getApplicationContext(), R.string.info_notification_dismiss, Toast.LENGTH_SHORT).show(); finish(); break; diff --git a/app/src/main/java/org/nuclearfog/twidda/ui/adapter/holder/StatusHolder.java b/app/src/main/java/org/nuclearfog/twidda/ui/adapter/holder/StatusHolder.java index 13d1847e..729073a1 100644 --- a/app/src/main/java/org/nuclearfog/twidda/ui/adapter/holder/StatusHolder.java +++ b/app/src/main/java/org/nuclearfog/twidda/ui/adapter/holder/StatusHolder.java @@ -42,8 +42,8 @@ import jp.wasabeef.picasso.transformations.RoundedCornersTransformation; */ public class StatusHolder extends ViewHolder implements OnClickListener { - private ImageView profile, rpUser, verifiedIcon, lockedIcon, rtIcon, favIcon, replyIcon; - private TextView username, screenname, text, repost, favorite, reposter, created, replyname, label; + private ImageView profile, repostUserIcon, verifiedIcon, lockedIcon, repostIcon, favoriteIcon, replyStatus; + private TextView username, screenname, text, repost, favorite, reply, reposter, created, replyname, label; private RecyclerView iconList; private GlobalSettings settings; @@ -64,16 +64,17 @@ public class StatusHolder extends ViewHolder implements OnClickListener { profile = itemView.findViewById(R.id.item_status_profile_image); verifiedIcon = itemView.findViewById(R.id.item_status_verified_icon); lockedIcon = itemView.findViewById(R.id.item_status_locked_icon); - rpUser = itemView.findViewById(R.id.item_status_reposter_icon); - rtIcon = itemView.findViewById(R.id.item_status_repost_icon); - favIcon = itemView.findViewById(R.id.item_status_favorite_icon); + repostUserIcon = itemView.findViewById(R.id.item_status_reposter_icon); + repostIcon = itemView.findViewById(R.id.item_status_repost_icon); + favoriteIcon = itemView.findViewById(R.id.item_status_favorite_icon); iconList = itemView.findViewById(R.id.item_status_attachment_list); - replyIcon = itemView.findViewById(R.id.item_status_reply); + replyStatus = itemView.findViewById(R.id.item_status_reply); username = itemView.findViewById(R.id.item_status_author_username); screenname = itemView.findViewById(R.id.item_status_author_screenname); text = itemView.findViewById(R.id.item_status_text); repost = itemView.findViewById(R.id.item_status_repost_count); favorite = itemView.findViewById(R.id.item_status_favorite_count); + reply = itemView.findViewById(R.id.item_status_reply_count); reposter = itemView.findViewById(R.id.item_status_reposter_name); created = itemView.findViewById(R.id.item_status_created_at); replyname = itemView.findViewById(R.id.item_status_reply_name); @@ -83,9 +84,9 @@ public class StatusHolder extends ViewHolder implements OnClickListener { iconList.setAdapter(adapter); if (settings.likeEnabled()) { - favIcon.setImageResource(R.drawable.like); + favoriteIcon.setImageResource(R.drawable.like); } else { - favIcon.setImageResource(R.drawable.favorite); + favoriteIcon.setImageResource(R.drawable.favorite); } AppStyles.setTheme(container, Color.TRANSPARENT); cardLayout.setCardBackgroundColor(settings.getCardColor()); @@ -117,17 +118,18 @@ public class StatusHolder extends ViewHolder implements OnClickListener { if (status.getEmbeddedStatus() != null) { reposter.setText(user.getScreenname()); reposter.setVisibility(View.VISIBLE); - rpUser.setVisibility(View.VISIBLE); + repostUserIcon.setVisibility(View.VISIBLE); status = status.getEmbeddedStatus(); user = status.getAuthor(); } else { reposter.setVisibility(View.GONE); - rpUser.setVisibility(View.GONE); + repostUserIcon.setVisibility(View.GONE); } username.setText(user.getUsername()); screenname.setText(user.getScreenname()); repost.setText(StringTools.NUMBER_FORMAT.format(status.getRepostCount())); favorite.setText(StringTools.NUMBER_FORMAT.format(status.getFavoriteCount())); + reply.setText(StringTools.NUMBER_FORMAT.format(status.getReplyCount())); created.setText(StringTools.formatCreationTime(itemView.getResources(), status.getTimestamp())); if (!status.getText().trim().isEmpty()) { Spanned textSpan = Tagger.makeTextWithLinks(status.getText(), settings.getHighlightColor()); @@ -137,14 +139,14 @@ public class StatusHolder extends ViewHolder implements OnClickListener { text.setVisibility(View.GONE); } if (status.isReposted()) { - rtIcon.setColorFilter(settings.getRepostIconColor()); + repostIcon.setColorFilter(settings.getRepostIconColor()); } else { - rtIcon.setColorFilter(settings.getIconColor()); + repostIcon.setColorFilter(settings.getIconColor()); } if (status.isFavorited()) { - favIcon.setColorFilter(settings.getFavoriteIconColor()); + favoriteIcon.setColorFilter(settings.getFavoriteIconColor()); } else { - favIcon.setColorFilter(settings.getIconColor()); + favoriteIcon.setColorFilter(settings.getIconColor()); } if (user.isVerified()) { verifiedIcon.setVisibility(View.VISIBLE); @@ -164,14 +166,14 @@ public class StatusHolder extends ViewHolder implements OnClickListener { profile.setImageResource(0); } if (status.getRepliedStatusId() > 0) { - replyIcon.setVisibility(View.VISIBLE); + replyStatus.setVisibility(View.VISIBLE); replyname.setVisibility(View.VISIBLE); if (!status.getReplyName().isEmpty()) replyname.setText(status.getReplyName()); else replyname.setText(R.string.status_replyname_empty); } else { - replyIcon.setVisibility(View.GONE); + replyStatus.setVisibility(View.GONE); replyname.setVisibility(View.GONE); } if (settings.statusIndicatorsEnabled()) { diff --git a/app/src/main/java/org/nuclearfog/twidda/ui/fragments/ListFragment.java b/app/src/main/java/org/nuclearfog/twidda/ui/fragments/ListFragment.java index 0beed0b4..2817a72f 100644 --- a/app/src/main/java/org/nuclearfog/twidda/ui/fragments/ListFragment.java +++ b/app/src/main/java/org/nuclearfog/twidda/ui/fragments/ListFragment.java @@ -98,9 +98,7 @@ public abstract class ListFragment extends Fragment implements OnRefreshListener * @param adapter adapter for the list */ protected void setAdapter(Adapter adapter) { - if (list != null) { - list.setAdapter(adapter); - } + list.setAdapter(adapter); } /** diff --git a/app/src/main/res/layout/item_status.xml b/app/src/main/res/layout/item_status.xml index 500b5326..10581fa7 100644 --- a/app/src/main/res/layout/item_status.xml +++ b/app/src/main/res/layout/item_status.xml @@ -185,8 +185,34 @@ android:layout_width="0dp" android:layout_height="@dimen/item_status_icon_size" android:layout_marginTop="@dimen/item_status_layout_margin" + app:layout_constraintHorizontal_weight="2" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toBottomOf="@id/item_status_attachment_list" + app:layout_constraintEnd_toStartOf="@id/item_status_reply_icon" /> + + + + @@ -208,8 +234,9 @@ android:layout_marginEnd="@dimen/item_status_text_margin" android:lines="1" android:textSize="@dimen/item_status_textsize_button" + app:layout_constraintHorizontal_weight="3" app:layout_constraintStart_toEndOf="@id/item_status_repost_icon" - app:layout_constraintTop_toTopOf="@id/item_status_repost_icon" + app:layout_constraintTop_toBottomOf="@id/item_status_attachment_list" app:layout_constraintBottom_toBottomOf="@id/item_status_repost_icon" app:layout_constraintEnd_toStartOf="@id/item_status_favorite_icon" /> @@ -232,8 +259,9 @@ android:layout_marginEnd="@dimen/item_status_text_margin" android:lines="1" android:textSize="@dimen/item_status_textsize_button" + app:layout_constraintHorizontal_weight="3" app:layout_constraintStart_toEndOf="@id/item_status_favorite_icon" - app:layout_constraintTop_toTopOf="@id/item_status_favorite_icon" + app:layout_constraintTop_toBottomOf="@id/item_status_attachment_list" app:layout_constraintEnd_toEndOf="parent" /> diff --git a/app/src/main/res/layout/page_status.xml b/app/src/main/res/layout/page_status.xml index fcdae5a2..02d3405c 100644 --- a/app/src/main/res/layout/page_status.xml +++ b/app/src/main/res/layout/page_status.xml @@ -239,22 +239,6 @@ android:layout_width="match_parent" android:layout_height="400dp"> -