Commit Graph

12 Commits

Author SHA1 Message Date
Nolan Lawson cbbf5abd7a
test: test for DOM listener memory leaks (#1654)
* test: test for DOM listener memory leaks

* fix whitespace change, unintended
2019-11-23 23:42:22 -08:00
Nolan Lawson fec0c282c9
fix: make autosuggest list appear over modal dialog (#1649)
fixes #1645
2019-11-23 13:21:21 -08:00
Nolan Lawson 07facea505
fix: improve autosuggest a11y (#1630)
* fix: improve autosuggest a11y

some progress on #1629

- works in Chrome on NVDA now
- works in Chrome on VoiceOver now
- shorter aria-labels, don't repeat information like "1 of 3", because
it causes the screen reader to speak too frequently, e.g. when the
selected result hasn't changed but the number of results has. Also both
NVDA and VoiceOver already speak this information
- stop doing a fancy fade animation, just show and hide the input
instantly. I worry it confuses screen readers to have the aria-hidden
attribute in there at all
- stop using a single id to identify the active descendant - give
immutable IDs and then update the aria-activedescendant instead. I think
this is what fixed Chrome.

* fix test
2019-11-09 20:38:29 -05:00
Nolan Lawson fbed5b8ac8
fix: improve autosuggest styles on small screens (#1529) 2019-09-24 00:50:25 -07:00
Nolan Lawson 8f3b0ac80a
fix: remove aria-live region for autosuggest (#1520) 2019-09-22 23:53:09 -07:00
Nolan Lawson 4232da5e33 fix: fix lint 2019-08-19 20:23:58 -07:00
Nolan Lawson cef76e6bba
fix: fix flash of searched content in autosuggest (#1188) 2019-05-06 08:34:20 -07:00
Nolan Lawson 2abe15cc6f
fix: fix autosuggest width on mobile (#1186)
fixes #1185
2019-05-06 08:34:03 -07:00
Nolan Lawson 8d0db2c97c
fix: make autosuggestion accessible (#1183)
* fix: make autosuggestion accessible

fixes #129

* remove tabindexes, fix aria-hidden
2019-05-05 22:08:54 -07:00
sgenoud 79184570b1 fix: Manage the width to take scrollbars into account (#1138)
* Manage the width to take scrollbars into account

* Additional modal layout styles changes
2019-04-13 11:02:25 -07:00
Nolan Lawson e666eb5955
perf: use lodash-lite for some functions (#853) 2018-12-23 10:10:16 -08:00
Nolan Lawson 4bd181d3cc
fix: update Sapper to latest (#775)
* fix: update to latest sapper

fixes #416

* fix error and debug pages

* requestIdleCallback makes column switching feel way nicer than double rAF

* add export feature

* add better csp info

* workaround for sapper sub-page issue

* clarify in readme about exporting

* fix now config

* switch from rIC to triple raf

* style-loader is no longer used

* update theming guide
2018-12-11 07:31:48 -08:00