* Add setting to control share button default behavior
This adds a setting to control the behavior of the share button on the status row actions view.
Currently, it always shares the link to the post as well as the post text.
In iOS 16.4, Apple added iMessage unfurling for Mastodon URLs.
When sharing posts from Ice Cubes via iMessage, this leads to the recipient seeing two copies of the post: one from the unfurled link and one from Ice Cubes including the post text.
Users will now have the option to exclude the post text from their sharing.
This is easier than tapping the 3-dots button on the post (which is kind of small) and then expanding the Share menu in the context menu, which is the other way to access this functionality at the
moment.
The default value for the new option will be "Link and Text", which is the current behavior - so we won't change the behavior on existing users.
* Add new strings to other language localizations
* Fix the lag of the display setting sliders
The sliders in the display settings were laggy because changing the value in the
theme class needs comparatively much time. This writing to the class is now
only done when the user lets go of the slider, so sliding it is responsive. I
was unable to make writing to the class more responsive, the example post needs
therefore a short time before it accepts the new values. Furthermore, all
AppStorage keys are now realized with a ThemeKey to clean the class up.
Fixes#1341
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
* Remove unnecessary changes to theme
The changing of theme keys is unnecessary for the fix oft the lag, so it's
removed.
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
* Rework fix to be more similar to other lag fixes
The fix now uses the ...LocalValues class, which published updates only every
half a second.
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
---------
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
The switching of icons didn't work on the iPad anymore (See
https://norden.social/@betamax65/110088664994961476). This might be a temporary
fix, depending on what caused the bug (which I couldn't determine). For now,
one icon in the set seemingly must have a complete iPad icon set, which is
achieved with the standard icon. Furthermore, an assert statement helps to
determine the problem with the icons. This statement won't be compiled into
release builds.
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
* Improve StatusRowView accessibility actions
Previously, there was no way to interact with links and hashtags.
Now, these are added to the Actions rotor
* Hide `topPaddingView`s from accessibility
* Fix accessible header rendering in non-filterable TimelineViews
Previously, all navigation title views were assumed to be popup buttons.
Now, we only change the representation for timelines that are filterable.
* Combine tagHeaderView text elements
Previously, these were two separate items
* Prefer shorter Quote action label
* Improve accessibility of StatusEmbeddedView
Previously, this element would be three different ones, and include all the actions on the `StatusRowView` proper. Now, it presents as one element with no actions.
* Add haptics to StatusRowView accessibility actions
* Improve accessibility of ConversationsListRow
This commit adds:
- A combined representation of the component views
- “Unread” as the first part of the label (if this is the case)
- All relevant actions as custom actions
- Reply as magic tap
* Remove StatusRowView accessibilityActions if viewModel.showActions is false
* Hide media attachments from accessibility if the view is not focused
* Combine NotificationRowView accessibility elements; add user actions
Previously, there was no real way to interact with these notifications.
Now, the notifications that show the actions row have the appropriate StatusRowView-derived actions, and new followers notifications have more actions that let you see each user’s profile.
* Prefer @Environment’s `accessibilityEnabled` over `isVoiceOverRunning`
This way we can cater for Voice Control, Full Keyboard Access and Switch Control as well.
---------
Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>
* Remove `.button` trait from `Link`s on Account Settings screen
SwiftUI currently sets both the `.button` and `.link` traits on these elements, which is a failure for WCAG 2.1 4.12: Name, Role, Value: https://www.w3.org/WAI/WCAG21/Understanding/name-role-value.html
There is a radar for this issue: FB11507660
* Improve accessibility by making `AppAccountView`s a Button
Previously, the component elements of the `fullView` would be rendered as 3-4 individual views that would _all_ be interactive and perform the same action.
Now, as a Button, only one accessibility element is vended.
* Fix account label color
---------
Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>
* Allow forced translation with DeepL
Translation with DeepL can now be forced either per post or on the system level.
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
* Require the use of a private API key
A private API key of the user is now required to allow "always translate via
DeepL".
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
* Persist a stored API key
An API key is stored even if useOnlyDeepL is disabled. If the API key is empty,
the setting is still disabled.
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
* Localize the texts
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
* Save API key while writing
The API key is now saved, even if the app is closed before leaving the
translation settings view.
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
* Fix build
* Fix theme
* Transition to KeychainSwift, clean up
KeychainHelper is replaced with the already-used KeychainSwift package, the
functions are cleaned up so that the process is easier to understand. The
deactivateToggleIfNoKey function doesn't change the behavior of the buttons or
context menus in the timeline, only demonstrates the necessity of an API key to
the user. Consequently, it's only called when the settings view is shown.
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
* Swiftformat + fixes
---------
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>
* Change arrows icon to rocket for boosts
* Fixing case (part 1)
* Fixing Case (part 2)
* Clean up after merge
* Fix for disabled boost
* Fixes
---------
Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>
* collapse long posts
* initialize user pref setting in init(), remove onAppear and onChange(pref) from view
---------
Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>
* Redesigned Swipe Action Settings screen
* Add TODO comments
* Redesigned Swipe Action Settings screen
* Redesigned Swipe Action Settings screen
* Add EN localization strings for primary/secondary
* Consolidate left/right swipe actions into one section
* Switch to targeted Swift concurrency warnings + fix them
* Polish localization update (#936)
* Updates to Dutch localization: (#935)
* de: translated the notes feature (#933)
* Fix 1 line note in centre (#938)
* Sort lists alphabetically in ListAddAccountView (#943)
* Optimize viewId (#942)
* Update Localizable.strings (#941)
Co-authored-by: Yusuke Arakawa <nekolaboratory@users.noreply.github.com>
* Update Nuke (#940)
* Remove Sendable conformance on Client as it's not needed
* Profile: Show about fields inline
* Added a tip that it's a video, and not an image when autoplay is off (#939)
* Added a tip that it's a video, and not an image when autoplay is off
* Centered - bigger version of the video tip
* Share post as image close#885
* Honour in app browser settings when opening profile about fields
* Fix threading UI
* More tweak to capture mode
* Update Localizable.strings (#948)
* Update Localizable.strings (#946)
Translated..
* Updated EmojiText to 2.x (#944)
Interface used by IceCubeApp has not changed from 1.x to 2.x
Looking at the library diff shows new features like SFSymbol powered emojis. Not like we're going to make use of that
https://github.com/divadretlaw/EmojiText/compare/v1.2.0...2.0.2
* Bump to 1.5.5
* Polish localization update (#949)
* Optimize avatar view (#950)
* Reduce AvatarPlaceholderView body calls
* Resize avatars
* Reworked post header view + add option to hide server name from username
* Better header spacing
* Further improvement to the post header
* Polish localization update (#954)
* Update Localizable.strings (#953)
* Show post header thread icon more consistently
* Fix post header
* Fix threading UI
* Fix trending refresh
* de: 1 new string -> translated (#955)
* Update Simplified Chinese Translation (#926)
* Update Korean localization (#957)
* Trim whitespace and newlines in instance rules list (#956)
* Fix theme not being applied live on status row close#961
* Update some translations (#959)
* Add indicator for bots accounts
* Bump to 1.5.6
* Fix status actions on boosting posts (#974)
* Fix context menus for boosts
* Allow my boost of my followers-only post
* Disable boost context menu on posts can't be boosted and show different string for boosting my own private post
* Localizations
* CR
---------
Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>
* Fix crash when opening account details (#972) close#918
* Tweak the theme selector view (#975)
Co-authored-by: Yusuke Arakawa <nekolaboratory@users.noreply.github.com>
* Change the Content Settings icon to match the timeline icon again. (#969)
* Fix display of multiple vote polls (#967)
Closes#952
* Updates to Dutch localization (#966)
* Font picker consistency (#960)
* Put SF Rounded into the popup menu with Hyperlegible & Dislexia
* Remove SF Rounded Toggle
* Fix In-App Safari (#945)
* Fix In-App Safari
* Open SFSafariViewController in a separate window
* Swiftformat
* Optimize custom font
* Fix a localization + make the ... menu zone bigger
* Update Localizable.strings (#976)
* Fix Equatable impl for Status and Account (thanks class)
* Make secondary column available on any size + add a toggle + faster macOS window resize
* Bigger secondary column width
* Composer: Fix swipe to dismiss
* Composer: Better ALT editing UI
* updates for Basque (#983)
added missing translations and small fixes
* Updated spanish localization (#982)
Co-authored-by: Roberto Pastor <roberto.pastor@cabify.com>
* Polish localization update (#980)
* Update Localizable.strings (#979)
More strings
* Singularize enum type names (#978)
* Fixes for composer and DM
* Remove padding
* Rename settings.swipeactions.status.icon-style
* Remove unused left/right localizable strings
* Add settings.swipeactions.appearance
* Add settings.swipeactions.status.explanation
* Add settings.swipeactions.primary and settings.swipeactions.secondary
* Add settings.swipeactions.use-theme-colors and settings.swipeactions.use-theme-colors-explanation
* Dutch localization update
---------
Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>
Co-authored-by: Andrzej Rózga <53080024+AndrzejRozga@users.noreply.github.com>
Co-authored-by: Cthulhux <github@tuxproject.de>
Co-authored-by: Sean Goldin <EvilOne@users.noreply.github.com>
Co-authored-by: David Davies-Payne <d2p@me.com>
Co-authored-by: Alex Grebenyuk <grebenyuk.alexander@gmail.com>
Co-authored-by: Yusuke Arakawa <108506642+nekolaboratory@users.noreply.github.com>
Co-authored-by: Yusuke Arakawa <nekolaboratory@users.noreply.github.com>
Co-authored-by: Thomas Durand <Dean151@users.noreply.github.com>
Co-authored-by: Dejavu Moe <jialong.vip@gmail.com>
Co-authored-by: Chanhwi Joo <56245920+te6-in@users.noreply.github.com>
Co-authored-by: Henrik Nyh <henrik@nyh.se>
Co-authored-by: nixzhu <zhuhongxu@gmail.com>
Co-authored-by: Gareth Simpson <g@xurble.org>
Co-authored-by: Peter-Josef Meisch <pj.meisch@sothawo.com>
Co-authored-by: David Walter <divadretlaw@users.noreply.github.com>
Co-authored-by: Xabi <xabi.rn@gmail.com>
Co-authored-by: Roberto Pastor <wedge.hero@gmail.com>
Co-authored-by: Roberto Pastor <roberto.pastor@cabify.com>
Co-authored-by: Louis Lac <lac.louis5@gmail.com>
