* Combine `joinedAtView` into one accessibility element
Previously, the calendar image was visible with a nonsensical label.
We use the `.combine` operator here to maintain the proper string formatting of the date.
* Improve the accessibility of the AccountDetailHeaderView
Previously, this image had no description and no indication that it had an associated interaction. Now, we wrap it in a button that performs the tap gesture action, and remove the element altogether if there is no avatar image set.
This commit also handles the checkmark for supporter users
* Tweak accessibility of Profile CustomInfoLabels
This commit:
- Reverses the order of title and value
- Sets the value as an `accessibilityValue`
- Adds a hint indicating what the button does, as they perform slightly different actions
* Make Profile tab header image into a Button
This element has an action associated with it (quicklook), so it makes more sense to have it as a button, and hide it if the user does not have an image set.
Without the action it would have been considered decorative and should be hidden.
* Change accessibilityLabel of Profile tab nav bar item to ‘Options’
“More” is considered overly generic.
This commit also adds two additional user input label options
* Add accessibility labels for the Profile tab `Picker`
Previously, these labels were the default accessibility label provided by the SF symbol, that almost, but not quite, made sense
* Remove StatusRowView swipe actions if VoiceOver is running
These swipe actions are automagically added to the accessibility element’s custom actions, in addition to the ones already there, which means that there is a significant (and confusing) amount of doubling up going on.
* Fix typo in StatusRowView.accessibilityActions
* Add accessibilityLabels to all StatusRowActionsView actions
* Provide explicit combined accessibility label for unfocused StatusRowView
Previously, this was a synthesized label, which read the elements in their traversal order, and didn’t provide any context for which of the three numbers corresponded to replies, boosts or favourites.
Now, we create an explicit combined label when the post isn’t being viewed by itself.
* Improve accessibility of StatusRow(Reblog|Reply)View
They are now combined elements and don’t vend the icon as its own element.
* Add missing punctuation to accessibility hints
* Remove interaction from Profile tab @username and profile note elements
These elements open the profile photo url, which is already provided explicitly through the profile photo
* Prefer spoiler warning for StatusRowView accessibility label
…but place the full, unredacted content in an `AccessibilityCustomContent` field for easy access.
Additionally, if VoiceOver is running, an action to expand the warning is also available.
* Represent `FollowButton` elements as Toggles to accessibility
Since these buttons have two states (though arguable in the case of following, but handled here by not changing the representation if a request is pending), it makes sense to handle them as toggles, so they will be read as “Following, On, <Trait>”
* Remove errant comment
* Add “Verified” accessibilityValue to profile fields
* Fix bug StatusRowView default action bug affecting VoiceOver users
Previously, the default (‘Activate’) action for VoiceOver users would be to share a link to the toot, rather than navigate to its detail. It’s hard to say exactly what caused this, but the root was the inclusion of the `contextMenu` in the `accessibilityActions`.
Now, double-tapping on a a non-focused `StatusRowView` will take you to the toot detail.
* Add header trait to Profile tab display name and familiar followers
These stand out as being header-like in presentation and represent the beginning of specific parts of the screen.
* Add conditional accessibility modifier to Profile tab user-defined fields that opens the correct link
* Add accessibility container that contextualises the user-defined fields
When VoiceOver users first enter a user-defined field, the container label will be read out before the element’s spoken description.
* Improve StatusRowView combined accessibility label
It will now start with:
“X boosted Y”, “X replied to @Y”, or “X…” depending on the context of the toot.
* Change familiar follows thumbnail to a Button; add display name as accessibility label
Previously, this button had no context, and would just be a series of images with nothing to allow users to disambiguate them.
* Revert changes from ZStack with tap gesture to Button
Using a Button for this purpose caused high weirdness in tap zones. Basically everything down to the familiar followers triggered both image buttons.
* Add image alt text to StatusRowView and StatusRowMediaPreviewView
Previously, there was no way for the intended audience for the alt text to find said text. There is a tap gesture on each image in the focused status row, but this is not advertised to the user.
Now, the first image’s alt text is read as part of the non-focused, combined representation, and each image has its own alt text attributed in the focused representation.
* Add Profile tab accessibility labels to indicate private/bot/muted/blocked accounts
Previously, the icon did not have any accessible representation (an empty text string).
* Add header trait to Profile “pinned post”
* Use the Account.Field.name for the user input label
* Replace spaces with commas in StatusRowView.combinedAccessibilityLabel
* Add localized label for the AI prompt status accessory view
Previously, this icon would have an accessibility label matching its SF symbol key, ‘faxmachine’.
* Darken status editor character count foreground color
By changing it to .secondary, it gets to an APCA contrast of 61, which is a _just_ passing Bronze score for that text size.
It’s still quite short of WCAG 2.1 AA at 3.3:1 (recommended is 4.5:1)
* Change remaining character count color to red when < 0
* Refine remaining character count accessibility
In this commit, we
- Change its trait to `.updatesFrequently`
- Set a localized `accessibilityLabel`
- Set its `accessibilityValue` to the remaining character count
- Disable user interaction (which is presumably set automatically by virtue of being enclosed in a `Menu`)
* Set accessibilitySortPriority on Status editor ScrollView
Previously, the traversal order placed the elements inside the `ScrollView` last. Now, they follow on from the navigation bar contents in the expected order.
* Hide the AvatarView from status creation accessibility
When there is only one account available, there is no functionality associated with this element, so it is considered decorative-only, and should be hidden
* Set TextView placeholder’s `accessibilityValue` to placeholder text when empty
This behaviour matches `UITextField`
* Hide TextView custom `placeholderView` from accessibility
Previously, TextView would vend two accessibility elements when the placeholder was visible. This causes needless confusion for users.
Now, the TextView matches the accessible behaviour of text inputs elsewhere.
* Improve accessibility of post `privacyMenu`
Previously, it would be presented as `Everyone, Button`. Now, we move the visibility to its `value` and use `Visibility` for its label, in conjunction with a hint that states it `Changes post audience`.
* Add `.button` trait and accessible label to emojis in `customEmojisSheet`
Previously, these would all present as `image` with no description, making it very hard to discern what kind of emoji you were adding.
* Change drafts sheet item type to `Button`
A button with an action has a more accessible representation than a `Text` with a tap gesture.
* Allow forced translation with DeepL
Translation with DeepL can now be forced either per post or on the system level.
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
* Require the use of a private API key
A private API key of the user is now required to allow "always translate via
DeepL".
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
* Persist a stored API key
An API key is stored even if useOnlyDeepL is disabled. If the API key is empty,
the setting is still disabled.
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
* Localize the texts
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
* Save API key while writing
The API key is now saved, even if the app is closed before leaving the
translation settings view.
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
* Fix build
* Fix theme
* Transition to KeychainSwift, clean up
KeychainHelper is replaced with the already-used KeychainSwift package, the
functions are cleaned up so that the process is easier to understand. The
deactivateToggleIfNoKey function doesn't change the behavior of the buttons or
context menus in the timeline, only demonstrates the necessity of an API key to
the user. Consequently, it's only called when the settings view is shown.
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
* Swiftformat + fixes
---------
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>
* Fixed problem with with the translation of "mentions" in plural form
- Localizable.stringsdict needs a digit (not string) to make a choice of a correct plural form.
- fixed StatusEditorAutoCompleteView
- changed %@ format specifier in Localizable.strings with %lld
* Polish localization update
---------
Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>
* collapse long posts
* initialize user pref setting in init(), remove onAppear and onChange(pref) from view
---------
Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>
* Enhance the message context menu
A direct message can now directly be bookmarked, the author can be publicly
mentioned and reported.
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
* Add options to the conversation list context menu
Since the latest message is shown in the conversation list, the user can now
interact with this message via the context menu similar to the messages in the
conversation history.
The "conversation" class had to be modified since
bookmarking and liking a message would have led to a race condition (depending
on the server) when fetching the conversations afterwards, so the only affected
the message is now immediately updated.
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
* Remove child view models
The child views models are removed, and the list row now only uses the conversation
object managed by the list view model.
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
* Make unmodified var let
The last state-var of a conversation isn't modified, instead, a new conversation
is created. Therefore, the var is now a let.
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
---------
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
* Clear up the translate-button
The Translate button on the post and in the context menu now does not show the
source language to avoid user confusion if the language set by the poster is
not the actual language of the post. This language is now only used to decide
whether to display the button in the main view. The Translate button in the
context menu is independent.
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
* Show the translation-source-language
The source-language of a translation is now shown.
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
* Remove unused strings
The now unused translate-from-strings are removed.
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
---------
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>
* Redesigned Swipe Action Settings screen
* Add TODO comments
* Redesigned Swipe Action Settings screen
* Redesigned Swipe Action Settings screen
* Add EN localization strings for primary/secondary
* Consolidate left/right swipe actions into one section
* Switch to targeted Swift concurrency warnings + fix them
* Polish localization update (#936)
* Updates to Dutch localization: (#935)
* de: translated the notes feature (#933)
* Fix 1 line note in centre (#938)
* Sort lists alphabetically in ListAddAccountView (#943)
* Optimize viewId (#942)
* Update Localizable.strings (#941)
Co-authored-by: Yusuke Arakawa <nekolaboratory@users.noreply.github.com>
* Update Nuke (#940)
* Remove Sendable conformance on Client as it's not needed
* Profile: Show about fields inline
* Added a tip that it's a video, and not an image when autoplay is off (#939)
* Added a tip that it's a video, and not an image when autoplay is off
* Centered - bigger version of the video tip
* Share post as image close#885
* Honour in app browser settings when opening profile about fields
* Fix threading UI
* More tweak to capture mode
* Update Localizable.strings (#948)
* Update Localizable.strings (#946)
Translated..
* Updated EmojiText to 2.x (#944)
Interface used by IceCubeApp has not changed from 1.x to 2.x
Looking at the library diff shows new features like SFSymbol powered emojis. Not like we're going to make use of that
https://github.com/divadretlaw/EmojiText/compare/v1.2.0...2.0.2
* Bump to 1.5.5
* Polish localization update (#949)
* Optimize avatar view (#950)
* Reduce AvatarPlaceholderView body calls
* Resize avatars
* Reworked post header view + add option to hide server name from username
* Better header spacing
* Further improvement to the post header
* Polish localization update (#954)
* Update Localizable.strings (#953)
* Show post header thread icon more consistently
* Fix post header
* Fix threading UI
* Fix trending refresh
* de: 1 new string -> translated (#955)
* Update Simplified Chinese Translation (#926)
* Update Korean localization (#957)
* Trim whitespace and newlines in instance rules list (#956)
* Fix theme not being applied live on status row close#961
* Update some translations (#959)
* Add indicator for bots accounts
* Bump to 1.5.6
* Fix status actions on boosting posts (#974)
* Fix context menus for boosts
* Allow my boost of my followers-only post
* Disable boost context menu on posts can't be boosted and show different string for boosting my own private post
* Localizations
* CR
---------
Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>
* Fix crash when opening account details (#972) close#918
* Tweak the theme selector view (#975)
Co-authored-by: Yusuke Arakawa <nekolaboratory@users.noreply.github.com>
* Change the Content Settings icon to match the timeline icon again. (#969)
* Fix display of multiple vote polls (#967)
Closes#952
* Updates to Dutch localization (#966)
* Font picker consistency (#960)
* Put SF Rounded into the popup menu with Hyperlegible & Dislexia
* Remove SF Rounded Toggle
* Fix In-App Safari (#945)
* Fix In-App Safari
* Open SFSafariViewController in a separate window
* Swiftformat
* Optimize custom font
* Fix a localization + make the ... menu zone bigger
* Update Localizable.strings (#976)
* Fix Equatable impl for Status and Account (thanks class)
* Make secondary column available on any size + add a toggle + faster macOS window resize
* Bigger secondary column width
* Composer: Fix swipe to dismiss
* Composer: Better ALT editing UI
* updates for Basque (#983)
added missing translations and small fixes
* Updated spanish localization (#982)
Co-authored-by: Roberto Pastor <roberto.pastor@cabify.com>
* Polish localization update (#980)
* Update Localizable.strings (#979)
More strings
* Singularize enum type names (#978)
* Fixes for composer and DM
* Remove padding
* Rename settings.swipeactions.status.icon-style
* Remove unused left/right localizable strings
* Add settings.swipeactions.appearance
* Add settings.swipeactions.status.explanation
* Add settings.swipeactions.primary and settings.swipeactions.secondary
* Add settings.swipeactions.use-theme-colors and settings.swipeactions.use-theme-colors-explanation
* Dutch localization update
---------
Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>
Co-authored-by: Andrzej Rózga <53080024+AndrzejRozga@users.noreply.github.com>
Co-authored-by: Cthulhux <github@tuxproject.de>
Co-authored-by: Sean Goldin <EvilOne@users.noreply.github.com>
Co-authored-by: David Davies-Payne <d2p@me.com>
Co-authored-by: Alex Grebenyuk <grebenyuk.alexander@gmail.com>
Co-authored-by: Yusuke Arakawa <108506642+nekolaboratory@users.noreply.github.com>
Co-authored-by: Yusuke Arakawa <nekolaboratory@users.noreply.github.com>
Co-authored-by: Thomas Durand <Dean151@users.noreply.github.com>
Co-authored-by: Dejavu Moe <jialong.vip@gmail.com>
Co-authored-by: Chanhwi Joo <56245920+te6-in@users.noreply.github.com>
Co-authored-by: Henrik Nyh <henrik@nyh.se>
Co-authored-by: nixzhu <zhuhongxu@gmail.com>
Co-authored-by: Gareth Simpson <g@xurble.org>
Co-authored-by: Peter-Josef Meisch <pj.meisch@sothawo.com>
Co-authored-by: David Walter <divadretlaw@users.noreply.github.com>
Co-authored-by: Xabi <xabi.rn@gmail.com>
Co-authored-by: Roberto Pastor <wedge.hero@gmail.com>
Co-authored-by: Roberto Pastor <roberto.pastor@cabify.com>
Co-authored-by: Louis Lac <lac.louis5@gmail.com>
* Fix context menus for boosts
* Allow my boost of my followers-only post
* Disable boost context menu on posts can't be boosted and show different string for boosting my own private post
* Localizations
* CR
---------
Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>
* Remove icons from settings
* Add new toggle for using the theme tint
* Localizations
* Add icon style picker
* Localizations
---------
Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>
- added missing string for "Official icons"
- added missing string for "Icons by ..."
- added String extension in IconSelectorView.swift
(maybe you prefer it in separate file)
Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>
* Use language detection to translate posts
The source language of a post is now determined via Apples internal language
detection, translation from the transmitted language is still possible.
* Make language detection posting more accessible
Language recognition is now always applied before posting, even if the user has
explicitly selected a different language. However, the user is always asked in
which of the two languages he wants to post.
* Add localizations
* Remove language detection in the timeline for now
The language detection in the timeline is for now removed to increase
timeline-performance.
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
* Show translate button even if no language is sent
The translate-button is shown even if no language is sent with the post.
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
* Adjust to new commits on main
Adjustments are made in regards to new developments on main.
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
---------
Signed-off-by: Paul Schuetz <pa.schuetz@web.de>
Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>
* Remove an unnecessary space from string
settings.swipeactions.status.trailing
* Make SwipeActionsSettingsView to be consistent with others
* Divide none as another section
* Add icons
* Make hollow icons work
* Show different button label by its status
* Use different colors by actions
* Fix swapped icons in settings
* Refactor
* swipe actions improvements
* use old values as default settings
* Polish swipe actions settings
* Fix background color
---------
Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>
* Add a preview toot tot the top of the display settings page.
* DisplayModel doesn't need to be @State
* Disable hitTest
* Example Post
---------
Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>
* Show confirmation dialog when deleting post
* Localization
* Fixes
---------
Co-authored-by: Yusuke Arakawa <nekolaboratory@users.noreply.github.com>
Co-authored-by: Thomas Ricouard <ricouard77@gmail.com>
Chris Kolbu
Chris Kolbu
Ico Davids
Paul Schuetz
Thomas Ricouard
Andrzej Rózga
Stian Øverbye
Peter-Josef Meisch
Gareth Simpson
Chanhwi Joo
Quin
Rainer Martinez
Yusuke Arakawa