From b3919702e098a3850998b9f5b2bc60b3f86b082d Mon Sep 17 00:00:00 2001 From: Ico Davids Date: Tue, 7 Mar 2023 18:23:38 +0100 Subject: [PATCH] Outlined icons in status editor (#1194) --- .../Editor/Components/StatusEditorAccessoryView.swift | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Packages/Status/Sources/Status/Editor/Components/StatusEditorAccessoryView.swift b/Packages/Status/Sources/Status/Editor/Components/StatusEditorAccessoryView.swift index 80f86215..4da3e5c2 100644 --- a/Packages/Status/Sources/Status/Editor/Components/StatusEditorAccessoryView.swift +++ b/Packages/Status/Sources/Status/Editor/Components/StatusEditorAccessoryView.swift @@ -9,6 +9,7 @@ struct StatusEditorAccessoryView: View { @EnvironmentObject private var preferences: UserPreferences @EnvironmentObject private var theme: Theme @EnvironmentObject private var currentInstance: CurrentInstance + @Environment(\.colorScheme) private var colorScheme @FocusState.Binding var isSpoilerTextFocused: Bool @ObservedObject var viewModel: StatusEditorViewModel @@ -30,7 +31,7 @@ struct StatusEditorAccessoryView: View { if viewModel.isMediasLoading { ProgressView() } else { - Image(systemName: "photo.fill.on.rectangle.fill") + Image(systemName: "photo.on.rectangle.angled") } } .accessibilityLabel("accessibility.editor.button.attach-photo") @@ -70,7 +71,10 @@ struct StatusEditorAccessoryView: View { Button { isCustomEmojisSheetDisplay = true } label: { - Image(systemName: "face.smiling.inverse") + // This is a workaround for an apparent bug in the `face.smiling` SF Symbol. + // See https://github.com/Dimillian/IceCubesApp/issues/1193 + let customEmojiSheetIconName = colorScheme == .light ? "face.smiling" : "face.smiling.inverse" + Image(systemName: customEmojiSheetIconName) } .accessibilityLabel("accessibility.editor.button.custom-emojis") }