From 921d28a57aa8e9e96b9324aaf13c435fad456921 Mon Sep 17 00:00:00 2001 From: Thomas Ricouard Date: Sun, 22 Jan 2023 09:15:01 +0100 Subject: [PATCH] Add setting to hide translate button close #252 --- IceCubesApp/App/Tabs/Settings/DisplaySettingsView.swift | 1 + .../Resources/Localization/de.lproj/Localizable.strings | 1 + .../Resources/Localization/en.lproj/Localizable.strings | 1 + .../Resources/Localization/es.lproj/Localizable.strings | 1 + .../Resources/Localization/it.lproj/Localizable.strings | 1 + .../Resources/Localization/nl.lproj/Localizable.strings | 1 + .../Resources/Localization/zh-Hans.lproj/Localizable.strings | 1 + Packages/Env/Sources/Env/UserPreferences.swift | 1 + Packages/Status/Sources/Status/Row/StatusRowView.swift | 4 +++- 9 files changed, 11 insertions(+), 1 deletion(-) diff --git a/IceCubesApp/App/Tabs/Settings/DisplaySettingsView.swift b/IceCubesApp/App/Tabs/Settings/DisplaySettingsView.swift index de0a37a4..f240576b 100644 --- a/IceCubesApp/App/Tabs/Settings/DisplaySettingsView.swift +++ b/IceCubesApp/App/Tabs/Settings/DisplaySettingsView.swift @@ -50,6 +50,7 @@ struct DisplaySettingsView: View { .font(.scaledBody) } } + Toggle("settings.display.translate-button", isOn: $userPreferences.showTranslateButton) } .listRowBackground(theme.primaryBackgroundColor) diff --git a/IceCubesApp/Resources/Localization/de.lproj/Localizable.strings b/IceCubesApp/Resources/Localization/de.lproj/Localizable.strings index b65f4a8b..e6f1b8d1 100644 --- a/IceCubesApp/Resources/Localization/de.lproj/Localizable.strings +++ b/IceCubesApp/Resources/Localization/de.lproj/Localizable.strings @@ -58,6 +58,7 @@ "settings.display.section.theme" = "Thema"; "settings.display.status.action-buttons" = "Status Aktions-Buttons"; "settings.display.status.media-style" = "Status Medien"; +"settings.display.translate-button" = "Show translate button"; "settings.display.theme.background" = "Hintergrundfarbe"; "settings.display.theme.secondary-background" = "Sekundäre Hintergrundfarbe"; "settings.display.theme.tint" = "Akzentfarbe"; diff --git a/IceCubesApp/Resources/Localization/en.lproj/Localizable.strings b/IceCubesApp/Resources/Localization/en.lproj/Localizable.strings index 4c419c7c..2d78f59f 100644 --- a/IceCubesApp/Resources/Localization/en.lproj/Localizable.strings +++ b/IceCubesApp/Resources/Localization/en.lproj/Localizable.strings @@ -58,6 +58,7 @@ "settings.display.section.theme" = "Theme"; "settings.display.status.action-buttons" = "Status action buttons"; "settings.display.status.media-style" = "Status media style"; +"settings.display.translate-button" = "Show translate button"; "settings.display.theme.background" = "Background color"; "settings.display.theme.secondary-background" = "Secondary Background color"; "settings.display.theme.tint" = "Tint color"; diff --git a/IceCubesApp/Resources/Localization/es.lproj/Localizable.strings b/IceCubesApp/Resources/Localization/es.lproj/Localizable.strings index aca73704..2c40bc7c 100644 --- a/IceCubesApp/Resources/Localization/es.lproj/Localizable.strings +++ b/IceCubesApp/Resources/Localization/es.lproj/Localizable.strings @@ -58,6 +58,7 @@ "settings.display.section.theme" = "Tema"; "settings.display.status.action-buttons" = "Botones de acción"; "settings.display.status.media-style" = "Estilo del contenido multimedia"; +"settings.display.translate-button" = "Show translate button"; "settings.display.theme.background" = "Color de fondo"; "settings.display.theme.secondary-background" = "Color de fondo secundario"; "settings.display.theme.tint" = "Color"; diff --git a/IceCubesApp/Resources/Localization/it.lproj/Localizable.strings b/IceCubesApp/Resources/Localization/it.lproj/Localizable.strings index 3ebcaa63..98923faf 100644 --- a/IceCubesApp/Resources/Localization/it.lproj/Localizable.strings +++ b/IceCubesApp/Resources/Localization/it.lproj/Localizable.strings @@ -58,6 +58,7 @@ "settings.display.section.theme" = "Tema"; "settings.display.status.action-buttons" = "Bottoni di azione"; "settings.display.status.media-style" = "Stile dei media"; +"settings.display.translate-button" = "Show translate button"; "settings.display.theme.background" = "Colore di sfondo"; "settings.display.theme.secondary-background" = "Colore di sfondo secondario"; "settings.display.theme.tint" = "Colore"; diff --git a/IceCubesApp/Resources/Localization/nl.lproj/Localizable.strings b/IceCubesApp/Resources/Localization/nl.lproj/Localizable.strings index ee9ecd48..d0b807ed 100644 --- a/IceCubesApp/Resources/Localization/nl.lproj/Localizable.strings +++ b/IceCubesApp/Resources/Localization/nl.lproj/Localizable.strings @@ -58,6 +58,7 @@ "settings.display.section.theme" = "Thema"; "settings.display.status.action-buttons" = "Actieknoppen"; "settings.display.status.media-style" = "Mediastijl"; +"settings.display.translate-button" = "Show translate button"; "settings.display.theme.background" = "Achtergrondkleur"; "settings.display.theme.secondary-background" = "Secundaire achtergrondkleur"; "settings.display.theme.tint" = "Kleurtint"; diff --git a/IceCubesApp/Resources/Localization/zh-Hans.lproj/Localizable.strings b/IceCubesApp/Resources/Localization/zh-Hans.lproj/Localizable.strings index bcea18ba..362f1535 100644 --- a/IceCubesApp/Resources/Localization/zh-Hans.lproj/Localizable.strings +++ b/IceCubesApp/Resources/Localization/zh-Hans.lproj/Localizable.strings @@ -58,6 +58,7 @@ "settings.display.section.theme" = "主题"; "settings.display.status.action-buttons" = "状态操作选项"; "settings.display.status.media-style" = "状态媒体样式"; +"settings.display.translate-button" = "Show translate button"; "settings.display.theme.background" = "背景颜色"; "settings.display.theme.secondary-background" = "二级背景颜色"; "settings.display.theme.tint" = "色调"; diff --git a/Packages/Env/Sources/Env/UserPreferences.swift b/Packages/Env/Sources/Env/UserPreferences.swift index 9a1b1a55..d4dfae71 100644 --- a/Packages/Env/Sources/Env/UserPreferences.swift +++ b/Packages/Env/Sources/Env/UserPreferences.swift @@ -14,6 +14,7 @@ public class UserPreferences: ObservableObject { @AppStorage("preferred_browser") public var preferredBrowser: PreferredBrowser = .inAppSafari @AppStorage("draft_posts") public var draftsPosts: [String] = [] @AppStorage("font_size_scale") public var fontSizeScale: Double = 1 + @AppStorage("show_translate_button_inline") public var showTranslateButton: Bool = true public var pushNotificationsCount: Int { get { diff --git a/Packages/Status/Sources/Status/Row/StatusRowView.swift b/Packages/Status/Sources/Status/Row/StatusRowView.swift index f3472e9f..3a48f161 100644 --- a/Packages/Status/Sources/Status/Row/StatusRowView.swift +++ b/Packages/Status/Sources/Status/Row/StatusRowView.swift @@ -236,7 +236,9 @@ public struct StatusRowView: View { Spacer() } - makeTranslateView(status: status) + if preferences.showTranslateButton { + makeTranslateView(status: status) + } if let poll = status.poll { StatusPollView(poll: poll, status: status)