Better notifications UX

This commit is contained in:
Thomas Ricouard 2022-12-24 10:14:47 +01:00
parent 8de2a8192b
commit 2c39af280e
2 changed files with 95 additions and 35 deletions

View File

@ -13,10 +13,39 @@ struct NotificationRowView: View {
var body: some View { var body: some View {
if let type = notification.supportedType { if let type = notification.supportedType {
HStack(alignment: .top, spacing: 8) { HStack(alignment: .top, spacing: 8) {
makeAvatarView(type: type)
VStack(alignment: .leading, spacing: 0) {
makeMainLabel(type: type)
makeContent(type: type)
}
}
} else {
EmptyView()
}
}
private func makeAvatarView(type: Models.Notification.NotificationType) -> some View {
ZStack(alignment: .topLeading) {
AvatarView(url: notification.account.avatar) AvatarView(url: notification.account.avatar)
.onTapGesture { .onTapGesture {
routeurPath.navigate(to: .accountDetailWithAccount(account: notification.account)) routeurPath.navigate(to: .accountDetailWithAccount(account: notification.account))
} }
ZStack(alignment: .center) {
Circle()
.strokeBorder(Color.white, lineWidth: 1)
.background(Circle().foregroundColor(Color.brand))
.frame(width: 24, height: 24)
Image(systemName: type.iconName())
.resizable()
.frame(width: 12, height: 12)
.foregroundColor(.white)
}
.offset(x: -14, y: -4)
}
}
private func makeMainLabel(type: Models.Notification.NotificationType) -> some View {
VStack(alignment: .leading, spacing: 0) { VStack(alignment: .leading, spacing: 0) {
HStack(spacing: 0) { HStack(spacing: 0) {
Text(notification.account.displayName) Text(notification.account.displayName)
@ -33,6 +62,11 @@ struct NotificationRowView: View {
.foregroundColor(.gray) .foregroundColor(.gray)
Spacer() Spacer()
} }
}
}
@ViewBuilder
private func makeContent(type: Models.Notification.NotificationType) -> some View {
if let status = notification.status { if let status = notification.status {
StatusRowView(viewModel: .init(status: status, isEmbed: true)) StatusRowView(viewModel: .init(status: status, isEmbed: true))
.padding(8) .padding(8)
@ -46,13 +80,18 @@ struct NotificationRowView: View {
Text(notification.account.acct) Text(notification.account.acct)
.font(.callout) .font(.callout)
.foregroundColor(.gray) .foregroundColor(.gray)
if type == .follow {
Text(notification.account.note.asSafeAttributedString)
.lineLimit(3)
.font(.body)
.foregroundColor(.gray)
.environment(\.openURL, OpenURLAction { url in
routeurPath.handle(url: url)
})
} }
} }
} }
} else {
EmptyView()
}
}
} }
extension Models.Notification.NotificationType { extension Models.Notification.NotificationType {
@ -76,6 +115,25 @@ extension Models.Notification.NotificationType {
return "has been edited" return "has been edited"
} }
} }
func iconName() -> String {
switch self {
case .status:
return "pencil"
case .mention:
return "at"
case .reblog:
return "arrow.left.arrow.right.circle.fill"
case .follow, .follow_request:
return "person.fill.badge.plus"
case .favourite:
return "star.fill"
case .poll:
return "chart.bar.fill"
case .update:
return "pencil.line"
}
}
} }
struct NotificationRowView_Previews: PreviewProvider { struct NotificationRowView_Previews: PreviewProvider {

View File

@ -16,8 +16,10 @@ public struct StatusRowView: View {
public var body: some View { public var body: some View {
VStack(alignment: .leading) { VStack(alignment: .leading) {
if !viewModel.isEmbed {
reblogView reblogView
replyView replyView
}
statusView statusView
if !viewModel.isEmbed { if !viewModel.isEmbed {
StatusActionsView(viewModel: viewModel) StatusActionsView(viewModel: viewModel)