Commit Graph

21 Commits

Author SHA1 Message Date
Marcin Wojnarowski 2b72fcce10
Fix minor post errors (#273)
* Use nested to decrease indentation

* Fix post tap area

* Fix overflow errors

* Add changelog entry
2021-11-03 06:21:00 +01:00
Marcin Wojnarowski 760565384f
Migrate ConfigStore to mobx (#270)
* Migrate ConfigStore to mobx

* Add tests

* Remove provider imports

* Mock shared_preferences

* Reorganize saving in ConfigStore
2021-10-31 12:52:58 +01:00
Filip Krawczyk 725807c75b CR fixes 2021-10-25 19:52:29 +02:00
Filip Krawczyk 8703246c65 upgrade dependency & build runner build 2021-10-24 23:11:44 +02:00
Filip Krawczyk 5dbb621582 add reporting functionality 2021-10-24 22:36:41 +02:00
Filip Krawczyk 316964e990 align link preview text to the left 2021-10-24 14:37:55 +02:00
Filip Krawczyk 709cb3c409 yet another round of changes addressing CR
* reorder sections in stores
* List -> Iterable
* .postView = X -> .updatePostView(X)
* Container -> DecoratedBox
* remove useless computed: `wasVoted`
2021-10-24 14:19:12 +02:00
Filip Krawczyk b6d03960e2 Merge branch 'master' into feature/blocking-v2 2021-10-21 20:51:35 +02:00
Filip Krawczyk 43f2a73ad8 make some flex layouts not hacky 2021-10-19 23:27:50 +02:00
Filip Krawczyk cff87e0682 Batch of changes addressing CR comments
post_info_section.dart
* Hook -> Stateless
* remove mysterious Rows & Columns

post_body.dart
* extract into variable instead of !-ing

post_media.dart
* extract url into variable, give reason for unwrapping
* make spinner adaptive

post_link_preview.dart
* extract url into a variable
* use ?? operator

full_post.dart
* fix bug from previous commit :^)

post_more_menu.dart
* remove useless column

post_title.dart
* rework variables to make it more safe

save_post_button.dart
* remove TODO comment that has been resolved

post_voting.dart
* spinner -> adaprive

post_voting.dart
* spinner -> adaptive
* stop manually adding myVote
2021-10-19 01:30:30 +02:00
Filip Krawczyk a884f07860 batch of changes adressing CR
comment_section.dart
* _SortSelection: text -> term
* assign fullPostView at the beggining of builder for later ease of use

full_post.dart
* use Providers in route methods since it makes the most sense
* merge _FPP & FPP to one widget
* assign postView earlier for ease of use
* Provider -> Provider.value

goto.dart
* switch goToPost to use Navigator with route instead of goTo

post_actions.dart
* padding fromLTRB -> symmetric

post_more_menu.dart
* turn showPostMoreMenu into a static method
* Provider -> Provider.value
* Hook -> Stateless
* goTo -> Navigator.push
2021-10-18 01:11:04 +02:00
Filip Krawczyk d223d71c59
Update lib/widgets/post/post_actions.dart
Co-authored-by: Marcin Wojnarowski <xmarcinmarcin@gmail.com>
2021-10-18 01:02:35 +02:00
krawieck aa448adeb7 Code review changes
* remove useless comment from post_status.dart
* move fixed in changelog into a proper section
* move refresh into a provider create in UserBlocksWrapper
* use errorTerm in UserBlocks instead of hardcoded message
* add missing trailing comma
* add route method BlocksPage
* remove useless lint ignore
* use originPreferredName instead of referredName
* make UserBlocksWrapper private
* revise AsyncStoreListener
2021-10-02 18:48:00 +02:00
krawieck 9ba800a435 Merge branch 'master' into feature/blocking-v2 2021-10-01 23:54:57 +02:00
krawieck 09ba4f32fc move files around so that it makes more sense 2021-10-01 23:39:43 +02:00
krawieck 46a2f48e3a transition comment section to use mobx 2021-10-01 23:03:42 +02:00
krawieck ee57a0de07 fix bug where loading fullpostview wouldn't show what user did 2021-09-15 00:23:55 +02:00
krawieck 88466dfd73 add community blocking + minor fixes
minor fixes:
* make link preview show up in proper times
* ListTile for (un)blocking communities had a thing switched around
2021-09-14 23:48:04 +02:00
krawieck 892c09c965 make asyncstorelistener better,
* add prop to asyncstorelistener: successMessageBuilder
* more menu reworkings
2021-09-11 16:26:10 +02:00
krawieck 399c0bdb83 small fixes & tweaks
* commenting uses mobx instead of hooks
* SavePostButton works with fullPost
* `is AsyncStateX` -> .errorTerm & .isLoading
* save post button better looking spinner
2021-09-11 01:27:21 +02:00
krawieck 2e8ca0e858 rework post and full_post to use mobx 2021-09-11 01:04:15 +02:00