Merge pull request #188 from krawieck/feature/own-lint-rules

This commit is contained in:
Filip Krawczyk 2021-03-21 18:50:08 +01:00 committed by GitHub
commit c762f93d1f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 111 additions and 62 deletions

View File

@ -1,7 +1,6 @@
<div align="center">
[![](https://github.com/krawieck/lemmur/workflows/ci/badge.svg)](https://github.com/krawieck/lemmur/actions)
[![style: effective dart](https://img.shields.io/badge/style-effective_dart-40c4ff.svg)](https://pub.dev/packages/effective_dart)
<img width=200px height=200px src="https://raw.githubusercontent.com/krawieck/lemmur/master/assets/readme_icon.svg"/>

View File

@ -1,62 +1,120 @@
include: package:effective_dart/analysis_options.yaml
linter:
rules:
public_member_api_docs: false
lines_longer_than_80_chars: false
prefer_single_quotes: true
prefer_final_locals: true
prefer_expression_function_bodies: true
avoid_bool_literals_in_conditional_expressions: true
exhaustive_cases: true
prefer_for_elements_to_map_fromIterable: true
prefer_if_null_operators: true
prefer_is_not_operator: true
use_is_even_rather_than_modulo: true
unnecessary_string_escapes: true
use_full_hex_values_for_flutter_colors: true
sort_unnamed_constructors_first: true
use_raw_strings: true
unnecessary_string_interpolations: true
void_checks: true
unnecessary_null_in_if_null_operators: true
unnecessary_raw_strings: true
unnecessary_null_aware_assignments: true
unnecessary_parenthesis: true
prefer_if_elements_to_conditional_expressions: true
unawaited_futures: true
prefer_typing_uninitialized_variables: true
sized_box_for_whitespace: true
recursive_getters: true
prefer_int_literals: true
prefer_spread_collections: true
prefer_null_aware_operators: true
prefer_final_in_for_each: true
prefer_contains: true
prefer_constructors_over_static_methods: true
prefer_conditional_assignment: true
prefer_asserts_in_initializer_lists: true
parameter_assignments: true
avoid_unused_constructor_parameters: true
empty_catches: true
cascade_invocations: true
await_only_futures: true
avoid_void_async: true
avoid_unnecessary_containers: true
avoid_single_cascade_in_expression_statements: true
avoid_returning_null_for_void: true
avoid_redundant_argument_values: true
avoid_escaping_inner_quotes: true
sort_child_properties_last: true
prefer_const_constructors: true
prefer_const_declarations: true
prefer_const_literals_to_create_immutables: true
prefer_const_constructors_in_immutables: true
- avoid_bool_literals_in_conditional_expressions
- avoid_catches_without_on_clauses
- avoid_catching_errors
- avoid_classes_with_only_static_members
- avoid_equals_and_hash_code_on_mutable_classes
- avoid_escaping_inner_quotes
- avoid_function_literals_in_foreach_calls
- avoid_init_to_null
- avoid_null_checks_in_equality_operators
- avoid_positional_boolean_parameters
- avoid_private_typedef_functions
- avoid_redundant_argument_values
- avoid_relative_lib_imports
- avoid_return_types_on_setters
- avoid_returning_null
- avoid_returning_null_for_void
- avoid_returning_this
- avoid_setters_without_getters
- avoid_single_cascade_in_expression_statements
- avoid_type_to_string
- avoid_types_on_closure_parameters
- avoid_unnecessary_containers
- avoid_unused_constructor_parameters
- avoid_void_async
- await_only_futures
- camel_case_extensions
- camel_case_types
- cascade_invocations
- cast_nullable_to_non_nullable
- constant_identifier_names
- curly_braces_in_flow_control_structures
- directives_ordering
- empty_catches
- empty_constructor_bodies
- exhaustive_cases
- file_names
- hash_and_equals
- implementation_imports
- library_names
- library_prefixes
- non_constant_identifier_names
- null_check_on_nullable_type_parameter
- omit_local_variable_types
- one_member_abstracts
- package_api_docs
- parameter_assignments
- prefer_adjacent_string_concatenation
- prefer_asserts_in_initializer_lists
- prefer_collection_literals
- prefer_conditional_assignment
- prefer_const_constructors
- prefer_const_constructors_in_immutables
- prefer_const_declarations
- prefer_const_literals_to_create_immutables
- prefer_constructors_over_static_methods
- prefer_contains
- prefer_equal_for_default_values
- prefer_expression_function_bodies
- prefer_final_fields
- prefer_final_in_for_each
- prefer_final_locals
- prefer_for_elements_to_map_fromIterable
- prefer_function_declarations_over_variables
- prefer_generic_function_type_aliases
- prefer_if_elements_to_conditional_expressions
- prefer_if_null_operators
- prefer_initializing_formals
- prefer_int_literals
- prefer_interpolation_to_compose_strings
- prefer_is_empty
- prefer_is_not_empty
- prefer_is_not_operator
- prefer_iterable_whereType
- prefer_mixin
- prefer_null_aware_operators
- prefer_relative_imports
- prefer_single_quotes
- prefer_spread_collections
- prefer_typing_uninitialized_variables
- recursive_getters
- sized_box_for_whitespace
- slash_for_doc_comments
- sort_child_properties_last
- sort_unnamed_constructors_first
- tighten_type_of_initializing_formals
- type_annotate_public_apis
- type_init_formals
- unawaited_futures
- unnecessary_brace_in_string_interps
- unnecessary_const
- unnecessary_getters_setters
- unnecessary_lambdas
- unnecessary_new
- unnecessary_null_aware_assignments
- unnecessary_null_checks
- unnecessary_null_in_if_null_operators
- unnecessary_parenthesis
- unnecessary_raw_strings
- unnecessary_string_escapes
- unnecessary_string_interpolations
- unnecessary_this
- use_full_hex_values_for_flutter_colors
- use_is_even_rather_than_modulo
- use_raw_strings
- use_rethrow_when_possible
- use_setters_to_change_properties
- use_to_and_as_if_applicable
- void_checks
analyzer:
exclude:
- "**/*.g.dart"
- "lib/gen/assets.gen.dart"
strong-mode:
# TODO: remove after migrating to null safety, this is already turned off by default
implicit-casts: false
# TODO: consider disabling
# implicit-dynamic: false

View File

@ -183,13 +183,6 @@ packages:
url: "https://pub.dartlang.org"
source: hosted
version: "1.3.12"
effective_dart:
dependency: "direct dev"
description:
name: effective_dart
url: "https://pub.dartlang.org"
source: hosted
version: "1.3.0"
fake_async:
dependency: transitive
description:

View File

@ -61,7 +61,6 @@ dependencies:
dev_dependencies:
flutter_test:
sdk: flutter
effective_dart: ^1.0.0
flutter_launcher_icons: ^0.8.1
json_serializable: ^3.5.1
build_runner: ^1.11.1