From 4367c4329eabb53932271ab0f272231c3df2f680 Mon Sep 17 00:00:00 2001 From: shilangyu Date: Sat, 6 Feb 2021 13:17:39 +0100 Subject: [PATCH 1/3] Fix missing about tile on windows --- lib/widgets/about_tile.dart | 5 ++++- windows/flutter/CMakeLists.txt | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/widgets/about_tile.dart b/lib/widgets/about_tile.dart index 9c8ba80..9240f56 100644 --- a/lib/widgets/about_tile.dart +++ b/lib/widgets/about_tile.dart @@ -16,7 +16,10 @@ class AboutTile extends HookWidget { @override Widget build(BuildContext context) { - final packageInfoSnap = useMemoFuture(PackageInfo.fromPlatform); + final packageInfoSnap = useMemoFuture( + () => PackageInfo.fromPlatform() + .onError((_, __) => PackageInfo(version: '')), + ); final assetBundle = DefaultAssetBundle.of(context); final changelogSnap = useMemoFuture(() => assetBundle.loadString('CHANGELOG.md')); diff --git a/windows/flutter/CMakeLists.txt b/windows/flutter/CMakeLists.txt index c7a8c76..744f08a 100644 --- a/windows/flutter/CMakeLists.txt +++ b/windows/flutter/CMakeLists.txt @@ -91,6 +91,7 @@ add_custom_command( ${FLUTTER_TOOL_ENVIRONMENT} "${FLUTTER_ROOT}/packages/flutter_tools/bin/tool_backend.bat" windows-x64 $ + VERBATIM ) add_custom_target(flutter_assemble DEPENDS "${FLUTTER_LIBRARY}" From 0bc90c93ca09704d7ac003cc12bcea009aaf6b2b Mon Sep 17 00:00:00 2001 From: shilangyu Date: Sat, 6 Feb 2021 13:19:16 +0100 Subject: [PATCH 2/3] Fix company name --- windows/runner/Runner.rc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/windows/runner/Runner.rc b/windows/runner/Runner.rc index 7b540bb..a6e22dd 100644 --- a/windows/runner/Runner.rc +++ b/windows/runner/Runner.rc @@ -89,11 +89,11 @@ BEGIN BEGIN BLOCK "040904e4" BEGIN - VALUE "CompanyName", "com.example" "\0" + VALUE "CompanyName", "com.krawieck" "\0" VALUE "FileDescription", "A new Flutter project." "\0" VALUE "FileVersion", VERSION_AS_STRING "\0" VALUE "InternalName", "lemmur" "\0" - VALUE "LegalCopyright", "Copyright (C) 2020 com.example. All rights reserved." "\0" + VALUE "LegalCopyright", "Copyright (C) 2020 com.krawieck. All rights reserved." "\0" VALUE "OriginalFilename", "lemmur.exe" "\0" VALUE "ProductName", "lemmur" "\0" VALUE "ProductVersion", VERSION_AS_STRING "\0" From ecda8384c6bea6dd8ab018768d476dba5ab66e37 Mon Sep 17 00:00:00 2001 From: shilangyu Date: Sat, 6 Feb 2021 14:37:35 +0100 Subject: [PATCH 3/3] Use stable Future API --- lib/widgets/about_tile.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/widgets/about_tile.dart b/lib/widgets/about_tile.dart index 9240f56..8b92589 100644 --- a/lib/widgets/about_tile.dart +++ b/lib/widgets/about_tile.dart @@ -18,7 +18,7 @@ class AboutTile extends HookWidget { Widget build(BuildContext context) { final packageInfoSnap = useMemoFuture( () => PackageInfo.fromPlatform() - .onError((_, __) => PackageInfo(version: '')), + .then((e) => e, onError: (_, __) => PackageInfo(version: '')), ); final assetBundle = DefaultAssetBundle.of(context); final changelogSnap =