chore: apply detekt to :core:markdown and :core:navigation (#646)

This commit is contained in:
Diego Beraldin 2024-03-30 14:35:16 +01:00 committed by GitHub
parent 25593e917a
commit 416a8cbd9f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
8 changed files with 31 additions and 6 deletions

View File

@ -0,0 +1,15 @@
<?xml version="1.0" ?>
<SmellBaseline>
<ManuallySuppressedIssues></ManuallySuppressedIssues>
<CurrentIssues>
<ID>FunctionNaming:CustomMarkdownImage.kt$@Composable internal fun CustomMarkdownImage( node: ASTNode, content: String, onOpenImage: ((String) -&gt; Unit)?, autoLoadImages: Boolean, )</ID>
<ID>FunctionNaming:CustomMarkdownImage.kt$@Composable internal fun CustomMarkdownImage( url: String, onOpenImage: ((String) -&gt; Unit)?, autoLoadImages: Boolean, )</ID>
<ID>FunctionNaming:CustomMarkdownSpoiler.kt$@Composable internal fun CustomMarkdownSpoiler( content: String, modifier: Modifier = Modifier, )</ID>
<ID>FunctionNaming:CustomMarkdownSpoiler.kt$@Composable private fun InnerSpoilerElement( title: String, content: String, modifier: Modifier = Modifier, )</ID>
<ID>FunctionNaming:CustomMarkdownWrapper.kt$@Composable fun CustomMarkdownWrapper( content: String, modifier: Modifier, colors: MarkdownColors = markdownColor(), typography: MarkdownTypography = markdownTypography(), padding: MarkdownPadding = markdownPadding(), autoLoadImages: Boolean, maxLines: Int? = null, onOpenUrl: ((String) -&gt; Unit)?, onOpenImage: ((String) -&gt; Unit)?, onClick: (() -&gt; Unit)?, onDoubleClick: (() -&gt; Unit)?, onLongClick: (() -&gt; Unit)?, )</ID>
<ID>LongMethod:CustomMarkdownWrapper.kt$@Composable fun CustomMarkdownWrapper( content: String, modifier: Modifier, colors: MarkdownColors = markdownColor(), typography: MarkdownTypography = markdownTypography(), padding: MarkdownPadding = markdownPadding(), autoLoadImages: Boolean, maxLines: Int? = null, onOpenUrl: ((String) -&gt; Unit)?, onOpenImage: ((String) -&gt; Unit)?, onClick: (() -&gt; Unit)?, onDoubleClick: (() -&gt; Unit)?, onLongClick: (() -&gt; Unit)?, )</ID>
<ID>LongParameterList:CustomMarkdownWrapper.kt$( content: String, modifier: Modifier, colors: MarkdownColors = markdownColor(), typography: MarkdownTypography = markdownTypography(), padding: MarkdownPadding = markdownPadding(), autoLoadImages: Boolean, maxLines: Int? = null, onOpenUrl: ((String) -&gt; Unit)?, onOpenImage: ((String) -&gt; Unit)?, onClick: (() -&gt; Unit)?, onDoubleClick: (() -&gt; Unit)?, onLongClick: (() -&gt; Unit)?, )</ID>
<ID>NestedBlockDepth:Utils.kt$private fun String.spoilerFixUp(): String</ID>
<ID>ReturnCount:Utils.kt$internal fun ASTNode.findChildOfTypeRecursive(type: IElementType): ASTNode?</ID>
</CurrentIssues>
</SmellBaseline>

View File

@ -41,6 +41,8 @@ internal fun CustomMarkdownImage(
)
}
private const val LOADING_ANIMATION_DURATION = 1000
@Composable
internal fun CustomMarkdownImage(
url: String,
@ -80,7 +82,7 @@ internal fun CustomMarkdownImage(
initialValue = 0f,
targetValue = 1f,
animationSpec = InfiniteRepeatableSpec(
animation = tween(1000)
animation = tween(LOADING_ANIMATION_DURATION)
),
)
res

View File

@ -111,4 +111,4 @@ private fun InnerSpoilerElement(
)
}
}
}
}

View File

@ -0,0 +1,8 @@
<?xml version="1.0" ?>
<SmellBaseline>
<ManuallySuppressedIssues></ManuallySuppressedIssues>
<CurrentIssues>
<ID>TooManyFunctions:DefaultNavigationCoordinator.kt$DefaultNavigationCoordinator : NavigationCoordinator</ID>
<ID>TooManyFunctions:NavigationCoordinator.kt$NavigationCoordinator</ID>
</CurrentIssues>
</SmellBaseline>

View File

@ -147,4 +147,4 @@ internal class DefaultNavigationCoordinator : NavigationCoordinator {
override fun changeTab(value: Tab) {
tabNavigator?.current = value
}
}
}

View File

@ -16,4 +16,4 @@ inline fun <reified T : ScreenModel> Screen.getScreenModel(
): T {
val koin = getKoin()
return rememberScreenModel(tag = tag) { koin.get(qualifier, parameters) }
}
}

View File

@ -44,4 +44,4 @@ interface NavigationCoordinator {
fun setExitMessageVisible(value: Boolean)
fun setTabNavigator(value: TabNavigator)
fun changeTab(value: Tab)
}
}

View File

@ -13,4 +13,4 @@ val navigationModule = module {
single<DrawerCoordinator> {
DefaultDrawerCoordinator()
}
}
}