JehanneOS/newlib
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

* external.cc (fillout_pinfo): Return NULL rather than 0.

Browse Source 
(exit_process): Guard against NULL pointer dereference found by Clang.
This commit is contained in:
Christopher Faylor
2012-07-02 19:48:33 +00:00
parent e14a5a7efa
commit fb348d22af
2 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
winsup/cygwin/external.cc
View File

@ -108,7 +108,7 @@ fillout_pinfo (pid_t pid, int winpid)
{
i = 0;
pids.reset ();
return 0;
return NULL;
}
return &ep;
}
@ -186,10 +186,12 @@ static void
exit_process (UINT status, bool useTerminateProcess)
{
pid_t pid = getpid ();
external_pinfo * ep = fillout_pinfo (pid, 1);
external_pinfo *ep = fillout_pinfo (pid, 1);
DWORD dwpid = ep ? ep->dwProcessId : pid;
pinfo p (pid, PID_MAP_RW);
if ((dwpid == GetCurrentProcessId()) && (p->pid == ep->pid))
if (ep)
pid = ep->pid;
if ((dwpid == GetCurrentProcessId()) && (p->pid == pid))
p.set_exit_code ((DWORD)status);
if (useTerminateProcess)
TerminateProcess (GetCurrentProcess(), status);