* sigproc.h (sigthread): Declare new methods. Create new winapi_lock field.

(sigframe:;set): Call get_winapi_lock after frame is set so that signal handler
thread knows not to call SuspendThread.
(sigframe::~sigframe): Release winapi_lock.
* exceptions.cc (sigthread::get_winapi_lock): New method.
(sigthread::release_winapi_lock): New method.
(setup_handler): Use get_winapi_lock to ensure that signalled thread is not
blocked in a Windows API.
* path.h (path_types): Avoid broken GCC warning.
This commit is contained in:
Christopher Faylor 2001-03-07 06:19:34 +00:00
parent 25ee9ae285
commit efd76e4140
4 changed files with 49 additions and 3 deletions

View File

@ -1,3 +1,17 @@
Wed Mar 7 01:08:21 2001 Christopher Faylor <cgf@cygnus.com>
* sigproc.h (sigthread): Declare new methods. Create new winapi_lock
field.
(sigframe:;set): Call get_winapi_lock after frame is set so that signal
handler thread knows not to call SuspendThread.
(sigframe::~sigframe): Release winapi_lock.
* exceptions.cc (sigthread::get_winapi_lock): New method.
(sigthread::release_winapi_lock): New method.
(setup_handler): Use get_winapi_lock to ensure that signalled thread is
not blocked in a Windows API.
* path.h (path_types): Avoid broken GCC warning.
Tue Mar 6 14:02:00 2001 Corinna Vinschen <corinna@vinschen.de> Tue Mar 6 14:02:00 2001 Corinna Vinschen <corinna@vinschen.de>
* path.cc (suffix_scan::has): Change order of conditionals * path.cc (suffix_scan::has): Change order of conditionals
@ -211,7 +225,7 @@ Wed Feb 28 15:10:00 2001 Corinna Vinschen <corinna@vinschen.de>
default values on reset command. default values on reset command.
2001-02-26 Mike Simons <msimons@moria.simons-clan.com> 2001-02-26 Mike Simons <msimons@moria.simons-clan.com>
* times.cc (settimeofday): Replace function stub with working code. * times.cc (settimeofday): Replace function stub with working code.
Mon Feb 26 10:42:00 2001 Corinna Vinschen <corinna@vinschen.de> Mon Feb 26 10:42:00 2001 Corinna Vinschen <corinna@vinschen.de>
@ -362,7 +376,7 @@ Wed Feb 14 14:54:40 2001 Christophe Iasci <chrisiasci@aol.com>
the library is not found the library is not found
2001-02-14 Egor Duda <deo@logos-m.ru> 2001-02-14 Egor Duda <deo@logos-m.ru>
* fhandler_console.cc (fhandler_console::char_command): Ignore unknown * fhandler_console.cc (fhandler_console::char_command): Ignore unknown
rendition codes in \033[xx;yym control sequences rendition codes in \033[xx;yym control sequences

View File

@ -647,6 +647,26 @@ interruptible (DWORD pc, int testvalid = 0)
return res; return res;
} }
bool
sigthread::get_winapi_lock (int test)
{
if (test)
return !InterlockedExchange (&winapi_lock, 1);
/* Need to do a busy loop because we can't block or a potential SuspendThread
will hang. */
while (InterlockedExchange (&winapi_lock, 1))
Sleep (1);
return 1;
}
void
sigthread::release_winapi_lock ()
{
/* Assumes that we have the lock. */
InterlockedExchange (&winapi_lock, 0);
}
static void __stdcall interrupt_setup (int sig, void *handler, DWORD retaddr, static void __stdcall interrupt_setup (int sig, void *handler, DWORD retaddr,
DWORD *retaddr_on_stack, DWORD *retaddr_on_stack,
struct sigaction& siga) struct sigaction& siga)
@ -778,8 +798,13 @@ setup_handler (int sig, void *handler, struct sigaction& siga)
If the thread is already suspended (which can occur when a program is stopped) then If the thread is already suspended (which can occur when a program is stopped) then
just queue the signal. */ just queue the signal. */
if (!mainthread.get_winapi_lock (1))
continue;
sigproc_printf ("suspending mainthread"); sigproc_printf ("suspending mainthread");
res = SuspendThread (hth); res = SuspendThread (hth);
mainthread.release_winapi_lock ();
if (mainthread.frame)
goto resume_thread; /* In case the main thread *just* set the frame */
/* Just set pending if thread is already suspended */ /* Just set pending if thread is already suspended */
if (res) if (res)

View File

@ -36,7 +36,7 @@ enum path_types
PATH_BINARY = MOUNT_BINARY, PATH_BINARY = MOUNT_BINARY,
PATH_EXEC = MOUNT_EXEC, PATH_EXEC = MOUNT_EXEC,
PATH_CYGWIN_EXEC = MOUNT_CYGWIN_EXEC, PATH_CYGWIN_EXEC = MOUNT_CYGWIN_EXEC,
PATH_ALL_EXEC = PATH_CYGWIN_EXEC | PATH_EXEC, PATH_ALL_EXEC = (PATH_CYGWIN_EXEC | PATH_EXEC),
PATH_ISDISK = 0x04000000, PATH_ISDISK = 0x04000000,
PATH_NOTEXEC = 0x08000000, PATH_NOTEXEC = 0x08000000,
PATH_HAS_SYMLINKS = 0x10000000, PATH_HAS_SYMLINKS = 0x10000000,

View File

@ -40,6 +40,9 @@ struct sigthread
DWORD id; DWORD id;
DWORD frame; DWORD frame;
CRITICAL_SECTION lock; CRITICAL_SECTION lock;
LONG winapi_lock;
bool get_winapi_lock (int test = 0);
void release_winapi_lock ();
void init (const char *s); void init (const char *s);
}; };
@ -51,8 +54,11 @@ private:
public: public:
void set (sigthread &t, DWORD ebp) void set (sigthread &t, DWORD ebp)
{ {
DWORD oframe = t.frame;
st = &t; st = &t;
t.frame = ebp; t.frame = ebp;
if (!oframe)
t.get_winapi_lock ();
} }
sigframe () {st = NULL;} sigframe () {st = NULL;}
@ -69,6 +75,7 @@ public:
{ {
EnterCriticalSection (&st->lock); EnterCriticalSection (&st->lock);
st->frame = 0; st->frame = 0;
st->release_winapi_lock ();
LeaveCriticalSection (&st->lock); LeaveCriticalSection (&st->lock);
st = NULL; st = NULL;
} }