JehanneOS/newlib
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

* pinfo.cc (pinfo::init): Detect potential race where short block has been

Browse Source 
retrieved but PID_EXECED flag is not set.
This commit is contained in:
Christopher Faylor
2012-09-17 20:07:49 +00:00
parent a271d2e310
commit ee705c1dcb
2 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
winsup/cygwin/ChangeLog
View File

@@ -1,3 +1,8 @@
2012-09-17 Christopher Faylor <me.cygwin2012@cgf.cx>
* pinfo.cc (pinfo::init): Detect potential race where short block has
been retrieved but PID_EXECED flag is not set.
2012-09-13 Christopher Faylor <me.cygwin2012@cgf.cx> 2012-09-13 Christopher Faylor <me.cygwin2012@cgf.cx>
* cygthread.cc (cygthread::stub): Remove old, unnecessary, FIXMEd code. * cygthread.cc (cygthread::stub): Remove old, unnecessary, FIXMEd code.

9
winsup/cygwin/pinfo.cc
View File

@@ -299,6 +299,15 @@ pinfo::init (pid_t n, DWORD flag, HANDLE h0)
bool created = shloc != SH_JUSTOPEN; bool created = shloc != SH_JUSTOPEN;
/* Detect situation where a transitional memory block is being retrieved.
If the block has been allocated with PINFO_REDIR_SIZE but not yet
updated with a PID_EXECED state then we'll retry. */
MEMORY_BASIC_INFORMATION mbi;
if (!created && procinfo->exists ()
&& VirtualQuery (procinfo, &mbi, sizeof (mbi))
&& mbi.RegionSize < sizeof (_pinfo))
goto loop;
if (!created && createit && (procinfo->process_state & PID_REAPED)) if (!created && createit && (procinfo->process_state & PID_REAPED))
{ {
memset (procinfo, 0, sizeof (*procinfo)); memset (procinfo, 0, sizeof (*procinfo));