JehanneOS/newlib
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Cygwin: FIFO: improve the interruptibility of raw_read

Browse Source 
During a blocking read, we sleep for 1 ms after each iteration through
the connected writers.  Currently we do this by calling Sleep (1).
Remove this call to Sleep and instead change the timeout in the
cygwait call from 0 to 1, so that raw_read can be interrupted while
sleeping.
This commit is contained in:
Ken Brown
2020-05-11 09:03:37 -04:00
parent 1f27345947
commit e637d53617
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
winsup/cygwin/fhandler_fifo.cc
View File

@@ -1335,8 +1335,8 @@ fhandler_fifo::raw_read (void *in_ptr, size_t& len)
} }
else else
{ {
/* Allow interruption. */ /* Allow interruption and don't hog the CPU. */
DWORD waitret = cygwait (NULL, cw_nowait, cw_cancel | cw_sig_eintr); DWORD waitret = cygwait (NULL, 1, cw_cancel | cw_sig_eintr);
if (waitret == WAIT_CANCELED) if (waitret == WAIT_CANCELED)
pthread::static_cancel_self (); pthread::static_cancel_self ();
else if (waitret == WAIT_SIGNALED) else if (waitret == WAIT_SIGNALED)
@@ -1356,8 +1356,6 @@ fhandler_fifo::raw_read (void *in_ptr, size_t& len)
set_errno (EBADF); set_errno (EBADF);
goto errout; goto errout;
} }
/* Don't hog the CPU. */
Sleep (1);
} }
errout: errout:
len = (size_t) -1; len = (size_t) -1;