From df7824d1a465473a1901f67e26fd1485756cb446 Mon Sep 17 00:00:00 2001 From: Wilco Dijkstra Date: Thu, 8 Nov 2018 15:50:42 +0000 Subject: [PATCH] Fix issue with dst bias in memset This patch fixes an issue in the previous memset loop change. If the zva size is >= 256 and there are more than 64 bytes left in the tail, we could enter the loop and thus need to rebias dst by 32 as well. Since no known CPUs use this size this can't be tested natively, so I've tested it on a simulator initialized with a large zva size. -- --- newlib/libc/machine/aarch64/memset.S | 1 + 1 file changed, 1 insertion(+) diff --git a/newlib/libc/machine/aarch64/memset.S b/newlib/libc/machine/aarch64/memset.S index 7c8fe583b..103e3f8bb 100644 --- a/newlib/libc/machine/aarch64/memset.S +++ b/newlib/libc/machine/aarch64/memset.S @@ -233,6 +233,7 @@ L(zva_other): subs count, count, zva_len b.hs 3b 4: add count, count, zva_len + sub dst, dst, 32 /* Bias dst for tail loop. */ b L(tail64) .size memset, . - memset