JehanneOS
/
newlib
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

* syscalls.cc (faccessat): Fix parens in flag expression when calling 

build_fh_name.

	* fhandler_disk_file.cc (fhandler_disk_file::mkdir): Fix typo in
	comment.
	* fhandler_socket.cc (fhandler_socket::bind): Ditto.
	* path.cc (symlink_worker): Ditto.
This commit is contained in:
Corinna Vinschen 2011-08-01 17:01:38 +00:00
parent ab0887572f
commit d32e0bfc08
5 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
winsup/cygwin/ChangeLog
View File

@ -1,3 +1,13 @@
2011-08-01 Corinna Vinschen <corinna@vinschen.de>
* syscalls.cc (faccessat): Fix parens in flag expression when calling
build_fh_name.
* fhandler_disk_file.cc (fhandler_disk_file::mkdir): Fix typo in
comment.
* fhandler_socket.cc (fhandler_socket::bind): Ditto.
* path.cc (symlink_worker): Ditto.
2011-07-31 Christopher Faylor <me.cygwin2011@cgf.cx> 2011-07-31 Christopher Faylor <me.cygwin2011@cgf.cx>
* dll_init.cc (dll_list::load_after_fork_impl): Add a hint to an error * dll_init.cc (dll_list::load_after_fork_impl): Add a hint to an error

2
winsup/cygwin/fhandler_disk_file.cc
View File

@ -1665,7 +1665,7 @@ fhandler_disk_file::mkdir (mode_t mode)
open the file again. open the file again.
FIXME: On remote NTFS shares open sometimes fails because even the FIXME: On remote NTFS shares open sometimes fails because even the
creator of the file doesn't have the right to change the DACL. creator of the file doesn't have the right to change the DACL.
I don't know what setting that is or howq to recognize such a share, I don't know what setting that is or how to recognize such a share,
so for now we don't request WRITE_DAC on remote drives. */ so for now we don't request WRITE_DAC on remote drives. */
access |= READ_CONTROL | WRITE_DAC; access |= READ_CONTROL | WRITE_DAC;
status = NtCreateFile (&dir, access, pc.get_object_attr (attr, sa), &io, NULL, status = NtCreateFile (&dir, access, pc.get_object_attr (attr, sa), &io, NULL,

2
winsup/cygwin/fhandler_socket.cc
View File

@ -956,7 +956,7 @@ fhandler_socket::bind (const struct sockaddr *name, int namelen)
open the file again. open the file again.
FIXME: On remote NTFS shares open sometimes fails because even the FIXME: On remote NTFS shares open sometimes fails because even the
creator of the file doesn't have the right to change the DACL. creator of the file doesn't have the right to change the DACL.
I don't know what setting that is or howq to recognize such a share, I don't know what setting that is or how to recognize such a share,
so for now we don't request WRITE_DAC on remote drives. */ so for now we don't request WRITE_DAC on remote drives. */
if (pc.has_acls () && !pc.isremote ()) if (pc.has_acls () && !pc.isremote ())
access |= READ_CONTROL | WRITE_DAC; access |= READ_CONTROL | WRITE_DAC;

2
winsup/cygwin/path.cc
View File

@ -1680,7 +1680,7 @@ symlink_worker (const char *oldpath, const char *newpath, bool use_winsym,
open the file again. open the file again.
FIXME: On remote NTFS shares open sometimes fails because even the FIXME: On remote NTFS shares open sometimes fails because even the
creator of the file doesn't have the right to change the DACL. creator of the file doesn't have the right to change the DACL.
I don't know what setting that is or howq to recognize such a share, I don't know what setting that is or how to recognize such a share,
so for now we don't request WRITE_DAC on remote drives. */ so for now we don't request WRITE_DAC on remote drives. */
access |= READ_CONTROL | WRITE_DAC; access |= READ_CONTROL | WRITE_DAC;

10
winsup/cygwin/syscalls.cc
View File

@ -4153,14 +4153,14 @@ faccessat (int dirfd, const char *pathname, int mode, int flags)
set_errno (EINVAL); set_errno (EINVAL);
else else
{ {
fhandler_base *fh = build_fh_name (path, fhandler_base *fh = build_fh_name (path, (flags & AT_SYMLINK_NOFOLLOW
PC_KEEP_HANDLE | ? PC_SYM_NOFOLLOW
(flags & AT_SYMLINK_NOFOLLOW) : PC_SYM_FOLLOW)
? PC_SYM_NOFOLLOW : PC_SYM_FOLLOW, | PC_KEEP_HANDLE,
stat_suffixes); stat_suffixes);
if (fh) if (fh)
{ {
res = fh->fhaccess (mode, flags & AT_EACCESS); res = fh->fhaccess (mode, !!(flags & AT_EACCESS));
delete fh; delete fh;
} }
} }