JehanneOS/newlib
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

* bsd_helper.cc (ipcexit_creat_hookthread): Delete shs to make

Browse Source 
Coverity happy (CID 59993).
	* transport_pipes.cc (transport_layer_pipes::listen): Make listen_pipe
	and connect_pipe statics to make Coverity happy (CID 60010/60011).
This commit is contained in:
Corinna Vinschen
2014-05-19 09:49:15 +00:00
parent 8c14a5065d
commit ca6183c344
3 changed files with 18 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
winsup/cygserver/ChangeLog
View File

@@ -1,3 +1,10 @@
2014-05-19 Corinna Vinschen <corinna@vinschen.de>
* bsd_helper.cc (ipcexit_creat_hookthread): Delete shs to make
Coverity happy (CID 59993).
* transport_pipes.cc (transport_layer_pipes::listen): Make listen_pipe
and connect_pipe statics to make Coverity happy (CID 60010/60011).
2014-04-16 Corinna Vinschen <corinna@vinschen.de> 2014-04-16 Corinna Vinschen <corinna@vinschen.de>
* pwdgrp.cc (client_request_pwdgrp::pwd_serve): Add 1 to the message * pwdgrp.cc (client_request_pwdgrp::pwd_serve): Add 1 to the message

1
winsup/cygserver/bsd_helper.cc
View File

@@ -209,6 +209,7 @@ ipcexit_creat_hookthread (struct thread *td)
HANDLE thread = CreateThread (NULL, 0, ipcexit_hookthread, shs, 0, &tid); HANDLE thread = CreateThread (NULL, 0, ipcexit_hookthread, shs, 0, &tid);
if (!thread) if (!thread)
{ {
delete shs;
log (LOG_CRIT, "failed to create thread, error = %u", GetLastError ()); log (LOG_CRIT, "failed to create thread, error = %u", GetLastError ());
return cygwin_internal (CW_GET_ERRNO_FROM_WINERROR, return cygwin_internal (CW_GET_ERRNO_FROM_WINERROR,
GetLastError (), ENOMEM); GetLastError (), ENOMEM);

14
winsup/cygserver/transport_pipes.cc
View File

@@ -83,6 +83,9 @@ transport_layer_pipes::~transport_layer_pipes ()
#ifndef __INSIDE_CYGWIN__ #ifndef __INSIDE_CYGWIN__
static HANDLE listen_pipe;
static HANDLE connect_pipe;
int int
transport_layer_pipes::listen () transport_layer_pipes::listen ()
{ {
@@ -94,16 +97,19 @@ transport_layer_pipes::listen ()
debug ("Try to create named pipe: %ls", _pipe_name); debug ("Try to create named pipe: %ls", _pipe_name);
HANDLE listen_pipe = /* We have to create the first instance of the listening pipe here, and
we also have to create at least one instance of the client side to avoid
a race condition.
See https://cygwin.com/ml/cygwin/2012-11/threads.html#00144 */
listen_pipe =
CreateNamedPipeW (_pipe_name, CreateNamedPipeW (_pipe_name,
PIPE_ACCESS_DUPLEX | FILE_FLAG_FIRST_PIPE_INSTANCE, PIPE_ACCESS_DUPLEX | FILE_FLAG_FIRST_PIPE_INSTANCE,
PIPE_TYPE_BYTE | PIPE_WAIT, PIPE_UNLIMITED_INSTANCES, PIPE_TYPE_BYTE | PIPE_WAIT, PIPE_UNLIMITED_INSTANCES,
0, 0, 1000, &sec_all_nih); 0, 0, 1000, &sec_all_nih);
if (listen_pipe != INVALID_HANDLE_VALUE) if (listen_pipe != INVALID_HANDLE_VALUE)
{ {
HANDLE connect_pipe = connect_pipe = CreateFileW (_pipe_name, GENERIC_READ | GENERIC_WRITE, 0,
CreateFileW (_pipe_name, GENERIC_READ | GENERIC_WRITE, 0, &sec_all_nih, &sec_all_nih, OPEN_EXISTING, 0, NULL);
OPEN_EXISTING, 0, NULL);
if (connect_pipe == INVALID_HANDLE_VALUE) if (connect_pipe == INVALID_HANDLE_VALUE)
{ {
CloseHandle (listen_pipe); CloseHandle (listen_pipe);