JehanneOS/newlib
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

* security.cc (is_group_member): Fix comment.

Browse Source
This commit is contained in:
Corinna Vinschen
2006-02-02 11:35:52 +00:00
parent 49e803c0b6
commit bb6f800d18
2 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
winsup/cygwin/ChangeLog
View File

@@ -1,3 +1,7 @@
2006-02-02 Corinna Vinschen <corinna@vinschen.de>
* security.cc (is_group_member): Fix comment.
2006-02-02 Corinna Vinschen <corinna@vinschen.de> 2006-02-02 Corinna Vinschen <corinna@vinschen.de>
* security.cc (is_group_member): Use local group info type 1. Test * security.cc (is_group_member): Use local group info type 1. Test

11
winsup/cygwin/security.cc
View File

@@ -388,11 +388,12 @@ is_group_member (WCHAR *wgroup, PSID pusersid, cygsidlist &grp_list)
Administrators or Users) can be members of local groups, even Administrators or Users) can be members of local groups, even
though MSDN states otherwise. The GUI refuses to put aliases into though MSDN states otherwise. The GUI refuses to put aliases into
local groups, but the CLI interface allows it. However, a normal local groups, but the CLI interface allows it. However, a normal
logon token does not contain those 2nd order aliases, so we also logon token does not contain groups, in which the user is only
should not put them into the token group list. indirectly a member by being a member of an alias in this group.
Note: Allowing those 2nd order aliases in our group list renders So we also should not put them into the token group list.
external tokens invalid, so that it becomes impossible to logon Note: Allowing those groups in our group list renders external
with password and valid logon token. */ tokens invalid, so that it becomes impossible to logon with
password and valid logon token. */
for (int glidx = 0; glidx < grp_list.count; ++glidx) for (int glidx = 0; glidx < grp_list.count; ++glidx)
if ((buf[bidx].lgrmi1_sidusage == SidTypeGroup if ((buf[bidx].lgrmi1_sidusage == SidTypeGroup
|| buf[bidx].lgrmi1_sidusage == SidTypeWellKnownGroup) || buf[bidx].lgrmi1_sidusage == SidTypeWellKnownGroup)