JehanneOS/newlib
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

* exceptions.cc (_cygtls::handle_SIGCONT): Simplify loop waiting for

Browse Source 
sig_handle_tty_stop to wake up.  Make sure to unlock before calling
	yield to avoid starvation of sig_handle_tty_stop.  Add comments.
	* miscfuncs.cc (yield): Explain why yield should never be called under
	_cygtls::lock conditions.  Call SleepEx with 1ms timeout.  Explain why.
This commit is contained in:
Corinna Vinschen
2013-06-06 15:29:41 +00:00
parent 925e1c8157
commit b3f0fb6baa
3 changed files with 30 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
winsup/cygwin/exceptions.cc
View File

@ -1253,25 +1253,18 @@ _cygtls::handle_SIGCONT ()
{
myself->stopsig = 0;
myself->process_state &= ~PID_STOPPED;
int state = 0;
/* Carefully tell sig_handle_tty_stop to wake up. */
while (state < 2)
{
lock ();
if (sig)
yield (); /* state <= 1 */
else if (state)
state++; /* state == 2 */
else
{
sig = SIGCONT;
SetEvent (signal_arrived);
state++; /* state == 1 */
}
unlock ();
}
lock ();
sig = SIGCONT;
SetEvent (signal_arrived);
/* Make sure yield doesn't run under lock condition to avoid
starvation of sig_handle_tty_stop. */
unlock ();
/* Wait until sig_handle_tty_stop woke up. */
while (sig)
yield ();
/* Tell wait_sig to handle any queued signals now that we're alive
again. */
again. */
sig_dispatch_pending (false);
}
/* Clear pending stop signals */