From 9655ff2680dc416225d4297a5540dd79a156206a Mon Sep 17 00:00:00 2001 From: Christopher Faylor Date: Tue, 8 Oct 2002 02:44:35 +0000 Subject: [PATCH] * dtable.cc (dtable::init_std_file_from_handle): Try to mimic standard open behavior with files redirected from stdin/stdout/stderr, i.e., fmode settings take precedence over mount settings. --- winsup/cygwin/ChangeLog | 6 ++++++ winsup/cygwin/dtable.cc | 9 +++++++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog index 175136eef..67ce476f6 100644 --- a/winsup/cygwin/ChangeLog +++ b/winsup/cygwin/ChangeLog @@ -1,3 +1,9 @@ +2002-10-07 Christopher Faylor + + * dtable.cc (dtable::init_std_file_from_handle): Try to mimic standard + open behavior with files redirected from stdin/stdout/stderr, i.e., + fmode settings take precedence over mount settings. + 2002-10-07 Christopher Faylor * dtable.cc (unknown_file): New variable. diff --git a/winsup/cygwin/dtable.cc b/winsup/cygwin/dtable.cc index 064fe69bf..d18f99b6b 100644 --- a/winsup/cygwin/dtable.cc +++ b/winsup/cygwin/dtable.cc @@ -267,8 +267,13 @@ dtable::init_std_file_from_handle (int fd, HANDLE handle, DWORD myaccess) else { path_conv pc; - build_fhandler_from_name (fd, name, handle, pc) - ->init (handle, myaccess, (name == unknown_file) ? 0 : pc.binmode ()); + unsigned bin; + fhandler_base *fh = build_fhandler_from_name (fd, name, handle, pc); + bin = fh->get_default_fmode (myaccess == GENERIC_READ ? O_RDONLY : O_WRONLY); + if (!bin && name != unknown_file) + bin = pc.binmode (); + + fh->init (handle, myaccess, bin); set_std_handle (fd); paranoid_printf ("fd %d, handle %p", fd, handle); }