JehanneOS/newlib
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

* thread.cc (pthread_rwlock::add_reader): Remove mx parameter for

Browse Source 
List_insert call.
(pthread::prepare): Ensure race safeness when adding function
pointers to atfork lists by using List_insert.
* thread.h (List_insert): Use InterlockedCompareExchangePointer to
ensure race safeness without using a mutex.
(List_remove): Use InterlockedCompareExchangePointer to
ensure race safeness with List_insert.
(List::insert): Remove mx parameter for	List_insert call.
This commit is contained in:
Thomas Pfaff
2003-12-01 22:10:57 +00:00
parent bd16a3a8a8
commit 94d2416049
3 changed files with 30 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
winsup/cygwin/thread.h
View File

@@ -224,14 +224,13 @@ verifyable_object_state verifyable_object_isvalid (void const *, long);
verifyable_object_state verifyable_object_isvalid (void const *, long, void *);
template <class list_node> inline void
List_insert (fast_mutex &mx, list_node *&head, list_node *node)
List_insert (list_node *&head, list_node *node)
{
if (!node)
return;
mx.lock ();
node->next = head;
head = node;
mx.unlock ();
do
node->next = head;
while (InterlockedCompareExchangePointer (&head, node, node->next) != node->next);
}
template <class list_node> inline void
@@ -240,16 +239,17 @@ List_remove (fast_mutex &mx, list_node *&head, list_node *node)
if (!node)
return;
mx.lock ();
if (node == head)
head = head->next;
else if (head)
if (head)
{
list_node *cur = head;
if (InterlockedCompareExchangePointer (&head, node->next, node) != node)
{
list_node *cur = head;
while (cur->next && node != cur->next)
cur = cur->next;
if (node == cur->next)
cur->next = cur->next->next;
while (cur->next && node != cur->next)
cur = cur->next;
if (node == cur->next)
cur->next = cur->next->next;
}
}
mx.unlock ();
}
@@ -274,7 +274,7 @@ template <class list_node> class List
void insert (list_node *node)
{
List_insert (mx, head, node);
List_insert (head, node);
}
void remove (list_node *node)