JehanneOS/newlib
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

* dtable.cc (dtable::get_debugger_info): Add missing braces.

Browse Source 
(dtable::stdio_init): Fix incorrect negation of not_open(2) condition.
This commit is contained in:
Corinna Vinschen
2011-08-18 09:16:50 +00:00
parent 927761a425
commit 8f19b4b64f
2 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
winsup/cygwin/ChangeLog
View File

@@ -1,3 +1,8 @@
2011-08-18 Corinna Vinschen <corinna@vinschen.de>
* dtable.cc (dtable::get_debugger_info): Add missing braces.
(dtable::stdio_init): Fix incorrect negation of not_open(2) condition.
2011-08-16 Pierre Humblet <Pierre.Humblet@ieee.org> 2011-08-16 Pierre Humblet <Pierre.Humblet@ieee.org>
* net.cc (gethostby_helper): Remove DEBUGGING code from and * net.cc (gethostby_helper): Remove DEBUGGING code from and

16
winsup/cygwin/dtable.cc
View File

@@ -130,12 +130,14 @@ dtable::get_debugger_info ()
| O_BINARY, 0777)) | O_BINARY, 0777))
release (i); release (i);
else else
CloseHandle (h); {
/* Copy to Windows' idea of a standard handle, otherwise CloseHandle (h);
we have invalid standard handles when calling Windows /* Copy to Windows' idea of a standard handle, otherwise
functions (small_printf and strace might suffer, too). */ we have invalid standard handles when calling Windows
SetStdHandle (std_consts[i], i ? fh->get_output_handle () functions (small_printf and strace might suffer, too). */
: fh->get_handle ()); SetStdHandle (std_consts[i], i ? fh->get_output_handle ()
: fh->get_handle ());
}
} }
} }
} }
@@ -172,7 +174,7 @@ dtable::stdio_init ()
initialized in dtable::get_debugger_info (). In this case initialized in dtable::get_debugger_info (). In this case
init_std_file_from_handle is a no-op, so, even if out == err we don't init_std_file_from_handle is a no-op, so, even if out == err we don't
want to duplicate the handle since it will be unused. */ want to duplicate the handle since it will be unused. */
if (out == err && (!being_debugged () || !not_open (2))) if (out == err && (!being_debugged () || not_open (2)))
{ {
/* Since this code is not invoked for forked tasks, we don't have /* Since this code is not invoked for forked tasks, we don't have
to worry about the close-on-exec flag here. */ to worry about the close-on-exec flag here. */