* spawn.cc (find_exec): Initialize err (CID 60111).

* strace.cc (strace::activate): Fix potential buffer overrun (CID 59938)
	* syscalls.cc (popen): Close parent pipe descriptor via fclosing fp on
	error to avoid resource leak (CID 59981).
	* thread.cc (pthread::exit): Avoid accessing cygtls member after
	deleting "this" (CID 60217).
This commit is contained in:
Corinna Vinschen
2014-06-23 19:05:15 +00:00
parent cf06a0b18c
commit 8431e478d2
5 changed files with 25 additions and 5 deletions

View File

@@ -4355,8 +4355,17 @@ popen (const char *command, const char *in_type)
/* If we reach here we've seen an error but the pipe handles are open.
Close them and return NULL. */
int save_errno = get_errno ();
close (fds[0]);
close (fds[1]);
if (fp)
{
/* Must fclose fp to avoid memory leak. */
fclose (fp);
close (fds[myix ^ 1]);
}
else
{
close (fds[0]);
close (fds[1]);
}
set_errno (save_errno);
#undef rw