Change the name "title_mutex" to "tty_mutex" throughout.

* tty.h (tty_list::allocate_tty): Turn argument into a boolean.
* tty.cc (tty_list::init): Protect entire allocation operation with tty_mutex
(formerly title_mutex) to protect against allocation races.
This commit is contained in:
Christopher Faylor
2004-05-17 15:27:56 +00:00
parent fb4489a53f
commit 641654f72a
7 changed files with 51 additions and 43 deletions

View File

@ -330,7 +330,7 @@ try_to_debug (bool waitloop)
/* if any of these mutexes is owned, we will fail to start any cygwin app
until trapped app exits */
ReleaseMutex (title_mutex);
ReleaseMutex (tty_mutex);
/* prevent recursive exception handling */
char* rawenv = GetEnvironmentStrings () ;
@ -1117,22 +1117,22 @@ signal_exit (int rc)
do_exit (rc);
}
HANDLE NO_COPY title_mutex = NULL;
HANDLE NO_COPY tty_mutex = NULL;
void
events_init (void)
{
char *name;
char mutex_name[CYG_MAX_PATH];
/* title_mutex protects modification of console title. It's necessary
/* tty_mutex is on while searching for a tty slot. It's necessary
while finding console window handle */
if (!(title_mutex = CreateMutex (&sec_all_nih, FALSE,
if (!(tty_mutex = CreateMutex (&sec_all_nih, FALSE,
name = shared_name (mutex_name,
"title_mutex", 0))))
"tty_mutex", 0))))
api_fatal ("can't create title mutex '%s', %E", name);
ProtectHandle (title_mutex);
ProtectHandle (tty_mutex);
new_muto (mask_sync);
windows_system_directory[0] = '\0';
(void) GetSystemDirectory (windows_system_directory, sizeof (windows_system_directory) - 2);