JehanneOS
/
newlib
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add comment to point out missing access right per documentation 

In get_mem_values we open the process without PROCESS_VM_READ access
and are *still* able to request working set information, despite
MSDN claiming we need it for this purpose.  Instead of adding this
access right, just add an comment to point this out for now.

Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
This commit is contained in:
Corinna Vinschen 2016-06-27 18:00:01 +02:00
parent ba58e5f20c
commit 532ecdd36f
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
winsup/cygwin/fhandler_process.cc
View File

@ -1436,6 +1436,10 @@ get_mem_values (DWORD dwProcessId, unsigned long *vmsize, unsigned long *vmrss,
PMEMORY_WORKING_SET_LIST p; PMEMORY_WORKING_SET_LIST p;
SIZE_T n = 0x4000, length; SIZE_T n = 0x4000, length;
/* This appears to work despite MSDN claiming that QueryWorkingSSet requires
PROCESS_QUERY_INFORMATION *and* PROCESS_VM_READ. Since we're trying to do
everything with least perms, we stick to PROCESS_QUERY_INFORMATION only
unless this changes in Windows for some reason. */
hProcess = OpenProcess (PROCESS_QUERY_INFORMATION, FALSE, dwProcessId); hProcess = OpenProcess (PROCESS_QUERY_INFORMATION, FALSE, dwProcessId);
if (hProcess == NULL) if (hProcess == NULL)
{ {