Revert "Refactor to avoid nonnull checks on "this" pointer."
This reverts commit 0008bdea02
.
This patch introduced a regression. Calling FOO=$(...) in zsh hangs
indefinitely and has to be killed forcefully.
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
This commit is contained in:
@ -155,8 +155,7 @@ proc_can_be_signalled (_pinfo *p)
|
||||
bool __reg1
|
||||
pid_exists (pid_t pid)
|
||||
{
|
||||
pinfo p(pid);
|
||||
return p && p->exists ();
|
||||
return pinfo (pid)->exists ();
|
||||
}
|
||||
|
||||
/* Return true if this is one of our children, false otherwise. */
|
||||
@ -1144,7 +1143,7 @@ remove_proc (int ci)
|
||||
if (_my_tls._ctinfo != procs[ci].wait_thread)
|
||||
procs[ci].wait_thread->terminate_thread ();
|
||||
}
|
||||
else if (procs[ci] && procs[ci]->exists ())
|
||||
else if (procs[ci]->exists ())
|
||||
return true;
|
||||
|
||||
sigproc_printf ("removing procs[%d], pid %d, nprocs %d", ci, procs[ci]->pid,
|
||||
|
Reference in New Issue
Block a user