JehanneOS/newlib
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

* cygcheck.cc (dll_info): Detect and report on symlinks. Output wrong

Browse Source 
architecture message inline with stdout for clarity.
* path.cc (is_symlink): Always reset file pointer to beginning on exit.
(readlink): Assume that file pointer is set to the beginning.
This commit is contained in:
Christopher Faylor
2013-07-07 16:57:11 +00:00
parent b1b497cb2e
commit 40f11fc133
3 changed files with 38 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
winsup/utils/path.cc
View File

@@ -140,9 +140,10 @@ is_exe (HANDLE fh)
bool
is_symlink (HANDLE fh)
{
bool ret = false;
int magic = get_word (fh, 0x0);
if (magic != SHORTCUT_MAGIC && magic != SYMLINK_MAGIC)
return false;
goto out;
DWORD got;
BY_HANDLE_FILE_INFORMATION local;
if (!GetFileInformationByHandle (fh, &local))
@@ -151,31 +152,34 @@ is_symlink (HANDLE fh)
{
DWORD size;
if (!local.dwFileAttributes & FILE_ATTRIBUTE_READONLY)
return false; /* Not a Cygwin symlink. */
goto out; /* Not a Cygwin symlink. */
if ((size = GetFileSize (fh, NULL)) > 8192)
return false; /* Not a Cygwin symlink. */
goto out; /* Not a Cygwin symlink. */
char buf[size];
SetFilePointer (fh, 0, 0, FILE_BEGIN);
if (!ReadFile (fh, buf, size, &got, 0))
return false;
goto out;
if (got != size || !cmp_shortcut_header ((win_shortcut_hdr *) buf))
return false; /* Not a Cygwin symlink. */
goto out; /* Not a Cygwin symlink. */
/* TODO: check for invalid path contents
(see symlink_info::check() in ../cygwin/path.cc) */
}
else /* magic == SYMLINK_MAGIC */
{
if (!local.dwFileAttributes & FILE_ATTRIBUTE_SYSTEM)
return false; /* Not a Cygwin symlink. */
goto out; /* Not a Cygwin symlink. */
char buf[sizeof (SYMLINK_COOKIE) - 1];
SetFilePointer (fh, 0, 0, FILE_BEGIN);
if (!ReadFile (fh, buf, sizeof (buf), &got, 0))
return false;
goto out;
if (got != sizeof (buf) ||
memcmp (buf, SYMLINK_COOKIE, sizeof (buf)) != 0)
return false; /* Not a Cygwin symlink. */
goto out; /* Not a Cygwin symlink. */
}
return true;
ret = true;
out:
SetFilePointer (fh, 0, 0, FILE_BEGIN);
return ret;
}
/* Assumes is_symlink(fh) is true */
@@ -196,8 +200,7 @@ readlink (HANDLE fh, char *path, int maxlen)
buf = (char *) alloca (fi.nFileSizeLow + 1);
file_header = (win_shortcut_hdr *) buf;
if (SetFilePointer (fh, 0L, NULL, FILE_BEGIN) == INVALID_SET_FILE_POINTER
|| !ReadFile (fh, buf, fi.nFileSizeLow, &rv, NULL)
if (!ReadFile (fh, buf, fi.nFileSizeLow, &rv, NULL)
|| rv != fi.nFileSizeLow)
return false;