JehanneOS/newlib
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Cygwin: get_posix_access: avoid negative subscript

Browse Source 
Don't refer to lacl[pos] unless we know that pos >= 0.
This commit is contained in:
Ken Brown 2019-08-26 13:38:31 -04:00
parent d065170441
commit 398476acd2
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
winsup/cygwin/sec_acl.cc
View File

@ -807,10 +807,10 @@ get_posix_access (PSECURITY_DESCRIPTOR psd,
lacl[pos].a_id = ACL_UNDEFINED_ID; lacl[pos].a_id = ACL_UNDEFINED_ID;
lacl[pos].a_perm = CYG_ACE_MASK_TO_POSIX (ace->Mask); lacl[pos].a_perm = CYG_ACE_MASK_TO_POSIX (ace->Mask);
aclsid[pos] = well_known_null_sid; aclsid[pos] = well_known_null_sid;
}
has_class_perm = true; has_class_perm = true;
class_perm = lacl[pos].a_perm; class_perm = lacl[pos].a_perm;
} }
}
if (ace->Header.AceFlags & SUB_CONTAINERS_AND_OBJECTS_INHERIT) if (ace->Header.AceFlags & SUB_CONTAINERS_AND_OBJECTS_INHERIT)
{ {
if ((pos = searchace (lacl, MAX_ACL_ENTRIES, if ((pos = searchace (lacl, MAX_ACL_ENTRIES,
@ -820,12 +820,12 @@ get_posix_access (PSECURITY_DESCRIPTOR psd,
lacl[pos].a_id = ACL_UNDEFINED_ID; lacl[pos].a_id = ACL_UNDEFINED_ID;
lacl[pos].a_perm = CYG_ACE_MASK_TO_POSIX (ace->Mask); lacl[pos].a_perm = CYG_ACE_MASK_TO_POSIX (ace->Mask);
aclsid[pos] = well_known_null_sid; aclsid[pos] = well_known_null_sid;
}
has_def_class_perm = true; has_def_class_perm = true;
def_class_perm = lacl[pos].a_perm; def_class_perm = lacl[pos].a_perm;
} }
} }
} }
}
continue; continue;
} }
if (ace_sid == owner_sid) if (ace_sid == owner_sid)