JehanneOS/newlib
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

* times.cc (utimes): Open files with GENERIC_WRITE on file systems

Browse Source 
not supporting ACLs.
This commit is contained in:
Corinna Vinschen 2005-02-11 14:27:36 +00:00
parent 3d11bd3e07
commit 199bf79367
2 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
winsup/cygwin/ChangeLog
View File

@ -1,3 +1,8 @@
2005-02-11 Corinna Vinschen <corinna@vinschen.de>
* times.cc (utimes): Open files with GENERIC_WRITE on file systems
not supporting ACLs.
2005-02-09 Corinna Vinschen <corinna@vinschen.de> 2005-02-09 Corinna Vinschen <corinna@vinschen.de>
* fhandler_disk_file.cc (fhandler_disk_file::ftruncate): Fix checking * fhandler_disk_file.cc (fhandler_disk_file::ftruncate): Fix checking

11
winsup/cygwin/times.cc
View File

@ -462,8 +462,15 @@ utimes (const char *path, const struct timeval *tvp)
/* MSDN suggests using FILE_FLAG_BACKUP_SEMANTICS for accessing /* MSDN suggests using FILE_FLAG_BACKUP_SEMANTICS for accessing
the times of directories. */ the times of directories. */
/* Note: It's not documented in MSDN that FILE_WRITE_ATTRIBUTES is /* Note: It's not documented in MSDN that FILE_WRITE_ATTRIBUTES is
sufficient to change the timestamps... */ sufficient to change the timestamps, but it is for NTFS and FAT,
HANDLE h = CreateFile (win32, FILE_WRITE_ATTRIBUTES, local or remote, NT and 9x. Unfortunately it's not sufficient
for a remote HPFS. Looking for a way to decide whether we
should use FILE_WRITE_ATTRIBUTES or GENERIC_WRITE, we're now
using the has_acls () attribute. The assumption is, that file
systems not supporting ACLs don't have a way to distinguish
between GENERIC_WRITE and FILE_WRITE_ATTRIBUTES anyway. */
HANDLE h = CreateFile (win32, win32.has_acls () ? FILE_WRITE_ATTRIBUTES
: GENERIC_WRITE,
FILE_SHARE_READ | FILE_SHARE_WRITE, FILE_SHARE_READ | FILE_SHARE_WRITE,
&sec_none_nih, OPEN_EXISTING, &sec_none_nih, OPEN_EXISTING,
FILE_ATTRIBUTE_NORMAL | FILE_FLAG_BACKUP_SEMANTICS, FILE_ATTRIBUTE_NORMAL | FILE_FLAG_BACKUP_SEMANTICS,